@output.ai/core 0.1.8-dev.pr156.05c9aa2 → 0.1.8-dev.pr156.696d4dd

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@output.ai/core",
-  "version": "0.1.8-dev.pr156.05c9aa2",
+  "version": "0.1.8-dev.pr156.696d4dd",
   "description": "The core module of the output framework",
   "type": "module",
   "exports": {

package/src/tracing/processors/local/index.js

@@ -1,12 +1,11 @@
 import { appendFileSync, mkdirSync, readdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
-import { dirname, join } from 'node:path';
-import { fileURLToPath } from 'url';
+import { join } from 'node:path';
 import buildTraceTree from '../../tools/build_trace_tree.js';
 import { EOL } from 'node:os';
 
 const oneWeekInMS = 1000 * 60 * 60 * 24 * 7;
-const __dirname = dirname( fileURLToPath( import.meta.url ) );
-const tempDir = join( __dirname, 'temp', 'traces' );
+// Use local working directory for temp files, not module-relative path
+const tempDir = join( process.cwd(), 'logs', 'temp', 'traces' );
 
 const accumulate = ( { entry, executionContext: { workflowId, startTime } } ) => {
   const path = join( tempDir, `${startTime}_${workflowId}.trace` );
@@ -28,15 +27,24 @@ export const init = () => {
 };
 
 /**
- * Get the base path for trace file storage
- * @returns {string} The base path where traces should be written
+ * Get the local file system path for ALL file I/O operations (read/write)
+ * Always uses the container's local working directory
+ * @param {string} workflowName - The name of the workflow
+ * @returns {string} The local filesystem path for file operations
  */
-const getBasePath = () => {
-  return process.env.HOST_TRACE_PATH || join( process.cwd(), 'logs' );
+const getLocalOutputDir = workflowName => {
+  return join( process.cwd(), 'logs', 'runs', workflowName );
 };
 
-const getOutputDir = workflowName => {
-  return join( getBasePath(), 'runs', workflowName );
+/**
+ * Get the host path for reporting trace file locations to users
+ * Uses HOST_TRACE_PATH if set (for Docker), otherwise uses local path
+ * @param {string} workflowName - The name of the workflow
+ * @returns {string} The path to report to users/API
+ */
+const getReportOutputDir = workflowName => {
+  const basePath = process.env.HOST_TRACE_PATH || join( process.cwd(), 'logs' );
+  return join( basePath, 'runs', workflowName );
 };
 
 const buildOutputFileName = ( { startTime, workflowId } ) => {
@@ -58,7 +66,8 @@ export const exec = ( { entry, executionContext } ) => {
   const { workflowId, workflowName, startTime } = executionContext;
   const content = buildTraceTree( accumulate( { entry, executionContext } ) );
 
-  const dir = getOutputDir( workflowName );
+  // Always use local path for writing files
+  const dir = getLocalOutputDir( workflowName );
   const path = join( dir, buildOutputFileName( { startTime, workflowId } ) );
 
   mkdirSync( dir, { recursive: true } );
@@ -74,5 +83,6 @@ export const exec = ( { entry, executionContext } ) => {
  * @returns {string} The absolute path where the trace will be saved
  */
 export const getDestination = ( { startTime, workflowId, workflowName } ) => {
-  return join( getOutputDir( workflowName ), buildOutputFileName( { workflowId, startTime } ) );
+  // Use report path for reporting to users/API
+  return join( getReportOutputDir( workflowName ), buildOutputFileName( { workflowId, startTime } ) );
 };

package/src/tracing/processors/local/index.spec.js

@@ -29,6 +29,7 @@ describe( 'tracing/processors/local', () => {
     vi.clearAllMocks();
     store.files.clear();
     process.argv[2] = '/tmp/project';
+    delete process.env.HOST_TRACE_PATH; // Clear HOST_TRACE_PATH for clean tests
   } );
 
   it( 'init(): creates temp dir and cleans up old files', async () => {
@@ -39,7 +40,8 @@ describe( 'tracing/processors/local', () => {
 
     init();
 
-    expect( mkdirSyncMock ).toHaveBeenCalledWith( expect.stringMatching( /temp\/traces$/ ), { recursive: true } );
+    // Should create temp dir under process.cwd()/logs, not module-relative
+    expect( mkdirSyncMock ).toHaveBeenCalledWith( expect.stringMatching( /logs\/temp\/traces$/ ), { recursive: true } );
     expect( rmSyncMock ).toHaveBeenCalledTimes( 1 );
   } );
 
@@ -78,5 +80,70 @@ describe( 'tracing/processors/local', () => {
     expect( destination ).toMatch( /^\/|^[A-Z]:\\/i ); // Starting with / or Windows drive letter
     expect( destination ).toContain( '/logs/runs/test-workflow/2020-01-02-03-04-05-678Z_workflow-id-123.json' );
   } );
+
+  it( 'exec(): writes to container path regardless of HOST_TRACE_PATH', async () => {
+    const { exec, init } = await import( './index.js' );
+
+    // Set HOST_TRACE_PATH to simulate Docker environment
+    process.env.HOST_TRACE_PATH = '/host/path/logs';
+
+    init();
+
+    const startTime = Date.parse( '2020-01-02T03:04:05.678Z' );
+    const ctx = { executionContext: { workflowId: 'id1', workflowName: 'WF', startTime } };
+
+    exec( { ...ctx, entry: { name: 'A', phase: 'start', timestamp: startTime } } );
+
+    expect( writeFileSyncMock ).toHaveBeenCalledTimes( 1 );
+    const [ writtenPath ] = writeFileSyncMock.mock.calls.at( -1 );
+
+    // Should write to process.cwd()/logs, NOT to HOST_TRACE_PATH
+    expect( writtenPath ).not.toContain( '/host/path/logs' );
+    expect( writtenPath ).toMatch( /logs\/runs\/WF\// );
+  } );
+
+  it( 'getDestination(): returns HOST_TRACE_PATH when set', async () => {
+    const { getDestination } = await import( './index.js' );
+
+    // Set HOST_TRACE_PATH to simulate Docker environment
+    process.env.HOST_TRACE_PATH = '/host/path/logs';
+
+    const startTime = Date.parse( '2020-01-02T03:04:05.678Z' );
+    const workflowId = 'workflow-id-123';
+    const workflowName = 'test-workflow';
+
+    const destination = getDestination( { startTime, workflowId, workflowName } );
+
+    // Should return HOST_TRACE_PATH-based path for reporting
+    expect( destination ).toBe( '/host/path/logs/runs/test-workflow/2020-01-02-03-04-05-678Z_workflow-id-123.json' );
+  } );
+
+  it( 'separation of write and report paths works correctly', async () => {
+    const { exec, getDestination, init } = await import( './index.js' );
+
+    // Set HOST_TRACE_PATH to simulate Docker environment
+    process.env.HOST_TRACE_PATH = '/Users/ben/project/logs';
+
+    init();
+
+    const startTime = Date.parse( '2020-01-02T03:04:05.678Z' );
+    const workflowId = 'workflow-id-123';
+    const workflowName = 'test-workflow';
+    const ctx = { executionContext: { workflowId, workflowName, startTime } };
+
+    // Execute to write file
+    exec( { ...ctx, entry: { name: 'A', phase: 'start', timestamp: startTime } } );
+
+    // Get destination for reporting
+    const destination = getDestination( { startTime, workflowId, workflowName } );
+
+    // Verify write path is local
+    const [ writtenPath ] = writeFileSyncMock.mock.calls.at( -1 );
+    expect( writtenPath ).not.toContain( '/Users/ben/project' );
+    expect( writtenPath ).toMatch( /logs\/runs\/test-workflow\// );
+
+    // Verify report path uses HOST_TRACE_PATH
+    expect( destination ).toBe( '/Users/ben/project/logs/runs/test-workflow/2020-01-02-03-04-05-678Z_workflow-id-123.json' );
+  } );
 } );