@output.ai/core 0.1.13 → 0.1.15

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@output.ai/core",
-  "version": "0.1.13",
+  "version": "0.1.15",
   "description": "The core module of the output framework",
   "type": "module",
   "exports": {

package/src/interface/webhook.js

@@ -1,5 +1,5 @@
 // THIS RUNS IN THE TEMPORAL'S SANDBOX ENVIRONMENT
-import { defineSignal, setHandler, proxyActivities, workflowInfo, proxySinks } from '@temporalio/workflow';
+import { defineSignal, setHandler, proxyActivities, workflowInfo, proxySinks, uuid4 } from '@temporalio/workflow';
 import { ACTIVITY_SEND_WEBHOOK } from '#consts';
 import { FatalError } from '#errors';
 import { validateCreateWebhook } from './validations/static.js';
@@ -20,7 +20,7 @@ export async function createWebhook( { url, payload } ) {
   const sinks = await proxySinks();
   const resumeSignal = defineSignal( 'resume' );
 
-  const traceId = `${workflowId}-${url}-${Date.now()}`;
+  const traceId = `${workflowId}-${url}-${uuid4}`;
   sinks.trace.addEventStart( { id: traceId, name: 'resume', kind: 'webhook' } );
   return new Promise( resolve =>
     setHandler( resumeSignal, responsePayload => {

package/src/interface/workflow.js

@@ -1,5 +1,5 @@
 // THIS RUNS IN THE TEMPORAL'S SANDBOX ENVIRONMENT
-import { proxyActivities, inWorkflowContext, executeChild, workflowInfo, ParentClosePolicy } from '@temporalio/workflow';
+import { proxyActivities, inWorkflowContext, executeChild, workflowInfo, uuid4, ParentClosePolicy } from '@temporalio/workflow';
 import { validateWorkflow } from './validations/static.js';
 import { validateWithSchema } from './validations/runtime.js';
 import { SHARED_STEP_PREFIX, ACTIVITY_GET_TRACE_DESTINATIONS } from '#consts';
@@ -25,10 +25,9 @@ export function workflow( { name, description, inputSchema, outputSchema, fn, op
   const steps = proxyActivities( activityOptions );
 
   const wrapper = async input => {
-    validateWithSchema( inputSchema, input, `Workflow ${name} input` );
-
     // this returns a plain function, for example, in unit tests
     if ( !inWorkflowContext() ) {
+      validateWithSchema( inputSchema, input, `Workflow ${name} input` );
       const output = await fn( input );
       validateWithSchema( outputSchema, output, `Workflow ${name} output` );
       return output;
@@ -53,6 +52,9 @@ export function workflow( { name, description, inputSchema, outputSchema, fn, op
       activityOptions: memo.activityOptions ?? activityOptions // Also preserve the original activity options
     } );
 
+    // validation comes after setting memo to have that info already set for interceptor even if validations fail
+    validateWithSchema( inputSchema, input, `Workflow ${name} input` );
+
     // binds the methods called in the code that Webpack loader will add, they will exposed via "this"
     const output = await fn.call( {
       invokeStep: async ( stepName, input, options ) => steps[`${workflowPath}#${stepName}`]( input, options ),
@@ -72,7 +74,7 @@ export function workflow( { name, description, inputSchema, outputSchema, fn, op
       startWorkflow: async ( childName, input, extra = {} ) =>
         executeChild( childName, {
           args: input ? [ input ] : [],
-          workflowId: `${workflowId}-${childName}-${Date.now()}`,
+          workflowId: `${workflowId}-${childName}-${uuid4()}`,
           parentClosePolicy: ParentClosePolicy[extra?.detached ? 'ABANDON' : 'TERMINATE'],
           memo: {
             executionContext,