@outbuild-company/schedule-core 1.5.0 → 1.6.1

package/dist/index.cjs

@@ -4024,7 +4024,10 @@ var MAX_CUSTOM_ID_LENGTH = 20;
 // src/columns/custom-id/custom-id-pipeline.ts
 var customIdPipeline = {
   targetField: "customId",
-  canEdit() {
+  canEdit(activity, hierarchy) {
+    if (isSummaryActivity2(activity, hierarchy)) {
+      return cannotEdit("summary", "summary_column_value");
+    }
     return canEdit();
   },
   parseInput(rawValue) {
@@ -10337,7 +10340,6 @@ function buildParentMutations(input) {
       fields.constraintType = CONSTRAINT_TYPE2.ASAP;
       fields.constraintDate = null;
       fields.progress = 0;
-      fields.expectedProgressBaseline = 0;
     }
   }
   return {
@@ -10403,6 +10405,18 @@ function findFirstSelectedSibling(taskId, selected, adapter) {
   }
   return firstSelected;
 }
+function hasAncestorInSet(activityId, candidates, adapter) {
+  const visited = /* @__PURE__ */ new Set([activityId]);
+  let parentId = normalizeParentKey(
+    adapter.getActivity(activityId)?.parentId
+  );
+  while (parentId !== ROOT_PARENT_ID && !visited.has(parentId)) {
+    if (candidates.has(parentId)) return true;
+    visited.add(parentId);
+    parentId = normalizeParentKey(adapter.getActivity(parentId)?.parentId);
+  }
+  return false;
+}
 function findPrevSiblingHelper(taskId, adapter) {
   const a = adapter.getActivity(taskId);
   if (!a) return null;
@@ -10469,16 +10483,13 @@ async function createActivityCore(action, deps, opts = {}) {
   const initialTouched = /* @__PURE__ */ new Set([newId]);
   if (parent) initialTouched.add(parent.id);
   const parentWasLeaf = parent !== null && adapter.getChildren(parent.id).length === 0;
+  const parentCustomId = parentWasLeaf ? parent?.customId : null;
   const beforeSnap = opts.skipBeforeSnap ? /* @__PURE__ */ new Map() : await snapshotActivities(adapter, initialTouched);
   adapter.addActivity(newActivity);
-  applyParentMutations(
-    action,
-    newId,
-    parent,
-    adapter,
-    opts.preserveParentCustomId ?? false,
-    parentWasLeaf
-  );
+  applyParentMutations(action, newId, parent, adapter, parentWasLeaf);
+  if (parentCustomId) {
+    deps.customIdTracker.releaseCustomId(parentCustomId);
+  }
   recomputeHhCascadeForActivity(newId, adapter);
   recomputeUsedCostCascadeForActivity(newId, adapter);
   recomputeCostCascadeForActivity(newId, adapter);
@@ -10548,7 +10559,7 @@ function assignCustomId(newActivity, action, deps, anchorSiblingId, parent, opts
       return;
     }
   }
-  const customIdAnchorId = anchorSiblingId ?? opts.customIdReferenceId;
+  const customIdAnchorId = opts.customIdReferenceId ?? anchorSiblingId;
   const derivesFromAnchor = customIdAnchorId !== void 0;
   const referenceActivity = derivesFromAnchor ? adapter.getActivity(customIdAnchorId) : parent;
   newActivity.customId = customIdTracker.generateCustomIdForNewChild({
@@ -10556,7 +10567,7 @@ function assignCustomId(newActivity, action, deps, anchorSiblingId, parent, opts
     useActivityCustomIdAsReference: derivesFromAnchor
   });
 }
-function applyParentMutations(action, newId, parent, adapter, preserveParentCustomId, parentWasLeaf) {
+function applyParentMutations(action, newId, parent, adapter, parentWasLeaf) {
   if (!parent) return;
   const parentMutations = buildParentMutations({
     parentId: action.parentId,
@@ -10566,8 +10577,6 @@ function applyParentMutations(action, newId, parent, adapter, preserveParentCust
   });
   if (!parentMutations) return;
   for (const [key, value] of Object.entries(parentMutations.fields)) {
-    const skipCustomIdMutation = key === ACTIVITY_PROPERTY.CUSTOM_ID && preserveParentCustomId;
-    if (skipCustomIdMutation) continue;
     setActivityFieldDynamic(adapter, parentMutations.parentId, key, value);
   }
   if (parentMutations.promotionSnapshot) {
@@ -10721,10 +10730,7 @@ async function dispatchActivityPaste(action, options, deps) {
       {
         skipCorrelativeRecompute: true,
         skipBeforeSnap: true,
-        ...mappedParent !== void 0 ? {
-          customIdReferenceId: action.referenceActivityId,
-          preserveParentCustomId: true
-        } : {}
+        customIdReferenceId: action.referenceActivityId
       }
     );
     if (!core.ok) return core;
@@ -11435,6 +11441,7 @@ async function dispatchActivityIndent(action, options, deps) {
   const failed = [];
   const succeededIds = [];
   const moves = [];
+  const plannedIds = /* @__PURE__ */ new Set();
   const blockingSet = new Set(selectedSet);
   const sortedIds = [...action.activityIds].sort((a, b) => {
     const aSnap = adapter.getActivity(a);
@@ -11453,6 +11460,7 @@ async function dispatchActivityIndent(action, options, deps) {
       blockingSet.delete(id);
       continue;
     }
+    if (hasAncestorInSet(id, plannedIds, adapter)) continue;
     const targetParentId = findPreviousNonSelectedSibling(
       id,
       blockingSet,
@@ -11469,6 +11477,7 @@ async function dispatchActivityIndent(action, options, deps) {
     const oldParentRaw = adapter.getActivity(id)?.parentId;
     const oldParentId = isRootParent(oldParentRaw) ? ROOT_PARENT_ID : String(oldParentRaw);
     moves.push({ activityId: id, newParentId: targetParentId, oldParentId });
+    plannedIds.add(id);
     touched.add(id);
     touched.add(targetParentId);
     if (oldParentId !== ROOT_PARENT_ID) touched.add(oldParentId);
@@ -11631,6 +11640,7 @@ async function dispatchActivityOutdent(action, options, deps) {
   const succeededIds = [];
   const oldParents = /* @__PURE__ */ new Set();
   const planned = [];
+  const plannedIds = /* @__PURE__ */ new Set();
   const sortedIds = [...action.activityIds].sort((a, b) => {
     const aSnap = adapter.getActivity(a);
     const bSnap = adapter.getActivity(b);
@@ -11648,6 +11658,7 @@ async function dispatchActivityOutdent(action, options, deps) {
       });
       continue;
     }
+    if (hasAncestorInSet(key, plannedIds, adapter)) continue;
     const oldParent = activity.parentId;
     if (isRootParent(oldParent)) {
       failed.push({
@@ -11689,6 +11700,7 @@ async function dispatchActivityOutdent(action, options, deps) {
       oldParentKey,
       targetIndexInGrandparent: targetIdx
     });
+    plannedIds.add(key);
     touched.add(String(key));
     touched.add(String(oldParentKey));
     if (grandparentKey !== ROOT_PARENT_ID) touched.add(String(grandparentKey));
@@ -12378,6 +12390,7 @@ function dispatchPersistenceAcknowledge(action, deps) {
     for (const assignment of activities) {
       const before = deps.adapter.getActivity(assignment.id);
       if (!before || before.proplannerId === assignment.proplannerId) continue;
+      const previousProplannerId = before.proplannerId;
       deps.adapter.setActivityField(
         assignment.id,
         "proplannerId",
@@ -12388,7 +12401,7 @@ function dispatchPersistenceAcknowledge(action, deps) {
         kind: "updated",
         fields: {
           proplannerId: {
-            before: before.proplannerId,
+            before: previousProplannerId,
             after: assignment.proplannerId
           }
         },
@@ -12398,13 +12411,14 @@ function dispatchPersistenceAcknowledge(action, deps) {
     for (const assignment of links) {
       const before = deps.adapter.getLink(assignment.id);
       if (!before || before.proplannerId === assignment.proplannerId) continue;
+      const previousProplannerId = before.proplannerId;
       deps.adapter.setLinkProplannerId(assignment.id, assignment.proplannerId);
       linkChanges.push({
         id: assignment.id,
         kind: "updated",
         fields: {
           proplannerId: {
-            before: before.proplannerId,
+            before: previousProplannerId,
             after: assignment.proplannerId
           }
         },
@@ -17035,7 +17049,6 @@ var PERSISTABLE_ACTIVITY_FIELDS = [
   "isLookahead",
   "newActivityIds",
   "hasNewActivities",
-  "pendingRequestIds",
   "responsableIds",
   "tagIds"
 ];
@@ -17047,7 +17060,6 @@ var DATE_FIELDS2 = /* @__PURE__ */ new Set([
 ]);
 var ID_ARRAY_FIELDS = /* @__PURE__ */ new Set([
   "newActivityIds",
-  "pendingRequestIds",
   "responsableIds",
   "tagIds"
 ]);
@@ -17105,10 +17117,15 @@ var SaveTracker = class {
     this.activitiesAtLastSave.clear();
     for (const activity of activities) {
       if (activity.proplannerId == null) continue;
-      this.activitiesAtLastSave.set(
-        String(activity.id),
-        projectPersistableActivity(activity)
-      );
+      this.activitiesAtLastSave.set(String(activity.id), {
+        persistable: projectPersistableActivity(activity),
+        deletedSnapshot: {
+          id: activity.id,
+          proplannerId: activity.proplannerId,
+          parentId: activity.parentId,
+          hadBaseline: activity.baselineSnapshot !== null || activity.baselinePoints.length > 0
+        }
+      });
     }
   }
   snapshotLinks(links) {
@@ -17116,11 +17133,51 @@ var SaveTracker = class {
     for (const link of links) {
       if (link.proplannerId == null) continue;
       this.linksAtLastSave.set(String(link.id), {
+        id: link.id,
+        proplannerId: link.proplannerId,
+        source: link.source,
+        target: link.target,
         lag: link.lag,
         type: link.type
       });
     }
   }
+  hasUnsavedChanges(activities, links) {
+    if (!this.initialized) return false;
+    if (this.deletedActivities(activities).length > 0) return true;
+    if (this.deletedLinks(links).length > 0) return true;
+    const activityChanged = activities.some((activity) => {
+      if (activity.proplannerId == null) return true;
+      const saved = this.activitiesAtLastSave.get(String(activity.id));
+      return !saved || activityChangedSince(activity, saved.persistable);
+    });
+    if (activityChanged) return true;
+    return links.some((link) => {
+      if (link.proplannerId == null) return true;
+      const saved = this.linksAtLastSave.get(String(link.id));
+      return !saved || link.lag !== saved.lag || link.type !== saved.type;
+    });
+  }
+  deletedActivities(activities) {
+    if (!this.initialized) return [];
+    const currentIds = new Set(
+      activities.map((activity) => String(activity.id))
+    );
+    const deleted = [];
+    for (const [activityId, saved] of this.activitiesAtLastSave) {
+      if (currentIds.has(activityId)) continue;
+      deleted.push({ ...saved.deletedSnapshot });
+    }
+    return deleted;
+  }
+  deletedLinks(links) {
+    if (!this.initialized) return [];
+    const currentIds = new Set(links.map((link) => String(link.id)));
+    return Array.from(
+      this.linksAtLastSave.entries(),
+      ([linkId, saved]) => currentIds.has(linkId) ? null : { ...saved }
+    ).filter((link) => link !== null);
+  }
   modifiedActivities(activities) {
     if (!this.initialized) return [];
     return activities.filter((activity) => {
@@ -17128,7 +17185,7 @@ var SaveTracker = class {
       if (activity.assignedDefaultCalendar) return true;
       const saved = this.activitiesAtLastSave.get(String(activity.id));
       if (!saved) return true;
-      return activityChangedSince(activity, saved);
+      return activityChangedSince(activity, saved.persistable);
     });
   }
   modifiedLinks(links) {
@@ -17288,7 +17345,7 @@ function parseActivity(raw, context) {
     hasCustomPonderator: raw.hasCustomPonderator,
     correlativeId: raw.correlative_id,
     uniqueCorrelativeId: raw.unique_correlative_id,
-    customId: raw.custom_id,
+    customId: normalizeCustomId(raw),
     subcontractId: raw.subcontractId,
     isLookahead: raw.isOnLookahead,
     hasLookaheadTasks: Array.isArray(raw.tasks) && raw.tasks.length > 0,
@@ -17312,6 +17369,9 @@ function parseActivity(raw, context) {
     criticalPath: null
   };
 }
+function normalizeCustomId(raw) {
+  return raw.has_childs ? null : raw.custom_id;
+}
 function forceRootProjectToRoot(activities) {
   const rootProject = activities.find(
     (activity) => activity.correlativeId === 0 && activity.type === "project"
@@ -18723,6 +18783,21 @@ var ScheduleCore = class {
     this.assertReady();
     return this._saveTracker.modifiedActivities(this.coreRuntime.state.getAllActivities()).map(cloneDomainValue);
   }
+  hasUnsavedChanges() {
+    this.assertReady();
+    return this._saveTracker.hasUnsavedChanges(
+      this.coreRuntime.state.getAllActivities(),
+      this.getAllLinksView()
+    );
+  }
+  getDeletedActivitiesSinceLastSave() {
+    this.assertReady();
+    return this._saveTracker.deletedActivities(this.coreRuntime.state.getAllActivities()).map(cloneDomainValue);
+  }
+  getDeletedLinksSinceLastSave() {
+    this.assertReady();
+    return this._saveTracker.deletedLinks(this.getAllLinksView()).map(cloneDomainValue);
+  }
   _enqueue(work) {
     const workPromise = this._opQueue.then(work, work);
     this._opQueue = workPromise.then(
@@ -19043,7 +19118,7 @@ var ScheduleCore = class {
       applyStatusPass(state, this.coreRuntime.sector.statusCriteria);
     }
   }
-  undo() {
+  undo(options = {}) {
     const operation = this._enqueue(async () => {
       this.assertReady();
       const entry = this._undo.takeUndo();
@@ -19063,7 +19138,7 @@ var ScheduleCore = class {
     });
     void operation.then(
       (changes) => {
-        if (changes) {
+        if (changes && options.skipCriticalPath !== true) {
           void this.recomputeCriticalPath().catch((error) => {
             this.coreRuntime.reporter.error(
               "[ScheduleCore] Critical Path recompute after undo failed",
@@ -19076,7 +19151,7 @@ var ScheduleCore = class {
     );
     return operation;
   }
-  redo() {
+  redo(options = {}) {
     const operation = this._enqueue(async () => {
       this.assertReady();
       const entry = this._undo.takeRedo();
@@ -19096,7 +19171,7 @@ var ScheduleCore = class {
     });
     void operation.then(
       (changes) => {
-        if (changes) {
+        if (changes && options.skipCriticalPath !== true) {
           void this.recomputeCriticalPath().catch((error) => {
             this.coreRuntime.reporter.error(
               "[ScheduleCore] Critical Path recompute after redo failed",