@outbuild-company/schedule-core 1.13.3 → 1.13.4

package/dist/index.d.cts

@@ -63,8 +63,8 @@ interface BaselineVersion {
 }
 /** Backend baseline point accepted at the package boundary. */
 interface BaselinePoint {
-    start_date: string;
-    end_date: string;
+    start_date: string | null;
+    end_date: string | null;
     /** Baseline duration in working days. */
     duration: number;
     cost: number | string;

package/dist/index.d.ts

@@ -63,8 +63,8 @@ interface BaselineVersion {
 }
 /** Backend baseline point accepted at the package boundary. */
 interface BaselinePoint {
-    start_date: string;
-    end_date: string;
+    start_date: string | null;
+    end_date: string | null;
     /** Baseline duration in working days. */
     duration: number;
     cost: number | string;

package/dist/index.js

@@ -15355,7 +15355,7 @@ function parseFiniteNonNegative(value) {
   if (!Number.isFinite(numeric) || numeric < 0) return null;
   return numeric;
 }
-function normalizeBaselinePoint(point, reporter, diagnostic) {
+function normalizeBaselinePoint(point, reporter, diagnostic, isMilestone = false) {
   const durationDays = parseFiniteNonNegative(point.duration);
   const cost = parseFiniteNonNegative(point.cost);
   const workHours = parseFiniteNonNegative(point.hh_work);
@@ -15371,9 +15371,17 @@ function normalizeBaselinePoint(point, reporter, diagnostic) {
     );
     return null;
   }
+  const startDate = parseBaselineDate(point.start_date);
+  const parsedEndDate = parseBaselineDate(point.end_date);
+  const hasInvertedLegacyMilestone = isMilestone && durationDays === 0 && startDate !== null && parsedEndDate !== null && parsedEndDate < startDate;
+  if (hasInvertedLegacyMilestone) {
+    reporter.warn(
+      "[baseline] normalizing inverted zero-duration milestone to one instant"
+    );
+  }
   return {
-    startDate: parseBaselineDate(point.start_date),
-    endDate: parseBaselineDate(point.end_date),
+    startDate,
+    endDate: hasInvertedLegacyMilestone ? startDate : parsedEndDate,
     durationDays,
     cost,
     workHours,
@@ -15417,14 +15425,20 @@ function applyBaselinePoints(adapter, points, reporter, recordDiagnostic = noopL
   }
   const changed = [];
   for (const [coreId, group] of grouped) {
+    const isMilestone = adapter.getActivity(coreId)?.type === ACTIVITY_TYPE.MILESTONE;
     adapter.setActivityField(
       coreId,
       "baselinePoints",
       group.map(
-        (point) => normalizeBaselinePoint(point, reporter, {
-          record: recordDiagnostic,
-          sampleId: coreId
-        })
+        (point) => normalizeBaselinePoint(
+          point,
+          reporter,
+          {
+            record: recordDiagnostic,
+            sampleId: coreId
+          },
+          isMilestone
+        )
       ).filter((point) => point !== null)
     );
     changed.push(coreId);
@@ -20909,13 +20923,18 @@ function parseCriticality(raw, reporter) {
   );
   return false;
 }
-function parseBaselinePoints(raw, reporter, recordDiagnostic, activityId) {
+function parseBaselinePoints(raw, reporter, recordDiagnostic, activityId, isMilestone) {
   if (!Array.isArray(raw)) return [];
   return raw.map(
-    (point) => normalizeBaselinePoint(point, reporter, {
-      record: recordDiagnostic,
-      sampleId: activityId
-    })
+    (point) => normalizeBaselinePoint(
+      point,
+      reporter,
+      {
+        record: recordDiagnostic,
+        sampleId: activityId
+      },
+      isMilestone
+    )
   ).filter((point) => point !== null);
 }
 function parseActivity(raw, context) {
@@ -20976,7 +20995,8 @@ function parseActivity(raw, context) {
       raw.baseline_points,
       context.reporter,
       context.recordDiagnostic,
-      String(raw.unique_id)
+      String(raw.unique_id),
+      isMilestone
     ),
     baselineSnapshot: null,
     recursiveDurationHours: durationToHours(