@outbuild-company/schedule-core 1.10.2 → 1.10.4

package/dist/index.d.cts

@@ -885,7 +885,6 @@ declare class ScheduleCore {
     private _reapplyActiveFilter;
     private _recordScheduleMutation;
     private _startCriticalPathForCurrentRevision;
-    private _runCriticalPathAndCapture;
     undo(options?: UndoOptions): Promise<ChangeSet | null>;
     private _runUndo;
     redo(options?: {

package/dist/index.d.ts

@@ -885,7 +885,6 @@ declare class ScheduleCore {
     private _reapplyActiveFilter;
     private _recordScheduleMutation;
     private _startCriticalPathForCurrentRevision;
-    private _runCriticalPathAndCapture;
     undo(options?: UndoOptions): Promise<ChangeSet | null>;
     private _runUndo;
     redo(options?: {

package/dist/index.js

@@ -4282,15 +4282,28 @@ var setDuration = (value) => ({
 });
 
 // src/columns/start-date/start-date-pipeline.ts
+var SIR_APPLY_EVENT_SOURCE = "sir-apply";
 var startDatePipeline = {
   targetField: "startDate",
-  canEdit(activity, hierarchy) {
+  canEdit(activity, hierarchy, edit) {
     if (isSummaryActivity2(activity, hierarchy)) {
       return cannotEdit("summary", "summary_column_value");
     }
-    if (hasProgress(activity)) {
+    if (!hasProgress(activity)) return canEdit();
+    if (edit?.eventSource !== SIR_APPLY_EVENT_SOURCE) {
       return cannotEdit("has_progress", "cant_edit_activity_with_progress");
     }
+    if (isCompletedActivity(activity)) {
+      return cannotEdit("completed", "cant_edit_completed_activity");
+    }
+    if (!isValidDate(edit.newValue)) return canEdit();
+    if (isSameDay(activity.startDate, edit.newValue)) return canEdit();
+    if (edit.newValue.getTime() > activity.startDate.getTime()) {
+      return cannotEdit(
+        "sir_start_after_progress",
+        "sir_cant_move_start_after_progress"
+      );
+    }
     return canEdit();
   },
   parseInput(rawValue, _activity, _ctx) {
@@ -9701,13 +9714,41 @@ async function createGanttAdapter(state, hoursPerDay) {
 
 // src/critical-path/run-critical-path.ts
 var CP_WRITE_YIELD_EVERY = 1e3;
-function fieldsForLink(rawResidual, sourceIsCritical, targetIsCritical, targetProgress) {
-  const freeSlackHours = typeof rawResidual === "number" && Number.isFinite(rawResidual) ? Object.is(rawResidual, -0) ? 0 : rawResidual : null;
+var finiteHoursOrNull = (value) => {
+  if (typeof value !== "number" || !Number.isFinite(value)) return null;
+  return Object.is(value, -0) ? 0 : value;
+};
+var linkFreeFloatDaysToHours = (valueDays, hoursPerDay) => {
+  if (typeof valueDays !== "number" || valueDays < 0) return null;
+  return slackDaysToHours(valueDays, hoursPerDay);
+};
+function fieldsForLink(input) {
+  const freeSlackHours = linkFreeFloatDaysToHours(
+    input.freeFloatDays,
+    input.hoursPerDay
+  );
+  const residualHours = finiteHoursOrNull(input.residualHours);
   return {
     freeSlackHours,
-    isCritical: freeSlackHours !== null && freeSlackHours <= 0 && sourceIsCritical && targetIsCritical && targetProgress === 0
+    isCritical: residualHours !== null && residualHours <= 0 && input.sourceIsCritical && input.targetIsCritical && input.targetProgress === 0
   };
 }
+async function collectLinkFreeFloatDays(freeFloat, isCurrent) {
+  const values = /* @__PURE__ */ new Map();
+  let sinceYield = 0;
+  for (const calculation of freeFloat.values()) {
+    for (const linkId in calculation.linksFreeFloat) {
+      if (!Object.hasOwn(calculation.linksFreeFloat, linkId)) continue;
+      if (++sinceYield >= CP_WRITE_YIELD_EVERY) {
+        sinceYield = 0;
+        await yieldToBrowser();
+        if (!isCurrent()) return null;
+      }
+      values.set(String(linkId), calculation.linksFreeFloat[linkId]);
+    }
+  }
+  return isCurrent() ? values : null;
+}
 async function collectActivityFields(state, maps, hoursPerDay, toCanonicalActivityId, isCurrent) {
   const fields = /* @__PURE__ */ new Map();
   let sinceYield = 0;
@@ -9733,7 +9774,7 @@ async function collectActivityFields(state, maps, hoursPerDay, toCanonicalActivi
   }
   return isCurrent() ? fields : null;
 }
-async function collectLinkFields(state, linkResidualHours, activityFields, isCurrent) {
+async function collectLinkFields(state, linkFreeFloatDays, linkResidualHours, activityFields, hoursPerDay, isCurrent) {
   const fields = /* @__PURE__ */ new Map();
   let sinceYield = 0;
   for (const link of state.getAllLinks()) {
@@ -9744,12 +9785,14 @@ async function collectLinkFields(state, linkResidualHours, activityFields, isCur
     }
     fields.set(
       String(link.id),
-      fieldsForLink(
-        linkResidualHours.get(String(link.id)),
-        activityFields.get(link.source)?.isCritical === true,
-        activityFields.get(link.target)?.isCritical === true,
-        state.getActivity(link.target)?.progress
-      )
+      fieldsForLink({
+        freeFloatDays: linkFreeFloatDays.get(String(link.id)),
+        residualHours: linkResidualHours.get(String(link.id)),
+        hoursPerDay,
+        sourceIsCritical: activityFields.get(link.source)?.isCritical === true,
+        targetIsCritical: activityFields.get(link.target)?.isCritical === true,
+        targetProgress: state.getActivity(link.target)?.progress
+      })
     );
   }
   return isCurrent() ? fields : null;
@@ -9832,10 +9875,17 @@ async function computeCriticalPathFields(state, hoursPerDay, isCurrent = () => t
     isCurrent
   );
   if (!activities) return null;
+  const linkFreeFloatDays = await collectLinkFreeFloatDays(
+    maps.freeFloat,
+    isCurrent
+  );
+  if (!linkFreeFloatDays) return null;
   const links = await collectLinkFields(
     state,
+    linkFreeFloatDays,
     criticalPath.linkResidualHours,
     activities,
+    hoursPerDay,
     isCurrent
   );
   return links ? { activities, links } : null;
@@ -13823,7 +13873,7 @@ async function dispatchBulkEdit(action, options, deps) {
   const warnings = [];
   let needsAutoSchedule = false;
   for (const edit of action.edits) {
-    const outcome = applyOneEdit2(edit, deps);
+    const outcome = applyOneEdit2(edit, deps, action.eventSource);
     verdicts.push(outcome.verdict);
     if (!outcome.verdict.ok || !outcome.changes) continue;
     const constraintWarning = toConstraintWarning(
@@ -13919,7 +13969,7 @@ async function dispatchBulkEdit(action, options, deps) {
     })
   };
 }
-function applyOneEdit2(edit, deps) {
+function applyOneEdit2(edit, deps, eventSource) {
   const { ctx } = deps;
   const activityId = edit.activityId;
   const pipeline = findPipelineForColumn(edit.column);
@@ -13944,7 +13994,10 @@ function applyOneEdit2(edit, deps) {
       changes: null
     };
   }
-  const editGate = pipeline.canEdit(activitySnap, ctx.hierarchy);
+  const editGate = pipeline.canEdit(activitySnap, ctx.hierarchy, {
+    eventSource,
+    newValue: edit.newValue
+  });
   if (!editGate.allowed) {
     return {
       verdict: {
@@ -21307,11 +21360,7 @@ var ScheduleCore = class _ScheduleCore {
       );
     });
     this._criticalPathReady = this._initPromise.then(
-      () => this._enqueue(async () => {
-        const result = await this._runCriticalPathAndCapture();
-        this._criticalPathRevision = this._scheduleRevision;
-        return result;
-      })
+      () => this._startCriticalPathForCurrentRevision()
     );
     const waitForCriticalPathOnLoad = input.criticalPathOnLoad === true;
     this._ready = waitForCriticalPathOnLoad ? this._criticalPathReady.then(() => void 0) : this._initPromise;
@@ -21949,39 +21998,6 @@ var ScheduleCore = class _ScheduleCore {
     void promise.then(clearIfActive, clearIfActive);
     return promise;
   }
-  async _runCriticalPathAndCapture() {
-    if (this._status === SCHEDULE_CORE_STATUS.DESTROYED) {
-      return {
-        changes: {
-          source: { kind: "init" },
-          activities: [],
-          links: [],
-          calendars: [],
-          trackingEvents: []
-        }
-      };
-    }
-    this.coreRuntime.state.beginWriteCapture();
-    this.coreRuntime.customIdTracker.beginCustomIdTransaction();
-    let changes;
-    try {
-      await applyCriticalPath(
-        this.coreRuntime.state,
-        this.coreRuntime.sector.hoursPerDay
-      );
-      changes = await assembleChangeSet(this.coreRuntime.state, {
-        source: { kind: "init" },
-        beforeSnap: /* @__PURE__ */ new Map(),
-        touchedIds: [],
-        scheduledIds: [],
-        hoursPerDay: this.coreRuntime.sector.hoursPerDay
-      });
-    } finally {
-      this.coreRuntime.state.endWriteCapture();
-      this.coreRuntime.customIdTracker.commitCustomIdTransaction();
-    }
-    return { changes };
-  }
   undo(options = {}) {
     const admitted = this._admitScheduleMutation();
     let changedState = false;