@ouro.bot/cli 0.1.0-alpha.915 → 0.1.0-alpha.916

package/changelog.json

@@ -1,6 +1,13 @@
 {
   "_note": "This changelog is maintained as part of the PR/version-bump workflow. Agent-curated, not auto-generated. Agents read this file directly via read_file to understand what changed between versions.",
   "versions": [
+    {
+      "version": "0.1.0-alpha.916",
+      "changes": [
+        "Security: the Teams sense waits for its bot credentials before listening and refuses to start without them (it used to start early in a developer mode that accepted messages from anyone); the daemon log no longer records values passed with --value, --secret, --password or --token.",
+        "Teams replies arrive: the reply was sent without a message type, so Teams dropped it and the chat showed a status bubble until \"This response was stopped\"; replies now finish with one AI label, no leading hourglass, and the status shows the current reasoning step's heading instead of raw reasoning. Delivery failures, and the Teams SDK's own warnings and errors, now reach the Teams log."
+      ]
+    },
     {
       "version": "0.1.0-alpha.915",
       "changes": [

package/deploy/unraid/sanctuary.ouro/bundle-meta.json

@@ -1,5 +1,5 @@
 {
-  "runtimeVersion": "0.1.0-alpha.915",
+  "runtimeVersion": "0.1.0-alpha.916",
   "bundleSchemaVersion": 3,
   "lastUpdated": "2026-09-03T00:00:00.000Z"
 }

package/deploy/unraid/sanctuary.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <Container version="2">
   <Name>ouro-butler</Name>
-  <Repository>ghcr.io/ourostack/ouroboros-butler:0.1.0-alpha.915</Repository>
+  <Repository>ghcr.io/ourostack/ouroboros-butler:0.1.0-alpha.916</Repository>
   <Registry>https://github.com/ourostack/ouroboros/pkgs/container/ouroboros-butler</Registry>
   <Network>host</Network>
   <Shell>sh</Shell>

package/dist/heart/daemon/cli-arg-redaction.js

@@ -0,0 +1,26 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.redactCliArgs = redactCliArgs;
+const runtime_1 = require("../../nerves/runtime");
+/** Flags whose next argument is a value the caller may consider secret. */
+const VALUE_FLAGS = new Set(["--value", "--secret", "--password", "--token"]);
+/**
+ * A command line that is safe to log: the argument after a value flag, and the value in
+ * `--flag=value`, is replaced. `ouro vault config set --value <secret>` is a supported way to
+ * store a credential, and the daemon log is not a place for it.
+ */
+function redactCliArgs(args) {
+    let redacted = 0;
+    const safe = args.map((arg, index) => {
+        const [flag] = arg.split("=", 1);
+        const afterFlag = index > 0 && VALUE_FLAGS.has(args[index - 1]);
+        const inline = arg.includes("=") && VALUE_FLAGS.has(flag);
+        if (afterFlag || inline)
+            redacted += 1;
+        return afterFlag ? "[redacted]" : inline ? `${flag}=[redacted]` : arg;
+    });
+    if (redacted > 0) {
+        (0, runtime_1.emitNervesEvent)({ component: "daemon", event: "daemon.cli_args_redacted", message: "kept command-line values out of the log", meta: { redacted } });
+    }
+    return safe;
+}

package/dist/heart/daemon/ouro-bot-entry.js

@@ -1,6 +1,7 @@
 #!/usr/bin/env node
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+const cli_arg_redaction_1 = require("./cli-arg-redaction");
 const runtime_1 = require("../../nerves/runtime");
 const runtime_logging_1 = require("./runtime-logging");
 const ouro_bot_wrapper_1 = require("../versioning/ouro-bot-wrapper");
@@ -9,7 +10,7 @@ const ouro_bot_wrapper_1 = require("../versioning/ouro-bot-wrapper");
     component: "daemon",
     event: "daemon.ouro_bot_entry_start",
     message: "starting ouro.bot wrapper entrypoint",
-    meta: { args: process.argv.slice(2) },
+    meta: { args: (0, cli_arg_redaction_1.redactCliArgs)(process.argv.slice(2)) },
 });
 void (0, ouro_bot_wrapper_1.runOuroBotWrapper)(process.argv.slice(2)).catch((error) => {
     const message = error instanceof Error ? error.message : String(error);

package/dist/heart/daemon/ouro-entry.js

@@ -2,6 +2,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 const runtime_1 = require("../../nerves/runtime");
+const cli_arg_redaction_1 = require("./cli-arg-redaction");
 const daemon_cli_1 = require("./daemon-cli");
 const runtime_logging_1 = require("./runtime-logging");
 (0, runtime_logging_1.configureDaemonRuntimeLogger)("ouro");
@@ -9,7 +10,7 @@ const runtime_logging_1 = require("./runtime-logging");
     component: "daemon",
     event: "daemon.cli_entry_start",
     message: "starting ouro CLI entrypoint",
-    meta: { args: process.argv.slice(2) },
+    meta: { args: (0, cli_arg_redaction_1.redactCliArgs)(process.argv.slice(2)) },
 });
 void (0, daemon_cli_1.runOuroCli)(process.argv.slice(2)).catch((error) => {
     const message = error instanceof Error ? error.message : String(error);

package/dist/heart/daemon/runtime-logging.js

@@ -52,7 +52,7 @@ function defaultLoggingForProcess(processName) {
             sinks: ["ndjson"],
         };
     }
-    if (processName === "telegram") {
+    if (processName === "telegram" || processName === "teams") {
         return {
             level: "info",
             sinks: ["terminal", "ndjson"],

package/dist/heart/versioning/ouro-bot-wrapper.js

@@ -34,6 +34,7 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.runOuroBotWrapper = runOuroBotWrapper;
+const cli_arg_redaction_1 = require("../daemon/cli-arg-redaction");
 const runtime_1 = require("../../nerves/runtime");
 const daemon_cli_1 = require("../daemon/daemon-cli");
 async function defaultLoadCanonicalRunner() {
@@ -57,7 +58,7 @@ async function runOuroBotWrapper(args, deps = {}) {
         component: "daemon",
         event: "daemon.ouro_bot_wrapper_start",
         message: "starting ouro.bot wrapper delegation",
-        meta: { args },
+        meta: { args: (0, cli_arg_redaction_1.redactCliArgs)(args) },
     });
     const loadCanonicalRunner = deps.loadCanonicalRunner ?? defaultLoadCanonicalRunner;
     const fallbackRunCli = deps.fallbackRunCli ?? daemon_cli_1.runOuroCli;

package/dist/senses/teams-entry.js

@@ -33,6 +33,7 @@ var __importStar = (this && this.__importStar) || (function () {
     };
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
+const runtime_logging_1 = require("../heart/daemon/runtime-logging");
 const runtime_1 = require("../nerves/runtime");
 // Fail fast if --agent is missing (before any src/ code tries getAgentName())
 const agentArgIndex = process.argv.indexOf("--agent");
@@ -42,14 +43,21 @@ if (!agentName) {
     console.error("Missing required --agent <name> argument.\nUsage: node dist/senses/teams-entry.js --agent ouroboros");
     process.exit(1);
 }
+// Without this the sense's events go to a console nobody reads: the daemon discards its output.
+(0, runtime_logging_1.configureDaemonRuntimeLogger)("teams");
 (0, runtime_1.emitNervesEvent)({
     component: "senses",
     event: "senses.entry_boot",
     message: "booting Teams entrypoint",
     meta: { entry: "teams", agentName },
 });
-Promise.resolve().then(() => __importStar(require("../heart/runtime-credentials"))).then(async ({ refreshRuntimeCredentialConfig }) => {
-    void refreshRuntimeCredentialConfig(agentName, { preserveCachedOnFailure: true }).catch(() => undefined);
+Promise.resolve().then(() => __importStar(require("../heart/runtime-credentials"))).then(async ({ waitForRuntimeCredentialBootstrap, readRuntimeCredentialConfig, refreshRuntimeCredentialConfig }) => {
+    // The bot's credentials must be loaded before the listener starts: without them the Teams SDK
+    // validates no sender, and startTeamsApp refuses to start.
+    const bootstrapped = await waitForRuntimeCredentialBootstrap(agentName);
+    if (!bootstrapped && !readRuntimeCredentialConfig(agentName).ok) {
+        await refreshRuntimeCredentialConfig(agentName, { preserveCachedOnFailure: true }).catch(() => undefined);
+    }
     const { startTeamsApp } = await Promise.resolve().then(() => __importStar(require("./teams")));
     startTeamsApp();
 })

package/dist/senses/teams.js

@@ -41,8 +41,10 @@ exports.sanitizeFeedbackComment = sanitizeFeedbackComment;
 exports.buildFeedbackSyntheticText = buildFeedbackSyntheticText;
 exports.buildWelcomeCard = buildWelcomeCard;
 exports.createTeamsCallbacks = createTeamsCallbacks;
+exports.reasoningStatus = reasoningStatus;
 exports.withConversationLock = withConversationLock;
 exports.handleTeamsMessage = handleTeamsMessage;
+exports.createTeamsSdkLogger = createTeamsSdkLogger;
 exports.sendProactiveTeamsMessageToSession = sendProactiveTeamsMessageToSession;
 exports.drainAndSendPendingTeams = drainAndSendPendingTeams;
 exports.startTeamsApp = startTeamsApp;
@@ -206,14 +208,29 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
     let lastPhrase = "";
     let flushTimer = null;
     const flushInterval = options?.flushIntervalMs ?? exports.DEFAULT_FLUSH_INTERVAL_MS;
+    // The SDK merges every chunk's entities into the final message, and Teams rejects a final
+    // message with more than one root message entity (400 BadSyntax), so only the first chunk
+    // carries the AI label.
+    let aiLabelAttached = false;
+    function streamChunk(text) {
+        if (aiLabelAttached)
+            return { type: "message", text, channelData: { feedbackLoopEnabled: true } };
+        aiLabelAttached = true;
+        return { type: "message", text, entities: aiLabelEntities(), channelData: { feedbackLoopEnabled: true } };
+    }
     // Track whether reasoning has changed since last flush (avoid redundant updates).
     let lastFlushedReasoningLen = 0;
+    let lastReasoningStatus = "";
     // Periodic tick: flush text buffer and push reasoning updates.
     function flushTick() {
         flushTextBuffer();
         if (reasoningBuf.length > lastFlushedReasoningLen) {
-            safeUpdate(reasoningBuf);
             lastFlushedReasoningLen = reasoningBuf.length;
+            const status = reasoningStatus(reasoningBuf);
+            if (status && status !== lastReasoningStatus) {
+                lastReasoningStatus = status;
+                safeUpdate(status);
+            }
         }
     }
     // Start the periodic flush timer. Idempotent -- no-op if already running.
@@ -230,9 +247,16 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
         }
     }
     // Mark stream as broken and abort the agent loop.
-    function markStopped() {
+    function markStopped(where, err) {
         if (stopped)
             return;
+        (0, runtime_1.emitNervesEvent)({
+            level: "warn",
+            component: "senses",
+            event: "teams.stream_stopped",
+            message: `teams stream stopped at ${where}`,
+            meta: { where, error: err instanceof Error ? err.message : err === undefined ? null : String(err), conversationId: options?.conversationId ?? null },
+        });
         stopped = true;
         stopPhraseRotation();
         stopFlushTimer();
@@ -248,7 +272,7 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
     // catch its rejection so we detect a dead stream and abort the agent loop.
     function catchAsync(result) {
         if (result && typeof result.catch === "function") {
-            result.catch(() => markStopped());
+            result.catch((err) => markStopped("stream-async", err));
         }
     }
     // Safely emit a text delta to the stream with AI labels.
@@ -258,12 +282,12 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
         if (stopped)
             return;
         try {
-            catchAsync(stream.emit({ text, entities: aiLabelEntities(), channelData: { feedbackLoopEnabled: true } }));
+            catchAsync(stream.emit(streamChunk(text)));
             streamHasContent = true;
             totalEmitted += text.length;
         }
-        catch {
-            markStopped();
+        catch (err) {
+            markStopped("safeEmit", err);
         }
     }
     // Awaitable emit — returns true if the emit succeeded, false if it failed.
@@ -275,15 +299,15 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
         try {
             // stream.emit() is typed as void but the Teams SDK returns a Promise
             // internally (async HTTP). Cast to capture the result for awaiting.
-            const result = stream.emit({ text, entities: aiLabelEntities(), channelData: { feedbackLoopEnabled: true } });
+            const result = stream.emit(streamChunk(text));
             streamHasContent = true;
             if (result && typeof result.then === "function") {
                 await result;
             }
             return true;
         }
-        catch {
-            markStopped();
+        catch (err) {
+            markStopped("tryEmit", err);
             return false;
         }
     }
@@ -296,7 +320,7 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
     // responsible for the `!stopped` precondition; no defensive guard here.
     async function tryEmitNoAbort(text) {
         try {
-            const result = stream.emit({ text, entities: aiLabelEntities(), channelData: { feedbackLoopEnabled: true } });
+            const result = stream.emit(streamChunk(text));
             streamHasContent = true;
             if (result && typeof result.then === "function") {
                 await result;
@@ -315,8 +339,8 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
         try {
             catchAsync(stream.update(text));
         }
-        catch {
-            markStopped();
+        catch (err) {
+            markStopped("safeUpdate", err);
         }
     }
     // Safely send a separate message via sendMessage (for content after first emit).
@@ -331,11 +355,11 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
             // Chain is idle -- start the send synchronously and mark busy
             sendChainBusy = true;
             try {
-                sendChain = sendMessage(text).catch(() => markStopped()).finally(() => { sendChainBusy = false; });
+                sendChain = sendMessage(text).catch((err) => markStopped("send", err)).finally(() => { sendChainBusy = false; });
             }
-            catch {
+            catch (err) {
                 sendChainBusy = false;
-                markStopped();
+                markStopped("send", err);
             }
         }
         else {
@@ -344,7 +368,7 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
                 if (stopped)
                     return;
                 return sendMessage(text);
-            }).catch(() => markStopped());
+            }).catch((err) => markStopped("send-queued", err));
         }
     }
     // Flush accumulated text buffer via safeEmit. The Teams SDK accumulates
@@ -429,9 +453,12 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
             /* v8 ignore next -- defensive guard: stopped set by prior error @preserve */
             if (stopped)
                 return;
-            stopPhraseRotation();
-            hadRealOutput = true;
             reasoningBuf += text;
+            // Keep the friendly phrases until a reasoning heading can replace them.
+            if (reasoningStatus(reasoningBuf)) {
+                stopPhraseRotation();
+                hadRealOutput = true;
+            }
             startFlushTimer();
         },
         onTextChunk: (text) => {
@@ -491,7 +518,7 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
                 // All delivery paths exhausted — now it is correct to abort the turn.
                 // markStopped() halts further stream activity and aborts the controller
                 // so the engine catches up and ends the turn cleanly.
-                markStopped();
+                markStopped("speak", lastError);
                 throw new Error(`teams speak delivery failed: ${lastError?.message ?? "no fallback available"}`);
             }
         },
@@ -508,7 +535,7 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
                 onToolStart: (name, args) => {
                     // speak is flow-control: its visible output is the message itself
                     // (delivered via onTextChunk + flushNow). Do NOT stop phrase rotation
-                    // here, do NOT emit the \u23f3 placeholder, do NOT post a tool-activity
+                    // here, do NOT post a tool-activity
                     // status update \u2014 all of those would create UI churn right before the
                     // actual speak content arrives.
                     if (name === "speak")
@@ -517,13 +544,6 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
                     // Force-flush any accumulated text, bypassing MIN_INITIAL_CHARS threshold
                     firstContentEmitted = true;
                     flushTextBuffer();
-                    // Emit a placeholder to satisfy the 15s Copilot timeout for initial
-                    // stream.emit(). Without this, long tool chains (e.g. ADO batch ops)
-                    // never emit before the timeout and the user sees "this response was
-                    // stopped". The placeholder is replaced by actual content on next emit.
-                    // https://learn.microsoft.com/en-us/answers/questions/2288017/m365-custom-engine-agents-timeout-message-after-15
-                    if (!streamHasContent)
-                        safeEmit("\u23f3");
                     toolCbs.onToolStart(name, args);
                     hadToolRun = true;
                 },
@@ -577,7 +597,7 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
                     // and fall through to sendMessage recovery.
                     const ok = await tryEmit(text);
                     if (!ok)
-                        markStopped();
+                        markStopped("flush");
                 }
                 if (stopped && !streamFinalized && sendMessage) {
                     // Stream is dead (not from finalization) — fall back to sendMessage; split on failure as recovery.
@@ -594,9 +614,22 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
             else if (!streamHasContent && !options?.suppressEmptyStreamMessage) {
                 safeEmit("(completed with tool calls only — no text response)");
             }
+            (0, runtime_1.emitNervesEvent)({
+                component: "senses",
+                event: "teams.flush_done",
+                message: "teams end-of-turn flush finished",
+                meta: { stopped, streamHasContent, streamFinalized, conversationId: options?.conversationId ?? null },
+            });
         },
     };
 }
+// The status bubble shows the latest reasoning heading (models write "**Heading**"
+// before each reasoning step), never the raw reasoning text itself.
+function reasoningStatus(reasoning) {
+    const headings = [...reasoning.matchAll(/\*\*([^*\n]+)\*\*/g)];
+    const last = headings.at(-1)?.[1]?.trim();
+    return last ? `${last}…` : null;
+}
 const _turnCoordinator = (0, turn_coordinator_1.createTurnCoordinator)();
 function teamsTurnKey(conversationId) {
     return `teams:${conversationId}`;
@@ -891,6 +924,7 @@ function createBotApp(teamsConfig) {
                 tenantId: teamsConfig.tenantId,
                 oauth: { defaultConnectionName: oauthConfig.graphConnectionName },
                 ...mentionStripping,
+                logger: createTeamsSdkLogger(),
             }),
             mode: "Bot Service (client secret)",
         };
@@ -903,21 +937,50 @@ function createBotApp(teamsConfig) {
                 ...(teamsConfig.managedIdentityClientId ? { managedIdentityClientId: teamsConfig.managedIdentityClientId } : {}),
                 oauth: { defaultConnectionName: oauthConfig.graphConnectionName },
                 ...mentionStripping,
+                logger: createTeamsSdkLogger(),
             }),
             mode: "Bot Service (managed identity)",
         };
     }
     else {
+        // With no credentials the Teams SDK validates no sender, so anyone who can reach the port can
+        // talk to the agent. That is only acceptable when a developer asks for it on their own machine.
+        if (process.env.OURO_TEAMS_DEVTOOLS !== "1") {
+            throw new Error("Teams bot credentials are missing (teams.clientId), so the Teams sense will not start: without them it would accept messages from anyone. Run `ouro connect teams`, or set OURO_TEAMS_DEVTOOLS=1 for local development with no real bot.");
+        }
         return {
             app: new teams_apps_1.App({
                 plugins: [new teams_dev_1.DevtoolsPlugin()],
                 ...mentionStripping,
+                logger: createTeamsSdkLogger(),
             }),
             mode: "DevtoolsPlugin",
         };
     }
 }
-/* v8 ignore stop */
+function createTeamsSdkLogger(name = "teams-sdk") {
+    const verbose = /stream/i.test(name);
+    const write = (level, msg) => {
+        if ((level === "debug" || level === "trace" || level === "info") && !verbose)
+            return;
+        (0, runtime_1.emitNervesEvent)({
+            level: level === "error" ? "error" : level === "warn" ? "warn" : "info",
+            component: "senses",
+            event: "teams.sdk_log",
+            message: `[${name}] ${msg.map((m) => (m instanceof Error ? m.message : typeof m === "string" ? m : JSON.stringify(m))).join(" ").slice(0, 300)}`,
+            meta: { logger: name, sdkLevel: level },
+        });
+    };
+    return {
+        debug: (...m) => write("debug", m),
+        info: (...m) => write("info", m),
+        warn: (...m) => write("warn", m),
+        error: (...m) => write("error", m),
+        trace: (...m) => write("trace", m),
+        log: (level, ...m) => write(level, m),
+        child: (child) => createTeamsSdkLogger(`${name}/${child}`),
+    };
+}
 // Register message, verify-state, and error handlers on an App instance.
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 function registerBotHandlers(app, label) {

package/npm-shrinkwrap.json

@@ -1,12 +1,12 @@
 {
   "name": "@ouro.bot/cli",
-  "version": "0.1.0-alpha.915",
+  "version": "0.1.0-alpha.916",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@ouro.bot/cli",
-      "version": "0.1.0-alpha.915",
+      "version": "0.1.0-alpha.916",
       "dependencies": {
         "@anthropic-ai/sdk": "^0.78.0",
         "@azure/identity": "^4.13.0",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ouro.bot/cli",
-  "version": "0.1.0-alpha.915",
+  "version": "0.1.0-alpha.916",
   "engines": {
     "node": ">=22"
   },