@ouro.bot/cli 0.1.0-alpha.55 → 0.1.0-alpha.551

package/dist/heart/daemon/skill-management-installer.js

@@ -0,0 +1,94 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ensureSkillManagement = ensureSkillManagement;
+const fs = __importStar(require("fs"));
+const path = __importStar(require("path"));
+const runtime_1 = require("../../nerves/runtime");
+const identity_1 = require("../identity");
+const SKILL_MANAGEMENT_URL = "https://raw.githubusercontent.com/ouroborosbot/ouroboros-skills/main/skills/skill-management/SKILL.md";
+async function ensureSkillManagement() {
+    const bundlesRoot = (0, identity_1.getAgentBundlesRoot)();
+    if (!fs.existsSync(bundlesRoot))
+        return;
+    // Find all agent bundles
+    const entries = fs.readdirSync(bundlesRoot).filter(e => e.endsWith(".ouro"));
+    if (entries.length === 0)
+        return;
+    // Check if ANY bundle is missing the skill
+    const missing = entries.filter(e => {
+        const targetPath = path.join(bundlesRoot, e, "skills", "skill-management.md");
+        return !fs.existsSync(targetPath);
+    });
+    if (missing.length === 0)
+        return;
+    // eslint-disable-next-line no-console -- terminal UX: visible install status
+    console.log("installing skill-management from ouroboros-skills...");
+    try {
+        const response = await fetch(SKILL_MANAGEMENT_URL);
+        if (!response.ok) {
+            // eslint-disable-next-line no-console -- terminal UX: visible install status
+            console.error(`✗ failed to fetch skill-management (HTTP ${response.status})`);
+            (0, runtime_1.emitNervesEvent)({
+                level: "warn",
+                component: "daemon",
+                event: "daemon.skill_management_install_error",
+                message: "failed to fetch skill-management from GitHub",
+                meta: { status: response.status, url: SKILL_MANAGEMENT_URL },
+            });
+            return;
+        }
+        const content = await response.text();
+        for (const bundle of missing) {
+            const skillsDir = path.join(bundlesRoot, bundle, "skills");
+            const targetPath = path.join(skillsDir, "skill-management.md");
+            fs.mkdirSync(skillsDir, { recursive: true });
+            fs.writeFileSync(targetPath, content, "utf-8");
+        }
+        // eslint-disable-next-line no-console -- terminal UX: visible install status
+        console.log(`✓ installed skill-management (${missing.length} agent${missing.length > 1 ? "s" : ""})`);
+    }
+    catch (error) {
+        // eslint-disable-next-line no-console -- terminal UX: visible install status
+        console.error(`✗ failed to install skill-management: ${error instanceof Error ? error.message : String(error)}`);
+        (0, runtime_1.emitNervesEvent)({
+            level: "warn",
+            component: "daemon",
+            event: "daemon.skill_management_install_error",
+            message: "failed to install skill-management skill",
+            meta: { error: error instanceof Error ? error.message : String(error) },
+        });
+    }
+}

package/dist/heart/daemon/socket-client.js

@@ -33,7 +33,8 @@ var __importStar = (this && this.__importStar) || (function () {
     };
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.DEFAULT_DAEMON_SOCKET_PATH = void 0;
+exports.DEFAULT_DAEMON_COMMAND_TIMEOUT_MS = exports.DEFAULT_DAEMON_SOCKET_PATH = void 0;
+exports.__bypassVitestGuardForTests = __bypassVitestGuardForTests;
 exports.sendDaemonCommand = sendDaemonCommand;
 exports.checkDaemonSocketAlive = checkDaemonSocketAlive;
 exports.requestInnerWake = requestInnerWake;
@@ -41,7 +42,82 @@ const fs = __importStar(require("fs"));
 const net = __importStar(require("net"));
 const runtime_1 = require("../../nerves/runtime");
 exports.DEFAULT_DAEMON_SOCKET_PATH = "/tmp/ouroboros-daemon.sock";
-function sendDaemonCommand(socketPath, command) {
+exports.DEFAULT_DAEMON_COMMAND_TIMEOUT_MS = 10 * 60 * 1000;
+/**
+ * Defense-in-depth: detect if we're running under vitest. Tests that forget
+ * to `vi.mock("../../heart/daemon/socket-client")` would otherwise leak real
+ * `inner.wake` commands (with whatever literal agent name the test uses,
+ * commonly "testagent") into whichever real daemon happens to be running on
+ * the developer's machine. That has caused real outages when test loops
+ * flooded the production-on-localhost daemon.
+ *
+ * We detect vitest via `process.argv` (not env vars — the project bans those)
+ * and convert all socket operations into safe no-ops. Individual tests are
+ * still expected to vi.mock this module so they can assert on call counts,
+ * but this guard guarantees that "I forgot to mock" can never again take
+ * down the daemon.
+ *
+ * The socket-client's OWN tests (which exercise the real functions against a
+ * test socket) call `__bypassVitestGuardForTests(true)` to opt out of the
+ * guard. We persist that flag on globalThis so it survives `vi.resetModules`
+ * (which clears the module cache between tests).
+ *
+ * HARDENING (cross-file leak protection): the bypass flag lives on globalThis
+ * and is process-wide. With vitest's default `fileParallelism: true`,
+ * concurrently-running test files in the same worker can have the bypass on
+ * even though they didn't ask for it — and any test that uses
+ * `name: "testagent"` and exercises a code path through this module will
+ * leak `inner.wake testagent` to the production daemon socket. We saw this
+ * cause a real outage on 2026-04-08 (daemon SIGTERMed mid-validation).
+ *
+ * Defense: even when the bypass flag is set, we ALWAYS hard-block calls that
+ * target the production daemon socket path. Test files that legitimately
+ * exercise the real socket-client code paths use a synthetic socket path like
+ * `/tmp/daemon.sock` or `/tmp/some-real-daemon.sock` — those keep working.
+ * Calls to `/tmp/ouroboros-daemon.sock` (DEFAULT_DAEMON_SOCKET_PATH) under
+ * vitest are unconditionally blocked, regardless of bypass state. This makes
+ * the cross-file leak vector impossible without restricting legitimate
+ * socket-client unit tests.
+ */
+const BYPASS_KEY = "__ouro_socket_client_bypass_vitest_guard__";
+/** ONLY for socket-client.test.ts. Do not call from any other test or production code. */
+function __bypassVitestGuardForTests(bypass) {
+    ;
+    globalThis[BYPASS_KEY] = bypass;
+}
+function isVitestProcess() {
+    /* v8 ignore next -- defensive: process and process.argv always exist in node @preserve */
+    if (typeof process === "undefined" || !Array.isArray(process.argv))
+        return false;
+    return process.argv.some((arg) => typeof arg === "string" && arg.includes("vitest"));
+}
+function isProductionDaemonSocket(socketPath) {
+    return socketPath === exports.DEFAULT_DAEMON_SOCKET_PATH;
+}
+/**
+ * Returns true when this socket call should be converted into a safe no-op
+ * because we're under vitest and the call would otherwise leak into a real
+ * daemon. The bypass flag short-circuits the guard for non-production socket
+ * paths only — production socket paths are ALWAYS blocked under vitest.
+ */
+function shouldSuppressSocketCall(socketPath) {
+    if (!isVitestProcess())
+        return false;
+    if (isProductionDaemonSocket(socketPath))
+        return true;
+    return globalThis[BYPASS_KEY] !== true;
+}
+function sendDaemonCommand(socketPath, command, options = {}) {
+    if (shouldSuppressSocketCall(socketPath)) {
+        (0, runtime_1.emitNervesEvent)({
+            level: "warn",
+            component: "daemon",
+            event: "daemon.socket_command_test_blocked",
+            message: "blocked socket command from leaking into real daemon under vitest",
+            meta: { socketPath, kind: command.kind, isProductionSocket: isProductionDaemonSocket(socketPath) },
+        });
+        return Promise.resolve({ ok: true, message: "test mode: socket call suppressed" });
+    }
     (0, runtime_1.emitNervesEvent)({
         component: "daemon",
         event: "daemon.socket_command_start",
@@ -51,14 +127,67 @@ function sendDaemonCommand(socketPath, command) {
     return new Promise((resolve, reject) => {
         const client = net.createConnection(socketPath);
         let raw = "";
+        let settled = false;
+        const timeoutMs = options.timeoutMs ?? exports.DEFAULT_DAEMON_COMMAND_TIMEOUT_MS;
+        const resolveOnce = (response) => {
+            /* v8 ignore next -- duplicate settlement guard; callers also guard event handlers before reaching this helper @preserve */
+            if (settled)
+                return;
+            settled = true;
+            resolve(response);
+        };
+        const rejectOnce = (error) => {
+            /* v8 ignore next -- duplicate timeout/error races should not re-reject the command promise @preserve */
+            if (settled)
+                return;
+            settled = true;
+            reject(error);
+        };
+        if ("setTimeout" in client && typeof client.setTimeout === "function") {
+            client.setTimeout(timeoutMs, () => {
+                const error = new Error(`Daemon command ${command.kind} timed out after ${timeoutMs}ms waiting for a response.`);
+                (0, runtime_1.emitNervesEvent)({
+                    level: "error",
+                    component: "daemon",
+                    event: "daemon.socket_command_timeout",
+                    message: "daemon socket command timed out",
+                    meta: {
+                        socketPath,
+                        kind: command.kind,
+                        timeoutMs,
+                        error: error.message,
+                    },
+                });
+                client.destroy();
+                rejectOnce(error);
+            });
+        }
         client.on("connect", () => {
-            client.write(JSON.stringify(command));
-            client.end();
+            // Write the command + newline delimiter. DO NOT call client.end()
+            // afterwards — the server closes the connection once it has written
+            // its response, which triggers our on("end") handler with the full
+            // response in `raw`.
+            //
+            // Calling client.end() here half-closes the TCP connection. The
+            // daemon server uses net.createServer() with the default
+            // allowHalfOpen: false, so when the server sees the client's FIN it
+            // auto-closes its own writable side — and any response the server
+            // tries to write after processing a long-running command (like
+            // agent.senseTurn, which runs a full LLM turn) gets dropped on the
+            // floor. Verified via repro: with client.end(), agent.senseTurn
+            // returns empty in ~149ms; without it, the same call returns the real
+            // response in ~5.8s. This is a regression of the fix in #303 that
+            // was silently reverted by 253e4b1f (commit titled "socket half-close
+            // fix" but actually *added* the half-close back).
+            client.write(JSON.stringify(command) + "\n");
         });
         client.on("data", (chunk) => {
             raw += chunk.toString("utf-8");
         });
         client.on("error", (error) => {
+            /* v8 ignore next -- duplicate post-settlement socket errors are ignored defensively @preserve */
+            if (settled)
+                return;
             (0, runtime_1.emitNervesEvent)({
                 level: "error",
                 component: "daemon",
@@ -70,9 +199,12 @@ function sendDaemonCommand(socketPath, command) {
                     error: error.message,
                 },
             });
-            reject(error);
+            rejectOnce(error);
         });
         client.on("end", () => {
+            /* v8 ignore next -- duplicate post-settlement socket end events are ignored defensively @preserve */
+            if (settled)
+                return;
             const trimmed = raw.trim();
             if (trimmed.length === 0 && command.kind === "daemon.stop") {
                 (0, runtime_1.emitNervesEvent)({
@@ -81,7 +213,7 @@ function sendDaemonCommand(socketPath, command) {
                     message: "daemon socket command completed",
                     meta: { socketPath, kind: command.kind, ok: true },
                 });
-                resolve({ ok: true, message: "daemon stopped" });
+                resolveOnce({ ok: true, message: "daemon stopped" });
                 return;
             }
             if (trimmed.length === 0) {
@@ -97,7 +229,7 @@ function sendDaemonCommand(socketPath, command) {
                         error: error.message,
                     },
                 });
-                reject(error);
+                rejectOnce(error);
                 return;
             }
             try {
@@ -112,7 +244,7 @@ function sendDaemonCommand(socketPath, command) {
                         ok: parsed.ok,
                     },
                 });
-                resolve(parsed);
+                resolveOnce(parsed);
             }
             catch (error) {
                 (0, runtime_1.emitNervesEvent)({
@@ -126,12 +258,15 @@ function sendDaemonCommand(socketPath, command) {
                         error: error instanceof Error ? error.message : String(error),
                     },
                 });
-                reject(error);
+                rejectOnce(error);
             }
         });
     });
 }
 function checkDaemonSocketAlive(socketPath) {
+    if (shouldSuppressSocketCall(socketPath)) {
+        return Promise.resolve(false);
+    }
     (0, runtime_1.emitNervesEvent)({
         component: "daemon",
         event: "daemon.socket_alive_check_start",
@@ -161,8 +296,10 @@ function checkDaemonSocketAlive(socketPath) {
             });
         }
         client.on("connect", () => {
-            client.write(JSON.stringify({ kind: "daemon.status" }));
-            client.end();
+            // Same half-close rationale as sendDaemonCommand: do NOT call
+            // client.end() here. The server closes after responding and that
+            // triggers the on("end") handler below.
+            client.write(JSON.stringify({ kind: "daemon.status" }) + "\n");
         });
         client.on("data", (chunk) => {
             raw += chunk.toString("utf-8");
@@ -184,6 +321,16 @@ function checkDaemonSocketAlive(socketPath) {
     });
 }
 async function requestInnerWake(agent, socketPath = exports.DEFAULT_DAEMON_SOCKET_PATH) {
+    if (shouldSuppressSocketCall(socketPath)) {
+        (0, runtime_1.emitNervesEvent)({
+            level: "warn",
+            component: "daemon",
+            event: "daemon.inner_wake_test_blocked",
+            message: "blocked inner wake from leaking into real daemon under vitest",
+            meta: { agent, socketPath, isProductionSocket: isProductionDaemonSocket(socketPath) },
+        });
+        return null;
+    }
     const socketAvailable = fs.existsSync(socketPath);
     (0, runtime_1.emitNervesEvent)({
         component: "daemon",

package/dist/heart/daemon/stale-bundle-prune.js

@@ -0,0 +1,96 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.pruneStaleEphemeralBundles = pruneStaleEphemeralBundles;
+const fs = __importStar(require("fs"));
+const path = __importStar(require("path"));
+const identity_1 = require("../identity");
+const runtime_1 = require("../../nerves/runtime");
+/**
+ * Scan the bundles root for `.ouro` directories that have no `agent.json`
+ * file (definitively dead ephemeral bundles) and delete them.
+ *
+ * Returns a list of pruned bundle directory names (e.g. `["stale.ouro"]`)
+ * for display purposes. Bundles that have `agent.json` -- even if disabled
+ * -- are never deleted. Errors on individual bundles are swallowed so that
+ * one permission-denied doesn't block pruning the rest.
+ */
+function pruneStaleEphemeralBundles(deps = {}) {
+    const bundlesRoot = deps.bundlesRoot ?? (0, identity_1.getAgentBundlesRoot)();
+    const readdirSync = deps.readdirSync ?? fs.readdirSync;
+    const existsSync = deps.existsSync ?? fs.existsSync;
+    const rmSync = deps.rmSync ?? fs.rmSync;
+    let entries;
+    try {
+        entries = readdirSync(bundlesRoot, { withFileTypes: true });
+    }
+    catch {
+        return [];
+    }
+    const pruned = [];
+    for (const entry of entries) {
+        if (!entry.isDirectory() || !entry.name.endsWith(".ouro"))
+            continue;
+        const bundlePath = path.join(bundlesRoot, entry.name);
+        const agentJsonPath = path.join(bundlePath, "agent.json");
+        if (existsSync(agentJsonPath))
+            continue;
+        try {
+            rmSync(bundlePath, { recursive: true, force: true });
+            pruned.push(entry.name);
+            (0, runtime_1.emitNervesEvent)({
+                level: "info",
+                component: "daemon",
+                event: "daemon.stale_bundle_pruned",
+                message: `pruned stale ephemeral bundle: ${entry.name}`,
+                meta: { bundle: entry.name, bundlePath },
+            });
+        }
+        catch (error) {
+            (0, runtime_1.emitNervesEvent)({
+                level: "warn",
+                component: "daemon",
+                event: "daemon.stale_bundle_prune_error",
+                message: `failed to prune stale bundle: ${entry.name}`,
+                meta: {
+                    bundle: entry.name,
+                    bundlePath,
+                    error: error instanceof Error ? error.message : String(error),
+                },
+            });
+        }
+    }
+    return pruned;
+}