@ouro.bot/cli 0.1.0-alpha.504 → 0.1.0-alpha.506

package/changelog.json

@@ -1,6 +1,22 @@
 {
   "_note": "This changelog is maintained as part of the PR/version-bump workflow. Agent-curated, not auto-generated. Agents read this file directly via read_file to understand what changed between versions.",
   "versions": [
+    {
+      "version": "0.1.0-alpha.506",
+      "changes": [
+        "Detect duplicate tool_call_id across assistant messages in `validateSessionMessages`. MiniMax-M2.7 emits canonical tool_call ids of the form `call_function_<hash>_<n>` and reuses the same id across turns when the same function gets called — which causes provider rejections on replay because tool_call_id is supposed to be unique per request. The session sanitize pass already had position-aware orphan detection (#613) and inline-reasoning strip (#612); this adds the third member of the family — collision detection.",
+        "New exported `detectDuplicateToolCallIds(messages)` returns `{ id, indices }[]` for each tool_call_id that appears in multiple assistant messages. Same-message duplicates (one assistant calling the same id twice) are not flagged — those are a legitimate parallel-call shape. `validateSessionMessages` now folds collisions into its violations list with a message that calls out MiniMax specifically so operators reading nerves know what they're looking at.",
+        "Detection only — no rewriting yet, since rewriting tool_call_ids and the matching tool_results requires careful pairing logic that risks regression. The collision is visible to operators via the `mind.session_invariant_violation` nerves event the sanitize pass already emits when violations are present, and the existing `nerves-review` CLI from #622 makes it filterable. 3 new tests cover collision detection, single-message parallel-call shape (no false positive), and the all-distinct happy path."
+      ]
+    },
+    {
+      "version": "0.1.0-alpha.505",
+      "changes": [
+        "New `ouro session-stats <session.json>` CLI for at-a-glance metrics on a saved session: total events, breakdown by role (system/user/assistant/tool), tool-call totals + top 5 by frequency, attachment count, time range with duration, projection breakdown (in/out, input tokens, max tokens, trimmed), and last usage. Read-only.",
+        "Pure `computeSessionStats(envelope, path)` core in `src/heart/session-stats.ts` — testable with synthesized envelopes, embeddable in future doctor checks. `runSessionStats(path)` adds the file-load layer; `formatStatsReport(report)` renders human-readable text; `--json` mode for jq piping. Composes with #619 (session-playback) and #622 (nerves-review): three pure-analyzer-plus-thin-CLI tools that together make a stuck session immediately diagnosable end-to-end.",
+        "8 tests cover role counts, tool-call name aggregation with frequency-sorted top-5, time range with and without authoredAt timestamps, attachment counting, projection-omission detection, the unrecognized-envelope stub, CLI no-args help, and CLI --json output. Wired as `npm run session:stats -- <path>` and `dist/heart/session-stats-cli-main.js`."
+      ]
+    },
     {
       "version": "0.1.0-alpha.504",
       "changes": [

package/dist/heart/session-events.js

@@ -35,6 +35,7 @@ var __importStar = (this && this.__importStar) || (function () {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.normalizeContinuityState = normalizeContinuityState;
 exports.validateSessionMessages = validateSessionMessages;
+exports.detectDuplicateToolCallIds = detectDuplicateToolCallIds;
 exports.repairSessionMessages = repairSessionMessages;
 exports.migrateToolNames = migrateToolNames;
 exports.sanitizeProviderMessages = sanitizeProviderMessages;
@@ -305,8 +306,49 @@ function validateSessionMessages(messages) {
         sawToolResultSincePrevAssistant = false;
         prevNonToolRole = msg.role;
     }
+    for (const collision of detectDuplicateToolCallIds(messages)) {
+        violations.push(`duplicate tool_call_id '${collision.id}' across assistant messages at indices ${collision.indices.join(", ")} — provider may reject (MiniMax canonicalizes call_function_<hash>_<n> across turns)`);
+    }
     return violations;
 }
+/**
+ * Detect tool_call_ids that appear in more than one assistant message
+ * within the conversation. MiniMax-M2.7 in particular emits canonical
+ * ids of the form `call_function_<hash>_<n>` and reuses the same id
+ * across turns when the same function is called — which causes provider
+ * rejections on replay because tool_call_id is supposed to be unique
+ * per request. We don't (yet) rewrite these here; this function exists
+ * so the sanitize pipeline can surface the collision through nerves
+ * (`mind.session_invariant_violation`) and operators can decide.
+ *
+ * Same-message duplicates (one assistant calling the same id twice)
+ * are not collisions — they're a legitimate parallel call shape and
+ * would be handled by the assistant's own emit logic. We only flag
+ * cross-message reuse.
+ */
+function detectDuplicateToolCallIds(messages) {
+    const idsByFirstIndex = new Map();
+    for (let i = 0; i < messages.length; i++) {
+        const msg = normalizeMessage(messages[i]);
+        if (msg.role !== "assistant")
+            continue;
+        const seenInThisMessage = new Set();
+        for (const call of msg.toolCalls) {
+            if (!call.id || seenInThisMessage.has(call.id))
+                continue;
+            seenInThisMessage.add(call.id);
+            const indices = idsByFirstIndex.get(call.id) ?? [];
+            indices.push(i);
+            idsByFirstIndex.set(call.id, indices);
+        }
+    }
+    const collisions = [];
+    for (const [id, indices] of idsByFirstIndex) {
+        if (indices.length > 1)
+            collisions.push({ id, indices });
+    }
+    return collisions;
+}
 function repairSessionMessages(messages) {
     const normalized = messages.map(normalizeMessage);
     const violations = validateSessionMessages(messages);

package/dist/heart/session-stats-cli-main.js

@@ -0,0 +1,5 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const session_stats_1 = require("./session-stats");
+const code = (0, session_stats_1.runSessionStatsCli)(process.argv.slice(2));
+process.exit(code);

package/dist/heart/session-stats.js

@@ -0,0 +1,182 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.computeSessionStats = computeSessionStats;
+exports.runSessionStats = runSessionStats;
+exports.formatStatsReport = formatStatsReport;
+exports.runSessionStatsCli = runSessionStatsCli;
+const fs = __importStar(require("node:fs"));
+const session_events_1 = require("./session-events");
+const ROLES = ["system", "user", "assistant", "tool"];
+function emptyByRole() {
+    const counts = {};
+    for (const role of ROLES)
+        counts[role] = 0;
+    return counts;
+}
+function eventTimeMs(event) {
+    const value = event.time.authoredAt ?? event.time.observedAt ?? null;
+    if (!value)
+        return null;
+    const ms = Date.parse(value);
+    return Number.isFinite(ms) ? ms : null;
+}
+function computeSessionStats(envelope, sessionPath) {
+    const byRole = emptyByRole();
+    let toolCallTotal = 0;
+    let attachments = 0;
+    const toolNameCounts = new Map();
+    let earliestMs = null;
+    let latestMs = null;
+    for (const event of envelope.events) {
+        byRole[event.role] = (byRole[event.role] ?? 0) + 1;
+        attachments += event.attachments.length;
+        for (const call of event.toolCalls) {
+            toolCallTotal += 1;
+            const name = call.function.name;
+            toolNameCounts.set(name, (toolNameCounts.get(name) ?? 0) + 1);
+        }
+        const ms = eventTimeMs(event);
+        if (ms !== null) {
+            if (earliestMs === null || ms < earliestMs)
+                earliestMs = ms;
+            if (latestMs === null || ms > latestMs)
+                latestMs = ms;
+        }
+    }
+    const top = [...toolNameCounts.entries()]
+        .sort((left, right) => right[1] - left[1])
+        .slice(0, 5)
+        .map(([name, count]) => ({ name, count }));
+    return {
+        sessionPath,
+        envelopeVersion: envelope.version,
+        totalEvents: envelope.events.length,
+        byRole,
+        toolCalls: {
+            total: toolCallTotal,
+            distinctNames: toolNameCounts.size,
+            topByFrequency: top,
+        },
+        attachments,
+        timeRange: {
+            earliest: earliestMs !== null ? new Date(earliestMs).toISOString() : null,
+            latest: latestMs !== null ? new Date(latestMs).toISOString() : null,
+            durationMs: earliestMs !== null && latestMs !== null ? latestMs - earliestMs : null,
+        },
+        projection: {
+            eventCount: envelope.projection.eventIds.length,
+            omittedFromProjection: Math.max(0, envelope.events.length - envelope.projection.eventIds.length),
+            inputTokens: envelope.projection.inputTokens,
+            maxTokens: envelope.projection.maxTokens,
+            trimmed: envelope.projection.trimmed,
+        },
+        lastUsage: envelope.lastUsage,
+    };
+}
+function runSessionStats(sessionPath) {
+    const text = fs.readFileSync(sessionPath, "utf-8");
+    const raw = JSON.parse(text);
+    const envelope = (0, session_events_1.parseSessionEnvelope)(raw);
+    if (!envelope) {
+        return {
+            sessionPath,
+            envelopeVersion: null,
+            totalEvents: 0,
+            byRole: emptyByRole(),
+            toolCalls: { total: 0, distinctNames: 0, topByFrequency: [] },
+            attachments: 0,
+            timeRange: { earliest: null, latest: null, durationMs: null },
+            projection: { eventCount: 0, omittedFromProjection: 0, inputTokens: null, maxTokens: null, trimmed: false },
+            lastUsage: null,
+        };
+    }
+    return computeSessionStats(envelope, sessionPath);
+}
+function formatStatsReport(report) {
+    const lines = [];
+    lines.push(`Session stats: ${report.sessionPath}`);
+    if (report.envelopeVersion === null) {
+        lines.push("  envelope: unrecognized (could not parse)");
+        return lines.join("\n");
+    }
+    lines.push(`  envelope version: ${report.envelopeVersion}`);
+    lines.push(`  total events:     ${report.totalEvents}`);
+    lines.push(`  by role:          system=${report.byRole.system} user=${report.byRole.user} assistant=${report.byRole.assistant} tool=${report.byRole.tool}`);
+    lines.push(`  tool calls:       ${report.toolCalls.total} (${report.toolCalls.distinctNames} distinct names)`);
+    if (report.toolCalls.topByFrequency.length > 0) {
+        lines.push("  top tools:");
+        for (const { name, count } of report.toolCalls.topByFrequency) {
+            lines.push(`    ${name}: ${count}`);
+        }
+    }
+    lines.push(`  attachments:      ${report.attachments}`);
+    if (report.timeRange.earliest && report.timeRange.latest) {
+        const durationSec = report.timeRange.durationMs !== null ? Math.round(report.timeRange.durationMs / 1000) : null;
+        lines.push(`  time range:       ${report.timeRange.earliest} → ${report.timeRange.latest}${durationSec !== null ? ` (${durationSec}s)` : ""}`);
+    }
+    lines.push("  projection:");
+    lines.push(`    in projection:  ${report.projection.eventCount}`);
+    lines.push(`    omitted:        ${report.projection.omittedFromProjection}`);
+    if (report.projection.inputTokens !== null)
+        lines.push(`    input tokens:   ${report.projection.inputTokens}`);
+    if (report.projection.maxTokens !== null)
+        lines.push(`    max tokens:     ${report.projection.maxTokens}`);
+    if (report.projection.trimmed)
+        lines.push("    trimmed:        true");
+    if (report.lastUsage) {
+        lines.push(`  last usage:       ${JSON.stringify(report.lastUsage)}`);
+    }
+    return lines.join("\n");
+}
+function runSessionStatsCli(argv) {
+    const positional = argv.filter((token) => !token.startsWith("--"));
+    const flags = new Set(argv.filter((token) => token.startsWith("--")));
+    if (flags.has("--help") || flags.has("-h") || positional.length === 0) {
+        // eslint-disable-next-line no-console -- meta-tooling
+        console.log("usage: ouro session-stats <session.json> [--json]");
+        return positional.length === 0 ? 2 : 0;
+    }
+    const report = runSessionStats(positional[0]);
+    if (flags.has("--json")) {
+        // eslint-disable-next-line no-console -- meta-tooling
+        console.log(JSON.stringify(report, null, 2));
+    }
+    else {
+        // eslint-disable-next-line no-console -- meta-tooling
+        console.log(formatStatsReport(report));
+    }
+    return 0;
+}

package/dist/mind/context.js

@@ -33,7 +33,7 @@ var __importStar = (this && this.__importStar) || (function () {
     };
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.validateSessionMessages = exports.repairSessionMessages = exports.migrateToolNames = void 0;
+exports.validateSessionMessages = exports.repairSessionMessages = exports.migrateToolNames = exports.detectDuplicateToolCallIds = void 0;
 exports.trimMessages = trimMessages;
 exports.saveSession = saveSession;
 exports.appendSyntheticAssistantMessage = appendSyntheticAssistantMessage;
@@ -50,6 +50,7 @@ const fs = __importStar(require("fs"));
 const path = __importStar(require("path"));
 const token_estimate_1 = require("./token-estimate");
 var session_events_2 = require("../heart/session-events");
+Object.defineProperty(exports, "detectDuplicateToolCallIds", { enumerable: true, get: function () { return session_events_2.detectDuplicateToolCallIds; } });
 Object.defineProperty(exports, "migrateToolNames", { enumerable: true, get: function () { return session_events_2.migrateToolNames; } });
 Object.defineProperty(exports, "repairSessionMessages", { enumerable: true, get: function () { return session_events_2.repairSessionMessages; } });
 Object.defineProperty(exports, "validateSessionMessages", { enumerable: true, get: function () { return session_events_2.validateSessionMessages; } });

package/dist/nerves/coverage/file-completeness.js

@@ -129,6 +129,10 @@ const DISPATCH_EXEMPT_PATTERNS = [
     // lives at the caller (tools-mail.ts mail_body handler) which fires
     // repertoire.mail_body_cache_hit on cache reuse.
     "mailroom/body-cache",
+    // Session stats: read-only session.json analyzer CLI for debugging.
+    // Diagnostics-only utility; output is human-readable summary.
+    "heart/session-stats-cli-main",
+    "heart/session-stats",
 ];
 function isDispatchExempt(filePath) {
     return DISPATCH_EXEMPT_PATTERNS.some((pattern) => filePath.includes(pattern));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ouro.bot/cli",
-  "version": "0.1.0-alpha.504",
+  "version": "0.1.0-alpha.506",
   "main": "dist/heart/daemon/ouro-entry.js",
   "bin": {
     "cli": "dist/heart/daemon/ouro-bot-entry.js",