@ouro.bot/cli 0.1.0-alpha.275 → 0.1.0-alpha.276

package/changelog.json

@@ -1,6 +1,12 @@
 {
   "_note": "This changelog is maintained as part of the PR/version-bump workflow. Agent-curated, not auto-generated. Agents read this file directly via read_file to understand what changed between versions.",
   "versions": [
+    {
+      "version": "0.1.0-alpha.276",
+      "changes": [
+        "fix(nerves): root-cause the `start_end_pairing` audit flake on `daemon.server_start`, `daemon.update_checker_start`, and `daemon.apply_pending_updates_start`. Three fixes: (1) `applyPendingUpdates` in `update-hooks.ts` now wraps its body in try/finally so `_end` always fires, including on the early returns for `!fs.existsSync(bundlesRoot)` and `readdirSync` throws that previously orphaned the `_start`. (2) `daemon.start()` now wraps the ~380-line startup body in a try/catch that emits `daemon.server_error` with the error message and rethrows — the audit's pairing rule accepts `_end` OR `_error` as a valid closure for a `_start`, so startup throws no longer orphan `server_start`. The body was extracted to a private `startInner()` method to keep the try/catch small and readable. (3) `startUpdateChecker` callers in the update-checker test suite were already paired via an `afterEach(stopUpdateChecker)`; audited and confirmed no new unpaired callers. Also adds a vitest `afterEach` pairing guard in `src/__tests__/nerves/global-capture.ts` that fails loudly on any orphaned lifecycle `_start` in a test's per-test event stream — scoped to the three lifecycle events above so it catches regressions without false-positiving on legitimate narrow-slice operational events like `repertoire.task_scan_start`. New `src/__tests__/nerves/pairing-regression.test.ts` locks in the contract with 5 tests (nonexistent-dir, readdirSync-throws, happy-path, startUpdateChecker-pair, daemon-start-throw). Three consecutive `npm run test:coverage` runs confirm zero flakes on the target events."
+      ]
+    },
     {
       "version": "0.1.0-alpha.275",
       "changes": [

package/dist/heart/daemon/daemon.js

@@ -397,6 +397,26 @@ class OuroDaemon {
             message: "starting daemon server",
             meta: { socketPath: this.socketPath },
         });
+        try {
+            await this.startInner();
+        }
+        catch (err) {
+            // Emit a paired terminating event (`_error`) so the nerves audit's
+            // start_end_pairing rule is satisfied when startup throws mid-sequence
+            // and `stop()` (which emits `server_end`) is never called.
+            (0, runtime_1.emitNervesEvent)({
+                level: "error",
+                component: "daemon",
+                event: "daemon.server_error",
+                message: "daemon start failed",
+                meta: {
+                    error: err instanceof Error ? err.message : /* v8 ignore next -- defensive: non-Error catch branch @preserve */ String(err),
+                },
+            });
+            throw err;
+        }
+    }
+    async startInner() {
         // Register update hooks and apply pending updates before starting agents
         (0, update_hooks_1.registerUpdateHook)(bundle_meta_1.bundleMetaHook);
         (0, update_hooks_1.registerUpdateHook)(agent_config_v2_1.agentConfigV2Hook);

package/dist/heart/versioning/update-hooks.js

@@ -65,74 +65,78 @@ async function applyPendingUpdates(bundlesRoot, currentVersion) {
         message: "applying pending updates",
         meta: { bundlesRoot, currentVersion },
     });
-    if (!fs.existsSync(bundlesRoot)) {
-        return summary;
-    }
-    let entries;
     try {
-        entries = fs.readdirSync(bundlesRoot, { withFileTypes: true });
-    }
-    catch {
-        return summary;
-    }
-    for (const entry of entries) {
-        if (!entry.isDirectory() || !entry.name.endsWith(".ouro"))
-            continue;
-        const agentRoot = path.join(bundlesRoot, entry.name);
-        let previousVersion;
-        const metaPath = path.join(agentRoot, "bundle-meta.json");
+        if (!fs.existsSync(bundlesRoot)) {
+            return summary;
+        }
+        let entries;
         try {
-            if (fs.existsSync(metaPath)) {
-                const raw = fs.readFileSync(metaPath, "utf-8");
-                const meta = JSON.parse(raw);
-                previousVersion = meta.runtimeVersion;
-                if (previousVersion === currentVersion) {
-                    continue;
-                }
-                // Skip downgrades — only update forward
-                if (semver.valid(previousVersion) && semver.valid(currentVersion) && semver.gte(previousVersion, currentVersion)) {
-                    (0, runtime_1.emitNervesEvent)({
-                        component: "daemon",
-                        event: "daemon.update_hook_skip_downgrade",
-                        message: "skipping downgrade",
-                        meta: { agentRoot, previousVersion, currentVersion },
-                    });
-                    continue;
-                }
-            }
+            entries = fs.readdirSync(bundlesRoot, { withFileTypes: true });
         }
         catch {
-            // Malformed or unreadable bundle-meta.json -- treat as needing update
-            previousVersion = undefined;
+            return summary;
         }
-        const ctx = { agentRoot, currentVersion, previousVersion };
-        for (const hook of _hooks) {
+        for (const entry of entries) {
+            if (!entry.isDirectory() || !entry.name.endsWith(".ouro"))
+                continue;
+            const agentRoot = path.join(bundlesRoot, entry.name);
+            let previousVersion;
+            const metaPath = path.join(agentRoot, "bundle-meta.json");
             try {
-                await hook(ctx);
+                if (fs.existsSync(metaPath)) {
+                    const raw = fs.readFileSync(metaPath, "utf-8");
+                    const meta = JSON.parse(raw);
+                    previousVersion = meta.runtimeVersion;
+                    if (previousVersion === currentVersion) {
+                        continue;
+                    }
+                    // Skip downgrades — only update forward
+                    if (semver.valid(previousVersion) && semver.valid(currentVersion) && semver.gte(previousVersion, currentVersion)) {
+                        (0, runtime_1.emitNervesEvent)({
+                            component: "daemon",
+                            event: "daemon.update_hook_skip_downgrade",
+                            message: "skipping downgrade",
+                            meta: { agentRoot, previousVersion, currentVersion },
+                        });
+                        continue;
+                    }
+                }
+            }
+            catch {
+                // Malformed or unreadable bundle-meta.json -- treat as needing update
+                previousVersion = undefined;
             }
-            catch (err) {
-                (0, runtime_1.emitNervesEvent)({
-                    component: "daemon",
-                    event: "daemon.update_hook_error",
-                    message: "update hook threw",
-                    meta: {
-                        agentRoot,
-                        error: err instanceof Error ? err.message : /* v8 ignore next -- defensive: non-Error catch branch @preserve */ String(err),
-                    },
-                });
+            const ctx = { agentRoot, currentVersion, previousVersion };
+            for (const hook of _hooks) {
+                try {
+                    await hook(ctx);
+                }
+                catch (err) {
+                    (0, runtime_1.emitNervesEvent)({
+                        component: "daemon",
+                        event: "daemon.update_hook_error",
+                        message: "update hook threw",
+                        meta: {
+                            agentRoot,
+                            error: err instanceof Error ? err.message : /* v8 ignore next -- defensive: non-Error catch branch @preserve */ String(err),
+                        },
+                    });
+                }
             }
+            summary.updated.push({
+                agent: entry.name.replace(/\.ouro$/, ""),
+                from: previousVersion,
+                to: currentVersion,
+            });
         }
-        summary.updated.push({
-            agent: entry.name.replace(/\.ouro$/, ""),
-            from: previousVersion,
-            to: currentVersion,
+        return summary;
+    }
+    finally {
+        (0, runtime_1.emitNervesEvent)({
+            component: "daemon",
+            event: "daemon.apply_pending_updates_end",
+            message: "pending updates applied",
+            meta: { bundlesRoot },
         });
     }
-    (0, runtime_1.emitNervesEvent)({
-        component: "daemon",
-        event: "daemon.apply_pending_updates_end",
-        message: "pending updates applied",
-        meta: { bundlesRoot },
-    });
-    return summary;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ouro.bot/cli",
-  "version": "0.1.0-alpha.275",
+  "version": "0.1.0-alpha.276",
   "main": "dist/heart/daemon/ouro-entry.js",
   "bin": {
     "cli": "dist/heart/daemon/ouro-bot-entry.js",