@ouro.bot/cli 0.1.0-alpha.235 → 0.1.0-alpha.237

package/changelog.json

@@ -1,6 +1,15 @@
 {
   "_note": "This changelog is maintained as part of the PR/version-bump workflow. Agent-curated, not auto-generated. Agents read this file directly via read_file to understand what changed between versions.",
   "versions": [
+    {
+      "version": "0.1.0-alpha.237",
+      "changes": [
+        "feat: pretty `ouro status` \u2014 ANSI colored output with box-drawing header, status dots, grouped senses/workers by agent. Added git sync info to overview.",
+        "fix: socket half-close \u2014 sendDaemonCommand now calls client.end() after writing, preventing intermittent connection hangs.",
+        "refactor: config tiers \u2014 replaced numeric T1/T2/T3 with `self` (agent-configurable) and `managed` (harness-only). All config keys are now agent-writable except `version` and `enabled`. mcpServers promoted to self.",
+        "refactor: removed confirmation system \u2014 deleted propose_config tool, confirmationRequired/confirmationAlwaysRequired/onConfirmAction from core, all tool definitions, and Teams sense. Was only wired up on Teams, silently failed everywhere else. -1,361 lines."
+      ]
+    },
     {
       "version": "0.1.0-alpha.235",
       "changes": [

package/dist/heart/config-registry.js

@@ -82,11 +82,11 @@ function validateObject(requiredFields) {
     };
 }
 const registryData = [
-    // --- Tier 3: Operator-only ---
+    // --- Managed: harness-only ---
     {
         path: "version",
-        tier: 3,
-        description: "Agent config schema version. Must be an integer >= 1.",
+        tier: "managed",
+        description: "Agent config schema version. Managed by the harness. Must be an integer >= 1.",
         default: 2,
         effects: "Controls which config migrations apply on load. Changing incorrectly can corrupt config.",
         topics: ["schema", "migration"],
@@ -94,25 +94,25 @@ const registryData = [
     },
     {
         path: "enabled",
-        tier: 3,
-        description: "Whether the agent is enabled. When false, the agent refuses to start.",
+        tier: "managed",
+        description: "Whether the agent is enabled. Managed by the harness. When false, the agent refuses to start.",
         default: true,
         effects: "Disables all agent functionality when set to false.",
         topics: ["lifecycle", "activation"],
         validate: validateBoolean,
     },
+    // --- Self: agent-configurable ---
     {
         path: "mcpServers",
-        tier: 3,
-        description: "MCP server configurations. Maps server name to command, args, and env.",
+        tier: "self",
+        description: "MCP server configurations. Maps server name to command, args, and env. The agent can add or remove MCP servers.",
         default: undefined,
-        effects: "Adds or removes MCP tool servers. Incorrect config can expose the agent to untrusted tool sources.",
+        effects: "Adds or removes MCP tool servers.",
         topics: ["tools", "mcp", "servers", "extensions"],
     },
-    // --- Tier 2: Proposal ---
     {
         path: "humanFacing.provider",
-        tier: 2,
+        tier: "self",
         description: "Provider for human-facing interactions (CLI, Teams, BlueBubbles).",
         default: "anthropic",
         effects: "Changes the LLM provider used for all human-facing conversations. Affects quality, latency, and cost.",
@@ -121,7 +121,7 @@ const registryData = [
     },
     {
         path: "humanFacing.model",
-        tier: 2,
+        tier: "self",
         description: "Model name for human-facing interactions.",
         default: "claude-opus-4-6",
         effects: "Changes the specific model used for human-facing conversations.",
@@ -130,7 +130,7 @@ const registryData = [
     },
     {
         path: "agentFacing.provider",
-        tier: 2,
+        tier: "self",
         description: "Provider for agent-facing interactions (inner dialog, delegation).",
         default: "anthropic",
         effects: "Changes the LLM provider used for inner dialog and agent-to-agent communication.",
@@ -139,7 +139,7 @@ const registryData = [
     },
     {
         path: "agentFacing.model",
-        tier: 2,
+        tier: "self",
         description: "Model name for agent-facing interactions.",
         default: "claude-opus-4-6",
         effects: "Changes the specific model used for inner dialog and agent-to-agent communication.",
@@ -148,7 +148,7 @@ const registryData = [
     },
     {
         path: "context.maxTokens",
-        tier: 2,
+        tier: "self",
         description: "Maximum context window size in tokens.",
         default: 80000,
         effects: "Larger values allow more context but increase cost and latency. Must match model capability.",
@@ -157,7 +157,7 @@ const registryData = [
     },
     {
         path: "senses.cli",
-        tier: 2,
+        tier: "self",
         description: "CLI sense configuration. Controls whether the CLI interface is enabled.",
         default: { enabled: true },
         effects: "Enables or disables the CLI (terminal) interaction channel.",
@@ -166,7 +166,7 @@ const registryData = [
     },
     {
         path: "senses.teams",
-        tier: 2,
+        tier: "self",
         description: "Teams sense configuration. Controls whether the Teams interface is enabled.",
         default: { enabled: false },
         effects: "Enables or disables the Microsoft Teams interaction channel.",
@@ -175,7 +175,7 @@ const registryData = [
     },
     {
         path: "senses.bluebubbles",
-        tier: 2,
+        tier: "self",
         description: "BlueBubbles sense configuration. Controls whether the iMessage interface is enabled.",
         default: { enabled: false },
         effects: "Enables or disables the BlueBubbles (iMessage) interaction channel.",
@@ -184,7 +184,7 @@ const registryData = [
     },
     {
         path: "sync.enabled",
-        tier: 2,
+        tier: "self",
         description: "Whether git-based bundle sync is enabled.",
         default: false,
         effects: "Enables automatic synchronization of agent state via git. Requires sync.remote to be configured.",
@@ -193,17 +193,16 @@ const registryData = [
     },
     {
         path: "sync.remote",
-        tier: 2,
+        tier: "self",
         description: "Git remote name used for bundle sync.",
         default: "origin",
         effects: "Controls which git remote is used when sync is enabled.",
         topics: ["sync", "git", "remote"],
         validate: validateString,
     },
-    // --- Tier 1: Self-service ---
     {
         path: "context.contextMargin",
-        tier: 1,
+        tier: "self",
         description: "Percentage of context window reserved as margin before compaction triggers.",
         default: 20,
         effects: "Higher values trigger compaction earlier, preserving more headroom. Lower values use more context.",
@@ -212,7 +211,7 @@ const registryData = [
     },
     {
         path: "phrases.thinking",
-        tier: 1,
+        tier: "self",
         description: "Array of phrases displayed while the agent is thinking.",
         default: ["working"],
         effects: "Changes the thinking indicator text shown to users. Purely cosmetic.",
@@ -221,7 +220,7 @@ const registryData = [
     },
     {
         path: "phrases.tool",
-        tier: 1,
+        tier: "self",
         description: "Array of phrases displayed while the agent is running a tool.",
         default: ["running tool"],
         effects: "Changes the tool-use indicator text shown to users. Purely cosmetic.",
@@ -230,7 +229,7 @@ const registryData = [
     },
     {
         path: "phrases.followup",
-        tier: 1,
+        tier: "self",
         description: "Array of phrases displayed during follow-up processing.",
         default: ["processing"],
         effects: "Changes the follow-up indicator text shown to users. Purely cosmetic.",
@@ -239,7 +238,7 @@ const registryData = [
     },
     {
         path: "shell.defaultTimeout",
-        tier: 1,
+        tier: "self",
         description: "Default timeout in milliseconds for shell command execution.",
         default: undefined,
         effects: "Controls how long shell commands run before timing out. Undefined uses system default.",
@@ -248,7 +247,7 @@ const registryData = [
     },
     {
         path: "logging.level",
-        tier: 1,
+        tier: "self",
         description: "Minimum log level: debug, info, warn, or error.",
         default: undefined,
         effects: "Controls verbosity of runtime logging. Lower levels produce more output.",
@@ -257,7 +256,7 @@ const registryData = [
     },
     {
         path: "logging.sinks",
-        tier: 1,
+        tier: "self",
         description: "Array of log sink types: 'terminal' and/or 'ndjson'.",
         default: undefined,
         effects: "Controls where log output is directed. Terminal shows in console, ndjson writes structured logs.",

package/dist/heart/core.js

@@ -905,23 +905,6 @@ async function runAgent(messages, callbacks, channel, signal, options) {
                         providerRuntime.appendToolOutput(tc.id, rejection);
                         continue;
                     }
-                    // Confirmation check for mutate tools.
-                    // confirmationAlwaysRequired tools cannot be bypassed by skipConfirmation.
-                    const needsConfirmation = (0, tools_1.isConfirmationRequired)(tc.name) && (!options?.skipConfirmation || (0, tools_1.isConfirmationAlwaysRequired)(tc.name));
-                    if (needsConfirmation) {
-                        let decision = "denied";
-                        if (callbacks.onConfirmAction) {
-                            decision = await callbacks.onConfirmAction(tc.name, args);
-                        }
-                        if (decision !== "confirmed") {
-                            const cancelled = "Action cancelled by user.";
-                            callbacks.onToolStart(tc.name, args);
-                            callbacks.onToolEnd(tc.name, argSummary, false);
-                            messages.push({ role: "tool", tool_call_id: tc.id, content: cancelled });
-                            providerRuntime.appendToolOutput(tc.id, cancelled);
-                            continue;
-                        }
-                    }
                     callbacks.onToolStart(tc.name, args);
                     let toolResult;
                     let success;
@@ -959,20 +942,48 @@ async function runAgent(messages, callbacks, channel, signal, options) {
                 callbacks.onError(new Error("context trimmed, retrying..."), "transient");
                 continue;
             }
-            // Transient errors: retry with exponential backoff
-            if (isTransientError(e) && retryCount < MAX_RETRIES) {
+            // Transient errors: retry with exponential backoff.
+            // Two-layer detection: generic isTransientError (HTTP codes, network patterns)
+            // PLUS provider-specific classifyError (catches SDK-wrapped errors that
+            // generic detection might miss).
+            const errorForClassification = e instanceof Error ? e : /* v8 ignore next -- defensive @preserve */ new Error(String(e));
+            let providerClassification;
+            try {
+                providerClassification = providerRuntime.classifyError(errorForClassification);
+            }
+            catch {
+                /* v8 ignore next -- defensive: classifyError should not throw @preserve */
+                providerClassification = "unknown";
+            }
+            const retryableByClassification = providerClassification === "rate-limit"
+                || providerClassification === "server-error"
+                || providerClassification === "network-error";
+            const retryableByGeneric = isTransientError(e);
+            const shouldRetry = (retryableByGeneric || retryableByClassification) && retryCount < MAX_RETRIES;
+            (0, runtime_1.emitNervesEvent)({
+                level: shouldRetry ? "info" : "warn",
+                event: shouldRetry ? "engine.provider_retry" : "engine.provider_retry_skip",
+                component: "engine",
+                message: shouldRetry
+                    ? `provider error is retryable (attempt ${retryCount + 1}/${MAX_RETRIES})`
+                    : `provider error is not retryable or retries exhausted`,
+                meta: {
+                    provider: providerRuntime.id,
+                    model: providerRuntime.model,
+                    retryCount,
+                    maxRetries: MAX_RETRIES,
+                    retryableByGeneric,
+                    retryableByClassification,
+                    providerClassification,
+                    errorMessage: errorForClassification.message.slice(0, 200),
+                    httpStatus: e.status ?? null,
+                },
+            });
+            if (shouldRetry) {
                 retryCount++;
                 const delay = RETRY_BASE_MS * Math.pow(2, retryCount - 1);
-                let classification;
-                try {
-                    classification = providerRuntime.classifyError(e instanceof Error ? e : /* v8 ignore next -- defensive: errors are always Error instances @preserve */ new Error(String(e)));
-                }
-                catch {
-                    /* v8 ignore next -- defensive: classifyError should not throw @preserve */
-                    classification = classifyTransientError(e);
-                }
                 /* v8 ignore next -- defensive: all classifications have labels @preserve */
-                const cause = TRANSIENT_RETRY_LABELS[classification] ?? classification;
+                const cause = TRANSIENT_RETRY_LABELS[providerClassification] ?? providerClassification;
                 callbacks.onError(new Error(`${cause}, retrying in ${delay / 1000}s (${retryCount}/${MAX_RETRIES})...`), "transient");
                 // Wait with abort support
                 const aborted = await new Promise((resolve) => {
@@ -995,14 +1006,8 @@ async function runAgent(messages, callbacks, channel, signal, options) {
                 providerRuntime.resetTurnState(messages);
                 continue;
             }
-            terminalError = e instanceof Error ? e : new Error(String(e));
-            try {
-                terminalErrorClassification = providerRuntime.classifyError(terminalError);
-            }
-            catch {
-                /* v8 ignore next -- defensive: classifyError should not throw @preserve */
-                terminalErrorClassification = "unknown";
-            }
+            terminalError = errorForClassification;
+            terminalErrorClassification = providerClassification;
             /* v8 ignore start — auth-failure guidance: tested via provider error classification tests @preserve */
             if (terminalErrorClassification === "auth-failure") {
                 const agentName = (0, identity_2.getAgentName)();

package/dist/heart/daemon/cli-render.js

@@ -89,6 +89,8 @@ function parseStatusPayload(data) {
         senseCount: numberField(overview.senseCount) ?? 0,
         entryPath: stringField(overview.entryPath) ?? "unknown",
         mode: stringField(overview.mode) ?? "unknown",
+        syncEnabled: booleanField(overview.syncEnabled) ?? false,
+        syncRemote: stringField(overview.syncRemote) ?? "origin",
     };
     const parsedSenses = senses.map((entry) => {
         if (!entry || typeof entry !== "object" || Array.isArray(entry))
@@ -141,6 +143,44 @@ function parseStatusPayload(data) {
         workers: parsedWorkers,
     };
 }
+// ── ANSI color helpers (private) ──
+const RESET = "\x1b[0m";
+const BOLD = "\x1b[1m";
+const DIM = "\x1b[2m";
+const TEAL = "\x1b[38;2;78;201;176m";
+const GREEN = "\x1b[38;2;46;204;64m";
+const RED = "\x1b[38;2;231;76;60m";
+const YELLOW = "\x1b[38;2;230;190;50m";
+/* v8 ignore start -- cosmetic ANSI wrappers @preserve */
+function teal(text) { return `${TEAL}${text}${RESET}`; }
+function green(text) { return `${GREEN}${text}${RESET}`; }
+function red(text) { return `${RED}${text}${RESET}`; }
+function yellow(text) { return `${YELLOW}${text}${RESET}`; }
+function bold(text) { return `${BOLD}${text}${RESET}`; }
+function dim(text) { return `${DIM}${text}${RESET}`; }
+/* v8 ignore stop */
+/* v8 ignore start -- cosmetic display: status dot color mapping tested visually @preserve */
+function statusDot(status) {
+    switch (status) {
+        case "running":
+        case "ok":
+        case "interactive":
+        case "enabled":
+            return green("●");
+        case "crashed":
+        case "warn":
+        case "error":
+            return red("●");
+        case "needs_config":
+            return yellow("●");
+        case "disabled":
+        case "stopped":
+            return dim("○");
+        default:
+            return dim("●");
+    }
+}
+/* v8 ignore stop */
 // ── Formatters ──
 function humanizeSenseName(sense, label) {
     if (label)
@@ -153,6 +193,7 @@ function humanizeSenseName(sense, label) {
         return "Teams";
     return sense;
 }
+/* v8 ignore start -- utility formatter; retained for non-status table output @preserve */
 function formatTable(headers, rows) {
     const widths = headers.map((header, index) => Math.max(header.length, ...rows.map((row) => row[index].length)));
     const renderRow = (row) => `| ${row.map((cell, index) => (index === row.length - 1
@@ -165,56 +206,96 @@ function formatTable(headers, rows) {
         ...rows.map(renderRow),
     ].join("\n");
 }
+/* v8 ignore stop */
 function formatDaemonStatusOutput(response, fallback) {
     const payload = parseStatusPayload(response.data);
     if (!payload)
         return fallback;
-    const overviewRows = [
-        ["Daemon", payload.overview.daemon],
-        ["Socket", payload.overview.socketPath],
-        ["Version", payload.overview.version],
-        ["Last Updated", payload.overview.lastUpdated],
-        ["Outlook", payload.overview.outlookUrl],
-        ["Entry Path", payload.overview.entryPath],
-        ["Mode", payload.overview.mode],
-        ["Workers", String(payload.overview.workerCount)],
-        ["Senses", String(payload.overview.senseCount)],
-        ["Health", payload.overview.health],
-    ];
-    const senseRows = payload.senses.map((row) => [
-        row.agent,
-        humanizeSenseName(row.sense, row.label),
-        row.enabled ? "ON" : "OFF",
-        row.status,
-        row.detail,
-    ]);
-    const workerRows = payload.workers.map((row) => {
-        /* v8 ignore start — exit info branches tested via daemon-crash-context; v8 misreports conditional chains @preserve */
-        let exitInfo = "n/a";
-        if (row.lastExitCode !== null)
-            exitInfo = `code=${row.lastExitCode}`;
-        if (row.lastSignal !== null)
-            exitInfo = row.lastExitCode !== null ? `code=${row.lastExitCode} sig=${row.lastSignal}` : `sig=${row.lastSignal}`;
-        /* v8 ignore stop */
-        return [
-            row.agent,
-            row.worker,
-            row.status,
-            row.pid === null ? "n/a" : String(row.pid),
-            String(row.restartCount),
-            exitInfo,
-        ];
-    });
-    return [
-        "Overview",
-        formatTable(["Item", "Value"], overviewRows),
-        "",
-        "Senses",
-        formatTable(["Agent", "Sense", "Enabled", "State", "Detail"], senseRows),
-        "",
-        "Workers",
-        formatTable(["Agent", "Worker", "State", "PID", "Restarts", "Last Exit"], workerRows),
-    ].join("\n");
+    const ov = payload.overview;
+    const lines = [];
+    // ── Header banner ──
+    const modeTag = ov.mode === "dev" ? "dev" : "";
+    const daemonStatus = ov.daemon === "running" ? green("●") + "  " + bold("running") : red("●") + "  " + bold(ov.daemon);
+    const modeStr = modeTag ? `  ${dim(`(${modeTag})`)}` : "";
+    const bannerContent = `  ${bold(ov.version)}  ${daemonStatus}${modeStr}  `;
+    // Measure raw content width (strip ANSI for width calc)
+    const rawBanner = bannerContent.replace(/\x1b\[[0-9;]*m/g, "");
+    const bannerWidth = Math.max(rawBanner.length, 42);
+    const titleLabel = " ouroboros daemon ";
+    const topRightPad = Math.max(0, bannerWidth - titleLabel.length - 2);
+    lines.push(`  ${teal("╭─")}${teal(titleLabel)}${teal("─".repeat(topRightPad))}${teal("╮")}`);
+    lines.push(`  ${teal("│")}${bannerContent}${" ".repeat(Math.max(0, bannerWidth - rawBanner.length))}${teal("│")}`);
+    lines.push(`  ${teal("╰")}${teal("─".repeat(bannerWidth))}${teal("╯")}`);
+    lines.push("");
+    // ── Key-value overview ──
+    const kvLine = (label, value) => `  ${teal(label.padEnd(11))} ${value}`;
+    lines.push(kvLine("Socket", ov.socketPath));
+    lines.push(kvLine("Outlook", ov.outlookUrl));
+    lines.push(kvLine("Health", `${statusDot(ov.health)} ${ov.health}`));
+    /* v8 ignore next -- cosmetic: sync-enabled branch requires agent with sync configured @preserve */
+    const syncLabel = ov.syncEnabled ? `${green("●")} enabled (remote: ${ov.syncRemote})` : `${dim("○")} disabled`;
+    lines.push(kvLine("Git Sync", syncLabel));
+    lines.push(kvLine("Updated", ov.lastUpdated));
+    lines.push("");
+    // ── Senses ──
+    if (payload.senses.length > 0) {
+        lines.push(`  ${teal("──")} ${bold("Senses")} ${teal("─".repeat(37))}`);
+        // Group senses by agent
+        const sensesByAgent = new Map();
+        for (const row of payload.senses) {
+            const list = sensesByAgent.get(row.agent) ?? [];
+            list.push(row);
+            sensesByAgent.set(row.agent, list);
+        }
+        // Calculate column widths for alignment
+        const allSenseNames = payload.senses.map((r) => humanizeSenseName(r.sense, r.label));
+        const nameWidth = Math.max(12, ...allSenseNames.map((n) => n.length));
+        const allStatuses = payload.senses.map((r) => r.status);
+        const statusWidth = Math.max(10, ...allStatuses.map((s) => s.length));
+        for (const [agent, rows] of sensesByAgent) {
+            lines.push(`  ${bold(agent)}`);
+            for (const row of rows) {
+                const name = humanizeSenseName(row.sense, row.label).padEnd(nameWidth);
+                const dot = row.enabled ? statusDot(row.status) : dim("○");
+                const statusText = (row.enabled ? row.status : "disabled").padEnd(statusWidth);
+                lines.push(`    ${name} ${dot} ${statusText}  ${dim(row.detail)}`);
+            }
+        }
+        lines.push("");
+    }
+    // ── Workers ──
+    if (payload.workers.length > 0) {
+        lines.push(`  ${teal("──")} ${bold("Workers")} ${teal("─".repeat(36))}`);
+        // Group workers by agent
+        const workersByAgent = new Map();
+        for (const row of payload.workers) {
+            const list = workersByAgent.get(row.agent) ?? [];
+            list.push(row);
+            workersByAgent.set(row.agent, list);
+        }
+        const allWorkerNames = payload.workers.map((r) => r.worker);
+        const workerNameWidth = Math.max(12, ...allWorkerNames.map((n) => n.length));
+        for (const [agent, rows] of workersByAgent) {
+            lines.push(`  ${bold(agent)}`);
+            for (const row of rows) {
+                const name = row.worker.padEnd(workerNameWidth);
+                const dot = statusDot(row.status);
+                const pidStr = row.pid !== null ? `pid ${row.pid}` : "";
+                const restartStr = `restarts: ${row.restartCount}`;
+                /* v8 ignore start — exit info branches tested via daemon-crash-context; v8 misreports conditional chains @preserve */
+                let exitStr = "";
+                if (row.lastExitCode !== null)
+                    exitStr = `exit=${row.lastExitCode}`;
+                if (row.lastSignal !== null)
+                    exitStr = row.lastExitCode !== null ? `exit=${row.lastExitCode} sig=${row.lastSignal}` : `sig=${row.lastSignal}`;
+                /* v8 ignore stop */
+                const details = [pidStr, restartStr, exitStr].filter(Boolean).join("  ");
+                lines.push(`    ${name} ${dot} ${row.status.padEnd(10)}  ${dim(details)}`);
+            }
+        }
+        lines.push("");
+    }
+    return lines.join("\n");
 }
 function formatVersionOutput() {
     const version = (0, runtime_metadata_1.getRuntimeMetadata)().version;
@@ -240,6 +321,8 @@ function buildStoppedStatusPayload(socketPath) {
             senseCount: 0,
             entryPath: path.join(repoRoot, "dist", "heart", "daemon", "daemon-entry.js"),
             mode: (0, runtime_mode_1.detectRuntimeMode)(repoRoot),
+            syncEnabled: false,
+            syncRemote: "origin",
         },
         senses: [],
         workers: [],

package/dist/heart/daemon/daemon.js

@@ -42,6 +42,7 @@ const net = __importStar(require("net"));
 const os = __importStar(require("os"));
 const path = __importStar(require("path"));
 const identity_1 = require("../identity");
+const config_1 = require("../config");
 const runtime_1 = require("../../nerves/runtime");
 const runtime_metadata_1 = require("./runtime-metadata");
 const runtime_mode_1 = require("./runtime-mode");
@@ -233,6 +234,7 @@ class OuroDaemon {
         const workers = buildWorkerRows(snapshots);
         const senses = this.senseManager?.listSenseRows() ?? [];
         const repoRoot = (0, identity_1.getRepoRoot)();
+        const syncConfig = (0, config_1.getSyncConfig)();
         return {
             overview: {
                 daemon: "running",
@@ -244,6 +246,8 @@ class OuroDaemon {
                 senseCount: senses.length,
                 entryPath: path.join(repoRoot, "dist", "heart", "daemon", "daemon-entry.js"),
                 mode: (0, runtime_mode_1.detectRuntimeMode)(repoRoot),
+                syncEnabled: syncConfig.enabled,
+                syncRemote: syncConfig.remote,
             },
             workers,
             senses,

package/dist/heart/daemon/socket-client.js

@@ -53,6 +53,7 @@ function sendDaemonCommand(socketPath, command) {
         let raw = "";
         client.on("connect", () => {
             client.write(JSON.stringify(command) + "\n");
+            client.end();
         });
         client.on("data", (chunk) => {
             raw += chunk.toString("utf-8");

package/dist/repertoire/ado-semantic.js

@@ -318,7 +318,6 @@ exports.adoSemanticToolDefinitions = [
             return result;
         },
         integration: "ado",
-        confirmationRequired: true,
         summaryKeys: ["organization", "project", "title"],
     },
     // -- ado_create_issue --
@@ -360,7 +359,6 @@ exports.adoSemanticToolDefinitions = [
             return result;
         },
         integration: "ado",
-        confirmationRequired: true,
         summaryKeys: ["organization", "project", "title"],
     },
     // -- ado_move_items --
@@ -415,7 +413,6 @@ exports.adoSemanticToolDefinitions = [
             return JSON.stringify({ moved, errors, organization: adoCtx.organization, project: adoCtx.project });
         },
         integration: "ado",
-        confirmationRequired: true,
         summaryKeys: ["organization", "project", "workItemIds"],
     },
     // -- ado_restructure_backlog --
@@ -474,7 +471,6 @@ exports.adoSemanticToolDefinitions = [
             return JSON.stringify({ results, organization: adoCtx.organization, project: adoCtx.project });
         },
         integration: "ado",
-        confirmationRequired: true,
         summaryKeys: ["organization", "project"],
     },
     // -- ado_validate_structure --
@@ -676,7 +672,6 @@ exports.adoSemanticToolDefinitions = [
             return JSON.stringify({ results, organization: adoCtx.organization, project: adoCtx.project });
         },
         integration: "ado",
-        confirmationRequired: true,
         summaryKeys: ["organization", "project"],
     },
     // -- ado_detect_orphans --

package/dist/repertoire/tools-config.js

@@ -118,7 +118,7 @@ exports.configToolDefinitions = [
             type: "function",
             function: {
                 name: "update_config",
-                description: "Update a Tier 1 (self-service) agent configuration value immediately. For Tier 2 keys that require operator approval, use propose_config instead. Tier 3 (operator-only) keys are refused.",
+                description: "Update an agent configuration value. Managed keys (version, enabled) cannot be modified.",
                 parameters: {
                     type: "object",
                     properties: {
@@ -152,15 +152,10 @@ exports.configToolDefinitions = [
                     return `Error: validation failed for "${a.path}": ${validationError}`;
                 }
             }
-            // Tier 3: refuse
-            if (entry.tier === 3) {
-                (0, runtime_1.emitNervesEvent)({ component: "repertoire", event: "repertoire.update_config_refused", message: `refused T3 change to ${a.path}`, meta: { path: a.path, tier: 3 } });
-                return `Refused: "${a.path}" is an operator-only (Tier 3) key. ${entry.description} Only the operator can change this value directly in agent.json.`;
-            }
-            // Tier 2: refuse — must use propose_config
-            if (entry.tier === 2) {
-                (0, runtime_1.emitNervesEvent)({ component: "repertoire", event: "repertoire.update_config_refused", message: `refused T2 change to ${a.path} — use propose_config`, meta: { path: a.path, tier: 2 } });
-                return `Refused: "${a.path}" is a Tier 2 (proposal) key that requires operator approval. Use propose_config instead of update_config to propose this change.`;
+            // Managed: refuse
+            if (entry.tier === "managed") {
+                (0, runtime_1.emitNervesEvent)({ component: "repertoire", event: "repertoire.update_config_refused", message: `refused managed change to ${a.path}`, meta: { path: a.path, tier: "managed" } });
+                return `This key is managed by the harness and cannot be modified directly.`;
             }
             const agentRoot = (0, identity_1.getAgentRoot)();
             const configPath = path.join(agentRoot, "agent.json");
@@ -172,7 +167,7 @@ exports.configToolDefinitions = [
                 /* v8 ignore next -- defensive: agent.json read failure in update_config @preserve */
                 return `Error: failed to read agent.json at ${configPath}`;
             }
-            // Apply T1 change immediately
+            // Apply change immediately
             const parts = entry.path.split(".");
             let target = rawConfig;
             for (let i = 0; i < parts.length - 1; i++) {
@@ -187,80 +182,4 @@ exports.configToolDefinitions = [
             return `Success: "${a.path}" updated to ${JSON.stringify(parsedValue)}. Change applied immediately.`;
         },
     },
-    {
-        tool: {
-            type: "function",
-            function: {
-                name: "propose_config",
-                description: "Propose a change to a Tier 2 (proposal) agent configuration value. Requires operator approval before the change is applied. For Tier 1 self-service keys, use update_config instead.",
-                parameters: {
-                    type: "object",
-                    properties: {
-                        path: { type: "string", description: "Config key in dot-notation (e.g., 'context.maxTokens', 'humanFacing.model')" },
-                        value: { type: "string", description: "New value as JSON (e.g., '120000', '\"azure\"', '{\"enabled\": true}')" },
-                    },
-                    required: ["path", "value"],
-                },
-            },
-        },
-        confirmationRequired: true,
-        confirmationAlwaysRequired: true,
-        handler: (a) => {
-            const entry = (0, config_registry_1.getRegistryEntry)(a.path);
-            if (!entry) {
-                (0, runtime_1.emitNervesEvent)({ component: "repertoire", event: "repertoire.propose_config_error", message: `unknown config path: ${a.path}`, meta: { path: a.path } });
-                return `Error: unknown config path "${a.path}". Use read_config to see available paths.`;
-            }
-            let parsedValue;
-            try {
-                parsedValue = JSON.parse(a.value);
-            }
-            catch {
-                (0, runtime_1.emitNervesEvent)({ component: "repertoire", event: "repertoire.propose_config_error", message: `invalid JSON value for ${a.path}`, meta: { path: a.path, value: a.value } });
-                return `Error: invalid JSON value. Provide value as valid JSON (e.g., 120000, "azure", {"enabled": true}).`;
-            }
-            // Validate value against registry entry's validator
-            /* v8 ignore next -- all current entries have validators; guard kept for future entries without one @preserve */
-            if (entry.validate) {
-                const validationError = entry.validate(parsedValue);
-                if (validationError) {
-                    (0, runtime_1.emitNervesEvent)({ component: "repertoire", event: "repertoire.propose_config_error", message: `validation failed for ${a.path}: ${validationError}`, meta: { path: a.path, value: a.value, validationError } });
-                    return `Error: validation failed for "${a.path}": ${validationError}`;
-                }
-            }
-            // Tier 3: refuse
-            if (entry.tier === 3) {
-                (0, runtime_1.emitNervesEvent)({ component: "repertoire", event: "repertoire.propose_config_refused", message: `refused T3 change to ${a.path}`, meta: { path: a.path, tier: 3 } });
-                return `Refused: "${a.path}" is an operator-only (Tier 3) key. ${entry.description} Only the operator can change this value directly in agent.json.`;
-            }
-            // Tier 1: refuse — use update_config for self-service keys
-            if (entry.tier === 1) {
-                (0, runtime_1.emitNervesEvent)({ component: "repertoire", event: "repertoire.propose_config_refused", message: `refused T1 change to ${a.path} — use update_config`, meta: { path: a.path, tier: 1 } });
-                return `Refused: "${a.path}" is a Tier 1 (self-service) key. Use update_config instead — no operator approval needed.`;
-            }
-            const agentRoot = (0, identity_1.getAgentRoot)();
-            const configPath = path.join(agentRoot, "agent.json");
-            let rawConfig;
-            try {
-                rawConfig = JSON.parse(fs.readFileSync(configPath, "utf-8"));
-            }
-            catch {
-                /* v8 ignore next -- defensive: agent.json read failure in propose_config @preserve */
-                return `Error: failed to read agent.json at ${configPath}`;
-            }
-            // Apply T2 change (operator confirmation already obtained via confirmationAlwaysRequired)
-            const parts = entry.path.split(".");
-            let target = rawConfig;
-            for (let i = 0; i < parts.length - 1; i++) {
-                if (!(parts[i] in target) || typeof target[parts[i]] !== "object" || target[parts[i]] === null) {
-                    target[parts[i]] = {};
-                }
-                target = target[parts[i]];
-            }
-            target[parts[parts.length - 1]] = parsedValue;
-            fs.writeFileSync(configPath, JSON.stringify(rawConfig, null, 2) + "\n", "utf-8");
-            (0, runtime_1.emitNervesEvent)({ component: "repertoire", event: "repertoire.propose_config_applied", message: `applied approved config change to ${a.path}`, meta: { path: a.path, tier: entry.tier, value: parsedValue } });
-            return `Success: "${a.path}" updated to ${JSON.stringify(parsedValue)}. Change approved and applied.`;
-        },
-    },
 ];

package/dist/repertoire/tools-github.js

@@ -42,7 +42,6 @@ exports.githubToolDefinitions = [
             return (0, github_client_1.githubRequest)(ctx.githubToken, "POST", `/repos/${owner}/${repo}/issues`, JSON.stringify(payload));
         },
         integration: "github",
-        confirmationRequired: true,
         summaryKeys: ["title"],
     },
 ];

package/dist/repertoire/tools-teams.js

@@ -64,7 +64,6 @@ exports.teamsToolDefinitions = [
             return (0, graph_client_1.graphRequest)(ctx.graphToken, args.method, args.path, args.body);
         },
         integration: "graph",
-        confirmationRequired: true,
         summaryKeys: ["method", "path"],
     },
     // -- Generic ADO tools --
@@ -126,7 +125,6 @@ exports.teamsToolDefinitions = [
             return (0, ado_client_1.adoRequest)(ctx.adoToken, args.method, args.organization, args.path, args.body, args.host);
         },
         integration: "ado",
-        confirmationRequired: true,
         summaryKeys: ["method", "organization", "path"],
     },
     // -- Convenience aliases (backward compat) --
@@ -237,7 +235,6 @@ exports.teamsToolDefinitions = [
             }
         },
         /* v8 ignore stop */
-        confirmationRequired: true,
         summaryKeys: ["user_name", "user_id"],
     },
     // -- Documentation tools --

package/dist/repertoire/tools.js

@@ -3,8 +3,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.surfaceToolDef = exports.restTool = exports.ponderTool = exports.observeTool = exports.settleTool = exports.tools = void 0;
 exports.resetMcpDefinitions = resetMcpDefinitions;
 exports.getToolsForChannel = getToolsForChannel;
-exports.isConfirmationRequired = isConfirmationRequired;
-exports.isConfirmationAlwaysRequired = isConfirmationAlwaysRequired;
 exports.execTool = execTool;
 exports.summarizeArgs = summarizeArgs;
 exports.buildToolResultSummary = buildToolResultSummary;
@@ -39,7 +37,7 @@ Object.defineProperty(exports, "surfaceToolDef", { enumerable: true, get: functi
 // All tool definitions in a single registry
 const allDefinitions = [...tools_base_1.baseToolDefinitions, ...tools_bluebubbles_1.bluebubblesToolDefinitions, ...tools_teams_1.teamsToolDefinitions, ...ado_semantic_1.adoSemanticToolDefinitions, ...tools_github_1.githubToolDefinitions, tools_surface_1.surfaceToolDefinition];
 // MCP tool definitions — populated each time getToolsForChannel() is called with an mcpManager.
-// Kept separate from allDefinitions so execTool/isConfirmation* can find them.
+// Kept separate from allDefinitions so execTool can find them.
 let mcpDefinitions = [];
 /** Exported for testing — reset the MCP definitions cache. */
 function resetMcpDefinitions() {
@@ -120,18 +118,6 @@ function findDefinition(toolName) {
     return allDefinitions.find((d) => d.tool.function.name === toolName)
         ?? mcpDefinitions.find((d) => d.tool.function.name === toolName);
 }
-// Check whether a tool requires user confirmation before execution.
-// Reads from ToolDefinition.confirmationRequired instead of a separate Set.
-function isConfirmationRequired(toolName) {
-    const def = findDefinition(toolName);
-    return def?.confirmationRequired === true;
-}
-// Check whether a tool's confirmation is non-bypassable (cannot be skipped by skipConfirmation).
-// Used for T2 config proposals that must always require operator approval.
-function isConfirmationAlwaysRequired(toolName) {
-    const def = findDefinition(toolName);
-    return def?.confirmationAlwaysRequired === true;
-}
 function normalizeGuardArgs(_name, args) {
     return args;
 }

package/dist/senses/inner-dialog.js

@@ -693,7 +693,6 @@ async function runInnerDialogTurn(options) {
             runAgentOptions: {
                 traceId,
                 toolChoiceRequired: true,
-                skipConfirmation: true,
                 mcpManager,
                 toolContext: {
                     signin: async () => undefined,

package/dist/senses/teams.js

@@ -41,7 +41,6 @@ exports.sanitizeFeedbackComment = sanitizeFeedbackComment;
 exports.buildFeedbackSyntheticText = buildFeedbackSyntheticText;
 exports.buildWelcomeCard = buildWelcomeCard;
 exports.createTeamsCallbacks = createTeamsCallbacks;
-exports.resolvePendingConfirmation = resolvePendingConfirmation;
 exports.withConversationLock = withConversationLock;
 exports.handleTeamsMessage = handleTeamsMessage;
 exports.sendProactiveTeamsMessageToSession = sendProactiveTeamsMessageToSession;
@@ -479,24 +478,6 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
                 safeSend(msg);
             }
         },
-        onConfirmAction: options?.conversationId
-            ? async (name, args) => {
-                const convId = options.conversationId;
-                const argsDesc = Object.entries(args).map(([k, v]) => `${k}: ${v}`).join(", ");
-                safeUpdate(`Confirm action: ${name} (${argsDesc}) -- reply "yes" to confirm or "no" to cancel`);
-                return new Promise((resolve) => {
-                    _pendingConfirmations.set(convId, resolve);
-                    // Auto-deny after 2 minutes to prevent indefinite blocking
-                    // (e.g. when the stream dies and the user never sees the prompt).
-                    setTimeout(() => {
-                        if (_pendingConfirmations.has(convId)) {
-                            _pendingConfirmations.delete(convId);
-                            resolve("denied");
-                        }
-                    }, 120_000);
-                });
-            }
-            : undefined,
         flush: async () => {
             stopFlushTimer();
             stopPhraseRotation();
@@ -534,26 +515,6 @@ function createTeamsCallbacks(stream, controller, sendMessage, options) {
         },
     };
 }
-// Per-conversation pending confirmation resolvers.
-// When a mutate tool needs confirmation, the resolver is stored here.
-// The next message from the same conversation resolves it.
-const _pendingConfirmations = new Map();
-// Confirmation response words (case-insensitive)
-const CONFIRM_WORDS = new Set(["yes", "confirm", "go", "y", "ok", "approve", "proceed"]);
-function resolvePendingConfirmation(convId, text) {
-    const resolver = _pendingConfirmations.get(convId);
-    if (!resolver)
-        return false;
-    _pendingConfirmations.delete(convId);
-    const word = text.trim().toLowerCase();
-    if (CONFIRM_WORDS.has(word)) {
-        resolver("confirmed");
-    }
-    else {
-        resolver("denied");
-    }
-    return true;
-}
 const _turnCoordinator = (0, turn_coordinator_1.createTurnCoordinator)();
 function teamsTurnKey(conversationId) {
     return `teams:${conversationId}`;
@@ -659,8 +620,6 @@ async function handleTeamsMessage(text, stream, conversationId, teamsContext, se
             },
             ...(reactionOverrides?.isReactionSignal ? { isReactionSignal: true } : {}),
         };
-        if (channelConfig.skipConfirmation)
-            agentOptions.skipConfirmation = true;
         // ── Call shared pipeline ──────────────────────────────────────────
         // Capture terminal errors — failover message replaces the error card if it triggers
         let capturedTerminalError = null;
@@ -961,13 +920,6 @@ function registerBotHandlers(app, label) {
         const userId = activity.from?.id || "";
         const channelId = activity.channelId || "msteams";
         (0, runtime_1.emitNervesEvent)({ level: "info", event: "channel.message_received", component: "channels", message: `[${label}] incoming teams message`, meta: { userId: userId.slice(0, 12), conversationId: convId.slice(0, 20) } });
-        // Resolve pending confirmations IMMEDIATELY — before token fetches or
-        // the conversation lock.  The original message holds the lock while
-        // awaiting confirmation, so acquiring it here would deadlock.  Token
-        // fetches are also unnecessary (and slow) for a simple yes/no reply.
-        if (resolvePendingConfirmation(convId, text)) {
-            return;
-        }
         const commandRegistry = createTeamsCommandRegistry();
         const parsedSlashCommand = (0, commands_1.parseSlashCommand)(text);
         if (parsedSlashCommand) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ouro.bot/cli",
-  "version": "0.1.0-alpha.235",
+  "version": "0.1.0-alpha.237",
   "main": "dist/heart/daemon/ouro-entry.js",
   "bin": {
     "cli": "dist/heart/daemon/ouro-bot-entry.js",