@ottochain/sdk 2.3.0 → 2.4.0

package/dist/esm/apps/corporate/state-machines/corp-board.js

@@ -1,4 +1,6 @@
 import { defineFiberApp } from "../../../schema/fiber-app.js";
+import { signerInSet, depInState } from "../../../schema/guards.js";
+import { addDependency } from "../../../schema/effects.js";
 /**
  * Board of directors state machine managing director seats, meetings, quorum, and formal board actions.
  * Supports staggered boards with classified directors.
@@ -34,7 +36,7 @@ export const corpBoardDef = defineFiberApp({
         },
     },
     createSchema: {
-        required: ["boardId", "entityId", "seats"],
+        required: ["boardId", "entityId", "seats", "authorizedRemovers"],
         properties: {
             boardId: {
                 type: "string",
@@ -46,6 +48,12 @@ export const corpBoardDef = defineFiberApp({
                 description: "Reference to parent corporate-entity",
                 immutable: true,
             },
+            authorizedRemovers: {
+                type: "array",
+                description: "State-pinned set of DAG addresses authorized to remove a director for cause (board/shareholder authority). A verified signer must be a member; checked against proofs[].address.",
+                immutable: false,
+                items: { type: "address" },
+            },
             seats: {
                 type: "object",
                 properties: {
@@ -119,6 +127,7 @@ export const corpBoardDef = defineFiberApp({
         properties: {
             boardId: { type: "string", immutable: true },
             entityId: { type: "string", immutable: true },
+            authorizedRemovers: { type: "array", items: { type: "address" } },
             directors: {
                 type: "array",
                 items: { $ref: "#/definitions/Director" },
@@ -145,6 +154,9 @@ export const corpBoardDef = defineFiberApp({
             },
             createdAt: { type: "timestamp", computed: true },
             updatedAt: { type: "timestamp", computed: true },
+            // Two-phase removal (#24): propose_removal binds the resolution fiber + records the pending
+            // removal here; remove_for_cause asserts the bound resolution is EXECUTED, then clears this.
+            pendingRemoval: { type: "object", nullable: true, computed: true },
         },
     },
     eventSchemas: {
@@ -189,18 +201,20 @@ export const corpBoardDef = defineFiberApp({
                 },
             },
         },
-        remove_for_cause: {
-            description: "Remove a director for cause (requires board or shareholder action depending on bylaws)",
-            required: [
-                "directorId",
-                "cause",
-                "removalResolutionRef",
-                "effectiveDate",
-            ],
+        propose_removal: {
+            description: "Phase 1 of for-cause removal: bind the executing resolution fiber (#24 _addDependency) and record the pending removal",
+            required: ["directorId", "cause", "removalResolutionRef"],
             properties: {
                 directorId: { type: "string" },
                 cause: { type: "string" },
                 removalResolutionRef: { type: "string" },
+            },
+        },
+        remove_for_cause: {
+            description: "Phase 2 of for-cause removal: execute once the bound removal resolution is EXECUTED",
+            required: ["directorId", "effectiveDate"],
+            properties: {
+                directorId: { type: "string" },
                 effectiveDate: { type: "string", format: "date" },
             },
         },
@@ -420,12 +434,8 @@ export const corpBoardDef = defineFiberApp({
             eventName: "elect_director",
             guard: {
                 and: [
-                    {
-                        or: [
-                            { ">": [{ var: "state.seats.vacant" }, 0] },
-                            { "==": [{ var: "event.isFillingVacancy" }, true] },
-                        ],
-                    },
+                    // vacancy gated solely on verified state — the forgeable event.isFillingVacancy disjunct was removed
+                    { ">": [{ var: "state.seats.vacant" }, 0] },
                     { "!=": [{ var: "event.electionResolutionRef" }, null] },
                     {
                         "!": {
@@ -435,11 +445,11 @@ export const corpBoardDef = defineFiberApp({
                                     and: [
                                         {
                                             "==": [
-                                                { var: ".directorId" },
+                                                { var: "directorId" },
                                                 { var: "event.directorId" },
                                             ],
                                         },
-                                        { "==": [{ var: ".status" }, "ACTIVE"] },
+                                        { "==": [{ var: "status" }, "ACTIVE"] },
                                     ],
                                 },
                             ],
@@ -452,7 +462,7 @@ export const corpBoardDef = defineFiberApp({
                     { var: "state" },
                     {
                         directors: {
-                            cat: [
+                            merge: [
                                 { var: "state.directors" },
                                 [
                                     {
@@ -482,9 +492,13 @@ export const corpBoardDef = defineFiberApp({
                             ],
                         },
                     },
+                    {
+                        _emit: [
+                            { name: "DIRECTOR_ELECTED", data: { var: "event" }, destination: "external" },
+                        ],
+                    },
                 ],
             },
-            emits: ["DIRECTOR_ELECTED"],
         },
         // ACTIVE -> ACTIVE (resign_director) and IN_MEETING -> ACTIVE (resign_director)
         {
@@ -496,8 +510,8 @@ export const corpBoardDef = defineFiberApp({
                     { var: "state.directors" },
                     {
                         and: [
-                            { "==": [{ var: ".directorId" }, { var: "event.directorId" }] },
-                            { "==": [{ var: ".status" }, "ACTIVE"] },
+                            { "==": [{ var: "directorId" }, { var: "event.directorId" }] },
+                            { "==": [{ var: "status" }, "ACTIVE"] },
                         ],
                     },
                 ],
@@ -513,7 +527,7 @@ export const corpBoardDef = defineFiberApp({
                                     if: [
                                         {
                                             "==": [
-                                                { var: ".directorId" },
+                                                { var: "directorId" },
                                                 { var: "event.directorId" },
                                             ],
                                         },
@@ -541,9 +555,13 @@ export const corpBoardDef = defineFiberApp({
                             ],
                         },
                     },
+                    {
+                        _emit: [
+                            { name: "DIRECTOR_RESIGNED", data: { var: "event" }, destination: "external" },
+                        ],
+                    },
                 ],
             },
-            emits: ["DIRECTOR_RESIGNED"],
         },
         {
             from: "IN_MEETING",
@@ -554,8 +572,8 @@ export const corpBoardDef = defineFiberApp({
                     { var: "state.directors" },
                     {
                         and: [
-                            { "==": [{ var: ".directorId" }, { var: "event.directorId" }] },
-                            { "==": [{ var: ".status" }, "ACTIVE"] },
+                            { "==": [{ var: "directorId" }, { var: "event.directorId" }] },
+                            { "==": [{ var: "status" }, "ACTIVE"] },
                         ],
                     },
                 ],
@@ -571,7 +589,7 @@ export const corpBoardDef = defineFiberApp({
                                     if: [
                                         {
                                             "==": [
-                                                { var: ".directorId" },
+                                                { var: "directorId" },
                                                 { var: "event.directorId" },
                                             ],
                                         },
@@ -599,33 +617,88 @@ export const corpBoardDef = defineFiberApp({
                             ],
                         },
                     },
+                    {
+                        _emit: [
+                            { name: "DIRECTOR_RESIGNED", data: { var: "event" }, destination: "external" },
+                        ],
+                    },
                 ],
             },
-            emits: ["DIRECTOR_RESIGNED"],
         },
-        // ACTIVE -> ACTIVE (remove_for_cause)
+        // ACTIVE -> ACTIVE (propose_removal) — phase 1 (#24): bind the executing resolution fiber and
+        // record the pending removal, so the next transition can read the resolution's state.
+        {
+            from: "ACTIVE",
+            to: "ACTIVE",
+            eventName: "propose_removal",
+            guard: {
+                and: [
+                    signerInSet("state.authorizedRemovers"),
+                    {
+                        some: [
+                            { var: "state.directors" },
+                            {
+                                and: [
+                                    { "==": [{ var: "directorId" }, { var: "event.directorId" }] },
+                                    { "==": [{ var: "status" }, "ACTIVE"] },
+                                ],
+                            },
+                        ],
+                    },
+                ],
+            },
+            effect: {
+                merge: [
+                    { var: "state" },
+                    {
+                        pendingRemoval: {
+                            directorId: { var: "event.directorId" },
+                            cause: { var: "event.cause" },
+                            resolutionRef: { var: "event.removalResolutionRef" },
+                            proposedAt: { var: "$ordinal" },
+                        },
+                    },
+                    // bind the resolution fiber so remove_for_cause can assert its state next transition
+                    addDependency({ var: "event.removalResolutionRef" }),
+                ],
+            },
+            dependencies: [],
+        },
+        // ACTIVE -> ACTIVE (remove_for_cause) — phase 2 (#24): execute once the bound removal resolution is
+        // EXECUTED. depInState replaces the dropped object-form dependency (which silently never gated).
         {
             from: "ACTIVE",
             to: "ACTIVE",
             eventName: "remove_for_cause",
+            // authority gate — a member of the pinned authorizedRemovers set must sign; an identity role
+            // attestation (BOARD_MEMBER/...) layers on additively when the identity registry lands (§4.2).
             guard: {
-                some: [
-                    { var: "state.directors" },
+                and: [
+                    signerInSet("state.authorizedRemovers"),
+                    // the proposal must target this director, and its bound resolution must be EXECUTED
                     {
-                        and: [
-                            { "==": [{ var: ".directorId" }, { var: "event.directorId" }] },
-                            { "==": [{ var: ".status" }, "ACTIVE"] },
+                        "==": [
+                            { var: "state.pendingRemoval.directorId" },
+                            { var: "event.directorId" },
+                        ],
+                    },
+                    depInState("state.pendingRemoval.resolutionRef", "EXECUTED"),
+                    // event.directorId is the lookup key only — the director must exist and be ACTIVE
+                    {
+                        some: [
+                            { var: "state.directors" },
+                            {
+                                and: [
+                                    {
+                                        "==": [{ var: "directorId" }, { var: "event.directorId" }],
+                                    },
+                                    { "==": [{ var: "status" }, "ACTIVE"] },
+                                ],
+                            },
                         ],
                     },
                 ],
             },
-            dependencies: [
-                {
-                    machine: "corporate-resolution",
-                    instanceRef: { var: "event.removalResolutionRef" },
-                    requiredState: "EXECUTED",
-                },
-            ],
             effect: {
                 merge: [
                     { var: "state" },
@@ -637,7 +710,7 @@ export const corpBoardDef = defineFiberApp({
                                     if: [
                                         {
                                             "==": [
-                                                { var: ".directorId" },
+                                                { var: "directorId" },
                                                 { var: "event.directorId" },
                                             ],
                                         },
@@ -664,10 +737,17 @@ export const corpBoardDef = defineFiberApp({
                                 },
                             ],
                         },
+                        // clear the consumed proposal
+                        pendingRemoval: null,
+                    },
+                    {
+                        _emit: [
+                            { name: "DIRECTOR_REMOVED", data: { var: "event" }, destination: "external" },
+                        ],
                     },
                 ],
             },
-            emits: ["DIRECTOR_REMOVED"],
+            dependencies: [],
         },
         // ACTIVE -> ACTIVE (designate_chair)
         {
@@ -679,8 +759,8 @@ export const corpBoardDef = defineFiberApp({
                     { var: "state.directors" },
                     {
                         and: [
-                            { "==": [{ var: ".directorId" }, { var: "event.directorId" }] },
-                            { "==": [{ var: ".status" }, "ACTIVE"] },
+                            { "==": [{ var: "directorId" }, { var: "event.directorId" }] },
+                            { "==": [{ var: "status" }, "ACTIVE"] },
                         ],
                     },
                 ],
@@ -698,7 +778,7 @@ export const corpBoardDef = defineFiberApp({
                                         {
                                             isChair: {
                                                 "==": [
-                                                    { var: ".directorId" },
+                                                    { var: "directorId" },
                                                     { var: "event.directorId" },
                                                 ],
                                             },
@@ -760,9 +840,13 @@ export const corpBoardDef = defineFiberApp({
                             quorumCount: 0,
                         },
                     },
+                    {
+                        _emit: [
+                            { name: "BOARD_MEETING_SCHEDULED", data: { var: "event" }, destination: "external" },
+                        ],
+                    },
                 ],
             },
-            emits: ["BOARD_MEETING_SCHEDULED"],
         },
         // ACTIVE -> ACTIVE (record_attendance)
         {
@@ -779,9 +863,9 @@ export const corpBoardDef = defineFiberApp({
                             {
                                 and: [
                                     {
-                                        "==": [{ var: ".directorId" }, { var: "event.directorId" }],
+                                        "==": [{ var: "directorId" }, { var: "event.directorId" }],
                                     },
-                                    { "==": [{ var: ".status" }, "ACTIVE"] },
+                                    { "==": [{ var: "status" }, "ACTIVE"] },
                                 ],
                             },
                         ],
@@ -797,7 +881,7 @@ export const corpBoardDef = defineFiberApp({
                                 { var: "state.currentMeeting" },
                                 {
                                     attendees: {
-                                        cat: [
+                                        merge: [
                                             { var: "state.currentMeeting.attendees" },
                                             [
                                                 {
@@ -840,9 +924,13 @@ export const corpBoardDef = defineFiberApp({
                             ],
                         },
                     },
+                    {
+                        _emit: [
+                            { name: "BOARD_MEETING_OPENED", data: { var: "event" }, destination: "external" },
+                        ],
+                    },
                 ],
             },
-            emits: ["BOARD_MEETING_OPENED"],
         },
         // IN_MEETING -> IN_MEETING (director_departs)
         {
@@ -865,7 +953,7 @@ export const corpBoardDef = defineFiberApp({
                                                 if: [
                                                     {
                                                         "==": [
-                                                            { var: ".directorId" },
+                                                            { var: "directorId" },
                                                             { var: "event.directorId" },
                                                         ],
                                                     },
@@ -897,9 +985,16 @@ export const corpBoardDef = defineFiberApp({
             eventName: "quorum_lost",
             guard: { "==": [{ var: "state.currentMeeting.quorumPresent" }, false] },
             effect: {
-                merge: [{ var: "state" }, { status: "QUORUM_LOST" }],
+                merge: [
+                    { var: "state" },
+                    { status: "QUORUM_LOST" },
+                    {
+                        _emit: [
+                            { name: "BOARD_QUORUM_LOST", data: { var: "event" }, destination: "external" },
+                        ],
+                    },
+                ],
             },
-            emits: ["BOARD_QUORUM_LOST"],
         },
         // QUORUM_LOST -> IN_MEETING
         {
@@ -908,9 +1003,16 @@ export const corpBoardDef = defineFiberApp({
             eventName: "quorum_restored",
             guard: { "==": [{ var: "state.currentMeeting.quorumPresent" }, true] },
             effect: {
-                merge: [{ var: "state" }, { status: "IN_MEETING" }],
+                merge: [
+                    { var: "state" },
+                    { status: "IN_MEETING" },
+                    {
+                        _emit: [
+                            { name: "BOARD_QUORUM_RESTORED", data: { var: "event" }, destination: "external" },
+                        ],
+                    },
+                ],
             },
-            emits: ["BOARD_QUORUM_RESTORED"],
         },
         // IN_MEETING -> ACTIVE (adjourn)
         {
@@ -925,7 +1027,7 @@ export const corpBoardDef = defineFiberApp({
                         status: "ACTIVE",
                         currentMeeting: null,
                         meetingHistory: {
-                            cat: [
+                            merge: [
                                 { var: "state.meetingHistory" },
                                 [
                                     {
@@ -943,9 +1045,13 @@ export const corpBoardDef = defineFiberApp({
                             ],
                         },
                     },
+                    {
+                        _emit: [
+                            { name: "BOARD_MEETING_ADJOURNED", data: { var: "event" }, destination: "external" },
+                        ],
+                    },
                 ],
             },
-            emits: ["BOARD_MEETING_ADJOURNED"],
         },
         // QUORUM_LOST -> ACTIVE (adjourn)
         {
@@ -960,7 +1066,7 @@ export const corpBoardDef = defineFiberApp({
                         status: "ACTIVE",
                         currentMeeting: null,
                         meetingHistory: {
-                            cat: [
+                            merge: [
                                 { var: "state.meetingHistory" },
                                 [
                                     {
@@ -978,9 +1084,13 @@ export const corpBoardDef = defineFiberApp({
                             ],
                         },
                     },
+                    {
+                        _emit: [
+                            { name: "BOARD_MEETING_ADJOURNED", data: { var: "event" }, destination: "external" },
+                        ],
+                    },
                 ],
             },
-            emits: ["BOARD_MEETING_ADJOURNED"],
         },
         // ACTIVE -> ACTIVE (update_seats)
         {