@otto-code/protocol 0.7.5 → 0.8.0

package/dist/git-hosting.js

@@ -3,7 +3,7 @@ import { z } from "zod";
 // A project's git hosting provider (GitHub, Bitbucket Cloud, ...) is chosen
 // per project in otto.json; all PR/issue functionality follows that choice.
 // Shared by messages.ts (wire schemas) and otto-config-schema.ts (project
-// config) — lives here to avoid a module cycle between those two.
+// config) - lives here to avoid a module cycle between those two.
 export const GitHostingProviderIdSchema = z.enum(["github", "bitbucket-cloud"]);
 // Wire form of the provider id. Deliberately an OPEN string, not the enum, so a
 // newer peer that adds a third provider (e.g. "gitlab") never makes an older
@@ -12,7 +12,7 @@ export const GitHostingProviderIdSchema = z.enum(["github", "bitbucket-cloud"]);
 // degrade gracefully for unknown ids. Keep the enum for otto.json config and the
 // GIT_HOSTING_PROVIDER_IDS known-set.
 export const GitHostingProviderIdWireSchema = z.string();
-// What a provider can do. The client renders only capability-true actions —
+// What a provider can do. The client renders only capability-true actions -
 // no emulation of missing features (feature contract).
 export const GitHostingCapabilitiesSchema = z.object({
     autoMerge: z.boolean().optional().default(false),
@@ -23,7 +23,7 @@ export const GitHostingCapabilitiesSchema = z.object({
     reviewDecisions: z.boolean().optional().default(false),
     issues: z.boolean().optional().default(false),
     // COMPAT(projectScaffold): added in v0.6.9. Repository-level operations used
-    // by the New project page — enumerate the repos/owners you can reach, and
+    // by the New project page - enumerate the repos/owners you can reach, and
     // create a brand-new remote repository. Absent on older daemons, which is
     // read as "can't", so the page hides those choices rather than emulating them.
     listRepositories: z.boolean().optional().default(false),

package/dist/git-remote.d.ts

@@ -1,6 +1,13 @@
 export interface GitRemoteLocation {
     transport: "scp" | "ssh" | "http" | "https";
     host: string;
+    /**
+     * Explicit non-default port from the remote (e.g. a self-hosted forge on
+     * `:60443`), or undefined for a default-port or scp-form remote. Kept separate
+     * from `host` so host-identity matching (forge detection, cloud-host checks)
+     * stays port-agnostic; only consumers that reconstruct a URL (web links) use it.
+     */
+    port?: string;
     path: string;
 }
 export interface GitHubRemoteIdentity {
@@ -15,4 +22,14 @@ export declare function parseGitRemoteLocation(remoteUrl: string): GitRemoteLoca
 export declare function parseGitHubRemoteIdentity(path: string): GitHubRemoteIdentity | null;
 export declare function isGitHubHost(host: string): boolean;
 export declare function normalizeHost(host: string): string;
+/**
+ * Whether `repo` is already a complete git remote (a URL or scp-like address)
+ * rather than `owner/repo` shorthand that still needs a clone protocol picked.
+ *
+ * Clients (app + CLI) and the daemon must agree on this classification: the
+ * daemon treats `parseGitRemoteLocation(repo) !== null` as "complete remote"
+ * and everything else as shorthand, so reuse the same parser here instead of a
+ * separate regex that would drift (e.g. accepting `git://` the parser rejects).
+ */
+export declare function isCompleteGitRemote(repo: string): boolean;
 //# sourceMappingURL=git-remote.d.ts.map

package/dist/git-remote.js

@@ -1,5 +1,10 @@
 const GITHUB_HOSTS = new Set(["github.com", "ssh.github.com"]);
 const BITBUCKET_CLOUD_HOSTS = new Set(["bitbucket.org", "altssh.bitbucket.org"]);
+const DEFAULT_PORT_BY_PROTOCOL = {
+    "https:": "443",
+    "http:": "80",
+    "ssh:": "22",
+};
 const TRANSPORT_BY_PROTOCOL = {
     "https:": "https",
     "http:": "http",
@@ -26,7 +31,9 @@ export function parseGitRemoteLocation(remoteUrl) {
     const trimmed = remoteUrl.trim();
     if (!trimmed)
         return null;
-    const scpLike = trimmed.match(/^[^@]+@([^:]+):(.+)$/u);
+    // scp form has no scheme. Testing it first would match `ssh://git@host:22/x`
+    // - `[^@]+` happily eats `ssh://git` - and swallow the port into the path.
+    const scpLike = trimmed.includes("://") ? null : trimmed.match(/^[^@]+@([^:]+):(.+)$/u);
     if (scpLike) {
         const host = normalizeHost(scpLike[1] ?? "");
         const path = normalizeRemotePath(scpLike[2] ?? "");
@@ -55,7 +62,9 @@ export function parseGitRemoteLocation(remoteUrl) {
     const normalizedPath = normalizeRemotePath(path);
     if (!isValidRemoteHost(host) || !normalizedPath)
         return null;
-    return { transport, host, path: normalizedPath };
+    const protocol = parsed.protocol.toLowerCase();
+    const port = parsed.port && parsed.port !== DEFAULT_PORT_BY_PROTOCOL[protocol] ? parsed.port : undefined;
+    return { transport, host, port, path: normalizedPath };
 }
 export function parseGitHubRemoteIdentity(path) {
     const segments = path.split("/").filter(Boolean);
@@ -81,4 +90,16 @@ function normalizeRemotePath(path) {
 function isValidRemoteHost(host) {
     return /^[a-z0-9](?:[a-z0-9._-]*[a-z0-9])?$/u.test(host);
 }
+/**
+ * Whether `repo` is already a complete git remote (a URL or scp-like address)
+ * rather than `owner/repo` shorthand that still needs a clone protocol picked.
+ *
+ * Clients (app + CLI) and the daemon must agree on this classification: the
+ * daemon treats `parseGitRemoteLocation(repo) !== null` as "complete remote"
+ * and everything else as shorthand, so reuse the same parser here instead of a
+ * separate regex that would drift (e.g. accepting `git://` the parser rejects).
+ */
+export function isCompleteGitRemote(repo) {
+    return parseGitRemoteLocation(repo) !== null;
+}
 //# sourceMappingURL=git-remote.js.map

package/dist/judge-verdict.d.ts

@@ -4,7 +4,7 @@ export type JudgeOutcome = (typeof JUDGE_OUTCOMES)[number];
 export declare function isJudgeOutcome(value: string): value is JudgeOutcome;
 /**
  * Coerce a raw verdict string to a known outcome. Anything that isn't an exact
- * known outcome is treated as `"fail"` — an unparseable verdict must not be read
+ * known outcome is treated as `"fail"` - an unparseable verdict must not be read
  * as a pass, so a gate never advances on a value it doesn't understand.
  */
 export declare function normalizeJudgeOutcome(value: string | undefined): JudgeOutcome;

package/dist/judge-verdict.js

@@ -10,7 +10,7 @@ import { z } from "zod";
 // Wire-forward-compat: kept a pure structural schema with plain leaves (no
 // transforms), so it can later ride a protocol message without breaking older
 // peers. The outcome rides as a plain string (like personality roles and effort
-// levels) rather than a z.enum, so the vocabulary can grow — consumers normalize
+// levels) rather than a z.enum, so the vocabulary can grow - consumers normalize
 // through `isJudgeOutcome` / `normalizeJudgeOutcome` instead of trusting the raw
 // value.
 // The pass/fail decision. Binary is enough for the signature loop-until-N-good
@@ -23,7 +23,7 @@ export function isJudgeOutcome(value) {
 }
 /**
  * Coerce a raw verdict string to a known outcome. Anything that isn't an exact
- * known outcome is treated as `"fail"` — an unparseable verdict must not be read
+ * known outcome is treated as `"fail"` - an unparseable verdict must not be read
  * as a pass, so a gate never advances on a value it doesn't understand.
  */
 export function normalizeJudgeOutcome(value) {