@otto-assistant/otto 0.7.18 → 0.7.20

package/dist/commands/permissions.js

@@ -57,7 +57,6 @@ function takePendingPermissionContext(contextHash) {
 function renderPermissionContext(permission) {
     const tool = permission.permission.toLowerCase();
     const meta = permission.metadata ?? {};
-    // Read a string value from metadata, trying multiple key names
     const getStr = (keys, fallback = '') => {
         for (const key of keys) {
             const val = meta[key];
@@ -66,7 +65,6 @@ function renderPermissionContext(permission) {
         }
         return fallback;
     };
-    const truncate = (s, maxLen = 500) => s.length > maxLen ? s.slice(0, maxLen - 1) + '…' : s;
     const clipBlock = (s, limit) => s.length > limit ? s.slice(0, limit - 1) + '…' : s;
     switch (tool) {
         case 'bash':
@@ -116,9 +114,8 @@ function renderPermissionContext(permission) {
             const parts = [];
             if (filePath)
                 parts.push(`**File:** \`${filePath}\``);
-            if (content) {
+            if (content)
                 parts.push(`\`\`\`\n${clipBlock(content, 600)}\n\`\`\``);
-            }
             return parts.join('\n');
         }
         case 'webfetch':
@@ -180,7 +177,6 @@ function renderPermissionContext(permission) {
             return `> ${clipBlock(description, 300)}`;
         }
         default: {
-            // Generic: show description or first meaningful metadata field
             const description = getStr(['description', 'action', 'operation', 'command']);
             if (description)
                 return `> *${clipBlock(description, 300)}*`;

package/dist/session-handler/thread-session-runtime.js

@@ -1000,7 +1000,12 @@ export class ThreadSessionRuntime {
             })();
             logger.log(`[EVENT] type=${event.type} eventSessionId=${eventSessionId || 'none'} activeSessionId=${sessionId || 'none'} ${this.formatRunStateForLog()}${eventDetails}`);
         }
-        const isGlobalEvent = event.type === 'tui.toast.show';
+        // permission.asked and question.asked must always reach the handler
+        // so they get forwarded to Discord even when the requesting session
+        // is a subagent whose metadata has been cleared from the buffer.
+        const isGlobalEvent = event.type === 'tui.toast.show' ||
+            event.type === 'permission.asked' ||
+            event.type === 'question.asked';
         const isScopedToastEvent = Boolean(toastSessionId);
         // Drop events that don't match current session (stale events from
         // previous sessions), unless it's a global event or a subtask session.
@@ -1818,8 +1823,11 @@ export class ThreadSessionRuntime {
         const isMainSession = permission.sessionID === sessionId;
         const isSubtaskSession = Boolean(subtaskInfo);
         if (!isMainSession && !isSubtaskSession) {
-            logger.log(`[PERMISSION IGNORED] Permission for unknown session (expected: ${sessionId} or subtask, got: ${permission.sessionID})`);
-            return;
+            logger.log(`[PERMISSION] Permission for non-main session (expected: ${sessionId} or subtask, got: ${permission.sessionID}) — forwarding to Discord anyway`);
+            // Do not return — still show buttons for the Discord thread.
+            // The session mismatch usually happens when the event buffer has
+            // been cleared and a subagent's permission.asked arrives without
+            // subtask metadata in the buffer. The user needs to see these.
         }
         // Auto-deny external_directory permissions for paths that do not exist
         // on the filesystem. There is no point asking the user to approve access

package/package.json

@@ -7,7 +7,7 @@
   },
   "module": "index.ts",
   "type": "module",
-  "version": "0.7.18",
+  "version": "0.7.20",
   "scripts": {
     "dev": "tsx src/bin.ts",
     "prepublishOnly": "pnpm build",

package/src/commands/permissions.ts

@@ -101,7 +101,6 @@ function renderPermissionContext(permission: PermissionRequest): string {
   const tool = permission.permission.toLowerCase()
   const meta = permission.metadata ?? {}
 
-  // Read a string value from metadata, trying multiple key names
   const getStr = (keys: string[], fallback = ''): string => {
     for (const key of keys) {
       const val = meta[key]
@@ -110,9 +109,6 @@ function renderPermissionContext(permission: PermissionRequest): string {
     return fallback
   }
 
-  const truncate = (s: string, maxLen = 500): string =>
-    s.length > maxLen ? s.slice(0, maxLen - 1) + '…' : s
-
   const clipBlock = (s: string, limit: number): string =>
     s.length > limit ? s.slice(0, limit - 1) + '…' : s
 
@@ -158,9 +154,7 @@ function renderPermissionContext(permission: PermissionRequest): string {
       if (!filePath && !content) return ''
       const parts: string[] = []
       if (filePath) parts.push(`**File:** \`${filePath}\``)
-      if (content) {
-        parts.push(`\`\`\`\n${clipBlock(content, 600)}\n\`\`\``)
-      }
+      if (content) parts.push(`\`\`\`\n${clipBlock(content, 600)}\n\`\`\``)
       return parts.join('\n')
     }
 
@@ -220,7 +214,6 @@ function renderPermissionContext(permission: PermissionRequest): string {
     }
 
     default: {
-      // Generic: show description or first meaningful metadata field
       const description = getStr(['description', 'action', 'operation', 'command'])
       if (description) return `> *${clipBlock(description, 300)}*`
       const relevantKeys = Object.keys(meta).filter(

package/src/session-handler/thread-session-runtime.ts

@@ -1452,7 +1452,13 @@ export class ThreadSessionRuntime {
       )
     }
 
-    const isGlobalEvent = event.type === 'tui.toast.show'
+    // permission.asked and question.asked must always reach the handler
+    // so they get forwarded to Discord even when the requesting session
+    // is a subagent whose metadata has been cleared from the buffer.
+    const isGlobalEvent =
+      event.type === 'tui.toast.show' ||
+      event.type === 'permission.asked' ||
+      event.type === 'question.asked'
     const isScopedToastEvent = Boolean(toastSessionId)
 
     // Drop events that don't match current session (stale events from
@@ -2490,9 +2496,12 @@ export class ThreadSessionRuntime {
 
     if (!isMainSession && !isSubtaskSession) {
       logger.log(
-        `[PERMISSION IGNORED] Permission for unknown session (expected: ${sessionId} or subtask, got: ${permission.sessionID})`,
+        `[PERMISSION] Permission for non-main session (expected: ${sessionId} or subtask, got: ${permission.sessionID}) — forwarding to Discord anyway`,
       )
-      return
+      // Do not return — still show buttons for the Discord thread.
+      // The session mismatch usually happens when the event buffer has
+      // been cleared and a subagent's permission.asked arrives without
+      // subtask metadata in the buffer. The user needs to see these.
     }
 
     // Auto-deny external_directory permissions for paths that do not exist