@otto-assistant/otto 0.1.2 → 0.7.16

package/src/commands/file-upload.ts

@@ -0,0 +1,389 @@
+// File upload tool handler - Shows Discord modal with FileUploadBuilder.
+// When the AI uses the otto_file_upload tool, the plugin inserts a row into
+// the ipc_requests DB table. The bot polls this table, picks up the request,
+// and shows a button in the thread. User clicks it to open a modal with a
+// native file picker. Uploaded files are downloaded to the project directory.
+// The bot writes file paths back to ipc_requests.response, and the plugin
+// polls until the response appears.
+
+import {
+  ButtonBuilder,
+  ButtonStyle,
+  ActionRowBuilder,
+  ModalBuilder,
+  FileUploadBuilder,
+  LabelBuilder,
+  ComponentType,
+  type ButtonInteraction,
+  type ModalSubmitInteraction,
+  type ThreadChannel,
+  MessageFlags,
+} from 'discord.js'
+import crypto from 'node:crypto'
+import fs from 'node:fs'
+import path from 'node:path'
+import { createLogger, LogPrefix } from '../logger.js'
+import { notifyError } from '../sentry.js'
+import { NOTIFY_MESSAGE_FLAGS } from '../discord-utils.js'
+
+const logger = createLogger(LogPrefix.FILE_UPLOAD)
+
+// 5 minute TTL for pending contexts - if user doesn't click within this time,
+// clean up the context and resolve with empty array to unblock the plugin tool
+const PENDING_TTL_MS = 5 * 60 * 1000
+
+export type FileUploadRequest = {
+  sessionId: string
+  threadId: string
+  directory: string
+  prompt: string
+  maxFiles: number
+}
+
+type PendingFileUploadContext = {
+  sessionId: string
+  directory: string
+  thread: ThreadChannel
+  prompt: string
+  maxFiles: number
+  contextHash: string
+  resolve: (filePaths: string[]) => void
+  reject: (error: Error) => void
+  messageId?: string
+  resolved: boolean
+  timer: ReturnType<typeof setTimeout>
+}
+
+export const pendingFileUploadContexts = new Map<
+  string,
+  PendingFileUploadContext
+>()
+
+/**
+ * Sanitize an attachment filename to prevent path traversal.
+ * Strips directory separators, .., and null bytes from the name.
+ * Prepends a short random prefix to avoid collisions between uploads.
+ */
+function sanitizeFilename(name: string): string {
+  // Extract just the base name (strips any directory components)
+  let sanitized = path.basename(name)
+  // Remove null bytes and other dangerous characters
+  sanitized = sanitized.replace(/[\x00]/g, '')
+  // If somehow still empty or just dots, give it a safe name
+  if (!sanitized || sanitized === '.' || sanitized === '..') {
+    sanitized = 'upload'
+  }
+  // Prefix with short random id to avoid collisions
+  const prefix = crypto.randomBytes(4).toString('hex')
+  return `${prefix}-${sanitized}`
+}
+
+/**
+ * Safely resolve a pending context exactly once. Prevents double-resolve from
+ * cancel/submit races by checking the `resolved` flag.
+ */
+function resolveContext(
+  context: PendingFileUploadContext,
+  filePaths: string[],
+): boolean {
+  if (context.resolved) {
+    return false
+  }
+  context.resolved = true
+  clearTimeout(context.timer)
+  pendingFileUploadContexts.delete(context.contextHash)
+  context.resolve(filePaths)
+  return true
+}
+
+/**
+ * Show a button in the thread that opens a file upload modal when clicked.
+ * Returns a promise that resolves with the downloaded file paths.
+ */
+export function showFileUploadButton({
+  thread,
+  sessionId,
+  directory,
+  prompt,
+  maxFiles,
+}: {
+  thread: ThreadChannel
+  sessionId: string
+  directory: string
+  prompt: string
+  maxFiles: number
+}): Promise<string[]> {
+  return new Promise((resolve, reject) => {
+    const contextHash = crypto.randomBytes(8).toString('hex')
+
+    // TTL timer: auto-cleanup if user never clicks the button
+    const timer = setTimeout(() => {
+      const ctx = pendingFileUploadContexts.get(contextHash)
+      if (ctx && !ctx.resolved) {
+        logger.log(
+          `File upload timed out for session ${sessionId}, hash=${contextHash}`,
+        )
+        resolveContext(ctx, [])
+        // Remove button from message
+        if (ctx.messageId) {
+          ctx.thread.messages
+            .fetch(ctx.messageId)
+            .then((msg) => {
+              return msg.edit({
+                content: `**File Upload Requested**\n${prompt.slice(0, 1900)}\n_Timed out_`,
+                components: [],
+              })
+            })
+            .catch(() => {})
+        }
+      }
+    }, PENDING_TTL_MS)
+
+    const context: PendingFileUploadContext = {
+      sessionId,
+      directory,
+      thread,
+      prompt,
+      maxFiles,
+      contextHash,
+      resolve,
+      reject,
+      resolved: false,
+      timer,
+    }
+
+    pendingFileUploadContexts.set(contextHash, context)
+
+    const uploadButton = new ButtonBuilder()
+      .setCustomId(`file_upload_btn:${contextHash}`)
+      .setLabel('Upload Files')
+      .setStyle(ButtonStyle.Primary)
+
+    const actionRow = new ActionRowBuilder<ButtonBuilder>().addComponents(
+      uploadButton,
+    )
+
+    thread
+      .send({
+        content: `**File Upload Requested**\n${prompt.slice(0, 1900)}`,
+        components: [actionRow],
+        flags: NOTIFY_MESSAGE_FLAGS,
+      })
+      .then((msg) => {
+        context.messageId = msg.id
+        logger.log(
+          `Showed file upload button for session ${sessionId}, hash=${contextHash}`,
+        )
+      })
+      .catch((err) => {
+        clearTimeout(timer)
+        pendingFileUploadContexts.delete(contextHash)
+        reject(new Error('Failed to send file upload button', { cause: err }))
+      })
+  })
+}
+
+/**
+ * Handle the file upload button click - opens a modal with FileUploadBuilder.
+ */
+export async function handleFileUploadButton(
+  interaction: ButtonInteraction,
+): Promise<void> {
+  const customId = interaction.customId
+  if (!customId.startsWith('file_upload_btn:')) {
+    return
+  }
+
+  const contextHash = customId.replace('file_upload_btn:', '')
+  const context = pendingFileUploadContexts.get(contextHash)
+
+  if (!context || context.resolved) {
+    await interaction.reply({
+      content: 'This file upload request has expired.',
+      flags: MessageFlags.Ephemeral,
+    })
+    return
+  }
+
+  const fileUpload = new FileUploadBuilder()
+    .setCustomId('uploaded_files')
+    .setMinValues(1)
+    .setMaxValues(context.maxFiles)
+
+  const label = new LabelBuilder()
+    .setLabel('Files')
+    .setDescription(context.prompt.slice(0, 100))
+    .setFileUploadComponent(fileUpload)
+
+  const modal = new ModalBuilder()
+    .setCustomId(`file_upload_modal:${contextHash}`)
+    .setTitle('Upload Files')
+    .addLabelComponents(label)
+
+  await interaction.showModal(modal)
+}
+
+/**
+ * Handle the modal submission - download files and resolve the pending promise.
+ */
+export async function handleFileUploadModalSubmit(
+  interaction: ModalSubmitInteraction,
+): Promise<void> {
+  const customId = interaction.customId
+  if (!customId.startsWith('file_upload_modal:')) {
+    return
+  }
+
+  const contextHash = customId.replace('file_upload_modal:', '')
+  const context = pendingFileUploadContexts.get(contextHash)
+
+  if (!context || context.resolved) {
+    await interaction.reply({
+      content: 'This file upload request has expired.',
+      flags: MessageFlags.Ephemeral,
+    })
+    return
+  }
+
+  try {
+    await interaction.deferReply({ flags: MessageFlags.Ephemeral })
+
+    // File upload data is nested in the LabelModalData -> FileUploadModalData
+    const fileField = interaction.fields.getField(
+      'uploaded_files',
+      ComponentType.FileUpload,
+    )
+    const attachments = fileField.attachments
+    if (!attachments || attachments.size === 0) {
+      await interaction.editReply({ content: 'No files were uploaded.' })
+      updateButtonMessage(context, '_No files uploaded_')
+      resolveContext(context, [])
+      return
+    }
+
+    const uploadsDir = path.join(context.directory, 'uploads')
+    fs.mkdirSync(uploadsDir, { recursive: true })
+
+    const downloadedPaths: string[] = []
+    const errors: string[] = []
+
+    for (const [, attachment] of attachments) {
+      // Check if context was cancelled (e.g. user sent new message) while
+      // we were downloading previous files - stop downloading more
+      if (context.resolved) {
+        break
+      }
+      try {
+        const response = await fetch(attachment.url)
+        if (!response.ok) {
+          errors.push(
+            `Failed to download ${attachment.name}: HTTP ${response.status}`,
+          )
+          continue
+        }
+        const buffer = Buffer.from(await response.arrayBuffer())
+        const safeName = sanitizeFilename(attachment.name)
+        const filePath = path.join(uploadsDir, safeName)
+        fs.writeFileSync(filePath, buffer)
+        downloadedPaths.push(filePath)
+      } catch (err) {
+        const msg = err instanceof Error ? err.message : String(err)
+        errors.push(`Failed to download ${attachment.name}: ${msg}`)
+      }
+    }
+
+    // If context was resolved by cancel/timeout during download, don't try to
+    // resolve again - just update the ephemeral reply
+    if (context.resolved) {
+      await interaction.editReply({ content: 'Upload was cancelled.' })
+      return
+    }
+
+    const fileNames = downloadedPaths.map((p) => {
+      return path.basename(p)
+    })
+    updateButtonMessage(
+      context,
+      downloadedPaths.length > 0
+        ? `Uploaded: ${fileNames.join(', ')}`
+        : '_Upload failed_',
+    )
+
+    const summary = (() => {
+      if (downloadedPaths.length > 0 && errors.length === 0) {
+        return `Uploaded ${downloadedPaths.length} file(s) successfully.`
+      }
+      if (downloadedPaths.length > 0 && errors.length > 0) {
+        return `Uploaded ${downloadedPaths.length} file(s). Errors: ${errors.join('; ')}`
+      }
+      return `Upload failed: ${errors.join('; ')}`
+    })()
+
+    await interaction.editReply({ content: summary })
+
+    resolveContext(context, downloadedPaths)
+
+    logger.log(
+      `File upload completed for session ${context.sessionId}: ${downloadedPaths.length} files`,
+    )
+  } catch (err) {
+    // Ensure context is always resolved even on unexpected errors
+    // so the plugin tool doesn't hang indefinitely
+    logger.error('Error in file upload modal submit:', err)
+    void notifyError(err, 'File upload modal submit error')
+    resolveContext(context, [])
+  }
+}
+
+/**
+ * Best-effort update of the original button message (remove button, append status).
+ */
+function updateButtonMessage(
+  context: PendingFileUploadContext,
+  status: string,
+): void {
+  if (!context.messageId) {
+    return
+  }
+  context.thread.messages
+    .fetch(context.messageId)
+    .then((msg) => {
+      return msg.edit({
+        content: `**File Upload Requested**\n${context.prompt.slice(0, 1900)}\n${status}`,
+        components: [],
+      })
+    })
+    .catch(() => {})
+}
+
+/**
+ * Cancel ALL pending file uploads for a thread (e.g. when user sends a new message).
+ */
+export async function cancelPendingFileUpload(
+  threadId: string,
+): Promise<boolean> {
+  const toCancel: PendingFileUploadContext[] = []
+  for (const [, ctx] of pendingFileUploadContexts) {
+    if (ctx.thread.id === threadId) {
+      toCancel.push(ctx)
+    }
+  }
+
+  if (toCancel.length === 0) {
+    return false
+  }
+
+  let cancelled = 0
+  for (const context of toCancel) {
+    const didResolve = resolveContext(context, [])
+    if (didResolve) {
+      updateButtonMessage(context, '_Cancelled - user sent a new message_')
+      cancelled++
+    }
+  }
+
+  if (cancelled > 0) {
+    logger.log(`Cancelled ${cancelled} file upload(s) for thread ${threadId}`)
+  }
+  return cancelled > 0
+}

package/src/commands/fork-subagent.ts

@@ -0,0 +1,263 @@
+// /fork-subagent command - Fork a subagent task session into a new thread.
+
+import {
+  ActionRowBuilder,
+  MessageFlags,
+  StringSelectMenuBuilder,
+  ThreadAutoArchiveDuration,
+  type ThreadChannel,
+  type ChatInputCommandInteraction,
+  type StringSelectMenuInteraction,
+} from 'discord.js'
+import {
+  getSessionEventSnapshot,
+  getThreadSession,
+  setThreadSession,
+} from '../database.js'
+import {
+  resolveTextChannel,
+  resolveWorkingDirectory,
+  sendThreadMessage,
+} from '../discord-utils.js'
+import {
+  collectSessionChunks,
+  batchChunksForDiscord,
+} from '../message-formatting.js'
+import { initializeOpencodeForDirectory } from '../opencode.js'
+import {
+  getDerivedSubagentSessions,
+  type EventBufferEntry,
+} from '../session-handler/event-stream-state.js'
+import { createLogger, LogPrefix } from '../logger.js'
+import {
+  getThreadChannel,
+  parsePersistedEventRows,
+} from './fork.js'
+
+const forkLogger = createLogger(LogPrefix.FORK)
+
+function truncateLabelPart(text: string, maxLength: number): string {
+  if (text.length <= maxLength) {
+    return text
+  }
+  if (maxLength <= 1) {
+    return text.slice(0, maxLength)
+  }
+  return `${text.slice(0, maxLength - 1)}…`
+}
+
+function getSubagentOptionLabel({
+  subagentType,
+  description,
+}: {
+  subagentType?: string
+  description?: string
+}): string {
+  const agent = truncateLabelPart(subagentType || 'task', 24)
+  const cleanedDescription = description?.trim() || 'No description'
+  const descriptionBudget = Math.max(1, 100 - agent.length - 3)
+  const truncatedDescription = truncateLabelPart(
+    cleanedDescription,
+    descriptionBudget,
+  )
+  return `${agent} · ${truncatedDescription}`
+}
+
+export async function handleForkSubagentCommand(
+  interaction: ChatInputCommandInteraction,
+): Promise<void> {
+  const threadChannel = getThreadChannel(interaction.channel)
+  if (threadChannel instanceof Error) {
+    await interaction.reply({
+      content: threadChannel.message,
+      flags: MessageFlags.Ephemeral,
+    })
+    return
+  }
+
+  const resolved = await resolveWorkingDirectory({
+    channel: threadChannel,
+  })
+  if (!resolved) {
+    await interaction.reply({
+      content: 'Could not determine project directory for this channel',
+      flags: MessageFlags.Ephemeral,
+    })
+    return
+  }
+
+  const sessionId = await getThreadSession(threadChannel.id)
+  if (!sessionId) {
+    await interaction.reply({
+      content: 'No active session in this thread',
+      flags: MessageFlags.Ephemeral,
+    })
+    return
+  }
+
+  await interaction.deferReply({ flags: MessageFlags.Ephemeral })
+
+  const rows = await getSessionEventSnapshot({ sessionId })
+  const events: EventBufferEntry[] = parsePersistedEventRows({ rows })
+  const subagentSessions = getDerivedSubagentSessions({
+    events,
+    mainSessionId: sessionId,
+  }).slice(0, 25)
+
+  if (subagentSessions.length === 0) {
+    await interaction.editReply({
+      content: 'No subagent task sessions found in this thread',
+    })
+    return
+  }
+
+  const options = subagentSessions.map((subagentSession) => ({
+    label: getSubagentOptionLabel({
+      subagentType: subagentSession.subagentType,
+      description: subagentSession.description,
+    }),
+    value: subagentSession.childSessionId,
+    description: new Date(subagentSession.timestamp).toLocaleString().slice(0, 100),
+  }))
+
+  const selectMenu = new StringSelectMenuBuilder()
+    .setCustomId(`fork_subagent_select:${sessionId}`)
+    .setPlaceholder('Select a subagent session to fork')
+    .addOptions(options)
+
+  const actionRow =
+    new ActionRowBuilder<StringSelectMenuBuilder>().addComponents(selectMenu)
+
+  await interaction.editReply({
+    content:
+      '**Fork Subagent Session**\nSelect a subagent task session to fork into a new thread:',
+    components: [actionRow],
+  })
+}
+
+export async function handleForkSubagentSelectMenu(
+  interaction: StringSelectMenuInteraction,
+): Promise<void> {
+  const customId = interaction.customId
+  if (!customId.startsWith('fork_subagent_select:')) {
+    return
+  }
+
+  const [, parentSessionId] = customId.split(':')
+  if (!parentSessionId) {
+    await interaction.reply({
+      content: 'Invalid selection data',
+      flags: MessageFlags.Ephemeral,
+    })
+    return
+  }
+
+  const selectedSessionId = interaction.values[0]
+  if (!selectedSessionId) {
+    await interaction.reply({
+      content: 'No subagent session selected',
+      flags: MessageFlags.Ephemeral,
+    })
+    return
+  }
+
+  await interaction.deferReply()
+
+  const threadChannel = getThreadChannel(interaction.channel)
+  if (threadChannel instanceof Error) {
+    await interaction.editReply(threadChannel.message)
+    return
+  }
+
+  const resolved = await resolveWorkingDirectory({
+    channel: threadChannel,
+  })
+  if (!resolved) {
+    await interaction.editReply('Could not determine project directory for this channel')
+    return
+  }
+
+  const rows = await getSessionEventSnapshot({ sessionId: parentSessionId })
+  const events: EventBufferEntry[] = parsePersistedEventRows({ rows })
+  const selectedSubagent = getDerivedSubagentSessions({
+    events,
+    mainSessionId: parentSessionId,
+  }).find((candidate) => {
+    return candidate.childSessionId === selectedSessionId
+  })
+
+  const getClient = await initializeOpencodeForDirectory(
+    resolved.projectDirectory,
+  )
+  if (getClient instanceof Error) {
+    await interaction.editReply(`Failed to fork session: ${getClient.message}`)
+    return
+  }
+
+  const forkResponse = await getClient().session.fork({
+    sessionID: selectedSessionId,
+  })
+  if (!forkResponse.data) {
+    await interaction.editReply('Failed to fork session')
+    return
+  }
+
+  const textChannel = await resolveTextChannel(threadChannel)
+  if (!textChannel) {
+    await interaction.editReply('Could not resolve parent text channel')
+    return
+  }
+
+  const forkedSession = forkResponse.data
+  const forkedThread = await textChannel.threads.create({
+    name: `Fork: ${selectedSubagent?.description || selectedSubagent?.subagentType || 'subagent session'}`.slice(0, 100),
+    autoArchiveDuration: ThreadAutoArchiveDuration.OneDay,
+    reason: `Forked subagent session ${selectedSessionId}`,
+  })
+
+  await setThreadSession(forkedThread.id, forkedSession.id)
+  await forkedThread.members.add(interaction.user.id)
+
+  forkLogger.log(
+    `Created forked subagent session ${forkedSession.id} in thread ${forkedThread.id} from ${selectedSessionId}`,
+  )
+
+  const agentLabel = selectedSubagent?.subagentType || 'task'
+  const descriptionLabel = selectedSubagent?.description || 'No description'
+
+  await sendThreadMessage(
+    forkedThread,
+    `**Forked subagent session created!**\nAgent: \`${agentLabel}\`\nTask: ${descriptionLabel}\nFrom: \`${selectedSessionId}\`\nNew session: \`${forkedSession.id}\``,
+  )
+
+  try {
+    const messagesResponse = await getClient().session.messages({
+      sessionID: forkedSession.id,
+    })
+    if (messagesResponse.data) {
+      const { chunks } = collectSessionChunks({
+        messages: messagesResponse.data,
+        limit: 30,
+      })
+      const batched = batchChunksForDiscord(chunks)
+      for (const batch of batched) {
+        await sendThreadMessage(forkedThread, batch.content)
+      }
+    }
+  } catch (error) {
+    forkLogger.error('Error replaying forked subagent history:', error)
+    await sendThreadMessage(
+      forkedThread,
+      'Failed to load session messages, but the session is connected and ready to continue.',
+    )
+  }
+
+  await sendThreadMessage(
+    forkedThread,
+    'You can now continue the conversation from this point.',
+  )
+
+  await interaction.editReply(
+    `Subagent session forked! Continue in ${forkedThread.toString()}`,
+  )
+}