@otaupdate/react-native 1.0.2 → 1.0.4

package/README.md

@@ -22,6 +22,26 @@ rollback-on-failure; JS handles the update check and the app-facing API.
 npm install @otaupdate/react-native
 ```
 
+> **Bare React Native on Android — pin your version to match your RN version.**
+> `npm install` with no version pin gets you the latest (currently 1.0.5).
+> That version relies on an internal React Native API whose shape changed
+> between RN releases — it requires **RN 0.80+**. If your app is on an
+> **older RN version (0.7x)**, pin `@otaupdate/react-native@1.0.4` instead:
+>
+> ```bash
+> npm install @otaupdate/react-native@1.0.4   # RN 0.7x
+> npm install @otaupdate/react-native@1.0.5   # RN 0.80+ (or just @otaupdate/react-native)
+> ```
+>
+> Both versions are fully functional and behave identically from the JS API
+> you call (`sync`, `checkForUpdate`, `withOtaUpdate`, etc. — none of that
+> changes). The only difference is *how* Android applies a mandatory/resume
+> install: 1.0.4 restarts the process (a brief visible flash during the
+> switch); 1.0.5 swaps the bundle in place with no restart and no flash, the
+> same way Expo's own update mechanism does, but that technique only exists
+> on newer RN. Expo and iOS are unaffected by any of this — both already
+> update seamlessly regardless of which SDK version you're on.
+
 ### Bare React Native
 
 **iOS**
@@ -320,3 +340,5 @@ compatible with. Devices on other binary versions never receive it.
 | `no_matching_binary_version` | The release's `targetBinaryVersion` does not cover the installed native version. |
 | Works in debug, not release | Debug builds load from Metro; the OTA path only runs in release builds. |
 | Android: mandatory update reload-loops (bare RN) | Fixed in 1.0.2. Before that, `IMMEDIATE`/`ON_NEXT_RESUME` tried an in-place JS reload that reused a bundle path fixed at process start, so the same mandatory update kept re-triggering forever. 1.0.2 does a real process restart instead — update to it. |
+| A newer update never shows up, app stays on an older-than-expected release | Fixed in 1.0.3. `notifyApplicationReady()` used to clear *any* pending hash unconditionally — if a second update was downloaded and queued for a future restart while the first one was still being confirmed, its pending state was silently wiped and the device never advanced to it. |
+| Android: old screen briefly visible during a mandatory/resume install | Improved in 1.0.3. The process-restart fix in 1.0.2 is correct but showed Android's default activity-transition animation (old screen sliding/fading out). 1.0.3 suppresses it via `overridePendingTransition(0, 0)` so the switch is instant. |

package/android/src/main/java/com/otaupdate/OtaUpdateModule.kt

@@ -246,7 +246,25 @@ class OtaUpdateModule(private val reactContext: ReactApplicationContext) :
     try {
       val launchIntent = context.packageManager.getLaunchIntentForPackage(context.packageName)
         ?: throw IllegalStateException("no launch intent for ${context.packageName}")
-      context.startActivity(Intent.makeRestartActivityTask(launchIntent.component))
+      val restartIntent = Intent.makeRestartActivityTask(launchIntent.component)
+
+      // Starting the restart from the current Activity (when one is attached)
+      // instead of the bare application context lets us suppress the default
+      // activity-transition animation right after — otherwise Android
+      // animates the old screen sliding/fading out while the new one comes
+      // in, so the old content stays visibly on screen for the transition's
+      // duration. overridePendingTransition(0, 0) makes the switch instant
+      // instead. Falls back to starting from the application context if no
+      // activity is currently attached — the restart still works, just with
+      // the default (visible) transition.
+      val activity = reactContext.currentActivity
+      if (activity != null) {
+        activity.startActivity(restartIntent)
+        @Suppress("DEPRECATION")
+        activity.overridePendingTransition(0, 0)
+      } else {
+        context.startActivity(restartIntent)
+      }
       Runtime.getRuntime().exit(0)
     } catch (e: Exception) {
       Log.e(OtaUpdateStore.TAG, "failed to restart the app process", e)

package/android/src/main/java/com/otaupdate/OtaUpdateStore.kt

@@ -147,10 +147,21 @@ class OtaUpdateStore(private val context: Context) {
     return true
   }
 
-  /** Confirms the running bundle. After this it can never be rolled back. */
+  /**
+   * Confirms the running bundle. After this it can never be rolled back.
+   *
+   * Only confirms when `pendingIsLoading` is true — meaning this session
+   * actually booted into `pendingHash` via `promotePendingIfAny()`. A
+   * `pendingHash` set by `markPending()` describes a *different*, newer
+   * package downloaded and queued for a *future* restart, not something
+   * running right now. Clearing it here — as an earlier version of this
+   * method did unconditionally — silently discarded that queued update: the
+   * next restart would find nothing pending and keep loading the older
+   * package, i.e. "the newly downloaded update never shows up."
+   */
   @Synchronized
   fun notifyApplicationReady() {
-    if (pendingHash == null) return
+    if (pendingHash == null || !pendingIsLoading) return
     Log.i(TAG, "update ${pendingHash} confirmed healthy")
     lastConfirmedHash = currentHash
     pendingHash = null

package/ios/OtaUpdateStore.m

@@ -143,9 +143,19 @@ static NSString *const kLogTag = @"[OtaUpdate]";
   }
 }
 
+/**
+ * Confirms the running bundle. After this it can never be rolled back.
+ *
+ * Only confirms when pendingIsLoading is YES — meaning this session actually
+ * booted into pendingHash via promotePendingIfAny. A pendingHash set by
+ * markPending: describes a *different*, newer package downloaded and queued
+ * for a *future* restart, not something running right now. Clearing it here
+ * unconditionally (as an earlier version of this method did) silently
+ * discarded that queued update.
+ */
 - (void)notifyApplicationReady {
   @synchronized(self) {
-    if (!self.pendingHash) return;
+    if (!self.pendingHash || !self.pendingIsLoading) return;
     NSLog(@"%@ update %@ confirmed healthy", kLogTag, self.pendingHash);
     self.lastConfirmedHash = self.currentHash;
     self.pendingHash = nil;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@otaupdate/react-native",
-  "version": "1.0.2",
+  "version": "1.0.4",
   "description": "Over-the-air JS bundle updates for React Native \u2014 bare and Expo",
   "license": "MIT",
   "publishConfig": {