@otaupdate/react-native 1.0.1 → 1.0.3

package/README.md

@@ -319,3 +319,6 @@ compatible with. Devices on other binary versions never receive it.
 | Every update rolls back | `notifyAppReady()` is never reached — usually an early crash, or the call sits behind a screen the user has to navigate to. |
 | `no_matching_binary_version` | The release's `targetBinaryVersion` does not cover the installed native version. |
 | Works in debug, not release | Debug builds load from Metro; the OTA path only runs in release builds. |
+| Android: mandatory update reload-loops (bare RN) | Fixed in 1.0.2. Before that, `IMMEDIATE`/`ON_NEXT_RESUME` tried an in-place JS reload that reused a bundle path fixed at process start, so the same mandatory update kept re-triggering forever. 1.0.2 does a real process restart instead — update to it. |
+| A newer update never shows up, app stays on an older-than-expected release | Fixed in 1.0.3. `notifyApplicationReady()` used to clear *any* pending hash unconditionally — if a second update was downloaded and queued for a future restart while the first one was still being confirmed, its pending state was silently wiped and the device never advanced to it. |
+| Android: old screen briefly visible during a mandatory/resume install | Improved in 1.0.3. The process-restart fix in 1.0.2 is correct but showed Android's default activity-transition animation (old screen sliding/fading out). 1.0.3 suppresses it via `overridePendingTransition(0, 0)` so the switch is instant. |

package/android/src/main/java/com/otaupdate/OtaUpdateModule.kt

@@ -1,9 +1,9 @@
 package com.otaupdate
 
+import android.content.Intent
 import android.os.Handler
 import android.os.Looper
 import android.util.Log
-import com.facebook.react.ReactApplication
 import com.facebook.react.bridge.Arguments
 import com.facebook.react.bridge.LifecycleEventListener
 import com.facebook.react.bridge.Promise
@@ -221,33 +221,53 @@ class OtaUpdateModule(private val reactContext: ReactApplicationContext) :
   }
 
   /**
-   * Recreates the React context so the new bundle is loaded. Handles both the
-   * bridge and bridgeless (new architecture) hosts; the bridgeless path is
-   * reached reflectively so this module still compiles against RN 0.71.
+   * Restarts the whole process so the new bundle is loaded.
+   *
+   * This used to try an in-place JS-context reload (ReactHost.reload() via
+   * reflection on the new architecture, recreateReactContextInBackground() as
+   * a bridge-mode fallback) — but on Android BOTH of those reuse a bundle
+   * loader/path that was fixed once at ReactInstanceManager/ReactHost
+   * construction time (see ReactInstanceManager#mBundleLoader, a `final`
+   * field, and DefaultReactHost's internal singleton caching). Neither ever
+   * re-consults MainApplication's getJSBundleFile()/jsBundleFilePath, so an
+   * IMMEDIATE or ON_NEXT_RESUME install silently kept reloading the OLD
+   * bundle forever — for a mandatory update this produced an infinite
+   * reload loop, since the freshly-reloaded old bundle immediately saw the
+   * same "mandatory update available" response and tried to install again.
+   *
+   * A genuine process kill + relaunch is the only reliable way to force
+   * MainApplication to re-run from scratch and pick up the new bundle path —
+   * the same technique restart libraries like react-native-restart use.
+   * iOS does not need this: RCTTriggerReloadCommandListeners re-queries
+   * bundleURL() fresh on every reload, so it was never affected.
    */
   private fun reload() {
-    val application = reactContext.applicationContext
-    if (application !is ReactApplication) {
-      Log.e(OtaUpdateStore.TAG, "Application does not implement ReactApplication — cannot restart")
-      return
-    }
-
+    val context = reactContext.applicationContext
     try {
-      val reactHost = runCatching {
-        ReactApplication::class.java.getMethod("getReactHost").invoke(application)
-      }.getOrNull()
-
-      if (reactHost != null) {
-        reactHost.javaClass.methods
-          .firstOrNull { it.name == "reload" && it.parameterTypes.size == 1 }
-          ?.invoke(reactHost, "OTA update applied")
-          ?: Log.e(OtaUpdateStore.TAG, "ReactHost has no reload(String) method")
-        return
+      val launchIntent = context.packageManager.getLaunchIntentForPackage(context.packageName)
+        ?: throw IllegalStateException("no launch intent for ${context.packageName}")
+      val restartIntent = Intent.makeRestartActivityTask(launchIntent.component)
+
+      // Starting the restart from the current Activity (when one is attached)
+      // instead of the bare application context lets us suppress the default
+      // activity-transition animation right after — otherwise Android
+      // animates the old screen sliding/fading out while the new one comes
+      // in, so the old content stays visibly on screen for the transition's
+      // duration. overridePendingTransition(0, 0) makes the switch instant
+      // instead. Falls back to starting from the application context if no
+      // activity is currently attached — the restart still works, just with
+      // the default (visible) transition.
+      val activity = reactContext.currentActivity
+      if (activity != null) {
+        activity.startActivity(restartIntent)
+        @Suppress("DEPRECATION")
+        activity.overridePendingTransition(0, 0)
+      } else {
+        context.startActivity(restartIntent)
       }
-
-      application.reactNativeHost.reactInstanceManager.recreateReactContextInBackground()
+      Runtime.getRuntime().exit(0)
     } catch (e: Exception) {
-      Log.e(OtaUpdateStore.TAG, "failed to restart the React context", e)
+      Log.e(OtaUpdateStore.TAG, "failed to restart the app process", e)
     }
   }
 

package/android/src/main/java/com/otaupdate/OtaUpdateStore.kt

@@ -147,10 +147,21 @@ class OtaUpdateStore(private val context: Context) {
     return true
   }
 
-  /** Confirms the running bundle. After this it can never be rolled back. */
+  /**
+   * Confirms the running bundle. After this it can never be rolled back.
+   *
+   * Only confirms when `pendingIsLoading` is true — meaning this session
+   * actually booted into `pendingHash` via `promotePendingIfAny()`. A
+   * `pendingHash` set by `markPending()` describes a *different*, newer
+   * package downloaded and queued for a *future* restart, not something
+   * running right now. Clearing it here — as an earlier version of this
+   * method did unconditionally — silently discarded that queued update: the
+   * next restart would find nothing pending and keep loading the older
+   * package, i.e. "the newly downloaded update never shows up."
+   */
   @Synchronized
   fun notifyApplicationReady() {
-    if (pendingHash == null) return
+    if (pendingHash == null || !pendingIsLoading) return
     Log.i(TAG, "update ${pendingHash} confirmed healthy")
     lastConfirmedHash = currentHash
     pendingHash = null

package/ios/OtaUpdateStore.m

@@ -143,9 +143,19 @@ static NSString *const kLogTag = @"[OtaUpdate]";
   }
 }
 
+/**
+ * Confirms the running bundle. After this it can never be rolled back.
+ *
+ * Only confirms when pendingIsLoading is YES — meaning this session actually
+ * booted into pendingHash via promotePendingIfAny. A pendingHash set by
+ * markPending: describes a *different*, newer package downloaded and queued
+ * for a *future* restart, not something running right now. Clearing it here
+ * unconditionally (as an earlier version of this method did) silently
+ * discarded that queued update.
+ */
 - (void)notifyApplicationReady {
   @synchronized(self) {
-    if (!self.pendingHash) return;
+    if (!self.pendingHash || !self.pendingIsLoading) return;
     NSLog(@"%@ update %@ confirmed healthy", kLogTag, self.pendingHash);
     self.lastConfirmedHash = self.currentHash;
     self.pendingHash = nil;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@otaupdate/react-native",
-  "version": "1.0.1",
+  "version": "1.0.3",
   "description": "Over-the-air JS bundle updates for React Native \u2014 bare and Expo",
   "license": "MIT",
   "publishConfig": {