@oss-autopilot/core 0.42.0 → 0.42.2

package/dist/core/pr-monitor.js

@@ -15,7 +15,7 @@ import { getOctokit } from './github.js';
 import { getStateManager } from './state.js';
 import { daysBetween, parseGitHubUrl, extractOwnerRepo } from './utils.js';
 import { runWorkerPool } from './concurrency.js';
-import { ConfigurationError, ValidationError } from './errors.js';
+import { ConfigurationError, ValidationError, errorMessage, getHttpStatusCode } from './errors.js';
 import { paginateAll } from './pagination.js';
 import { debug, warn, timed } from './logger.js';
 import { getHttpCache, cachedRequest } from './http-cache.js';
@@ -114,9 +114,9 @@ export class PRMonitor {
                         prs.push(pr);
                 }
                 catch (error) {
-                    const errorMessage = error instanceof Error ? error.message : String(error);
-                    warn('pr-monitor', `Error fetching ${item.html_url}: ${errorMessage}`);
-                    failures.push({ prUrl: item.html_url, error: errorMessage });
+                    const errMsg = errorMessage(error);
+                    warn('pr-monitor', `Error fetching ${item.html_url}: ${errMsg}`);
+                    failures.push({ prUrl: item.html_url, error: errMsg });
                 }
             }, MAX_CONCURRENT_REQUESTS);
         });
@@ -162,14 +162,14 @@ export class PRMonitor {
             paginateAll((page) => this.octokit.issues.listComments({ owner, repo, issue_number: number, per_page: 100, page })),
             this.octokit.pulls.listReviews({ owner, repo, pull_number: number }),
             paginateAll((page) => this.octokit.pulls.listReviewComments({ owner, repo, pull_number: number, per_page: 100, page })).catch((err) => {
-                const status = err?.status;
+                const status = getHttpStatusCode(err);
                 // Rate limit errors must propagate — silently swallowing them hides
                 // a systemic problem and produces misleading results (#229).
                 if (status === 429) {
                     throw err;
                 }
                 if (status === 403) {
-                    const msg = (err?.message ?? '').toLowerCase();
+                    const msg = errorMessage(err).toLowerCase();
                     if (msg.includes('rate limit') || msg.includes('abuse detection')) {
                         throw err;
                     }
@@ -283,6 +283,11 @@ export class PRMonitor {
             // If the contributor pushed a commit after the maintainer's comment,
             // the changes have been addressed — waiting for maintainer re-review
             if (latestCommitDate && lastMaintainerCommentDate && latestCommitDate > lastMaintainerCommentDate) {
+                // Safety net (#431): if a CHANGES_REQUESTED review was submitted after
+                // the commit, the maintainer still expects changes — don't mask it
+                if (latestChangesRequestedDate && latestCommitDate < latestChangesRequestedDate) {
+                    return 'needs_response';
+                }
                 if (ciStatus === 'failing')
                     return 'failing_ci';
                 return 'changes_addressed';
@@ -349,7 +354,7 @@ export class PRMonitor {
                 this.octokit.repos.getCombinedStatusForRef({ owner, repo, ref: sha }),
                 // 404 is expected for repos without check runs configured; log other errors for debugging
                 this.octokit.checks.listForRef({ owner, repo, ref: sha }).catch((err) => {
-                    const status = err?.status;
+                    const status = getHttpStatusCode(err);
                     if (status === 404) {
                         debug('pr-monitor', `Check runs 404 for ${owner}/${repo}@${sha.slice(0, 7)} (no checks configured)`);
                     }
@@ -378,8 +383,8 @@ export class PRMonitor {
             return mergeStatuses(checkRunAnalysis, combinedAnalysis, checkRuns.length);
         }
         catch (error) {
-            const statusCode = error.status;
-            const errorMessage = error instanceof Error ? error.message : String(error);
+            const statusCode = getHttpStatusCode(error);
+            const errMsg = errorMessage(error);
             if (statusCode === 401) {
                 warn('pr-monitor', `CI check failed for ${owner}/${repo}: Invalid token`);
             }
@@ -392,7 +397,7 @@ export class PRMonitor {
                 return { status: 'unknown', failingCheckNames: [], failingCheckConclusions: new Map() };
             }
             else {
-                warn('pr-monitor', `Failed to check CI for ${owner}/${repo}@${sha.slice(0, 7)}: ${errorMessage}`);
+                warn('pr-monitor', `Failed to check CI for ${owner}/${repo}@${sha.slice(0, 7)}: ${errMsg}`);
             }
             return { status: 'unknown', failingCheckNames: [], failingCheckConclusions: new Map() };
         }
@@ -451,7 +456,7 @@ export class PRMonitor {
                 }
                 else {
                     chunkFailures++;
-                    warn(MODULE, `Failed to fetch stars for ${chunk[j]}: ${result.reason instanceof Error ? result.reason.message : result.reason}`);
+                    warn(MODULE, `Failed to fetch stars for ${chunk[j]}: ${errorMessage(result.reason)}`);
                 }
             }
             // If entire chunk failed, likely a systemic issue (rate limit, auth, outage) — abort remaining
@@ -466,47 +471,6 @@ export class PRMonitor {
         debug(MODULE, `Fetched star counts for ${results.size}/${repos.length} repos`);
         return results;
     }
-    /**
-     * Shared helper: search for recent PRs and filter out own repos, excluded repos/orgs.
-     * Returns parsed search results that pass all filters.
-     */
-    async fetchRecentPRs(query, label, days, mapItem) {
-        const config = this.stateManager.getState().config;
-        if (!config.githubUsername) {
-            warn(MODULE, `Skipping recently ${label} PRs fetch: no githubUsername configured. Run /setup-oss to configure.`);
-            return [];
-        }
-        const sinceDate = new Date();
-        sinceDate.setDate(sinceDate.getDate() - days);
-        const since = sinceDate.toISOString().split('T')[0]; // YYYY-MM-DD
-        debug(MODULE, `Fetching recently ${label} PRs for @${config.githubUsername} (since ${since})...`);
-        const { data } = await this.octokit.search.issuesAndPullRequests({
-            q: query.replace('{username}', config.githubUsername).replace('{since}', since),
-            sort: 'updated',
-            order: 'desc',
-            per_page: 100,
-        });
-        const results = [];
-        for (const item of data.items) {
-            const parsed = parseGitHubUrl(item.html_url);
-            if (!parsed) {
-                warn(MODULE, `Could not parse GitHub URL from API response: ${item.html_url}`);
-                continue;
-            }
-            const repo = `${parsed.owner}/${parsed.repo}`;
-            // Skip own repos
-            if (parsed.owner.toLowerCase() === config.githubUsername.toLowerCase())
-                continue;
-            // Skip excluded repos and orgs
-            if (config.excludeRepos.includes(repo))
-                continue;
-            if (config.excludeOrgs?.some((org) => parsed.owner.toLowerCase() === org.toLowerCase()))
-                continue;
-            results.push(mapItem(item, { owner: parsed.owner, repo, number: parsed.number }));
-        }
-        debug(MODULE, `Found ${results.length} recently ${label} PRs`);
-        return results;
-    }
     /**
      * Fetch PRs closed without merge in the last N days.
      * Delegates to github-stats module.

package/dist/core/review-analysis.js

@@ -101,11 +101,11 @@ export function checkUnrespondedComments(comments, reviews, reviewComments, user
         if (!review.submitted_at)
             continue;
         const body = (review.body || '').trim();
-        // Include COMMENTED reviews even without body text — they indicate
-        // inline review comments were posted and may need a response (#151).
-        // Skip other empty-body reviews (APPROVED, CHANGES_REQUESTED, DISMISSED)
-        // as those are state changes without comment text.
-        if (!body && review.state !== 'COMMENTED')
+        // Include COMMENTED and CHANGES_REQUESTED reviews even without body text —
+        // they indicate inline review comments were posted and need a response (#151, #431).
+        // CHANGES_REQUESTED with only inline comments is actionable maintainer feedback.
+        // Skip other empty-body reviews (APPROVED, DISMISSED) as those are state changes.
+        if (!body && review.state !== 'COMMENTED' && review.state !== 'CHANGES_REQUESTED')
             continue;
         const author = review.user?.login || 'unknown';
         // For inline-only COMMENTED reviews, skip pure self-replies (#199)
@@ -117,7 +117,9 @@ export function checkUnrespondedComments(comments, reviews, reviewComments, user
         // Resolve body: prefer actual text, then inline comment text, then synthetic placeholder
         const resolvedBody = body ||
             (review.id != null ? getInlineCommentBody(review.id, reviewComments) : undefined) ||
-            '(posted inline review comments)';
+            (review.state === 'CHANGES_REQUESTED'
+                ? '(requested changes via inline review comments)'
+                : '(posted inline review comments)');
         timeline.push({
             author,
             body: resolvedBody,

package/dist/core/state.js

@@ -6,7 +6,7 @@ import * as fs from 'fs';
 import * as path from 'path';
 import { INITIAL_STATE, } from './types.js';
 import { getStatePath, getBackupDir, getDataDir } from './utils.js';
-import { ValidationError } from './errors.js';
+import { ValidationError, errorMessage } from './errors.js';
 import { debug, warn } from './logger.js';
 const MODULE = 'state';
 // Current state version
@@ -272,8 +272,7 @@ export class StateManager {
             return true;
         }
         catch (error) {
-            const errorMessage = error instanceof Error ? error.message : String(error);
-            warn(MODULE, `Failed to migrate state: ${errorMessage}`);
+            warn(MODULE, `Failed to migrate state: ${errorMessage(error)}`);
             // Clean up partial migration to avoid inconsistent state
             const newStatePath = getStatePath();
             if (fs.existsSync(newStatePath) && fs.existsSync(LEGACY_STATE_FILE)) {
@@ -471,12 +470,12 @@ export class StateManager {
                     fs.unlinkSync(path.join(backupDir, file));
                 }
                 catch (error) {
-                    warn(MODULE, `Could not delete old backup ${file}:`, error instanceof Error ? error.message : error);
+                    warn(MODULE, `Could not delete old backup ${file}:`, errorMessage(error));
                 }
             }
         }
         catch (error) {
-            warn(MODULE, 'Could not clean up backups:', error instanceof Error ? error.message : error);
+            warn(MODULE, 'Could not clean up backups:', errorMessage(error));
         }
     }
     /**

package/dist/core/test-utils.d.ts

@@ -0,0 +1,14 @@
+/**
+ * Shared test factories for oss-autopilot.
+ *
+ * Centralises mock object construction so that when types gain new required
+ * fields we only update one place. Every factory accepts a `Partial<T>`
+ * override bag — callers only specify the fields relevant to their test.
+ */
+import type { FetchedPR, DailyDigest, ShelvedPRRef, AgentState } from './types.js';
+import type { CapacityAssessment } from '../formatters/json.js';
+export declare function makeFetchedPR(overrides?: Partial<FetchedPR>): FetchedPR;
+export declare function makeDailyDigest(overrides?: Partial<DailyDigest>): DailyDigest;
+export declare function makeShelvedPRRef(overrides?: Partial<ShelvedPRRef>): ShelvedPRRef;
+export declare function makeCapacityAssessment(overrides?: Partial<CapacityAssessment>): CapacityAssessment;
+export declare function makeAgentState(overrides?: Partial<AgentState>): AgentState;

package/dist/core/test-utils.js

@@ -0,0 +1,125 @@
+/**
+ * Shared test factories for oss-autopilot.
+ *
+ * Centralises mock object construction so that when types gain new required
+ * fields we only update one place. Every factory accepts a `Partial<T>`
+ * override bag — callers only specify the fields relevant to their test.
+ */
+// ---------------------------------------------------------------------------
+// FetchedPR
+// ---------------------------------------------------------------------------
+export function makeFetchedPR(overrides = {}) {
+    const repo = overrides.repo ?? 'owner/repo';
+    const number = overrides.number ?? 1;
+    return {
+        id: 1,
+        url: `https://github.com/${repo}/pull/${number}`,
+        repo,
+        number,
+        title: 'Test PR',
+        status: 'healthy',
+        displayLabel: '[Healthy]',
+        displayDescription: 'Everything looks good',
+        createdAt: '2025-06-01T00:00:00Z',
+        updatedAt: '2025-06-15T00:00:00Z',
+        daysSinceActivity: 2,
+        ciStatus: 'passing',
+        failingCheckNames: [],
+        classifiedChecks: [],
+        hasMergeConflict: false,
+        reviewDecision: 'approved',
+        hasUnrespondedComment: false,
+        hasIncompleteChecklist: false,
+        maintainerActionHints: [],
+        ...overrides,
+    };
+}
+// ---------------------------------------------------------------------------
+// DailyDigest
+// ---------------------------------------------------------------------------
+export function makeDailyDigest(overrides = {}) {
+    return {
+        generatedAt: '2025-06-20T00:00:00Z',
+        openPRs: [],
+        prsNeedingResponse: [],
+        ciFailingPRs: [],
+        ciBlockedPRs: [],
+        ciNotRunningPRs: [],
+        mergeConflictPRs: [],
+        needsRebasePRs: [],
+        missingRequiredFilesPRs: [],
+        incompleteChecklistPRs: [],
+        needsChangesPRs: [],
+        changesAddressedPRs: [],
+        waitingOnMaintainerPRs: [],
+        approachingDormant: [],
+        dormantPRs: [],
+        healthyPRs: [],
+        recentlyClosedPRs: [],
+        recentlyMergedPRs: [],
+        shelvedPRs: [],
+        autoUnshelvedPRs: [],
+        summary: {
+            totalActivePRs: 0,
+            totalNeedingAttention: 0,
+            totalMergedAllTime: 0,
+            mergeRate: 0,
+        },
+        ...overrides,
+    };
+}
+// ---------------------------------------------------------------------------
+// ShelvedPRRef
+// ---------------------------------------------------------------------------
+export function makeShelvedPRRef(overrides = {}) {
+    return {
+        number: 1,
+        url: 'https://github.com/owner/repo/pull/1',
+        title: 'Shelved PR',
+        repo: 'owner/repo',
+        daysSinceActivity: 45,
+        status: 'healthy',
+        ...overrides,
+    };
+}
+// ---------------------------------------------------------------------------
+// CapacityAssessment
+// ---------------------------------------------------------------------------
+export function makeCapacityAssessment(overrides = {}) {
+    return {
+        hasCapacity: true,
+        activePRCount: 3,
+        maxActivePRs: 10,
+        shelvedPRCount: 0,
+        criticalIssueCount: 0,
+        reason: 'You have capacity',
+        ...overrides,
+    };
+}
+// ---------------------------------------------------------------------------
+// AgentState (partial — for tests that need a state object)
+// ---------------------------------------------------------------------------
+export function makeAgentState(overrides = {}) {
+    return {
+        version: 2,
+        repoScores: {},
+        config: {
+            setupComplete: false,
+            githubUsername: 'testuser',
+            excludeRepos: [],
+            maxActivePRs: 10,
+            dormantThresholdDays: 30,
+            approachingDormantDays: 25,
+            maxIssueAgeDays: 90,
+            languages: [],
+            labels: [],
+            trustedProjects: [],
+            minRepoScoreThreshold: 4,
+            starredRepos: [],
+        },
+        events: [],
+        lastRunAt: '2025-06-20T00:00:00Z',
+        activeIssues: [],
+        ...overrides,
+    };
+}

package/dist/core/utils.d.ts

@@ -157,6 +157,17 @@ export declare function splitRepo(repoFullName: string): {
     owner: string;
     repo: string;
 };
+/**
+ * Case-insensitive check whether a repo owner matches the given GitHub username.
+ * Used to skip a user's own repos (PRs to your own repos aren't OSS contributions).
+ */
+export declare function isOwnRepo(owner: string, username: string): boolean;
+/**
+ * Read the CLI package version from package.json relative to the running CLI bundle.
+ * Resolves `../package.json` from `process.argv[1]` (the bundle entry point).
+ * Falls back to '0.0.0' if the file is unreadable.
+ */
+export declare function getCLIVersion(): string;
 /**
  * Formats a timestamp as a human-readable relative time string.
  *

package/dist/core/utils.js

@@ -228,6 +228,27 @@ export function splitRepo(repoFullName) {
     const [owner, repo] = repoFullName.split('/');
     return { owner, repo };
 }
+/**
+ * Case-insensitive check whether a repo owner matches the given GitHub username.
+ * Used to skip a user's own repos (PRs to your own repos aren't OSS contributions).
+ */
+export function isOwnRepo(owner, username) {
+    return owner.toLowerCase() === username.toLowerCase();
+}
+/**
+ * Read the CLI package version from package.json relative to the running CLI bundle.
+ * Resolves `../package.json` from `process.argv[1]` (the bundle entry point).
+ * Falls back to '0.0.0' if the file is unreadable.
+ */
+export function getCLIVersion() {
+    try {
+        const pkgPath = path.join(path.dirname(process.argv[1]), '..', 'package.json');
+        return JSON.parse(fs.readFileSync(pkgPath, 'utf-8')).version;
+    }
+    catch {
+        return '0.0.0';
+    }
+}
 /**
  * Formats a timestamp as a human-readable relative time string.
  *

package/dist/formatters/json.d.ts

@@ -108,7 +108,6 @@ export interface CompactRepoGroup {
 }
 export interface DailyOutput {
     digest: DailyDigestCompact;
-    updates: unknown[];
     capacity: CapacityAssessment;
     summary: string;
     briefSummary: string;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oss-autopilot/core",
-  "version": "0.42.0",
+  "version": "0.42.2",
   "description": "CLI and core library for managing open source contributions",
   "type": "module",
   "bin": {