@osovv/vv-opencode 0.35.23 → 0.35.24

package/dist/plugins/workflow/tooling.d.ts

@@ -8,8 +8,10 @@ export type WorkflowToolDefinition<TArgs, TResult> = {
     execute: (args: TArgs, context: WorkflowToolContext, store?: WorkItemStore) => TResult;
 };
 type OpenInputItem = {
-    key: string;
-    title: string;
+    key?: unknown;
+    title?: unknown;
+    mode?: unknown;
+    requiredReviewers?: unknown;
 };
 type OpenArgs = {
     items: OpenInputItem[];

package/dist/plugins/workflow/tooling.js

@@ -1,8 +1,8 @@
 // FILE: src/plugins/workflow/tooling.ts
-// VERSION: 0.1.1
+// VERSION: 0.2.0
 // START_MODULE_CONTRACT
-//   PURPOSE: Provide work-item tooling handlers that wrap workflow state operations with structured protocol-friendly responses.
-//   SCOPE: work_item_open, work_item_list, and work_item_close tool definitions and deterministic execution responses.
+//   PURPOSE: Provide work-item tooling handlers that wrap explicit workflow state operations with structured protocol-friendly responses.
+//   SCOPE: work_item_open, work_item_list, and work_item_close tool definitions, explicit open-contract validation, round metadata serialization, and deterministic execution responses.
 //   DEPENDS: [src/plugins/workflow/state.ts]
 //   LINKS: [M-WORKFLOW-TOOLING]
 //   ROLE: RUNTIME
@@ -12,12 +12,13 @@
 // START_MODULE_MAP
 //   WorkflowToolContext - Minimal execution context required by workflow tools.
 //   WorkflowToolDefinition - Deterministic tool definition shape with execute handler.
-//   createWorkItemOpenTool - Creates work_item_open tool wrapper around openWorkItem.
-//   createWorkItemListTool - Creates work_item_list tool wrapper around listWorkItems.
-//   createWorkItemCloseTool - Creates work_item_close tool wrapper around closeWorkItem.
+//   createWorkItemOpenTool - Creates work_item_open tool wrapper around explicit openWorkItem contract.
+//   createWorkItemListTool - Creates work_item_list tool wrapper with mode and round metadata.
+//   createWorkItemCloseTool - Creates work_item_close tool wrapper with ready_to_close gating responses.
 // END_MODULE_MAP
 //
 // START_CHANGE_SUMMARY
+//   LAST_CHANGE: [v0.2.0 - Required explicit work-item mode and requiredReviewers, and exposed review-round metadata in list/open tool output.]
 //   LAST_CHANGE: [v0.1.1 - Wired work_item_list includeClosed flag into state listing options.]
 //   LAST_CHANGE: [v0.1.0 - Added workflow core tooling handlers for open/list/close operations with structured results and VVOC headers.]
 // END_CHANGE_SUMMARY
@@ -28,8 +29,83 @@ function coerceNonEmptyString(value) {
     const trimmed = value.trim();
     return trimmed || undefined;
 }
+function isWorkItemMode(value) {
+    return value === "implementation" || value === "review_only";
+}
+function isReviewerRole(value) {
+    return value === "spec" || value === "code";
+}
+function canonicalizeReviewers(value) {
+    if (!Array.isArray(value) || value.length === 0)
+        return undefined;
+    if (!value.every(isReviewerRole))
+        return undefined;
+    const unique = new Set(value);
+    if (unique.size !== value.length)
+        return undefined;
+    return [...value].sort((left, right) => {
+        if (left === right)
+            return 0;
+        return left === "spec" ? -1 : 1;
+    });
+}
+function normalizeOpenInputItem(item, sessionId) {
+    const key = coerceNonEmptyString(item.key);
+    const title = coerceNonEmptyString(item.title);
+    if (!key || !title) {
+        return {
+            ok: false,
+            errorCode: "INVALID_INPUT",
+            message: "INVALID_INPUT: key and title must be non-empty strings",
+        };
+    }
+    if (!isWorkItemMode(item.mode)) {
+        return {
+            ok: false,
+            errorCode: "INVALID_INPUT",
+            message: "INVALID_INPUT: mode must be implementation or review_only",
+        };
+    }
+    const requiredReviewers = canonicalizeReviewers(item.requiredReviewers);
+    if (!requiredReviewers) {
+        return {
+            ok: false,
+            errorCode: "INVALID_INPUT",
+            message: "INVALID_INPUT: requiredReviewers must be a non-empty array containing unique spec/code reviewers",
+        };
+    }
+    return {
+        ok: true,
+        input: {
+            sessionId,
+            key,
+            title,
+            mode: item.mode,
+            requiredReviewers,
+        },
+    };
+}
+function serializeWorkItem(record) {
+    return {
+        workItemId: record.workItemId,
+        header: `VVOC_WORK_ITEM_ID: ${record.workItemId}`,
+        key: record.key,
+        title: record.title,
+        mode: record.mode,
+        requiredReviewers: record.requiredReviewers,
+        state: record.state,
+        specReviewCount: record.specReviewCount,
+        codeReviewCount: record.codeReviewCount,
+        reviewRound: getReviewRound(record),
+        currentRound: record.currentRound,
+        completedReviewRoundCount: record.completedReviewRoundCount,
+        createdAt: record.createdAt,
+        updatedAt: record.updatedAt,
+        ...(record.closedAt ? { closedAt: record.closedAt } : {}),
+    };
+}
 // START_CONTRACT: createWorkItemOpenTool
-//   PURPOSE: Build work_item_open handler that supports deterministic batch idempotent open operations.
+//   PURPOSE: Build work_item_open handler that supports deterministic batch idempotent open operations with explicit workflow intent.
 //   INPUTS: { store: WorkItemStore - workflow in-memory store }
 //   OUTPUTS: { WorkflowToolDefinition<OpenArgs, unknown> - executable tool definition }
 //   SIDE_EFFECTS: [Mutates in-memory work-item store through open operations]
@@ -38,24 +114,19 @@ function coerceNonEmptyString(value) {
 export function createWorkItemOpenTool(store) {
     return {
         name: "work_item_open",
-        description: "Open one or more workflow work items idempotently.",
+        description: "Open one or more workflow work items idempotently with explicit mode and requiredReviewers.",
         execute: (args, context, overrideStore) => {
             const inputItems = Array.isArray(args.items) ? args.items : [];
             const results = inputItems.map((item) => {
-                const key = coerceNonEmptyString(item.key);
-                const title = coerceNonEmptyString(item.title);
-                if (!key || !title) {
+                const normalized = normalizeOpenInputItem(item, context.sessionId);
+                if (!normalized.ok) {
                     return {
                         ok: false,
-                        errorCode: "INVALID_INPUT",
-                        message: "INVALID_INPUT: key and title must be non-empty strings",
+                        errorCode: normalized.errorCode,
+                        message: normalized.message,
                     };
                 }
-                const opened = openWorkItem(overrideStore ?? store, {
-                    sessionId: context.sessionId,
-                    key,
-                    title,
-                });
+                const opened = openWorkItem(overrideStore ?? store, normalized.input);
                 if (!opened.ok) {
                     return {
                         ok: false,
@@ -69,7 +140,7 @@ export function createWorkItemOpenTool(store) {
                     reused: opened.reused,
                     workItemId: opened.record.workItemId,
                     header: opened.header,
-                    state: opened.record.state,
+                    ...serializeWorkItem(opened.record),
                 };
             });
             return {
@@ -81,7 +152,7 @@ export function createWorkItemOpenTool(store) {
     };
 }
 // START_CONTRACT: createWorkItemListTool
-//   PURPOSE: Build work_item_list handler that returns current work items and review metadata.
+//   PURPOSE: Build work_item_list handler that returns current work items and explicit review-round metadata.
 //   INPUTS: { store: WorkItemStore - workflow in-memory store }
 //   OUTPUTS: { WorkflowToolDefinition<ListArgs, unknown> - executable tool definition }
 //   SIDE_EFFECTS: [none]
@@ -99,24 +170,13 @@ export function createWorkItemListTool(store) {
                 tool: "work_item_list",
                 sessionId: context.sessionId,
                 includeClosed,
-                items: records.map((record) => ({
-                    workItemId: record.workItemId,
-                    header: `VVOC_WORK_ITEM_ID: ${record.workItemId}`,
-                    key: record.key,
-                    title: record.title,
-                    state: record.state,
-                    specReviewCount: record.specReviewCount,
-                    codeReviewCount: record.codeReviewCount,
-                    reviewRound: getReviewRound(record),
-                    createdAt: record.createdAt,
-                    updatedAt: record.updatedAt,
-                })),
+                items: records.map(serializeWorkItem),
             };
         },
     };
 }
 // START_CONTRACT: createWorkItemCloseTool
-//   PURPOSE: Build work_item_close handler that closes an existing work item.
+//   PURPOSE: Build work_item_close handler that closes a ready_to_close work item.
 //   INPUTS: { store: WorkItemStore - workflow in-memory store }
 //   OUTPUTS: { WorkflowToolDefinition<CloseArgs, unknown> - executable tool definition }
 //   SIDE_EFFECTS: [Mutates in-memory work-item store through close operations]
@@ -125,7 +185,7 @@ export function createWorkItemListTool(store) {
 export function createWorkItemCloseTool(store) {
     return {
         name: "work_item_close",
-        description: "Close a workflow work item by id.",
+        description: "Close a workflow work item by id when it is ready_to_close.",
         execute: (args, context, overrideStore) => {
             const s = overrideStore ?? store;
             const workItemId = coerceNonEmptyString(args.workItemId);

package/dist/plugins/workflow/tooling.js.map

@@ -1 +1 @@
-{"version":3,"file":"tooling.js","sourceRoot":"","sources":["../../../src/plugins/workflow/tooling.ts"],"names":[],"mappings":"AAAA,wCAAwC;AACxC,iBAAiB;AACjB,wBAAwB;AACxB,iIAAiI;AACjI,uHAAuH;AACvH,6CAA6C;AAC7C,gCAAgC;AAChC,kBAAkB;AAClB,sBAAsB;AACtB,sBAAsB;AACtB,EAAE;AACF,mBAAmB;AACnB,gFAAgF;AAChF,uFAAuF;AACvF,sFAAsF;AACtF,uFAAuF;AACvF,yFAAyF;AACzF,iBAAiB;AACjB,EAAE;AACF,uBAAuB;AACvB,gGAAgG;AAChG,0IAA0I;AAC1I,qBAAqB;AAErB,OAAO,EACL,aAAa,EACb,cAAc,EACd,aAAa,EACb,YAAY,GAEb,MAAM,YAAY,CAAC;AA6BpB,SAAS,oBAAoB,CAAC,KAAc;IAC1C,IAAI,OAAO,KAAK,KAAK,QAAQ;QAAE,OAAO,SAAS,CAAC;IAChD,MAAM,OAAO,GAAG,KAAK,CAAC,IAAI,EAAE,CAAC;IAC7B,OAAO,OAAO,IAAI,SAAS,CAAC;AAC9B,CAAC;AAED,yCAAyC;AACzC,wGAAwG;AACxG,gEAAgE;AAChE,wFAAwF;AACxF,8EAA8E;AAC9E,kDAAkD;AAClD,uCAAuC;AACvC,MAAM,UAAU,sBAAsB,CACpC,KAAoB;IAEpB,OAAO;QACL,IAAI,EAAE,gBAAgB;QACtB,WAAW,EAAE,oDAAoD;QACjE,OAAO,EAAE,CAAC,IAAI,EAAE,OAAO,EAAE,aAAa,EAAE,EAAE;YACxC,MAAM,UAAU,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC;YAE/D,MAAM,OAAO,GAAG,UAAU,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE;gBACtC,MAAM,GAAG,GAAG,oBAAoB,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;gBAC3C,MAAM,KAAK,GAAG,oBAAoB,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;gBAC/C,IAAI,CAAC,GAAG,IAAI,CAAC,KAAK,EAAE,CAAC;oBACnB,OAAO;wBACL,EAAE,EAAE,KAAK;wBACT,SAAS,EAAE,eAAe;wBAC1B,OAAO,EAAE,wDAAwD;qBAClE,CAAC;gBACJ,CAAC;gBAED,MAAM,MAAM,GAAG,YAAY,CAAC,aAAa,IAAI,KAAK,EAAE;oBAClD,SAAS,EAAE,OAAO,CAAC,SAAS;oBAC5B,GAAG;oBACH,KAAK;iBACN,CAAC,CAAC;gBAEH,IAAI,CAAC,MAAM,CAAC,EAAE,EAAE,CAAC;oBACf,OAAO;wBACL,EAAE,EAAE,KAAK;wBACT,SAAS,EAAE,MAAM,CAAC,SAAS;wBAC3B,OAAO,EAAE,MAAM,CAAC,OAAO;wBACvB,kBAAkB,EAAE,MAAM,CAAC,kBAAkB;qBAC9C,CAAC;gBACJ,CAAC;gBAED,OAAO;oBACL,EAAE,EAAE,IAAI;oBACR,MAAM,EAAE,MAAM,CAAC,MAAM;oBACrB,UAAU,EAAE,MAAM,CAAC,MAAM,CAAC,UAAU;oBACpC,MAAM,EAAE,MAAM,CAAC,MAAM;oBACrB,KAAK,EAAE,MAAM,CAAC,MAAM,CAAC,KAAK;iBAC3B,CAAC;YACJ,CAAC,CAAC,CAAC;YAEH,OAAO;gBACL,IAAI,EAAE,gBAAgB;gBACtB,SAAS,EAAE,OAAO,CAAC,SAAS;gBAC5B,KAAK,EAAE,OAAO;aACf,CAAC;QACJ,CAAC;KACF,CAAC;AACJ,CAAC;AAED,yCAAyC;AACzC,+FAA+F;AAC/F,gEAAgE;AAChE,wFAAwF;AACxF,yBAAyB;AACzB,kDAAkD;AAClD,uCAAuC;AACvC,MAAM,UAAU,sBAAsB,CACpC,KAAoB;IAEpB,OAAO;QACL,IAAI,EAAE,gBAAgB;QACtB,WAAW,EAAE,mDAAmD;QAChE,OAAO,EAAE,CAAC,IAAI,EAAE,OAAO,EAAE,aAAa,EAAE,EAAE;YACxC,MAAM,CAAC,GAAG,aAAa,IAAI,KAAK,CAAC;YACjC,MAAM,aAAa,GAAG,IAAI,CAAC,aAAa,KAAK,IAAI,CAAC;YAClD,MAAM,OAAO,GAAG,aAAa,CAAC,CAAC,EAAE,OAAO,CAAC,SAAS,EAAE,EAAE,aAAa,EAAE,CAAC,CAAC;YACvE,OAAO;gBACL,IAAI,EAAE,gBAAgB;gBACtB,SAAS,EAAE,OAAO,CAAC,SAAS;gBAC5B,aAAa;gBACb,KAAK,EAAE,OAAO,CAAC,GAAG,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;oBAC9B,UAAU,EAAE,MAAM,CAAC,UAAU;oBAC7B,MAAM,EAAE,sBAAsB,MAAM,CAAC,UAAU,EAAE;oBACjD,GAAG,EAAE,MAAM,CAAC,GAAG;oBACf,KAAK,EAAE,MAAM,CAAC,KAAK;oBACnB,KAAK,EAAE,MAAM,CAAC,KAAK;oBACnB,eAAe,EAAE,MAAM,CAAC,eAAe;oBACvC,eAAe,EAAE,MAAM,CAAC,eAAe;oBACvC,WAAW,EAAE,cAAc,CAAC,MAAM,CAAC;oBACnC,SAAS,EAAE,MAAM,CAAC,SAAS;oBAC3B,SAAS,EAAE,MAAM,CAAC,SAAS;iBAC5B,CAAC,CAAC;aACJ,CAAC;QACJ,CAAC;KACF,CAAC;AACJ,CAAC;AAED,0CAA0C;AAC1C,8EAA8E;AAC9E,gEAAgE;AAChE,yFAAyF;AACzF,+EAA+E;AAC/E,kDAAkD;AAClD,wCAAwC;AACxC,MAAM,UAAU,uBAAuB,CACrC,KAAoB;IAEpB,OAAO;QACL,IAAI,EAAE,iBAAiB;QACvB,WAAW,EAAE,mCAAmC;QAChD,OAAO,EAAE,CAAC,IAAI,EAAE,OAAO,EAAE,aAAa,EAAE,EAAE;YACxC,MAAM,CAAC,GAAG,aAAa,IAAI,KAAK,CAAC;YACjC,MAAM,UAAU,GAAG,oBAAoB,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;YACzD,IAAI,CAAC,UAAU,EAAE,CAAC;gBAChB,OAAO;oBACL,IAAI,EAAE,iBAAiB;oBACvB,SAAS,EAAE,OAAO,CAAC,SAAS;oBAC5B,EAAE,EAAE,KAAK;oBACT,SAAS,EAAE,eAAe;oBAC1B,OAAO,EAAE,sDAAsD;iBAChE,CAAC;YACJ,CAAC;YAED,MAAM,MAAM,GAAG,aAAa,CAAC,CAAC,EAAE,OAAO,CAAC,SAAS,EAAE,UAAU,CAAC,CAAC;YAC/D,IAAI,CAAC,MAAM,CAAC,EAAE,EAAE,CAAC;gBACf,OAAO;oBACL,IAAI,EAAE,iBAAiB;oBACvB,SAAS,EAAE,OAAO,CAAC,SAAS;oBAC5B,EAAE,EAAE,KAAK;oBACT,SAAS,EAAE,MAAM,CAAC,SAAS;oBAC3B,OAAO,EAAE,MAAM,CAAC,OAAO;iBACxB,CAAC;YACJ,CAAC;YAED,OAAO;gBACL,IAAI,EAAE,iBAAiB;gBACvB,SAAS,EAAE,OAAO,CAAC,SAAS;gBAC5B,EAAE,EAAE,IAAI;gBACR,UAAU,EAAE,MAAM,CAAC,MAAM,CAAC,UAAU;gBACpC,MAAM,EAAE,MAAM,CAAC,MAAM;gBACrB,KAAK,EAAE,MAAM,CAAC,MAAM,CAAC,KAAK;gBAC1B,QAAQ,EAAE,MAAM,CAAC,MAAM,CAAC,QAAQ;aACjC,CAAC;QACJ,CAAC;KACF,CAAC;AACJ,CAAC"}
+{"version":3,"file":"tooling.js","sourceRoot":"","sources":["../../../src/plugins/workflow/tooling.ts"],"names":[],"mappings":"AAAA,wCAAwC;AACxC,iBAAiB;AACjB,wBAAwB;AACxB,0IAA0I;AAC1I,yLAAyL;AACzL,6CAA6C;AAC7C,gCAAgC;AAChC,kBAAkB;AAClB,sBAAsB;AACtB,sBAAsB;AACtB,EAAE;AACF,mBAAmB;AACnB,gFAAgF;AAChF,uFAAuF;AACvF,wGAAwG;AACxG,+FAA+F;AAC/F,yGAAyG;AACzG,iBAAiB;AACjB,EAAE;AACF,uBAAuB;AACvB,gJAAgJ;AAChJ,gGAAgG;AAChG,0IAA0I;AAC1I,qBAAqB;AAErB,OAAO,EACL,aAAa,EACb,cAAc,EACd,aAAa,EACb,YAAY,GAMb,MAAM,YAAY,CAAC;AA+BpB,SAAS,oBAAoB,CAAC,KAAc;IAC1C,IAAI,OAAO,KAAK,KAAK,QAAQ;QAAE,OAAO,SAAS,CAAC;IAChD,MAAM,OAAO,GAAG,KAAK,CAAC,IAAI,EAAE,CAAC;IAC7B,OAAO,OAAO,IAAI,SAAS,CAAC;AAC9B,CAAC;AAED,SAAS,cAAc,CAAC,KAAc;IACpC,OAAO,KAAK,KAAK,gBAAgB,IAAI,KAAK,KAAK,aAAa,CAAC;AAC/D,CAAC;AAED,SAAS,cAAc,CAAC,KAAc;IACpC,OAAO,KAAK,KAAK,MAAM,IAAI,KAAK,KAAK,MAAM,CAAC;AAC9C,CAAC;AAED,SAAS,qBAAqB,CAAC,KAAc;IAC3C,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,SAAS,CAAC;IAClE,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,cAAc,CAAC;QAAE,OAAO,SAAS,CAAC;IACnD,MAAM,MAAM,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,CAAC;IAC9B,IAAI,MAAM,CAAC,IAAI,KAAK,KAAK,CAAC,MAAM;QAAE,OAAO,SAAS,CAAC;IACnD,OAAO,CAAC,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE;QACrC,IAAI,IAAI,KAAK,KAAK;YAAE,OAAO,CAAC,CAAC;QAC7B,OAAO,IAAI,KAAK,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;IAClC,CAAC,CAAC,CAAC;AACL,CAAC;AAED,SAAS,sBAAsB,CAC7B,IAAmB,EACnB,SAAiB;IAIjB,MAAM,GAAG,GAAG,oBAAoB,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IAC3C,MAAM,KAAK,GAAG,oBAAoB,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAC/C,IAAI,CAAC,GAAG,IAAI,CAAC,KAAK,EAAE,CAAC;QACnB,OAAO;YACL,EAAE,EAAE,KAAK;YACT,SAAS,EAAE,eAAe;YAC1B,OAAO,EAAE,wDAAwD;SAClE,CAAC;IACJ,CAAC;IACD,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;QAC/B,OAAO;YACL,EAAE,EAAE,KAAK;YACT,SAAS,EAAE,eAAe;YAC1B,OAAO,EAAE,2DAA2D;SACrE,CAAC;IACJ,CAAC;IACD,MAAM,iBAAiB,GAAG,qBAAqB,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC;IACxE,IAAI,CAAC,iBAAiB,EAAE,CAAC;QACvB,OAAO;YACL,EAAE,EAAE,KAAK;YACT,SAAS,EAAE,eAAe;YAC1B,OAAO,EACL,kGAAkG;SACrG,CAAC;IACJ,CAAC;IAED,OAAO;QACL,EAAE,EAAE,IAAI;QACR,KAAK,EAAE;YACL,SAAS;YACT,GAAG;YACH,KAAK;YACL,IAAI,EAAE,IAAI,CAAC,IAAI;YACf,iBAAiB;SAClB;KACF,CAAC;AACJ,CAAC;AAED,SAAS,iBAAiB,CAAC,MAAsB;IAC/C,OAAO;QACL,UAAU,EAAE,MAAM,CAAC,UAAU;QAC7B,MAAM,EAAE,sBAAsB,MAAM,CAAC,UAAU,EAAE;QACjD,GAAG,EAAE,MAAM,CAAC,GAAG;QACf,KAAK,EAAE,MAAM,CAAC,KAAK;QACnB,IAAI,EAAE,MAAM,CAAC,IAAI;QACjB,iBAAiB,EAAE,MAAM,CAAC,iBAAiB;QAC3C,KAAK,EAAE,MAAM,CAAC,KAAK;QACnB,eAAe,EAAE,MAAM,CAAC,eAAe;QACvC,eAAe,EAAE,MAAM,CAAC,eAAe;QACvC,WAAW,EAAE,cAAc,CAAC,MAAM,CAAC;QACnC,YAAY,EAAE,MAAM,CAAC,YAAY;QACjC,yBAAyB,EAAE,MAAM,CAAC,yBAAyB;QAC3D,SAAS,EAAE,MAAM,CAAC,SAAS;QAC3B,SAAS,EAAE,MAAM,CAAC,SAAS;QAC3B,GAAG,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,EAAE,QAAQ,EAAE,MAAM,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;KAC1D,CAAC;AACJ,CAAC;AAED,yCAAyC;AACzC,sIAAsI;AACtI,gEAAgE;AAChE,wFAAwF;AACxF,8EAA8E;AAC9E,kDAAkD;AAClD,uCAAuC;AACvC,MAAM,UAAU,sBAAsB,CACpC,KAAoB;IAEpB,OAAO;QACL,IAAI,EAAE,gBAAgB;QACtB,WAAW,EACT,6FAA6F;QAC/F,OAAO,EAAE,CAAC,IAAI,EAAE,OAAO,EAAE,aAAa,EAAE,EAAE;YACxC,MAAM,UAAU,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC;YAE/D,MAAM,OAAO,GAAG,UAAU,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE;gBACtC,MAAM,UAAU,GAAG,sBAAsB,CAAC,IAAI,EAAE,OAAO,CAAC,SAAS,CAAC,CAAC;gBACnE,IAAI,CAAC,UAAU,CAAC,EAAE,EAAE,CAAC;oBACnB,OAAO;wBACL,EAAE,EAAE,KAAK;wBACT,SAAS,EAAE,UAAU,CAAC,SAAS;wBAC/B,OAAO,EAAE,UAAU,CAAC,OAAO;qBAC5B,CAAC;gBACJ,CAAC;gBAED,MAAM,MAAM,GAAG,YAAY,CAAC,aAAa,IAAI,KAAK,EAAE,UAAU,CAAC,KAAK,CAAC,CAAC;gBACtE,IAAI,CAAC,MAAM,CAAC,EAAE,EAAE,CAAC;oBACf,OAAO;wBACL,EAAE,EAAE,KAAK;wBACT,SAAS,EAAE,MAAM,CAAC,SAAS;wBAC3B,OAAO,EAAE,MAAM,CAAC,OAAO;wBACvB,kBAAkB,EAAE,MAAM,CAAC,kBAAkB;qBAC9C,CAAC;gBACJ,CAAC;gBAED,OAAO;oBACL,EAAE,EAAE,IAAI;oBACR,MAAM,EAAE,MAAM,CAAC,MAAM;oBACrB,UAAU,EAAE,MAAM,CAAC,MAAM,CAAC,UAAU;oBACpC,MAAM,EAAE,MAAM,CAAC,MAAM;oBACrB,GAAG,iBAAiB,CAAC,MAAM,CAAC,MAAM,CAAC;iBACpC,CAAC;YACJ,CAAC,CAAC,CAAC;YAEH,OAAO;gBACL,IAAI,EAAE,gBAAgB;gBACtB,SAAS,EAAE,OAAO,CAAC,SAAS;gBAC5B,KAAK,EAAE,OAAO;aACf,CAAC;QACJ,CAAC;KACF,CAAC;AACJ,CAAC;AAED,yCAAyC;AACzC,8GAA8G;AAC9G,gEAAgE;AAChE,wFAAwF;AACxF,yBAAyB;AACzB,kDAAkD;AAClD,uCAAuC;AACvC,MAAM,UAAU,sBAAsB,CACpC,KAAoB;IAEpB,OAAO;QACL,IAAI,EAAE,gBAAgB;QACtB,WAAW,EAAE,mDAAmD;QAChE,OAAO,EAAE,CAAC,IAAI,EAAE,OAAO,EAAE,aAAa,EAAE,EAAE;YACxC,MAAM,CAAC,GAAG,aAAa,IAAI,KAAK,CAAC;YACjC,MAAM,aAAa,GAAG,IAAI,CAAC,aAAa,KAAK,IAAI,CAAC;YAClD,MAAM,OAAO,GAAG,aAAa,CAAC,CAAC,EAAE,OAAO,CAAC,SAAS,EAAE,EAAE,aAAa,EAAE,CAAC,CAAC;YACvE,OAAO;gBACL,IAAI,EAAE,gBAAgB;gBACtB,SAAS,EAAE,OAAO,CAAC,SAAS;gBAC5B,aAAa;gBACb,KAAK,EAAE,OAAO,CAAC,GAAG,CAAC,iBAAiB,CAAC;aACtC,CAAC;QACJ,CAAC;KACF,CAAC;AACJ,CAAC;AAED,0CAA0C;AAC1C,mFAAmF;AACnF,gEAAgE;AAChE,yFAAyF;AACzF,+EAA+E;AAC/E,kDAAkD;AAClD,wCAAwC;AACxC,MAAM,UAAU,uBAAuB,CACrC,KAAoB;IAEpB,OAAO;QACL,IAAI,EAAE,iBAAiB;QACvB,WAAW,EAAE,6DAA6D;QAC1E,OAAO,EAAE,CAAC,IAAI,EAAE,OAAO,EAAE,aAAa,EAAE,EAAE;YACxC,MAAM,CAAC,GAAG,aAAa,IAAI,KAAK,CAAC;YACjC,MAAM,UAAU,GAAG,oBAAoB,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;YACzD,IAAI,CAAC,UAAU,EAAE,CAAC;gBAChB,OAAO;oBACL,IAAI,EAAE,iBAAiB;oBACvB,SAAS,EAAE,OAAO,CAAC,SAAS;oBAC5B,EAAE,EAAE,KAAK;oBACT,SAAS,EAAE,eAAe;oBAC1B,OAAO,EAAE,sDAAsD;iBAChE,CAAC;YACJ,CAAC;YAED,MAAM,MAAM,GAAG,aAAa,CAAC,CAAC,EAAE,OAAO,CAAC,SAAS,EAAE,UAAU,CAAC,CAAC;YAC/D,IAAI,CAAC,MAAM,CAAC,EAAE,EAAE,CAAC;gBACf,OAAO;oBACL,IAAI,EAAE,iBAAiB;oBACvB,SAAS,EAAE,OAAO,CAAC,SAAS;oBAC5B,EAAE,EAAE,KAAK;oBACT,SAAS,EAAE,MAAM,CAAC,SAAS;oBAC3B,OAAO,EAAE,MAAM,CAAC,OAAO;iBACxB,CAAC;YACJ,CAAC;YAED,OAAO;gBACL,IAAI,EAAE,iBAAiB;gBACvB,SAAS,EAAE,OAAO,CAAC,SAAS;gBAC5B,EAAE,EAAE,IAAI;gBACR,UAAU,EAAE,MAAM,CAAC,MAAM,CAAC,UAAU;gBACpC,MAAM,EAAE,MAAM,CAAC,MAAM;gBACrB,KAAK,EAAE,MAAM,CAAC,MAAM,CAAC,KAAK;gBAC1B,QAAQ,EAAE,MAAM,CAAC,MAAM,CAAC,QAAQ;aACjC,CAAC;QACJ,CAAC;KACF,CAAC;AACJ,CAAC"}

package/dist/plugins/workflow/transitions.d.ts

@@ -1,7 +1,12 @@
-import type { ParsedResultBlock, TrackedAgentName } from "./protocol.js";
-import type { WorkItemState } from "./state.js";
+import type { TrackedAgentName } from "./protocol.js";
+import type { ReviewerAgentName, ReviewerRole, ReviewRound, WorkItemRecord, WorkItemState } from "./state.js";
 export declare const MAX_REVIEW_ROUNDS = 2;
-export declare function getAllowedNextAgent(state: WorkItemState): TrackedAgentName | null;
-export declare function isAllowedTransition(state: WorkItemState, agent: TrackedAgentName): boolean;
-export declare function getNextState(currentState: WorkItemState, result: ParsedResultBlock): WorkItemState;
+export declare function getReviewerRoleForAgent(agent: TrackedAgentName): ReviewerRole | undefined;
+export declare function getReviewerAgentForRole(role: ReviewerRole): ReviewerAgentName;
+export declare function hasNeedsContextResult(round: ReviewRound): boolean;
+export declare function getAllowedNextAgents(record: WorkItemRecord): TrackedAgentName[];
+export declare function isAllowedTransition(record: WorkItemRecord, agent: TrackedAgentName): boolean;
+export declare function getAttemptedImplementationRound(record: WorkItemRecord): number;
+export declare function isRoundSettled(round: ReviewRound): boolean;
+export declare function resolveCompletedRoundState(record: WorkItemRecord, round: ReviewRound): WorkItemState;
 export declare function shouldBlockRound(reviewRound: number): boolean;

package/dist/plugins/workflow/transitions.js

@@ -1,8 +1,8 @@
 // FILE: src/plugins/workflow/transitions.ts
-// VERSION: 0.2.0
+// VERSION: 0.3.0
 // START_MODULE_CONTRACT
-//   PURPOSE: Provide deterministic workflow transition rules, allowed-next-agent resolution, and loop-gate policy checks.
-//   SCOPE: Work-item state transition mapping from tracked results, launch permission checks by state, and review-round limit checks.
+//   PURPOSE: Provide deterministic workflow launch policy, reviewer role mapping, review-round aggregation, and loop-gate policy checks.
+//   SCOPE: Record-aware launch allowance resolution, reviewer agent/role mapping, explicit review-round settlement checks, mode-specific aggregate state resolution, and implementation retry round-limit helpers.
 //   DEPENDS: [src/plugins/workflow/protocol.ts, src/plugins/workflow/state.ts]
 //   LINKS: [M-WORKFLOW-TRANSITIONS]
 //   ROLE: RUNTIME
@@ -10,90 +10,132 @@
 // END_MODULE_CONTRACT
 //
 // START_MODULE_MAP
-//   MAX_REVIEW_ROUNDS - Maximum allowed review rounds before loop-gate block.
-//   getNextState - Computes next work-item state from tracked agent result.
-//   getAllowedNextAgent - Resolves the only allowed tracked agent for a state.
-//   isAllowedTransition - Checks whether launching an agent from current state is allowed.
-//   shouldBlockRound - Enforces loop-gate policy for review rounds.
+//   MAX_REVIEW_ROUNDS - Maximum allowed implementation review rounds before loop-gate block.
+//   getReviewerRoleForAgent - Maps tracked reviewer subagent name to domain reviewer role.
+//   getReviewerAgentForRole - Maps domain reviewer role to tracked reviewer subagent name.
+//   getAllowedNextAgents - Returns tracked agents currently allowed for a work item.
+//   isAllowedTransition - Checks whether launching a tracked agent is valid for a work item.
+//   getAttemptedImplementationRound - Computes the implementation retry round for loop gating.
+//   shouldBlockRound - Enforces loop-gate policy for implementation retry rounds.
+//   hasNeedsContextResult - Checks whether a round already recorded NEEDS_CONTEXT.
+//   isRoundSettled - Checks whether a review round can aggregate to a lifecycle state.
+//   resolveCompletedRoundState - Resolves mode-specific lifecycle state for a settled review round.
 // END_MODULE_MAP
 //
 // START_CHANGE_SUMMARY
+//   LAST_CHANGE: [v0.3.0 - Replaced sequential reviewer transitions with record-aware explicit review-round launch policy and mode-specific collect-all aggregation.]
 //   LAST_CHANGE: [v0.2.0 - Allowed fresh work items to start with reviewer subagents for review-only workflows.]
 //   LAST_CHANGE: [v0.1.0 - Added deterministic state transition policy, launch-allowance resolution, and review round-gate checks.]
 // END_CHANGE_SUMMARY
 export const MAX_REVIEW_ROUNDS = 2;
-// START_CONTRACT: getAllowedNextAgent
-//   PURPOSE: Resolve the single tracked agent allowed to run from the current state.
-//   INPUTS: { state: WorkItemState - current work-item lifecycle state }
-//   OUTPUTS: { TrackedAgentName | null - allowed tracked agent or null when no launch is allowed }
+// START_CONTRACT: getReviewerRoleForAgent
+//   PURPOSE: Map a tracked reviewer subagent to the stored domain reviewer role.
+//   INPUTS: { agent: TrackedAgentName - tracked subagent name }
+//   OUTPUTS: { ReviewerRole | undefined - reviewer role for reviewer subagents, undefined for implementer }
+//   SIDE_EFFECTS: [none]
+//   LINKS: [M-WORKFLOW-TRANSITIONS, M-WORKFLOW-STATE]
+// END_CONTRACT: getReviewerRoleForAgent
+export function getReviewerRoleForAgent(agent) {
+    if (agent === "vv-spec-reviewer")
+        return "spec";
+    if (agent === "vv-code-reviewer")
+        return "code";
+    return undefined;
+}
+// START_CONTRACT: getReviewerAgentForRole
+//   PURPOSE: Map a domain reviewer role to the tracked reviewer subagent that satisfies it.
+//   INPUTS: { role: ReviewerRole - domain reviewer role }
+//   OUTPUTS: { ReviewerAgentName - tracked reviewer subagent }
+//   SIDE_EFFECTS: [none]
+//   LINKS: [M-WORKFLOW-TRANSITIONS, M-WORKFLOW-STATE]
+// END_CONTRACT: getReviewerAgentForRole
+export function getReviewerAgentForRole(role) {
+    return role === "spec" ? "vv-spec-reviewer" : "vv-code-reviewer";
+}
+// START_CONTRACT: hasNeedsContextResult
+//   PURPOSE: Check whether a review round already recorded a NEEDS_CONTEXT result.
+//   INPUTS: { round: ReviewRound - current or completed review round }
+//   OUTPUTS: { boolean - true when any reviewer result is NEEDS_CONTEXT }
 //   SIDE_EFFECTS: [none]
 //   LINKS: [M-WORKFLOW-TRANSITIONS]
-// END_CONTRACT: getAllowedNextAgent
-export function getAllowedNextAgent(state) {
-    if (state === "open" || state === "awaiting_implementer") {
-        return "vv-implementer";
+// END_CONTRACT: hasNeedsContextResult
+export function hasNeedsContextResult(round) {
+    return Object.values(round.results).some((result) => result?.status === "NEEDS_CONTEXT");
+}
+// START_CONTRACT: getAllowedNextAgents
+//   PURPOSE: Resolve all tracked agents currently allowed to launch for a work item.
+//   INPUTS: { record: WorkItemRecord - current work-item record }
+//   OUTPUTS: { TrackedAgentName[] - allowed tracked agents, empty when none are allowed }
+//   SIDE_EFFECTS: [none]
+//   LINKS: [M-WORKFLOW-TRANSITIONS]
+// END_CONTRACT: getAllowedNextAgents
+export function getAllowedNextAgents(record) {
+    if (record.mode === "implementation" &&
+        (record.state === "open" || record.state === "awaiting_implementer")) {
+        return ["vv-implementer"];
     }
-    if (state === "awaiting_spec_review") {
-        return "vv-spec-reviewer";
+    if (record.state !== "awaiting_reviews" ||
+        !record.currentRound ||
+        record.currentRound.status !== "active") {
+        return [];
     }
-    if (state === "awaiting_code_review") {
-        return "vv-code-reviewer";
+    if (hasNeedsContextResult(record.currentRound)) {
+        return [];
     }
-    return null;
+    return record.currentRound.pendingReviewers.map(getReviewerAgentForRole);
 }
 // START_CONTRACT: isAllowedTransition
-//   PURPOSE: Check whether launching the requested tracked agent is valid for current state.
-//   INPUTS: { state: WorkItemState - current state, agent: TrackedAgentName - requested tracked subagent }
-//   OUTPUTS: { boolean - true when launch is allowed }
+//   PURPOSE: Check whether launching a tracked agent is valid for the current work-item record.
+//   INPUTS: { record: WorkItemRecord - current work-item record, agent: TrackedAgentName - requested tracked subagent }
+//   OUTPUTS: { boolean - true when launch is currently allowed }
 //   SIDE_EFFECTS: [none]
 //   LINKS: [M-WORKFLOW-TRANSITIONS]
 // END_CONTRACT: isAllowedTransition
-export function isAllowedTransition(state, agent) {
-    if (state === "open") {
-        return (agent === "vv-implementer" || agent === "vv-spec-reviewer" || agent === "vv-code-reviewer");
-    }
-    return getAllowedNextAgent(state) === agent;
+export function isAllowedTransition(record, agent) {
+    return getAllowedNextAgents(record).includes(agent);
+}
+// START_CONTRACT: getAttemptedImplementationRound
+//   PURPOSE: Compute the implementation retry round that would be entered by launching vv-implementer now.
+//   INPUTS: { record: WorkItemRecord - current work item }
+//   OUTPUTS: { number - attempted implementation round }
+//   SIDE_EFFECTS: [none]
+//   LINKS: [M-WORKFLOW-TRANSITIONS]
+// END_CONTRACT: getAttemptedImplementationRound
+export function getAttemptedImplementationRound(record) {
+    return record.completedReviewRoundCount + 1;
+}
+// START_CONTRACT: isRoundSettled
+//   PURPOSE: Determine whether a review round can aggregate to a lifecycle state.
+//   INPUTS: { round: ReviewRound - current review round }
+//   OUTPUTS: { boolean - true when no in-flight result can still change aggregation timing }
+//   SIDE_EFFECTS: [none]
+//   LINKS: [M-WORKFLOW-TRANSITIONS]
+// END_CONTRACT: isRoundSettled
+export function isRoundSettled(round) {
+    if (round.inFlightReviewers.length > 0)
+        return false;
+    if (hasNeedsContextResult(round))
+        return true;
+    return round.pendingReviewers.length === 0;
 }
-// START_CONTRACT: getNextState
-//   PURPOSE: Compute deterministic next work-item state from a tracked subagent result.
-//   INPUTS: { currentState: WorkItemState - current lifecycle state, result: ParsedResultBlock - validated tracked result block }
+// START_CONTRACT: resolveCompletedRoundState
+//   PURPOSE: Resolve the lifecycle state for a settled review round using mode-specific aggregation rules.
+//   INPUTS: { record: WorkItemRecord - owning work item, round: ReviewRound - settled review round }
 //   OUTPUTS: { WorkItemState - next lifecycle state }
 //   SIDE_EFFECTS: [none]
 //   LINKS: [M-WORKFLOW-TRANSITIONS]
-// END_CONTRACT: getNextState
-export function getNextState(currentState, result) {
-    if (result.agent === "vv-implementer") {
-        if (result.status === "DONE" || result.status === "DONE_WITH_CONCERNS") {
-            return "awaiting_spec_review";
-        }
-        if (result.status === "NEEDS_CONTEXT") {
-            return "needs_context";
-        }
-        return "blocked";
-    }
-    if (result.agent === "vv-spec-reviewer") {
-        if (result.status === "PASS") {
-            return "awaiting_code_review";
-        }
-        if (result.status === "FAIL") {
-            return "awaiting_implementer";
-        }
-        return "needs_context";
-    }
-    if (result.agent === "vv-code-reviewer") {
-        if (result.status === "PASS") {
-            return "ready_to_close";
-        }
-        if (result.status === "FAIL") {
-            return "awaiting_implementer";
-        }
+// END_CONTRACT: resolveCompletedRoundState
+export function resolveCompletedRoundState(record, round) {
+    if (hasNeedsContextResult(round))
         return "needs_context";
-    }
-    return currentState;
+    const allPass = round.requiredReviewers.every((reviewer) => round.results[reviewer]?.status === "PASS");
+    if (allPass)
+        return "ready_to_close";
+    return record.mode === "review_only" ? "ready_to_close" : "awaiting_implementer";
 }
 // START_CONTRACT: shouldBlockRound
-//   PURPOSE: Enforce loop-gate policy by rejecting rounds above MAX_REVIEW_ROUNDS.
-//   INPUTS: { reviewRound: number - computed review round }
+//   PURPOSE: Enforce loop-gate policy by rejecting implementation rounds above MAX_REVIEW_ROUNDS.
+//   INPUTS: { reviewRound: number - attempted implementation round }
 //   OUTPUTS: { boolean - true when launch must be blocked }
 //   SIDE_EFFECTS: [none]
 //   LINKS: [M-WORKFLOW-TRANSITIONS]

package/dist/plugins/workflow/transitions.js.map

@@ -1 +1 @@
-{"version":3,"file":"transitions.js","sourceRoot":"","sources":["../../../src/plugins/workflow/transitions.ts"],"names":[],"mappings":"AAAA,4CAA4C;AAC5C,iBAAiB;AACjB,wBAAwB;AACxB,0HAA0H;AAC1H,sIAAsI;AACtI,+EAA+E;AAC/E,oCAAoC;AACpC,kBAAkB;AAClB,sBAAsB;AACtB,sBAAsB;AACtB,EAAE;AACF,mBAAmB;AACnB,8EAA8E;AAC9E,4EAA4E;AAC5E,+EAA+E;AAC/E,2FAA2F;AAC3F,oEAAoE;AACpE,iBAAiB;AACjB,EAAE;AACF,uBAAuB;AACvB,iHAAiH;AACjH,oIAAoI;AACpI,qBAAqB;AAKrB,MAAM,CAAC,MAAM,iBAAiB,GAAG,CAAC,CAAC;AAEnC,sCAAsC;AACtC,qFAAqF;AACrF,yEAAyE;AACzE,mGAAmG;AACnG,yBAAyB;AACzB,oCAAoC;AACpC,oCAAoC;AACpC,MAAM,UAAU,mBAAmB,CAAC,KAAoB;IACtD,IAAI,KAAK,KAAK,MAAM,IAAI,KAAK,KAAK,sBAAsB,EAAE,CAAC;QACzD,OAAO,gBAAgB,CAAC;IAC1B,CAAC;IACD,IAAI,KAAK,KAAK,sBAAsB,EAAE,CAAC;QACrC,OAAO,kBAAkB,CAAC;IAC5B,CAAC;IACD,IAAI,KAAK,KAAK,sBAAsB,EAAE,CAAC;QACrC,OAAO,kBAAkB,CAAC;IAC5B,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED,sCAAsC;AACtC,6FAA6F;AAC7F,2GAA2G;AAC3G,uDAAuD;AACvD,yBAAyB;AACzB,oCAAoC;AACpC,oCAAoC;AACpC,MAAM,UAAU,mBAAmB,CAAC,KAAoB,EAAE,KAAuB;IAC/E,IAAI,KAAK,KAAK,MAAM,EAAE,CAAC;QACrB,OAAO,CACL,KAAK,KAAK,gBAAgB,IAAI,KAAK,KAAK,kBAAkB,IAAI,KAAK,KAAK,kBAAkB,CAC3F,CAAC;IACJ,CAAC;IACD,OAAO,mBAAmB,CAAC,KAAK,CAAC,KAAK,KAAK,CAAC;AAC9C,CAAC;AAED,+BAA+B;AAC/B,wFAAwF;AACxF,kIAAkI;AAClI,sDAAsD;AACtD,yBAAyB;AACzB,oCAAoC;AACpC,6BAA6B;AAC7B,MAAM,UAAU,YAAY,CAC1B,YAA2B,EAC3B,MAAyB;IAEzB,IAAI,MAAM,CAAC,KAAK,KAAK,gBAAgB,EAAE,CAAC;QACtC,IAAI,MAAM,CAAC,MAAM,KAAK,MAAM,IAAI,MAAM,CAAC,MAAM,KAAK,oBAAoB,EAAE,CAAC;YACvE,OAAO,sBAAsB,CAAC;QAChC,CAAC;QACD,IAAI,MAAM,CAAC,MAAM,KAAK,eAAe,EAAE,CAAC;YACtC,OAAO,eAAe,CAAC;QACzB,CAAC;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,IAAI,MAAM,CAAC,KAAK,KAAK,kBAAkB,EAAE,CAAC;QACxC,IAAI,MAAM,CAAC,MAAM,KAAK,MAAM,EAAE,CAAC;YAC7B,OAAO,sBAAsB,CAAC;QAChC,CAAC;QACD,IAAI,MAAM,CAAC,MAAM,KAAK,MAAM,EAAE,CAAC;YAC7B,OAAO,sBAAsB,CAAC;QAChC,CAAC;QACD,OAAO,eAAe,CAAC;IACzB,CAAC;IAED,IAAI,MAAM,CAAC,KAAK,KAAK,kBAAkB,EAAE,CAAC;QACxC,IAAI,MAAM,CAAC,MAAM,KAAK,MAAM,EAAE,CAAC;YAC7B,OAAO,gBAAgB,CAAC;QAC1B,CAAC;QACD,IAAI,MAAM,CAAC,MAAM,KAAK,MAAM,EAAE,CAAC;YAC7B,OAAO,sBAAsB,CAAC;QAChC,CAAC;QACD,OAAO,eAAe,CAAC;IACzB,CAAC;IAED,OAAO,YAAY,CAAC;AACtB,CAAC;AAED,mCAAmC;AACnC,mFAAmF;AACnF,4DAA4D;AAC5D,4DAA4D;AAC5D,yBAAyB;AACzB,oCAAoC;AACpC,iCAAiC;AACjC,gCAAgC;AAChC,MAAM,UAAU,gBAAgB,CAAC,WAAmB;IAClD,OAAO,WAAW,GAAG,iBAAiB,CAAC;AACzC,CAAC;AACD,8BAA8B"}
+{"version":3,"file":"transitions.js","sourceRoot":"","sources":["../../../src/plugins/workflow/transitions.ts"],"names":[],"mappings":"AAAA,4CAA4C;AAC5C,iBAAiB;AACjB,wBAAwB;AACxB,yIAAyI;AACzI,mNAAmN;AACnN,+EAA+E;AAC/E,oCAAoC;AACpC,kBAAkB;AAClB,sBAAsB;AACtB,sBAAsB;AACtB,EAAE;AACF,mBAAmB;AACnB,6FAA6F;AAC7F,2FAA2F;AAC3F,2FAA2F;AAC3F,qFAAqF;AACrF,6FAA6F;AAC7F,+FAA+F;AAC/F,kFAAkF;AAClF,mFAAmF;AACnF,uFAAuF;AACvF,oGAAoG;AACpG,iBAAiB;AACjB,EAAE;AACF,uBAAuB;AACvB,sKAAsK;AACtK,iHAAiH;AACjH,oIAAoI;AACpI,qBAAqB;AAWrB,MAAM,CAAC,MAAM,iBAAiB,GAAG,CAAC,CAAC;AAEnC,0CAA0C;AAC1C,iFAAiF;AACjF,gEAAgE;AAChE,4GAA4G;AAC5G,yBAAyB;AACzB,sDAAsD;AACtD,wCAAwC;AACxC,MAAM,UAAU,uBAAuB,CAAC,KAAuB;IAC7D,IAAI,KAAK,KAAK,kBAAkB;QAAE,OAAO,MAAM,CAAC;IAChD,IAAI,KAAK,KAAK,kBAAkB;QAAE,OAAO,MAAM,CAAC;IAChD,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,0CAA0C;AAC1C,4FAA4F;AAC5F,0DAA0D;AAC1D,+DAA+D;AAC/D,yBAAyB;AACzB,sDAAsD;AACtD,wCAAwC;AACxC,MAAM,UAAU,uBAAuB,CAAC,IAAkB;IACxD,OAAO,IAAI,KAAK,MAAM,CAAC,CAAC,CAAC,kBAAkB,CAAC,CAAC,CAAC,kBAAkB,CAAC;AACnE,CAAC;AAED,wCAAwC;AACxC,mFAAmF;AACnF,uEAAuE;AACvE,0EAA0E;AAC1E,yBAAyB;AACzB,oCAAoC;AACpC,sCAAsC;AACtC,MAAM,UAAU,qBAAqB,CAAC,KAAkB;IACtD,OAAO,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,eAAe,CAAC,CAAC;AAC3F,CAAC;AAED,uCAAuC;AACvC,qFAAqF;AACrF,kEAAkE;AAClE,0FAA0F;AAC1F,yBAAyB;AACzB,oCAAoC;AACpC,qCAAqC;AACrC,MAAM,UAAU,oBAAoB,CAAC,MAAsB;IACzD,IACE,MAAM,CAAC,IAAI,KAAK,gBAAgB;QAChC,CAAC,MAAM,CAAC,KAAK,KAAK,MAAM,IAAI,MAAM,CAAC,KAAK,KAAK,sBAAsB,CAAC,EACpE,CAAC;QACD,OAAO,CAAC,gBAAgB,CAAC,CAAC;IAC5B,CAAC;IAED,IACE,MAAM,CAAC,KAAK,KAAK,kBAAkB;QACnC,CAAC,MAAM,CAAC,YAAY;QACpB,MAAM,CAAC,YAAY,CAAC,MAAM,KAAK,QAAQ,EACvC,CAAC;QACD,OAAO,EAAE,CAAC;IACZ,CAAC;IAED,IAAI,qBAAqB,CAAC,MAAM,CAAC,YAAY,CAAC,EAAE,CAAC;QAC/C,OAAO,EAAE,CAAC;IACZ,CAAC;IAED,OAAO,MAAM,CAAC,YAAY,CAAC,gBAAgB,CAAC,GAAG,CAAC,uBAAuB,CAAC,CAAC;AAC3E,CAAC;AAED,sCAAsC;AACtC,gGAAgG;AAChG,wHAAwH;AACxH,iEAAiE;AACjE,yBAAyB;AACzB,oCAAoC;AACpC,oCAAoC;AACpC,MAAM,UAAU,mBAAmB,CAAC,MAAsB,EAAE,KAAuB;IACjF,OAAO,oBAAoB,CAAC,MAAM,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC;AACtD,CAAC;AAED,kDAAkD;AAClD,2GAA2G;AAC3G,2DAA2D;AAC3D,yDAAyD;AACzD,yBAAyB;AACzB,oCAAoC;AACpC,gDAAgD;AAChD,MAAM,UAAU,+BAA+B,CAAC,MAAsB;IACpE,OAAO,MAAM,CAAC,yBAAyB,GAAG,CAAC,CAAC;AAC9C,CAAC;AAED,iCAAiC;AACjC,kFAAkF;AAClF,0DAA0D;AAC1D,6FAA6F;AAC7F,yBAAyB;AACzB,oCAAoC;AACpC,+BAA+B;AAC/B,MAAM,UAAU,cAAc,CAAC,KAAkB;IAC/C,IAAI,KAAK,CAAC,iBAAiB,CAAC,MAAM,GAAG,CAAC;QAAE,OAAO,KAAK,CAAC;IACrD,IAAI,qBAAqB,CAAC,KAAK,CAAC;QAAE,OAAO,IAAI,CAAC;IAC9C,OAAO,KAAK,CAAC,gBAAgB,CAAC,MAAM,KAAK,CAAC,CAAC;AAC7C,CAAC;AAED,6CAA6C;AAC7C,2GAA2G;AAC3G,qGAAqG;AACrG,sDAAsD;AACtD,yBAAyB;AACzB,oCAAoC;AACpC,2CAA2C;AAC3C,MAAM,UAAU,0BAA0B,CACxC,MAAsB,EACtB,KAAkB;IAElB,IAAI,qBAAqB,CAAC,KAAK,CAAC;QAAE,OAAO,eAAe,CAAC;IACzD,MAAM,OAAO,GAAG,KAAK,CAAC,iBAAiB,CAAC,KAAK,CAC3C,CAAC,QAAQ,EAAE,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,EAAE,MAAM,KAAK,MAAM,CACzD,CAAC;IACF,IAAI,OAAO;QAAE,OAAO,gBAAgB,CAAC;IACrC,OAAO,MAAM,CAAC,IAAI,KAAK,aAAa,CAAC,CAAC,CAAC,gBAAgB,CAAC,CAAC,CAAC,sBAAsB,CAAC;AACnF,CAAC;AAED,mCAAmC;AACnC,kGAAkG;AAClG,qEAAqE;AACrE,4DAA4D;AAC5D,yBAAyB;AACzB,oCAAoC;AACpC,iCAAiC;AACjC,gCAAgC;AAChC,MAAM,UAAU,gBAAgB,CAAC,WAAmB;IAClD,OAAO,WAAW,GAAG,iBAAiB,CAAC;AACzC,CAAC;AACD,8BAA8B"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@osovv/vv-opencode",
-  "version": "0.35.23",
+  "version": "0.35.24",
   "description": "Portable OpenCode workflow toolkit — 6 plugins, managed agents & skills, a spec-to-code pipeline, security, and the vvoc CLI.",
   "type": "module",
   "main": "./dist/index.js",

package/schemas/vvoc/v3.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json-schema.org/draft/2020-12/schema",
-  "$id": "https://cdn.jsdelivr.net/npm/@osovv/vv-opencode@0.35.23/schemas/vvoc/v3.json",
+  "$id": "https://cdn.jsdelivr.net/npm/@osovv/vv-opencode@0.35.24/schemas/vvoc/v3.json",
   "title": "vvoc config",
   "description": "Canonical vvoc configuration document.",
   "type": "object",

package/templates/agents/vv-controller.md

@@ -28,7 +28,7 @@ Choose the lightest safe route for each request:
 - `docs_only`: documentation-only change. You may edit documentation directly and verify formatting or relevant checks.
 - `investigate_first`: bugs, pasted errors, regressions, failing tests, unclear behavior, or unknown root cause. Delegate to `investigator`, then present findings to the user before taking any implementation action.
 - `change_with_review`: multi-file, ambiguous, risky, public API/config/setup behavior, persistence, security-sensitive, or cross-module changes. Use the tracked implementer/reviewer loop.
-- `review_only`: explicit review request. Decide whether spec review, code review, or both are needed. Open a work item before invoking tracked reviewers. Findings are the final output — do not proceed to fixes without user confirmation.
+- `review_only`: explicit review request. Decide whether spec review, code review, or both are needed. Open one work item with `mode: "review_only"` and `requiredReviewers` containing `"spec"`, `"code"`, or both before invoking tracked reviewers. Findings are the final output — reviewer `FAIL` is a completed review result, not a route to `vv-implementer`; do not proceed to fixes without user confirmation.
 - `large_feature`: broad feature or architectural change. Use `vv-spec` for requirements and design, then `vv-plan` for the implementation plan, ask for user approval after the spec, and do not implement until approval is explicit.
 
 Prefer existing project patterns, libraries, and established repository structure over novel approaches.
@@ -95,7 +95,7 @@ When rerouting, state the current route, the trigger, the next route, and why th
 
 <tracked_implementation_loop>
 - Use this for `change_with_review` and for implementation after an approved `large_feature` architecture.
-- Open a work item with `work_item_open` before launching `vv-implementer`, `vv-spec-reviewer`, or `vv-code-reviewer`.
+- Open a work item with `work_item_open` before launching `vv-implementer`, `vv-spec-reviewer`, or `vv-code-reviewer`; each item must include `key`, `title`, `mode` (`implementation` or `review_only`), and `requiredReviewers` (`spec`, `code`, or both).
 - Put the returned `VVOC_WORK_ITEM_ID: wi-N` header as the first line of each tracked subagent prompt.
 - On implementation retries after review findings, include the normalized finding packet immediately after the required `VVOC_WORK_ITEM_ID` header in the `vv-implementer` assignment so the implementer starts from settled files, lines, scopes, and evidence without rebuilding the packet from scratch.
 - Treat `NEEDS_CONTEXT` and `BLOCKED` as hard stops requiring explicit user action.
@@ -103,7 +103,7 @@ When rerouting, state the current route, the trigger, the next route, and why th
 - Close completed work items with `work_item_close` after implementation, review, and verification are complete.
 - Use work-item identity for all review loops.
 
-Execution order: 1. `vv-implementer` 2. `vv-spec-reviewer` 3. `vv-code-reviewer` 4. verification and close
+Execution order for implementation mode: 1. `vv-implementer` 2. launch all required reviewers (`vv-spec-reviewer` for `spec`, `vv-code-reviewer` for `code`) as needed 3. collect the full review round before deciding whether to retry implementation or close 4. verification and close
 </tracked_implementation_loop>
 
 <hard_stop_handoff>

package/templates/skills/vv-execute/SKILL.md

@@ -174,7 +174,7 @@ Every material finding from plan.xml must be enumerated explicitly in the packet
 </step>
 
 <step name="dispatch">
-Open a work item with work_item_open for this task (e.g. "Implement &lt;component&gt;").
+Open an implementation work item with work_item_open for this task (e.g. `{ key, title, mode: "implementation", requiredReviewers: ["spec", "code"] }`).
 Dispatch vv-implementer with VVOC_WORK_ITEM_ID header + the constructed packet.
 The implementer writes code, runs tests, and returns a status. This controller verifies acceptance criteria and commits after verification passes.
 </step>

package/templates/skills/vv-plan/SKILL.md

@@ -160,7 +160,7 @@ export type CacheStoreOptions = {
 <rule>If the user requests changes, keep the plan status as draft, make the changes, re-run self-review, save the updated plan, and ask for approval again.</rule>
 <rule>After explicit user approval, update the saved plan file so the top-level status is &lt;status&gt;approved&lt;/status&gt;.</rule>
 <rule>After the saved plan status is approved, present the user with two execution options:</rule>
-<option name="workflow">Workflow tracked loop (recommended) — vv-implementer executes tasks, followed by vv-spec-reviewer and vv-code-reviewer. Uses work_item_open/close for each implementation wave.</option>
+<option name="workflow">Workflow tracked loop (recommended) — vv-implementer executes tasks, followed by required reviewers. Uses work_item_open with `mode: "implementation"` and explicit `requiredReviewers`, then work_item_close after the collect-all review round is ready to close.</option>
 <option name="manual">Manual execution — the user or another agent executes tasks step by step following the plan directly.</option>
 <rule>Wait for the user's choice. Do NOT start implementation.</rule>
 </execution_handoff>

package/templates/skills/vv-review/SKILL.md

@@ -14,9 +14,9 @@ You are the vv-review skill. Your job is to route review requests to the appropr
   - Spec review (vv-spec-reviewer): when checking against a spec or acceptance criteria
   - Code review (vv-code-reviewer): when checking for bugs, regressions, maintainability, or security
   - Both: when the request calls for comprehensive review</rule>
-<step>Open a work item with work_item_open before dispatching any tracked reviewer sub-agents.</step>
+<step>Open one review-only work item with work_item_open before dispatching tracked reviewer sub-agents. Use `mode: "review_only"` and set `requiredReviewers` to `['spec']`, `['code']`, or `['spec', 'code']` based on the selected reviewers.</step>
 <step>Put the VVOC_WORK_ITEM_ID header as the first line of each reviewer sub-agent prompt.</step>
-<step>Collect findings from each reviewer. Present them together as the review report.</step>
+<step>Collect findings from each required reviewer. In review_only mode, reviewer FAIL is a completed finding result; it does not route to vv-implementer and must not prevent other required reviewers from completing.</step>
 <step>Findings are the FINAL output. Do NOT proceed to fixes without explicit user confirmation.</step>
 <step>Close the work item with work_item_close after the review is complete.</step>
 </workflow>