@osolmaz/pi-workflows 0.16.0 → 0.16.2

package/src/viewer/tui.ts

@@ -1,6 +1,7 @@
 import type { WorkflowClient } from "../client/client.js";
 import { materializeRunView } from "../client/materialize.js";
 import { sanitizeText } from "../render/ansi.js";
+import { formatDuration } from "../render/format.js";
 import type { JsonValue } from "../state/json.js";
 
 const ALT_SCREEN_ON = "\u001b[?1049h\u001b[?25l";
@@ -17,6 +18,7 @@ export async function runViewer(options: ViewerOptions): Promise<void> {
   let value: JsonValue = options.runId === undefined ? [] : null;
   let selected = 0;
   let scroll = 0;
+  let selectedStepIndex: number | null = null;
   let mode: "runs" | "run" = options.runId === undefined ? "runs" : "run";
   let unsubscribe: (() => Promise<void>) | undefined;
   let runMaterializationGeneration = 0;
@@ -30,6 +32,8 @@ export async function runViewer(options: ViewerOptions): Promise<void> {
       height,
       mode === "runs" ? selected : undefined,
       scroll,
+      new Date(),
+      selectedStepIndex,
     );
     process.stdout.write(`${CLEAR}${lines.join("\n")}`);
   };
@@ -39,6 +43,7 @@ export async function runViewer(options: ViewerOptions): Promise<void> {
     await unsubscribe?.();
     mode = "runs";
     scroll = 0;
+    selectedStepIndex = null;
     unsubscribe = await options.client.watchRuns((event) => {
       value = event.payload;
       selected = Math.min(selected, Math.max(0, arrayLength(value) - 1));
@@ -51,6 +56,7 @@ export async function runViewer(options: ViewerOptions): Promise<void> {
     await unsubscribe?.();
     mode = "run";
     scroll = 0;
+    selectedStepIndex = null;
     unsubscribe = await options.client.watchRun(runId, (event) => {
       const generation = ++runMaterializationGeneration;
       value = event.payload;
@@ -75,6 +81,8 @@ export async function runViewer(options: ViewerOptions): Promise<void> {
     draw();
     if (rawModeSupported) process.stdin.setRawMode(true);
     process.stdin.resume();
+    const redrawTimer = setInterval(draw, 1_000);
+    redrawTimer.unref?.();
     await new Promise<void>((resolve) => {
       const onKey = (data: Buffer) => {
         const key = data.toString("utf8");
@@ -101,6 +109,29 @@ export async function runViewer(options: ViewerOptions): Promise<void> {
           } else if (key === "\u001b[6~") {
             scroll += page;
             draw();
+          } else if (key === "[") {
+            const total = runStepCount(value);
+            if (total > 0) {
+              selectedStepIndex = Math.max(0, (selectedStepIndex ?? total - 1) - 1);
+              scroll = 0;
+              draw();
+            }
+          } else if (key === "]") {
+            const total = runStepCount(value);
+            if (total > 0) {
+              const next = (selectedStepIndex ?? total - 1) + 1;
+              selectedStepIndex = next >= total - 1 ? null : next;
+              scroll = 0;
+              draw();
+            }
+          } else if (key === "\u001b[F" || key === "G" || key === "L") {
+            selectedStepIndex = null;
+            scroll = 0;
+            draw();
+          } else if (key === "\u001b[H" || key === "g") {
+            selectedStepIndex = runStepCount(value) > 0 ? 0 : null;
+            scroll = 0;
+            draw();
           }
         } else if (mode === "runs") {
           if (key === "\u001b[A" || key === "k") {
@@ -117,6 +148,7 @@ export async function runViewer(options: ViewerOptions): Promise<void> {
       };
       process.stdin.on("data", onKey);
     });
+    clearInterval(redrawTimer);
   } finally {
     runMaterializationGeneration += 1;
     await unsubscribe?.();
@@ -132,6 +164,8 @@ export function renderClientView(
   height: number,
   selected: number | undefined,
   scroll: number,
+  now: Date = new Date(),
+  selectedStepIndex: number | null = null,
 ): string[] {
   if (Array.isArray(value)) {
     if (value.length === 0) return ["No workflow runs found."];
@@ -146,12 +180,12 @@ export function renderClientView(
       return truncate(`${prefix}${summary(item)}`, width);
     });
   }
-  const lines = renderRun(value);
+  const lines = renderRun(value, now, selectedStepIndex);
   const start = Math.min(scroll, Math.max(0, lines.length - height));
   return lines.slice(start, start + height).map((line) => truncate(line, width));
 }
 
-function renderRun(value: JsonValue): string[] {
+function renderRun(value: JsonValue, now: Date, selectedStepIndex: number | null): string[] {
   if (!isRecord(value) || value.schema !== "pi-workflows.run-view.v1") {
     return JSON.stringify(value, null, 2).split("\n");
   }
@@ -166,20 +200,46 @@ function renderRun(value: JsonValue): string[] {
         : "unknown";
   const runId = typeof value.runId === "string" ? sanitizeText(value.runId) : "unknown";
   const status = typeof display.status === "string" ? display.status : "unknown";
+  const steps = Array.isArray(state.steps) ? state.steps : [];
+  const selected =
+    steps.length === 0
+      ? -1
+      : Math.min(Math.max(0, selectedStepIndex ?? steps.length - 1), steps.length - 1);
+  const startedAt = typeof manifest.startedAt === "string" ? Date.parse(manifest.startedAt) : NaN;
+  const finishedAt =
+    typeof manifest.finishedAt === "string" ? Date.parse(manifest.finishedAt) : NaN;
+  const elapsed = Number.isFinite(startedAt)
+    ? ` · elapsed ${formatDuration(Math.max(0, (Number.isFinite(finishedAt) ? finishedAt : now.getTime()) - startedAt))}`
+    : "";
+  const position =
+    selectedStepIndex === null || selected < 0 ? "" : ` · step ${selected + 1}/${steps.length}`;
   const lines = [
     `workflow ${workflowName}`,
-    `${statusGlyph(status)} ${sanitizeText(status)} · run ${runId}`,
+    `${statusGlyph(status)} ${sanitizeText(status)} · run ${runId}${elapsed}${position}`,
   ];
   if (typeof display.reason === "string") lines.push(`reason: ${sanitizeText(display.reason)}`);
 
-  const steps = Array.isArray(state.steps) ? state.steps : [];
   if (steps.length > 0) {
     lines.push("", "steps");
-    for (const step of steps) {
+    for (const [index, step] of steps.entries()) {
       if (!isRecord(step)) continue;
       const nodeId = typeof step.nodeId === "string" ? sanitizeText(step.nodeId) : "unknown";
       const outcome = typeof step.outcome === "string" ? step.outcome : "unknown";
-      lines.push(`  ${stepGlyph(outcome)} ${nodeId} · ${sanitizeText(outcome)}`);
+      lines.push(
+        `${index === selected ? ">" : " "} ${stepGlyph(outcome)} ${nodeId} · ${sanitizeText(outcome)}`,
+      );
+    }
+    const inspected = steps[selected];
+    if (isRecord(inspected)) {
+      const nodeId =
+        typeof inspected.nodeId === "string" ? sanitizeText(inspected.nodeId) : "unknown";
+      const output = Object.hasOwn(inspected, "error") ? inspected.error : inspected.output;
+      lines.push("", `step output — ${nodeId}`);
+      lines.push(
+        ...JSON.stringify(output ?? null, null, 2)
+          .split("\n")
+          .map((line) => `  ${sanitizeText(line)}`),
+      );
     }
   }
   if (status === "completed" && Object.hasOwn(state, "finalOutput")) {
@@ -218,6 +278,11 @@ function selectedRunId(value: JsonValue, index: number): string | undefined {
   return isRecord(item) && typeof item.runId === "string" ? item.runId : undefined;
 }
 
+function runStepCount(value: JsonValue): number {
+  if (!isRecord(value) || !isRecord(value.state) || !Array.isArray(value.state.steps)) return 0;
+  return value.state.steps.length;
+}
+
 function arrayLength(value: JsonValue): number {
   return Array.isArray(value) ? value.length : 0;
 }

package/src/workflows/composition.ts

@@ -589,15 +589,10 @@ function wrappedEffect(
   project: (context: WorkflowNodeContext) => WorkflowNodeContext,
 ): WorkflowManagedEffect | undefined {
   if (node.effect === undefined) return undefined;
-  const idempotencyKey = node.effect.idempotencyKey;
   const request = node.effect.request;
   return {
     type: node.effect.type,
     recovery: node.effect.recovery,
-    idempotencyKey:
-      typeof idempotencyKey === "function"
-        ? (context: WorkflowNodeContext) => idempotencyKey(project(context))
-        : idempotencyKey,
     request:
       typeof request === "function"
         ? (context: WorkflowNodeContext) => request(project(context))

package/src/workflows/definition.ts

@@ -191,14 +191,6 @@ function workflowEffect(
   return {
     type: normalized,
     recovery,
-    idempotencyKey: ({ state }: WorkflowNodeContext) => {
-      const nodeId = state.currentNode;
-      if (nodeId === undefined) {
-        throw new Error("Managed effect resolution requires an active workflow node");
-      }
-      const nodeInvocation = state.steps.filter((step) => step.nodeId === nodeId).length + 1;
-      return `${state.runId}:${normalized}:${nodeId}:${nodeInvocation}`;
-    },
     request: ({ input, outputs }: WorkflowNodeContext) => ({ input, outputs }),
   };
 }

package/src/workflows/engine.ts

@@ -1563,17 +1563,15 @@ export class WorkflowEngine {
       );
     }
     const effectType = node.effect.type.trim();
-    const idempotencyKey =
-      typeof node.effect.idempotencyKey === "function"
-        ? await node.effect.idempotencyKey(context)
-        : node.effect.idempotencyKey;
+    const invocation = context.state.steps.filter((step) => step.nodeId === nodeId).length + 1;
+    const idempotencyKey = `${context.state.runId}:${effectType}:${nodeId}:${invocation}`;
     const request =
       typeof node.effect.request === "function"
         ? await node.effect.request(context)
         : node.effect.request;
     /* istanbul ignore if -- definition validation and effect helpers reject empty fields */
-    if (effectType.length === 0 || idempotencyKey.trim().length === 0) {
-      throw new Error("Managed effect type and idempotency key must be nonempty text");
+    if (effectType.length === 0) {
+      throw new Error("Managed effect type must be nonempty text");
     }
     canonicalJson(request);
     const reservation = await this.store.reserveEffect({

package/src/workflows/human-decision.ts

@@ -468,6 +468,14 @@ export class HumanDecisionStore {
     channel: string,
     value: HumanDecisionDeliveryRecord,
   ): Promise<"created" | "adopted"> {
+    return this.recordDeliverySync(request, channel, value);
+  }
+
+  recordDeliverySync(
+    request: HumanDecisionRequest | HumanDecisionChannelRequest,
+    channel: string,
+    value: HumanDecisionDeliveryRecord,
+  ): "created" | "adopted" {
     return this.recordChannelMessage(request.decisionId, channel, "delivery", value);
   }
 
@@ -570,6 +578,14 @@ export class HumanDecisionStore {
     channel: string,
     value: HumanDecisionSettlementRecord,
   ): Promise<"created" | "adopted"> {
+    return this.recordSettlementSync(decisionId, channel, value);
+  }
+
+  recordSettlementSync(
+    decisionId: string,
+    channel: string,
+    value: HumanDecisionSettlementRecord,
+  ): "created" | "adopted" {
     return this.recordChannelMessage(decisionId, channel, "settlement", value);
   }
 
@@ -1066,7 +1082,7 @@ export class HumanDecisionStore {
     purpose: "delivery" | "settlement",
     value: T,
   ): "created" | "adopted" {
-    const safeChannel = requireSimpleId(channel, "Human decision channel");
+    const safeChannel = requireChannelId(channel, "Human decision channel");
     assertId(value.attemptId, `${purpose} attempt id`);
     return this.state.transaction(() => {
       if (this.readRequestRow(decisionId) === undefined) {
@@ -1120,7 +1136,7 @@ export class HumanDecisionStore {
     channel: string,
     purpose: "delivery" | "settlement",
   ): T[] {
-    const channelId = channelIdFor(requireSimpleId(channel, "Human decision channel"));
+    const channelId = channelIdFor(requireChannelId(channel, "Human decision channel"));
     const rows = this.state.connection
       .prepare(
         `SELECT content_hash AS contentHash

package/src/workflows/index.ts

@@ -92,7 +92,6 @@ export {
   type WorkflowFollowUpQueueRecord,
   type WorkflowFollowUpRecord,
   type WorkflowFollowUpState,
-  type WorkflowPresentationState,
   type WorkflowQueueFollowUpRequest,
   type WorkflowRemoveFollowUpRequest,
   type WorkflowSettingsChangeContext,

package/src/workflows/schema.ts

@@ -113,12 +113,6 @@ export function assertValidActionNode(node: ActionNodeDefinition, nodeId = "acti
   if (node.effect.recovery !== "idempotent" && node.effect.recovery !== "manual") {
     fail(`node ${nodeId} effect recovery must be idempotent or manual`);
   }
-  if (
-    typeof node.effect.idempotencyKey !== "string" &&
-    typeof node.effect.idempotencyKey !== "function"
-  ) {
-    fail(`node ${nodeId} effect idempotencyKey must be text or a function`);
-  }
   if (!("request" in node.effect)) {
     fail(`node ${nodeId} effect requires request data or a request function`);
   }

package/src/workflows/settings.ts

@@ -101,20 +101,7 @@ export type WorkflowSettingsChangeResult = {
   adopted: boolean;
 };
 
-export type WorkflowFollowUpState =
-  | "queued"
-  | "pending_presentation"
-  | "ready"
-  | "sent"
-  | "removed"
-  | "cancelled";
-
-export type WorkflowPresentationState =
-  | "none"
-  | "not-needed"
-  | "pending"
-  | "settled"
-  | "unavailable";
+export type WorkflowFollowUpState = "queued" | "removed" | "cancelled";
 
 export type WorkflowFollowUpRecord = {
   followUpId: string;
@@ -126,20 +113,14 @@ export type WorkflowFollowUpRecord = {
   source: string;
   prompt: string;
   state: WorkflowFollowUpState;
-  sessionEntryId?: string;
   reason?: string;
   createdAt: string;
   updatedAt: string;
-  sentAt?: string;
 };
 
 export type WorkflowFollowUpQueueRecord = {
   runId: string;
   originSessionId?: string;
-  presentationState: WorkflowPresentationState;
-  presentationEntryId?: string;
-  presentationAssistantEntryId?: string;
-  presentationReason?: string;
   followUps: WorkflowFollowUpRecord[];
 };