@osolmaz/pi-workflows 0.14.0 → 0.15.0

package/examples/workflows/command-batch.workflow.ts

@@ -2,6 +2,7 @@ import {
   action,
   compute,
   defineWorkflow,
+  manualEffect,
   runCommandBatch,
   type CommandBatchRequest,
 } from "@osolmaz/pi-workflows";
@@ -40,6 +41,7 @@ export default defineWorkflow({
         }) satisfies CommandBatchRequest,
     }),
     run: action({
+      effect: manualEffect("example.command-batch.run"),
       run: async (context) =>
         await runCommandBatch(context.outputs.prepare as CommandBatchRequest, {
           signal: context.signal,

package/examples/workflows/shell.workflow.ts

@@ -1,4 +1,4 @@
-import { compute, defineWorkflow, shell } from "@osolmaz/pi-workflows";
+import { compute, defineWorkflow, manualEffect, shell } from "@osolmaz/pi-workflows";
 
 type ShellInput = {
   text?: string;
@@ -10,6 +10,7 @@ export default defineWorkflow({
   startAt: "echo_text",
   nodes: {
     echo_text: shell({
+      effect: manualEffect("example.shell.echo-text"),
       exec: ({ input }) => ({
         command: "printf",
         args: ["%s", (input as ShellInput).text ?? "hello from pi-workflows"],

package/herdr-plugin.toml

@@ -1,6 +1,6 @@
 id = "osolmaz.pi-workflows"
 name = "pi-workflows"
-version = "0.14.0"
+version = "0.15.0"
 min_herdr_version = "0.7.0"
 description = "Open the active pi-workflows run in piw from a managed Herdr pane."
 platforms = ["linux", "macos"]

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@osolmaz/pi-workflows",
-  "version": "0.14.0",
+  "version": "0.15.0",
   "description": "Workflow and controller runtime with a live terminal viewer for the pi coding agent",
   "keywords": [
     "pi-package"

package/src/builtins/autoimplement.workflow.ts

@@ -11,6 +11,7 @@ import {
   defineWorkflow,
   includeWorkflow,
   includedResult,
+  manualEffect,
 } from "../workflows/definition.js";
 import { digest } from "../workflows/human-decision.js";
 import { allowSettingsPath, workflowSettings } from "../workflows/settings.js";
@@ -1768,6 +1769,7 @@ export const autoimplementWorkflow = defineWorkflow({
       run: selectReviewCommands,
     }),
     runReview: action({
+      effect: manualEffect("pi-workflows.autoimplement.review"),
       statusDetail: "running pi-reviewer commands",
       timeoutMs: (context) => {
         const selected = latestOutput<ReviewCommandSelection>(context, ["selectReviewCommands"]);
@@ -1884,6 +1886,7 @@ export const autoimplementWorkflow = defineWorkflow({
       validate: parseCiInspectionForPublished,
     }),
     trackCi: action({
+      effect: manualEffect("pi-workflows.autoimplement.track-ci"),
       statusDetail: "tracking pending CI commands",
       timeoutMs: (context) => {
         const inspected = latestOutput<CiInspectionBatch>(context, ["inspectCi"]);

package/src/builtins/change-verification.workflow.ts

@@ -11,7 +11,7 @@ import {
   type CommandBatchItemResult,
   type CommandBatchResult,
 } from "../workflows/command-batch.js";
-import { action, agent, compute, defineWorkflow } from "../workflows/definition.js";
+import { action, agent, compute, defineWorkflow, manualEffect } from "../workflows/definition.js";
 import type { WorkflowActionContext, WorkflowNodeContext } from "../workflows/types.js";
 import { validateVerificationCommandSafety } from "./autoimplement-command-batches.js";
 import {
@@ -1027,16 +1027,21 @@ export const changeVerificationWorkflow = defineWorkflow({
       validate: parsePlannedChecks,
     }),
     runCandidate: action({
+      effect: manualEffect("pi-workflows.change-verification.candidate"),
       run: async (context) =>
         await runCandidate(context, checksForContext(context as unknown as WorkflowNodeContext)),
     }),
     runBase: action({
+      effect: manualEffect("pi-workflows.change-verification.base"),
       run: async (context) =>
         await runBase(context, checksForContext(context as unknown as WorkflowNodeContext)),
     }),
     classify: compute({ run: latestClassification }),
     repairGuard: compute({ run: repairGuard }),
-    mechanicalRepair: action({ run: runMechanicalRepair }),
+    mechanicalRepair: action({
+      effect: manualEffect("pi-workflows.change-verification.mechanical-repair"),
+      run: runMechanicalRepair,
+    }),
     semanticRepair: agent({
       prompt: (context) => {
         const input = context.input as ChangeVerificationInput;

package/src/builtins/metadata.ts

@@ -0,0 +1,9 @@
+export const BUILTIN_WORKFLOW_METADATA = [
+  { id: "plain-summary", revision: "3" },
+  { id: "autoplan", revision: "6" },
+  { id: "autodoc", revision: "2" },
+  { id: "autoimplement", revision: "11" },
+  { id: "plan-approval", revision: "4" },
+  { id: "sanity-check", revision: "6" },
+  { id: "monitor", revision: "11" },
+] as const;

package/src/builtins/monitor.workflow.ts

@@ -3,6 +3,7 @@ import {
   agent,
   compute,
   defineWorkflow,
+  idempotentEffect,
   includeWorkflow,
   includedResult,
   notify,
@@ -855,6 +856,7 @@ const monitorWorkflow: WorkflowDefinition = defineWorkflow({
     guard: compute({ run: guardObservation }),
     estimate: compute({ run: ({ outputs }) => estimateTracks(outputs) }),
     publish_progress: action({
+      effect: idempotentEffect("pi-workflows.monitor.publish-progress"),
       statusDetail: "publishing monitor progress",
       run: async ({ outputs, publishUpdate, signal }) => {
         const observation = currentObservation(outputs);
@@ -944,6 +946,7 @@ const monitorWorkflow: WorkflowDefinition = defineWorkflow({
       },
     }),
     schedule: action({
+      effect: idempotentEffect("pi-workflows.monitor.schedule"),
       statusDetail: "scheduling next monitor observation",
       run: async ({ outputs, publishUpdate }) => {
         const config = configFrom(outputs);
@@ -965,6 +968,7 @@ const monitorWorkflow: WorkflowDefinition = defineWorkflow({
       },
     }),
     sleep: shell({
+      effect: idempotentEffect("pi-workflows.monitor.sleep"),
       statusDetail: "waiting for next monitor observation",
       timeoutMs: MAX_INTERVAL_MINUTES * 60_000 + NODE_TIMEOUT_MARGIN_MS,
       exec: ({ outputs }) => {

package/src/builtins/sanity-check.workflow.ts

@@ -10,6 +10,7 @@ import {
   compute,
   defineWorkflow,
   includeWorkflow,
+  manualEffect,
 } from "../workflows/definition.js";
 import { extractJsonValue } from "../workflows/json.js";
 import type { WorkflowActionContext, WorkflowProgressStatus } from "../workflows/types.js";
@@ -780,6 +781,7 @@ export const sanityCheckWorkflow = defineWorkflow({
       run: ({ input }) => input as SanityCheckConfig,
     }),
     collectEvidence: action({
+      effect: manualEffect("pi-workflows.sanity-check.collect-evidence"),
       statusDetail: "collecting contribution evidence",
       timeoutMs: 2 * 60_000,
       run: async ({ outputs, signal }) =>
@@ -790,11 +792,13 @@ export const sanityCheckWorkflow = defineWorkflow({
         ),
     }),
     review: action({
+      effect: manualEffect("pi-workflows.sanity-check.review"),
       statusDetail: "reviewing contribution",
       timeoutMs: REVIEW_TIMEOUT_MS,
       run: runReviews,
     }),
     verify: action({
+      effect: manualEffect("pi-workflows.sanity-check.verify"),
       statusDetail: "verifying findings",
       timeoutMs: REVIEW_TIMEOUT_MS,
       run: verifyReviews,

package/src/builtins/workspace-preparation.workflow.ts

@@ -1,7 +1,7 @@
 import { execFile } from "node:child_process";
 import path from "node:path";
 import { promisify } from "node:util";
-import { action, agent, compute, defineWorkflow } from "../workflows/definition.js";
+import { action, agent, compute, defineWorkflow, manualEffect } from "../workflows/definition.js";
 
 const execFileAsync = promisify(execFile);
 
@@ -625,6 +625,7 @@ export const workspacePreparationWorkflow = defineWorkflow({
   },
   nodes: {
     inspect: action({
+      effect: manualEffect("pi-workflows.workspace-preparation.inspect"),
       run: async ({ input }) => await inspectWorkspace(input as WorkspacePreparationInput),
     }),
     propose: agent({
@@ -638,6 +639,7 @@ export const workspacePreparationWorkflow = defineWorkflow({
       validate: parseProposal,
     }),
     apply: action({
+      effect: manualEffect("pi-workflows.workspace-preparation.apply"),
       run: async ({ input, outputs }) =>
         await prepareWorkspace(
           input as WorkspacePreparationInput,

package/src/controllers/index.ts

@@ -45,11 +45,6 @@ export {
   loadDiscoveredControllers,
   type DiscoveredController,
 } from "./loader.js";
-export {
-  WorkflowEngineScheduler,
-  type ResolvedChildWorkflow,
-  type WorkflowEngineSchedulerOptions,
-} from "./workflow-engine-scheduler.js";
 export {
   ControllerWorkflowCoordinator,
   type ControllerWorkflowControlRequest,