@osimatic/helpers-js 1.5.31 → 1.5.33

package/location.js

@@ -24,7 +24,7 @@ class Country {
 		return [...countryCode.toUpperCase()].map(c => String.fromCodePoint(0x1F1E6 - 65 + c.charCodeAt(0))).join('');
 	}
 
-	static fillSelect(select, defaultValue=null, showFlags=false, locale='fr-FR', countriesList=null, addNoneValue=false, noneLabel='- Aucun -') {
+	static fillSelect(select, defaultValue=null, locale='fr-FR', showFlags=false, countriesList=null, addNoneValue=false, noneLabel='- Aucun -') {
 		select = toEl(select);
 		if (!select) {
 			return;
@@ -54,7 +54,7 @@ class Country {
 	}
 
 	static fillSelectWithFlags(select, defaultValue=null, locale='fr-FR', countriesList=null, addNoneValue=false, noneLabel='- Aucun -') {
-		return Country.fillSelect(select, defaultValue, true, locale, countriesList, addNoneValue, noneLabel);
+		return Country.fillSelect(select, defaultValue, locale, true, countriesList, addNoneValue, noneLabel);
 	}
 
 	static getCountryName(countryCode, locale='fr-FR') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@osimatic/helpers-js",
-  "version": "1.5.31",
+  "version": "1.5.33",
   "main": "main.js",
   "scripts": {
     "test": "jest",

package/tests/location.test.js

@@ -123,6 +123,74 @@ describe('Country', () => {
 			expect(typeof result).toBe('object');
 		});
 	});
+
+	describe('fillSelect', () => {
+		function makeSelect() {
+			const options = [];
+			return {
+				children: options,
+				value: null,
+				insertAdjacentHTML(position, html) { options.push(html); },
+			};
+		}
+
+		test('should populate with all countries in given locale', () => {
+			const select = makeSelect();
+			Country.fillSelect(select, null, 'fr-FR');
+			expect(select.children.length).toBeGreaterThan(0);
+			expect(select.children.some(h => h.includes('value="FR"'))).toBe(true);
+			expect(select.children.some(h => h.includes('France'))).toBe(true);
+		});
+
+		test('should restrict to provided countriesList', () => {
+			const select = makeSelect();
+			Country.fillSelect(select, null, 'fr-FR', false, ['FR', 'DE', 'US']);
+			expect(select.children).toHaveLength(3);
+			expect(select.children.some(h => h.includes('value="FR"'))).toBe(true);
+			expect(select.children.some(h => h.includes('value="DE"'))).toBe(true);
+		});
+
+		test('should add none option when addNoneValue is true', () => {
+			const select = makeSelect();
+			Country.fillSelect(select, null, 'fr-FR', false, ['FR'], true, '-- Aucun --');
+			expect(select.children[0]).toContain('value=""');
+			expect(select.children[0]).toContain('-- Aucun --');
+			expect(select.children).toHaveLength(2);
+		});
+
+		test('should add data-content with flag-icons when showFlags is true', () => {
+			const select = makeSelect();
+			Country.fillSelect(select, null, 'fr-FR', true, ['FR']);
+			expect(select.children[0]).toContain('data-content=');
+			expect(select.children[0]).toContain('fi fi-fr');
+		});
+
+		test('should not add options if select already has children', () => {
+			const select = makeSelect();
+			select.children.push('<option value="FR">France</option>');
+			Country.fillSelect(select, null, 'fr-FR');
+			expect(select.children).toHaveLength(1);
+		});
+	});
+
+	describe('fillSelectWithFlags', () => {
+		function makeSelect() {
+			const options = [];
+			return {
+				children: options,
+				value: null,
+				insertAdjacentHTML(position, html) { options.push(html); },
+			};
+		}
+
+		test('should add data-content with flag-icons', () => {
+			const select = makeSelect();
+			Country.fillSelectWithFlags(select, null, 'fr-FR', ['FR', 'US']);
+			expect(select.children).toHaveLength(2);
+			expect(select.children[0]).toContain('fi fi-fr');
+			expect(select.children[1]).toContain('fi fi-us');
+		});
+	});
 });
 
 describe('Locale', () => {