@osimatic/helpers-js 1.0.26 → 1.0.29

package/changelog.txt

@@ -33,4 +33,8 @@ majSelectPeriode() / majSelectCompare() -> updatePeriodSelect(form)
 
 let URL_REFRESH = ... -> HTTPRequest.setRefreshTokenUrl(URL_REFRESH)
 let _httpHeaders = {...} -> HTTPRequest.setHeader(key, value);
-let httpHeaders = {...} -> HTTPRequest.setHeader(key, value);
+let httpHeaders = {...} -> HTTPRequest.setHeader(key, value);
+remplacer l'utilisation des variables httpHeaders / _httpHeaders par HTTPRequest.getHeaders()
+
+FlashMessage.displayRequestFailure(status, exception, modal) -> FlashMessage.displayError(labelErrorOccured, modal)
+FormHelper.logRequestFailure(status, exception) -> HTTPRequest.logJqueryRequestFailure(jqxhr, status, exception) (le log de l'erreur est devenu inutile car fait de base dans la classe HTTPRequest)

package/flash_message.js

@@ -1,9 +1,4 @@
 class FlashMessage {
-	static displayRequestFailure(status, exception, modal) {
-		console.log('request failure. Status: ', status, ' Exception: ', exception);
-		this.display('danger', typeof labelErrorOccured != 'undefined' ? labelErrorOccured :  "Une erreur s'est produite.", false, modal);
-	}
-
 	static displaySuccess(message, reload, modal) {
 		this.display('success', message, reload, modal);
 	}
@@ -32,6 +27,13 @@ class FlashMessage {
 			document.location.reload();
 		}
 	}
+
+	/** @deprecated **/
+	static displayRequestFailure(status, exception, modal) {
+		console.log('request failure. Status: ', status, ' Exception: ', exception);
+		this.display('danger', typeof labelErrorOccured != 'undefined' ? labelErrorOccured :  "Une erreur s'est produite.", false, modal);
+	}
+
 }
 
 module.exports = { FlashMessage };

package/form_helper.js

@@ -1,8 +1,4 @@
 class FormHelper {
-	static logRequestFailure(status, exception) {
-		console.log('request failure. Status: '+status+' ; Exception: '+exception);
-	}
-
 	static resetSelectOption(form, selectName) {
 		form.find('select[name="'+selectName+'"] option').prop('disabled', false).prop('selected', false);
 	}
@@ -257,6 +253,14 @@ class FormHelper {
 
 		errorsParentDiv.prepend(errorDiv);
 	}
+
+
+
+	/** @deprecated **/
+	static logRequestFailure(status, exception) {
+		console.log('request failure. Status: '+status+' ; Exception: '+exception);
+	}
+
 }
 
 module.exports = { FormHelper };

package/network.js

@@ -30,33 +30,55 @@ class HTTPRequest {
 		return httpHeaders;
 	}
 
-	static async get(url, data, successCallback, errorCallback) {
+	static formatQueryString(data) {
 		if (data == null) {
-			data = '';
+			return '';
 		}
-		else if (typeof data == 'object') {
+		if (typeof data == 'object') {
 			data = UrlAndQueryString.buildQuery(data);
 		}
 		if (data !== '' && data.substring(0, 1) !== '&') {
 			data = '&' + data;
 		}
+		return data;
+	}
+
+	static formatFormData(data) {
+		if (!(data instanceof FormData)) {
+			let formData = new FormData();
+			Object.entries(data).forEach(([key, value]) => formData.append(key, value));
+			return formData;
+		}
+		return data;
+	}
+
+	static logRequestFailure(response, json) {
+		console.error('Request failure. Status: '+response.statusText+' ; HTTP Code : '+response.status, json);
+	}
+
+	static logJqueryRequestFailure(jqxhr, status, errorThrown) {
+		console.error('Request failure. Status: '+status+' ; HTTP Code: '+jqxhr.responseJSON.code+(null!=errorThrown && ''!==errorThrown ? ' ; Error message: '+errorThrown : ''), jqxhr.responseJSON);
+	}
+
+	static async get(url, data, successCallback, errorCallback) {
+		url += (!url.includes('?') ? '?' : '') + this.formatQueryString(data);
+		data = null;
 
 		if (window.fetch) {
-			let requestInit = {
+			const response = await fetch(url, {
 				method: 'GET',
 				headers: HTTPRequest.getHeaders(),
 				mode: 'cors',
 				cache: 'no-cache'
-			}
+			});
 
 			let jsonData = {};
-			const response = await fetch(url + (!url.includes('?') ? '?' : '') + data, requestInit);
 			try {
 				jsonData = await response.json();
 				//console.log(url, jsonData);
 				//console.log(response.status, response.statusText, jsonData['error']);
 
-				if (response.status == 401 && (response.statusText == "Expired JWT Token" || typeof jsonData['error'] != 'undefined' && jsonData['error'] === 'expired_token')) {
+				if (response.status == 401 && (response.statusText === "Expired JWT Token" || typeof jsonData['error'] != 'undefined' && jsonData['error'] === 'expired_token')) {
 					HTTPRequest.refreshToken(() => HTTPRequest.get(url, data, successCallback, errorCallback));
 					return;
 				}
@@ -67,11 +89,17 @@ class HTTPRequest {
 				}
 			}
 			catch (e) {
-				console.log(e);
-				errorCallback(response, response.status, e);
+				console.error(e);
+				if (typeof errorCallback != 'undefined' && errorCallback != null) {
+					errorCallback(response, response.status, e);
+				}
 				return;
 			}
-			errorCallback(response, response.status, null, jsonData);
+
+			HTTPRequest.logRequestFailure(response, jsonData);
+			if (typeof errorCallback != 'undefined' && errorCallback != null) {
+				errorCallback(response, response.status, null, jsonData);
+			}
 			return;
 		}
 
@@ -79,32 +107,32 @@ class HTTPRequest {
 		console.error('fetch\'s polyfill used');
 		$.ajax({
 			type: 'GET',
-			url: url + (!url.includes('?') ? '?' : '') + data,
+			url: url,
 			headers: HTTPRequest.getHeaders(),
 			dataType: 'json',
 			cache: false,
 			success: (data) => successCallback(data),
-			error: (jqxhr, status, exception) => {
-				if (typeof jqxhr.responseJSON != 'undefined' && jqxhr.responseJSON.code == 401 && jqxhr.responseJSON.message == "Expired JWT Token") {
+			error: (jqxhr, status, errorThrown) => {
+				if (typeof jqxhr.responseJSON != 'undefined' && jqxhr.responseJSON.code == 401 && (jqxhr.responseJSON.message === "Expired JWT Token"  || (typeof jqxhr.responseJSON['error'] != 'undefined' && jqxhr.responseJSON['error'] === 'expired_token' ))) {
 					HTTPRequest.refreshToken(() => HTTPRequest.get(url, data, successCallback, errorCallback));
-				} else {
-					errorCallback(jqxhr, status, exception);
+					return;
+				}
+
+				HTTPRequest.logJqueryRequestFailure(jqxhr, status, errorThrown);
+				if (typeof errorCallback != 'undefined' && errorCallback != null) {
+					errorCallback(jqxhr, status, errorThrown);
 				}
 			}
 		});
 	}
 
-	static async download(url, data, errorCallback, completeCallback) {
-		if (data == null) {
-			data = '';
-		}
-		else if (typeof data == 'object') {
-			data = UrlAndQueryString.buildQuery(data);
-		}
-		if (data !== '' && data.substring(0, 1) !== '&') {
-			data = '&' + data;
-		}
+	static async download(url, data, errorCallback, completeCallback, method) {
+		method = typeof method == 'undefined' || null == method ? 'GET' : method;
 
+		if ('POST' !== method) {
+			url += (!url.includes('?') ? '?' : '') + this.formatQueryString(data);
+			data = null;
+		}
 
 		if (window.fetch) {
 			let requestInit = {
@@ -114,26 +142,34 @@ class HTTPRequest {
 				cache: 'no-cache'
 			}
 
-			const response = await fetch(url + (!url.includes('?') ? '?' : '') + data, requestInit);
+			if ('POST' === method) {
+				requestInit['method'] = 'POST';
+				requestInit['body'] = this.formatFormData(data);
+			}
+
+			const response = await fetch(url, requestInit);
 			try {
 				const blobData = await response.blob();
 				/*console.log(url);
 				console.log(blobData);*/
 
-				if (response.status == 401 && response.statusText == "Expired JWT Token") {
-					HTTPRequest.refreshToken(() => HTTPRequest.download(url, data, errorCallback, completeCallback));
+				if (response.status == 401 && response.statusText === "Expired JWT Token") {
+					HTTPRequest.refreshToken(() => HTTPRequest.download(url, data, errorCallback, completeCallback, method));
 					return;
 				}
 
 				if (response.ok) {
 					File.download(blobData, response.headers.get('content-type'), response.headers.get('content-disposition'));
 				}
-				else if (typeof errorCallback != 'undefined' && errorCallback != null) {
-					errorCallback(response, response.status, null);
+				else {
+					HTTPRequest.logRequestFailure(response, null);
+					if (typeof errorCallback != 'undefined' && errorCallback != null) {
+						errorCallback(response, response.status, null);
+					}
 				}
 			}
 			catch (e) {
-				console.log(e);
+				console.error(e);
 				if (typeof errorCallback != 'undefined' && errorCallback != null) {
 					errorCallback(response, response.status, e);
 				}
@@ -146,20 +182,35 @@ class HTTPRequest {
 
 		//l'api fetch n'est pas dispo pour ce navigateur => normalement ce cas ne devrait pas arriver car le polyfill est chargé
 		console.error('fetch\'s polyfill used');
-		$.ajax({
+
+
+		let ajaxOptions = {
 			type: 'GET',
-			url: url + (!url.includes('?') ? '?' : '') + data,
+			url: url,
 			headers: HTTPRequest.getHeaders(),
 			cache: false,
 			xhrFields: {
 				responseType: 'blob'
 			},
+		};
+		if ('POST' === method) {
+			ajaxOptions['type'] = 'POST';
+			ajaxOptions['data'] = this.formatFormData(data);
+			ajaxOptions['contentType'] = false;
+			ajaxOptions['processData'] = false;
+		}
+
+		$.ajax(Object.assign({...ajaxOptions}, {
 			success: (data, status, jqxhr) => File.download(data, jqxhr.getResponseHeader('Content-Type'), jqxhr.getResponseHeader('Content-Disposition')),
-			error: (jqxhr, status, exception) => {
-				if (typeof jqxhr.responseJSON != 'undefined' && jqxhr.responseJSON.code == 401 && jqxhr.responseJSON.message == "Expired JWT Token") {
-					HTTPRequest.refreshToken(() => HTTPRequest.download(url, data, errorCallback, completeCallback));
-				} else if (typeof errorCallback != 'undefined' && errorCallback != null) {
-					errorCallback(jqxhr, status, exception);
+			error: (jqxhr, status, errorThrown) => {
+				if (typeof jqxhr.responseJSON != 'undefined' && jqxhr.responseJSON.code == 401 && (jqxhr.responseJSON.message === "Expired JWT Token"  || (typeof jqxhr.responseJSON['error'] != 'undefined' && jqxhr.responseJSON['error'] === 'expired_token' ))) {
+					HTTPRequest.refreshToken(() => HTTPRequest.download(url, data, errorCallback, completeCallback, method));
+					return;
+				}
+
+				HTTPRequest.logJqueryRequestFailure(jqxhr, status, errorThrown);
+				if (typeof errorCallback != 'undefined' && errorCallback != null) {
+					errorCallback(jqxhr, status, errorThrown);
 				}
 			},
 			complete: (jqxhr, status) => {
@@ -167,33 +218,35 @@ class HTTPRequest {
 					completeCallback(jqxhr, status);
 				}
 			}
-		});
+		}));
 	}
 
 	static async post(url, formData, successCallback, errorCallback, formErrorCallback) {
+		formData = this.formatFormData(formData);
+
 		if (window.fetch && false) {
-			let requestInit = {
+			const response = await fetch(url, {
 				method: 'POST',
 				body: formData,
 				headers: HTTPRequest.getHeaders(),
 				mode: 'cors',
 				cache: 'no-cache'
-			};
+			});
 
 			let jsonData = {};
-			const response = await fetch(url, requestInit);
-
 			try {
 				jsonData = await response.json();
 				//console.log(url, jsonData);
 
-				if (response.status == 401 && (response.statusText == "Expired JWT Token" || typeof jsonData['error'] != 'undefined' && jsonData['error'] === 'expired_token')) {
+				if (response.status == 401 && (response.statusText === "Expired JWT Token" || (typeof jsonData['error'] != 'undefined' && jsonData['error'] === 'expired_token'))) {
 					HTTPRequest.refreshToken(() => HTTPRequest.post(url, formData, successCallback, errorCallback, formErrorCallback));
 					return;
 				}
 
 				if (response.ok) {
-					successCallback(jsonData);
+					if (typeof successCallback != 'undefined' && successCallback != null) {
+						successCallback(jsonData);
+					}
 					return;
 				}
 
@@ -203,12 +256,17 @@ class HTTPRequest {
 				}
 			}
 			catch (e) {
-				console.log(e);
-				errorCallback(response, response.status, e);
+				console.error(e);
+				if (typeof errorCallback != 'undefined' && errorCallback != null) {
+					errorCallback(response, response.status, e);
+				}
 				return;
 			}
 
-			errorCallback(response, response.status, null, jsonData);
+			HTTPRequest.logRequestFailure(response, jsonData);
+			if (typeof errorCallback != 'undefined' && errorCallback != null) {
+				errorCallback(response, response.status, null, jsonData);
+			}
 			return;
 		}
 
@@ -223,14 +281,24 @@ class HTTPRequest {
 			cache: false,
 			contentType: false,
 			processData: false,
-			success: (data) => successCallback(data),
-			error: (jqxhr, status, exception) => {
-				if (typeof jqxhr.responseJSON != 'undefined' && jqxhr.responseJSON.code == 401 && jqxhr.responseJSON.message == "Expired JWT Token") {
+			success: (data) => {
+				if (typeof successCallback != 'undefined' && successCallback != null) {
+					successCallback(data);
+				}
+			},
+			error: (jqxhr, status, errorThrown) => {
+				if (typeof jqxhr.responseJSON != 'undefined' && jqxhr.responseJSON.code == 401 && (jqxhr.responseJSON.message === "Expired JWT Token"  || (typeof jqxhr.responseJSON['error'] != 'undefined' && jqxhr.responseJSON['error'] === 'expired_token' ))) {
 					HTTPRequest.refreshToken(() => HTTPRequest.post(url, formData, successCallback, errorCallback, formErrorCallback));
-				} else if (jqxhr.status == 400 && typeof formErrorCallback != 'undefined' && formErrorCallback != null) {
-					formErrorCallback(jqxhr, status, exception);
-				} else {
-					errorCallback(jqxhr, status, exception);
+					return;
+				}
+				if (jqxhr.status == 400 && typeof formErrorCallback != 'undefined' && formErrorCallback != null) {
+					formErrorCallback(jqxhr, status, errorThrown);
+					return;
+				}
+
+				HTTPRequest.logJqueryRequestFailure(jqxhr, status, errorThrown);
+				if (typeof errorCallback != 'undefined' && errorCallback != null) {
+					errorCallback(jqxhr, status, errorThrown);
 				}
 			}
 		});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@osimatic/helpers-js",
-  "version": "1.0.26",
+  "version": "1.0.29",
   "main": "index.js",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"