@osfactory/har 1.14.2 → 1.15.0

package/dist/index.js

@@ -38722,6 +38722,26 @@ function substituteEnvTemplate(template, values) {
     }
   );
 }
+function findUnsubstitutedTemplateVars(template) {
+  const allowed = new Set(AGENT_ENV_TEMPLATE_VARS);
+  const found = /* @__PURE__ */ new Map();
+  template.split("\n").forEach((line, idx) => {
+    if (/^\s*#/.test(line)) return;
+    const re2 = /\$(?:\{([A-Za-z_][A-Za-z0-9_]*)([^}]*)(\}?)|([A-Za-z_][A-Za-z0-9_]*))/g;
+    for (let m = re2.exec(line); m !== null; m = re2.exec(line)) {
+      const braced = m[1] !== void 0;
+      const name = braced ? m[1] : m[4];
+      const plain = !braced || m[2] === "" && m[3] === "}";
+      const reason = plain ? "not-substituted" : "parameter-syntax";
+      if (plain && allowed.has(name)) continue;
+      const key = `${reason}:${name}`;
+      const entry = found.get(key) ?? { name, reason, lines: [] };
+      if (!entry.lines.includes(idx + 1)) entry.lines.push(idx + 1);
+      found.set(key, entry);
+    }
+  });
+  return [...found.values()];
+}
 function generateAgentEnvFile(options) {
   const templatePath = options.templatePath ?? path24.join(options.harnessDir, "env.template");
   if (!fs24.existsSync(templatePath)) return false;
@@ -39011,7 +39031,7 @@ function defaultAppPort(base, agentId, step) {
 function slotPortLaneEnd(defaultPort, step) {
   return defaultPort + step - 1;
 }
-function isPortInUse(port, host = "127.0.0.1") {
+function probeTcpPort(port, host) {
   try {
     (0, import_child_process6.execSync)(`bash -c 'exec 3<>/dev/tcp/${host}/${port}'`, { stdio: "ignore" });
     return true;
@@ -39019,6 +39039,10 @@ function isPortInUse(port, host = "127.0.0.1") {
     return false;
   }
 }
+function isPortInUse(port, host) {
+  if (host !== void 0) return probeTcpPort(port, host);
+  return probeTcpPort(port, "127.0.0.1") || probeTcpPort(port, "::1");
+}
 function pickFreePort(start, end) {
   for (let port = start; port <= end; port++) {
     if (!isPortInUse(port)) return port;
@@ -84481,6 +84505,7 @@ function applyLine(repoPath, lineSpec, options = {}) {
 // src/harness/doctor.ts
 init_stages();
 init_hooks2();
+init_agent_env();
 
 // src/harness/migrations.ts
 var fs64 = __toESM(require("fs"));
@@ -84965,6 +84990,7 @@ var CHECK_LABELS = {
   "lifecycle-stages": "lifecycle stages (launch/verify/teardown)",
   "verification-ids": "verificationStages ids",
   "port-lanes": "infra port lanes",
+  "env-template": "env.template placeholders",
   "slot-registry": "slot registry worktrees",
   hooks: "lifecycle hooks (.har/hooks)",
   "retired-machinery": "no references to retired runtime machinery",
@@ -85192,6 +85218,27 @@ function runDoctor(repoPath) {
       }
     }
   }
+  const envTemplatePath = path73.join(harnessDir, "env.template");
+  if (!fs65.existsSync(envTemplatePath)) {
+    skipped.add("env-template");
+  } else {
+    const allowed = new Set(AGENT_ENV_TEMPLATE_VARS);
+    const allowedVars = AGENT_ENV_TEMPLATE_VARS.join(", ");
+    const template = fs65.readFileSync(envTemplatePath, "utf8");
+    for (const { name, reason, lines } of findUnsubstitutedTemplateVars(template)) {
+      const rest = lines.slice(1);
+      const more = rest.length ? ` (also line${rest.length > 1 ? "s" : ""} ${rest.join(", ")})` : "";
+      const literalDollar = "A literal `$` cannot be written in env.template: envsubst has no escape and keeps `\\$` as-is";
+      findings.push({
+        check: "env-template",
+        severity: "warning",
+        file: "env.template",
+        line: lines[0],
+        message: reason === "parameter-syntax" ? `\${${name}\u2026} uses shell parameter syntax, which launch never expands \u2014 the whole reference is written literally to .env.agent.<id>${more}` : `\${${name}} is not substituted at launch and will be written literally to .env.agent.<id>${more}`,
+        remedy: reason === "parameter-syntax" && allowed.has(name) ? `Write a plain \${${name}}; :- / :? / # / % are not supported by envsubst` : `Use one of ${allowedVars} (plain \${NAME}, no modifiers), or hard-code the value (variables in harness.env are not substituted into env.template). ${literalDollar}`
+      });
+    }
+  }
   const manifest = readManifest(repoPath);
   if (!manifest?.ejected) {
     skipped.add("ejected-runtime");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@osfactory/har",
-  "version": "1.14.2",
+  "version": "1.15.0",
   "description": "HAR: open agent harness CLI and MCP server for coding agents, isolated worktrees, and software-factory workflows",
   "keywords": [
     "har",