@osdk/maker 0.13.0-beta.1 → 0.13.0-beta.11

package/CHANGELOG.md

@@ -1,5 +1,115 @@
 # @osdk/maker
 
+## 0.13.0-beta.11
+
+### Minor Changes
+
+- 5fd12eb: Fix interface display metadata to include icon
+- f2dbc3d: Fix test from semantic merge conflict
+- 712dfbe: Improve interface action validation
+
+### Patch Changes
+
+- Updated dependencies [7b97128]
+  - @osdk/api@2.5.0-beta.11
+
+## 0.13.0-beta.10
+
+### Minor Changes
+
+- 11fd3fb: Add api name validation for object types
+
+### Patch Changes
+
+- @osdk/api@2.5.0-beta.10
+
+## 0.13.0-beta.9
+
+### Minor Changes
+
+- 1b60527: Remove foundry.ontologies dependency
+
+### Patch Changes
+
+- @osdk/api@2.5.0-beta.9
+
+## 0.13.0-beta.8
+
+### Minor Changes
+
+- f9b6dc4: Write value types to ontology IR file
+- b1c99bf: Revert .js -> .ts extension for codegen
+
+### Patch Changes
+
+- Updated dependencies [ca1fabe]
+  - @osdk/api@2.5.0-beta.8
+
+## 0.13.0-beta.7
+
+### Minor Changes
+
+- 6da8fd2: Write value type IR correctly
+
+## 0.13.0-beta.6
+
+### Minor Changes
+
+- 07083e1: Action submission conditions can have custom metadata
+
+### Patch Changes
+
+- @osdk/api@2.5.0-beta.7
+
+## 0.13.0-beta.5
+
+### Minor Changes
+
+- cbcf2ad: Add branching support
+- 04fe946: Use block data type for imports
+
+### Patch Changes
+
+- @osdk/api@2.5.0-beta.6
+
+## 0.13.0-beta.4
+
+### Minor Changes
+
+- a00d2ed: Update Platform SDK dependencies
+- a96d89e: Update Platform SDK dependencies
+
+### Patch Changes
+
+- @osdk/api@2.5.0-beta.4
+
+## 0.13.0-beta.3
+
+### Minor Changes
+
+- 7bdac45: Update Platform SDK dependency
+
+### Patch Changes
+
+- Updated dependencies [7bdac45]
+- Updated dependencies [20962bc]
+- Updated dependencies [e48be06]
+  - @osdk/api@2.5.0-beta.3
+
+## 0.13.0-beta.2
+
+### Minor Changes
+
+- 7cdab1d: Update platform sdk dependencies
+- 40d43c2: Make codegen TS compiler friendly
+- 5f72188: Fix object action param optionality for non-array props
+
+### Patch Changes
+
+- Updated dependencies [7160276]
+- Updated dependencies [76905f5]
+  - @osdk/api@2.5.0-beta.2
+
 ## 0.12.0-beta.21
 
 ### Minor Changes

package/build/browser/api/defineAction.js

@@ -17,7 +17,7 @@
 import { consola } from "consola";
 import invariant from "tiny-invariant";
 import { convertToDisplayName, getAllInterfaceProperties } from "./defineObject.js";
-import { namespace, ontologyDefinition, updateOntology } from "./defineOntology.js";
+import { importedTypes, namespace, ontologyDefinition, updateOntology } from "./defineOntology.js";
 import { convertConditionDefinition, convertMappingValue } from "./ontologyUtils.js";
 import { CREATE_OR_MODIFY_OBJECT_PARAMETER, MODIFY_OBJECT_PARAMETER, OntologyEntityTypeEnum } from "./types.js";
 export function defineCreateInterfaceObjectAction(interfaceType, objectType, validation) {
@@ -86,7 +86,7 @@ export function defineCreateInterfaceObjectAction(interfaceType, objectType, val
       }
     }],
     ...(validation ? {
-      validation: [convertValidationRule(validation)]
+      validation: convertValidationRule(validation)
     } : {})
   });
 }
@@ -99,7 +99,7 @@ export function defineCreateObjectAction(def) {
   if (def.parameterOrdering) {
     validateParameterOrdering(def.parameterOrdering, parameterNames, actionApiName);
   }
-  const parameters = createParameters(def, parameterNames, true);
+  const parameters = createParameters(def, parameterNames);
   const mappings = Object.fromEntries(Object.entries(def.nonParameterMappings ?? {}).map(([id, value]) => [id, convertMappingValue(value)]));
   return defineAction({
     apiName: actionApiName,
@@ -128,7 +128,7 @@ export function defineCreateObjectAction(def) {
     }],
     parameterOrdering: def.parameterOrdering ?? createDefaultParameterOrdering(def, parameters),
     ...(def.actionLevelValidation ? {
-      validation: [convertValidationRule(def.actionLevelValidation)]
+      validation: convertValidationRule(def.actionLevelValidation)
     } : {}),
     ...(def.defaultFormat && {
       defaultFormat: def.defaultFormat
@@ -211,7 +211,7 @@ export function defineModifyInterfaceObjectAction(interfaceType, objectType, val
       }
     }],
     ...(validation ? {
-      validation: [convertValidationRule(validation)]
+      validation: convertValidationRule(validation)
     } : {})
   });
 }
@@ -228,7 +228,7 @@ export function defineModifyObjectAction(def) {
     }
     validateParameterOrdering(def.parameterOrdering, parameterNames, actionApiName);
   }
-  const parameters = createParameters(def, parameterNames, false);
+  const parameters = createParameters(def, parameterNames);
   parameters.forEach(p => {
     if (p.id !== MODIFY_OBJECT_PARAMETER && p.defaultValue === undefined) {
       p.defaultValue = {
@@ -268,7 +268,7 @@ export function defineModifyObjectAction(def) {
     },
     parameterOrdering: def.parameterOrdering ?? createDefaultParameterOrdering(def, parameters, MODIFY_OBJECT_PARAMETER),
     ...(def.actionLevelValidation ? {
-      validation: [convertValidationRule(def.actionLevelValidation)]
+      validation: convertValidationRule(def.actionLevelValidation)
     } : {}),
     ...(def.defaultFormat && {
       defaultFormat: def.defaultFormat
@@ -321,7 +321,7 @@ export function defineDeleteObjectAction(def) {
       typeGroups: []
     },
     ...(def.actionLevelValidation ? {
-      validation: [convertValidationRule(def.actionLevelValidation)]
+      validation: convertValidationRule(def.actionLevelValidation)
     } : {})
   });
 }
@@ -338,7 +338,7 @@ export function defineCreateOrModifyObjectAction(def) {
     }
     validateParameterOrdering(def.parameterOrdering, parameterNames, actionApiName);
   }
-  const parameters = createParameters(def, parameterNames, false);
+  const parameters = createParameters(def, parameterNames);
   parameters.forEach(p => {
     if (p.id !== CREATE_OR_MODIFY_OBJECT_PARAMETER && p.defaultValue === undefined) {
       p.defaultValue = {
@@ -378,7 +378,7 @@ export function defineCreateOrModifyObjectAction(def) {
     },
     parameterOrdering: def.parameterOrdering ?? createDefaultParameterOrdering(def, parameters, CREATE_OR_MODIFY_OBJECT_PARAMETER),
     ...(def.actionLevelValidation ? {
-      validation: [convertValidationRule(def.actionLevelValidation)]
+      validation: convertValidationRule(def.actionLevelValidation)
     } : {}),
     ...(def.defaultFormat && {
       defaultFormat: def.defaultFormat
@@ -419,6 +419,41 @@ export function defineAction(actionDef) {
     if (rule.type === "deleteObjectRule") {
       !parameterIds.some(id => id === rule.deleteObjectRule.objectToDelete) ? process.env.NODE_ENV !== "production" ? invariant(false, `Object to delete parameter must be defined in parameters`) : invariant(false) : void 0;
     }
+    if (rule.type === "modifyInterfaceRule") {
+      // all referenced SPTs exist globally
+      Object.keys(rule.modifyInterfaceRule.sharedPropertyValues).forEach(spt => {
+        !(ontologyDefinition.SHARED_PROPERTY_TYPE[spt] !== undefined || importedTypes.SHARED_PROPERTY_TYPE[spt] !== undefined) ? process.env.NODE_ENV !== "production" ? invariant(false, `Shared property type ${spt} does not exist.
+            If this SPT was imported, you may need to use [spt.apiName] as the key so that it is qualified with the right namespace`) : invariant(false) : void 0;
+      });
+
+      // The there must be a parameter for the interface, and the interface there must exist
+      const interfaceParam = actionDef.parameters.find(p => p.id === rule.modifyInterfaceRule.interfaceObjectToModifyParameter);
+      !(interfaceParam !== undefined && typeof interfaceParam.type === "object" && (interfaceParam.type.type === "interfaceReference" || interfaceParam.type.type === "interfaceReferenceList")) ? process.env.NODE_ENV !== "production" ? invariant(false, `Interface object to modify parameter must be an interface reference`) : invariant(false) : void 0;
+      const interfaceReference = interfaceParam.type.type === "interfaceReference" ? interfaceParam.type.interfaceReference.interfaceTypeRid : interfaceParam.type.interfaceReferenceList.interfaceTypeRid;
+      !(ontologyDefinition.INTERFACE_TYPE[interfaceReference] !== undefined || importedTypes.INTERFACE_TYPE[interfaceReference] !== undefined) ? process.env.NODE_ENV !== "production" ? invariant(false, `Interface type ${interfaceReference} does not exist`) : invariant(false) : void 0;
+
+      // All referenced SPTs must exist on the interface
+      const interfaceType = ontologyDefinition.INTERFACE_TYPE[interfaceReference];
+      Object.keys(rule.modifyInterfaceRule.sharedPropertyValues).forEach(spt => {
+        !(interfaceType.propertiesV2[spt] !== undefined) ? process.env.NODE_ENV !== "production" ? invariant(false, `Shared property type ${spt} does not exist in interface type ${interfaceReference}`) : invariant(false) : void 0;
+      });
+    }
+    if (rule.type === "addInterfaceRule") {
+      // All referenced SPTs must exist globally
+      Object.keys(rule.addInterfaceRule.sharedPropertyValues).forEach(spt => {
+        !(ontologyDefinition.SHARED_PROPERTY_TYPE[spt] !== undefined || importedTypes.SHARED_PROPERTY_TYPE[spt] !== undefined) ? process.env.NODE_ENV !== "production" ? invariant(false, `Shared property type ${spt} does not exist. 
+          If this SPT was imported, you may need to use [spt.apiName] as the key so that it is qualified with the right namespace`) : invariant(false) : void 0;
+      });
+
+      // The referenced interface must exist globally
+      const interfaceType = ontologyDefinition.INTERFACE_TYPE[rule.addInterfaceRule.interfaceApiName] ?? importedTypes.INTERFACE_TYPE[rule.addInterfaceRule.interfaceApiName];
+      !(interfaceType !== undefined) ? process.env.NODE_ENV !== "production" ? invariant(false, `Interface type ${rule.addInterfaceRule.interfaceApiName} does not exist`) : invariant(false) : void 0;
+
+      // All referenced SPTs must exist on the interface
+      Object.keys(rule.addInterfaceRule.sharedPropertyValues).forEach(spt => {
+        !(interfaceType.propertiesV2[spt] !== undefined) ? process.env.NODE_ENV !== "production" ? invariant(false, `Shared property type ${spt} does not exist in interface type ${interfaceType.apiName}`) : invariant(false) : void 0;
+      });
+    }
   });
   const fullAction = {
     ...actionDef,
@@ -435,7 +470,7 @@ export function defineAction(actionDef) {
   updateOntology(fullAction);
   return fullAction;
 }
-function createParameters(def, parameterSet, defaultRequired) {
+function createParameters(def, parameterSet) {
   const targetParam = [];
   parameterSet.forEach(name => {
     if (name === MODIFY_OBJECT_PARAMETER) {
@@ -497,13 +532,13 @@ function createParameters(def, parameterSet, defaultRequired) {
     validation: def.parameterConfiguration?.[id] !== undefined ? {
       ...def.parameterConfiguration?.[id],
       allowedValues: def.parameterConfiguration?.[id].allowedValues ?? (def.parameterConfiguration?.[id].customParameterType ? extractAllowedValuesFromActionParameterType(def.parameterConfiguration?.[id].customParameterType) : extractAllowedValuesFromPropertyType(def.objectType.properties?.[id].type)),
-      required: def.parameterConfiguration?.[id].required ?? defaultRequired
+      required: def.parameterConfiguration?.[id].required ?? def.objectType.properties?.[id]?.nullability?.noNulls ?? false
     } : {
       required: def.objectType.properties?.[id].array ?? false ? {
         listLength: def.objectType.properties?.[id].nullability?.noEmptyCollections ? {
           min: 1
         } : {}
-      } : def.objectType.properties?.[id].nullability?.noNulls ?? defaultRequired,
+      } : def.objectType.properties?.[id].nullability?.noNulls ?? false,
       allowedValues: extractAllowedValuesFromPropertyType(def.objectType.properties?.[id].type)
     },
     defaultValue: def.parameterConfiguration?.[id]?.defaultValue,
@@ -788,13 +823,15 @@ function sanitize(s) {
   return s.includes(".") ? s : namespace + s;
 }
 function convertValidationRule(actionValidation) {
-  return {
-    condition: convertConditionDefinition(actionValidation.condition),
-    displayMetadata: actionValidation.displayMetadata ?? {
-      failureMessage: "Did not satisfy validation",
-      typeClasses: []
-    }
-  };
+  return actionValidation.map(rule => {
+    return {
+      condition: convertConditionDefinition(rule.condition),
+      displayMetadata: rule.displayMetadata ?? {
+        failureMessage: "Did not satisfy validation",
+        typeClasses: []
+      }
+    };
+  });
 }
 function validateActionConfiguration(action) {
   const seenParameterIds = new Set();