@osdk/generator 2.1.0-beta.2 → 2.1.0-beta.20

package/build/browser/v2.0/generateClientSdkVersionTwoPointZero.test.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+import { consola } from "consola";
 import { mkdir, readdir, rmdir, writeFile } from "fs/promises";
 import * as immer from "immer";
 import { beforeEach, describe, expect, it, test, vi } from "vitest";
@@ -153,12 +154,20 @@ const referencedOntology = {
           "taskId": {
             "dataType": {
               "type": "string"
-            }
+            },
+            "rid": "ridForTaskId"
           },
           "body": {
             "dataType": {
               "type": "string"
-            }
+            },
+            "rid": "ridForBody"
+          },
+          "shouldBeIgnored": {
+            "dataType": {
+              "type": "futureUnknownType"
+            },
+            "rid": "ridForShouldBeIgnored"
           }
         },
         "status": "ACTIVE",
@@ -184,6 +193,7 @@ const referencedOntology = {
           rid: "idk"
         }
       },
+      implementedByObjectTypes: [],
       links: {}
     }
   },
@@ -256,12 +266,14 @@ const referencingOntology = {
           "id": {
             dataType: {
               type: "integer"
-            }
+            },
+            rid: "rid"
           },
           "body": {
             dataType: {
               type: "string"
-            }
+            },
+            "rid": "rid"
           }
         },
         rid: "ridForThing",
@@ -288,12 +300,14 @@ const referencingOntology = {
           "id": {
             dataType: {
               type: "integer"
-            }
+            },
+            rid: "rid"
           },
           "body": {
             dataType: {
               type: "string"
-            }
+            },
+            rid: "rid"
           }
         },
         rid: "theRid",
@@ -396,7 +410,7 @@ describe("generator", () => {
         ActionReturnTypeForOptions,
         ApplyActionOptions,
         ApplyBatchActionOptions,
-      } from '@osdk/api';
+      } from '@osdk/client';
       import { $osdkMetadata } from '../../OntologyMetadata';
       import type { Todo } from '../objects/Todo';
 
@@ -472,7 +486,7 @@ describe("generator", () => {
         ActionReturnTypeForOptions,
         ApplyActionOptions,
         ApplyBatchActionOptions,
-      } from '@osdk/api';
+      } from '@osdk/client';
       import { $osdkMetadata } from '../../OntologyMetadata';
       import type { Todo } from '../objects/Todo';
 
@@ -548,7 +562,7 @@ describe("generator", () => {
       ",
         "/foo/ontology/interfaces.ts": "export { SomeInterface } from './interfaces/SomeInterface';
       ",
-        "/foo/ontology/interfaces/SomeInterface.ts": "import type { PropertyDef as $PropertyDef } from '@osdk/api';
+        "/foo/ontology/interfaces/SomeInterface.ts": "import type { PropertyDef as $PropertyDef } from '@osdk/client';
       import { $osdkMetadata } from '../../OntologyMetadata';
 
       import type {
@@ -556,7 +570,7 @@ describe("generator", () => {
         ObjectSet as $ObjectSet,
         Osdk as $Osdk,
         PropertyValueWireToClient as $PropType,
-      } from '@osdk/api';
+      } from '@osdk/client';
 
       export type OsdkObjectLinks$SomeInterface = {};
 
@@ -566,20 +580,18 @@ describe("generator", () => {
         export interface Props {
           readonly SomeProperty: $PropType['string'] | undefined;
         }
-        export interface StrictProps {
-          readonly SomeProperty: $PropType['string'] | undefined;
-        }
+        export type StrictProps = Props;
 
         export interface ObjectSet extends $ObjectSet<SomeInterface, SomeInterface.ObjectSet> {}
 
         export type OsdkInstance<
-          OPTIONS extends never | '$notStrict' | '$rid' = never,
+          OPTIONS extends never | '$rid' = never,
           K extends keyof SomeInterface.Props = keyof SomeInterface.Props,
         > = $Osdk.Instance<SomeInterface, OPTIONS, K>;
 
         /** @deprecated use OsdkInstance */
         export type OsdkObject<
-          OPTIONS extends never | '$notStrict' | '$rid' = never,
+          OPTIONS extends never | '$rid' = never,
           K extends keyof SomeInterface.Props = keyof SomeInterface.Props,
         > = OsdkInstance<OPTIONS, K>;
       }
@@ -619,7 +631,7 @@ describe("generator", () => {
         "/foo/ontology/objects.ts": "export { Person } from './objects/Person';
       export { Todo } from './objects/Todo';
       ",
-        "/foo/ontology/objects/Person.ts": "import type { PropertyDef as $PropertyDef } from '@osdk/api';
+        "/foo/ontology/objects/Person.ts": "import type { PropertyDef as $PropertyDef } from '@osdk/client';
       import { $osdkMetadata } from '../../OntologyMetadata';
       import type { $ExpectedClientVersion } from '../../OntologyMetadata';
       import type { Todo } from './Todo';
@@ -627,14 +639,14 @@ describe("generator", () => {
         PropertyKeys as $PropertyKeys,
         ObjectTypeDefinition as $ObjectTypeDefinition,
         ObjectMetadata as $ObjectMetadata,
-      } from '@osdk/api';
+      } from '@osdk/client';
       import type {
         ObjectSet as $ObjectSet,
         Osdk as $Osdk,
         OsdkObject as $OsdkObject,
         PropertyValueWireToClient as $PropType,
         SingleLinkAccessor as $SingleLinkAccessor,
-      } from '@osdk/api';
+      } from '@osdk/client';
 
       export namespace Person {
         export type PropertyKeys = 'email';
@@ -644,22 +656,20 @@ describe("generator", () => {
         }
 
         export interface Props {
-          readonly email: $PropType['string'] | undefined;
-        }
-        export interface StrictProps {
           readonly email: $PropType['string'];
         }
+        export type StrictProps = Props;
 
         export interface ObjectSet extends $ObjectSet<Person, Person.ObjectSet> {}
 
         export type OsdkInstance<
-          OPTIONS extends never | '$notStrict' | '$rid' = never,
+          OPTIONS extends never | '$rid' = never,
           K extends keyof Person.Props = keyof Person.Props,
         > = $Osdk.Instance<Person, OPTIONS, K>;
 
         /** @deprecated use OsdkInstance */
         export type OsdkObject<
-          OPTIONS extends never | '$notStrict' | '$rid' = never,
+          OPTIONS extends never | '$rid' = never,
           K extends keyof Person.Props = keyof Person.Props,
         > = OsdkInstance<OPTIONS, K>;
       }
@@ -709,7 +719,7 @@ describe("generator", () => {
         osdkMetadata: $osdkMetadata,
       };
       ",
-        "/foo/ontology/objects/Todo.ts": "import type { PropertyDef as $PropertyDef } from '@osdk/api';
+        "/foo/ontology/objects/Todo.ts": "import type { PropertyDef as $PropertyDef } from '@osdk/client';
       import { $osdkMetadata } from '../../OntologyMetadata';
       import type { $ExpectedClientVersion } from '../../OntologyMetadata';
       import type { Person } from './Person';
@@ -717,14 +727,14 @@ describe("generator", () => {
         PropertyKeys as $PropertyKeys,
         ObjectTypeDefinition as $ObjectTypeDefinition,
         ObjectMetadata as $ObjectMetadata,
-      } from '@osdk/api';
+      } from '@osdk/client';
       import type {
         ObjectSet as $ObjectSet,
         Osdk as $Osdk,
         OsdkObject as $OsdkObject,
         PropertyValueWireToClient as $PropType,
         SingleLinkAccessor as $SingleLinkAccessor,
-      } from '@osdk/api';
+      } from '@osdk/client';
 
       export namespace Todo {
         export type PropertyKeys = 'id' | 'body' | 'complete';
@@ -734,26 +744,22 @@ describe("generator", () => {
         }
 
         export interface Props {
-          readonly body: $PropType['string'] | undefined;
-          readonly complete: $PropType['boolean'] | undefined;
-          readonly id: $PropType['integer'] | undefined;
-        }
-        export interface StrictProps {
           readonly body: $PropType['string'] | undefined;
           readonly complete: $PropType['boolean'] | undefined;
           readonly id: $PropType['integer'];
         }
+        export type StrictProps = Props;
 
         export interface ObjectSet extends $ObjectSet<Todo, Todo.ObjectSet> {}
 
         export type OsdkInstance<
-          OPTIONS extends never | '$notStrict' | '$rid' = never,
+          OPTIONS extends never | '$rid' = never,
           K extends keyof Todo.Props = keyof Todo.Props,
         > = $Osdk.Instance<Todo, OPTIONS, K>;
 
         /** @deprecated use OsdkInstance */
         export type OsdkObject<
-          OPTIONS extends never | '$notStrict' | '$rid' = never,
+          OPTIONS extends never | '$rid' = never,
           K extends keyof Todo.Props = keyof Todo.Props,
         > = OsdkInstance<OPTIONS, K>;
       }
@@ -823,8 +829,7 @@ describe("generator", () => {
         "/foo/ontology/queries.ts": "export { getCount } from './queries/getCount';
       export { returnsTodo } from './queries/returnsTodo';
       ",
-        "/foo/ontology/queries/getCount.ts": "import type { QueryDefinition, VersionBound } from '@osdk/api';
-      import type { QueryParam, QueryResult } from '@osdk/api';
+        "/foo/ontology/queries/getCount.ts": "import type { QueryDefinition, QueryParam, QueryResult, VersionBound } from '@osdk/client';
       import type { $ExpectedClientVersion } from '../../OntologyMetadata';
       import { $osdkMetadata } from '../../OntologyMetadata';
 
@@ -877,8 +882,7 @@ describe("generator", () => {
         osdkMetadata: $osdkMetadata,
       };
       ",
-        "/foo/ontology/queries/returnsTodo.ts": "import type { QueryDefinition, VersionBound } from '@osdk/api';
-      import type { QueryParam, QueryResult } from '@osdk/api';
+        "/foo/ontology/queries/returnsTodo.ts": "import type { QueryDefinition, QueryParam, QueryResult, VersionBound } from '@osdk/client';
       import type { $ExpectedClientVersion } from '../../OntologyMetadata';
       import { $osdkMetadata } from '../../OntologyMetadata';
       import type { Todo } from '../objects/Todo';
@@ -949,14 +953,14 @@ describe("generator", () => {
   it("throws an error if a namespace is provided that all top levels do not use", async () => {
     await expect(generateClientSdkVersionTwoPointZero({
       ...TodoWireOntology
-    }, "", helper.minimalFiles, BASE_PATH, "module"));
+    }, "", helper.minimalFiles, BASE_PATH, "module", undefined, undefined, undefined, true));
     // Disabled for now since we can't really enforce it from dev console at the moment
     // .rejects.toThrowErrorMatchingInlineSnapshot(
     //   `[Error: Found type { ns:'undefined', shortName: 'Todo'} but it is not in the generation namespace 'foo.bar'. This violates the contract of the generator.]`,
     // );
   });
   it("does not throw an error if a namespace is provided that all top levels use", async () => {
-    await expect(generateClientSdkVersionTwoPointZero(fooBarTodoWireOntology, "", helper.minimalFiles, BASE_PATH, "module")).resolves.toMatchInlineSnapshot(`undefined`);
+    await expect(generateClientSdkVersionTwoPointZero(fooBarTodoWireOntology, "", helper.minimalFiles, BASE_PATH, "module", undefined, undefined, undefined, true)).resolves.toMatchInlineSnapshot(`undefined`);
     expect(helper.getFiles()["/foo/ontology/objects/foo.bar.Todo.ts"]).toBeUndefined();
     expect(helper.getFiles()["/foo/ontology/objects/Todo.ts"]).not.toBeUndefined();
     expect(tweakedFilesForSnapshotConsistency(helper.getFiles())).toMatchInlineSnapshot(`
@@ -1156,20 +1160,18 @@ describe("generator", () => {
           export interface Props {
             readonly SomeProperty: $PropType['string'] | undefined;
           }
-          export interface StrictProps {
-            readonly SomeProperty: $PropType['string'] | undefined;
-          }
+          export type StrictProps = Props;
 
           export interface ObjectSet extends $ObjectSet<SomeInterface, SomeInterface.ObjectSet> {}
 
           export type OsdkInstance<
-            OPTIONS extends never | '$notStrict' | '$rid' = never,
+            OPTIONS extends never | '$rid' = never,
             K extends keyof SomeInterface.Props = keyof SomeInterface.Props,
           > = $Osdk.Instance<SomeInterface, OPTIONS, K>;
 
           /** @deprecated use OsdkInstance */
           export type OsdkObject<
-            OPTIONS extends never | '$notStrict' | '$rid' = never,
+            OPTIONS extends never | '$rid' = never,
             K extends keyof SomeInterface.Props = keyof SomeInterface.Props,
           > = OsdkInstance<OPTIONS, K>;
         }
@@ -1234,22 +1236,20 @@ describe("generator", () => {
           }
 
           export interface Props {
-            readonly email: $PropType['string'] | undefined;
-          }
-          export interface StrictProps {
             readonly email: $PropType['string'];
           }
+          export type StrictProps = Props;
 
           export interface ObjectSet extends $ObjectSet<Person, Person.ObjectSet> {}
 
           export type OsdkInstance<
-            OPTIONS extends never | '$notStrict' | '$rid' = never,
+            OPTIONS extends never | '$rid' = never,
             K extends keyof Person.Props = keyof Person.Props,
           > = $Osdk.Instance<Person, OPTIONS, K>;
 
           /** @deprecated use OsdkInstance */
           export type OsdkObject<
-            OPTIONS extends never | '$notStrict' | '$rid' = never,
+            OPTIONS extends never | '$rid' = never,
             K extends keyof Person.Props = keyof Person.Props,
           > = OsdkInstance<OPTIONS, K>;
         }
@@ -1324,26 +1324,22 @@ describe("generator", () => {
           }
 
           export interface Props {
-            readonly body: $PropType['string'] | undefined;
-            readonly complete: $PropType['boolean'] | undefined;
-            readonly id: $PropType['integer'] | undefined;
-          }
-          export interface StrictProps {
             readonly body: $PropType['string'] | undefined;
             readonly complete: $PropType['boolean'] | undefined;
             readonly id: $PropType['integer'];
           }
+          export type StrictProps = Props;
 
           export interface ObjectSet extends $ObjectSet<Todo, Todo.ObjectSet> {}
 
           export type OsdkInstance<
-            OPTIONS extends never | '$notStrict' | '$rid' = never,
+            OPTIONS extends never | '$rid' = never,
             K extends keyof Todo.Props = keyof Todo.Props,
           > = $Osdk.Instance<Todo, OPTIONS, K>;
 
           /** @deprecated use OsdkInstance */
           export type OsdkObject<
-            OPTIONS extends never | '$notStrict' | '$rid' = never,
+            OPTIONS extends never | '$rid' = never,
             K extends keyof Todo.Props = keyof Todo.Props,
           > = OsdkInstance<OPTIONS, K>;
         }
@@ -1413,8 +1409,7 @@ describe("generator", () => {
           "/foo/ontology/queries.ts": "export { getCount } from './queries/getCount.js';
         export { returnsTodo } from './queries/returnsTodo.js';
         ",
-          "/foo/ontology/queries/getCount.ts": "import type { QueryDefinition, VersionBound } from '@osdk/api';
-        import type { QueryParam, QueryResult } from '@osdk/api';
+          "/foo/ontology/queries/getCount.ts": "import type { QueryDefinition, QueryParam, QueryResult, VersionBound } from '@osdk/api';
         import type { $ExpectedClientVersion } from '../../OntologyMetadata.js';
         import { $osdkMetadata } from '../../OntologyMetadata.js';
 
@@ -1467,8 +1462,7 @@ describe("generator", () => {
           osdkMetadata: $osdkMetadata,
         };
         ",
-          "/foo/ontology/queries/returnsTodo.ts": "import type { QueryDefinition, VersionBound } from '@osdk/api';
-        import type { QueryParam, QueryResult } from '@osdk/api';
+          "/foo/ontology/queries/returnsTodo.ts": "import type { QueryDefinition, QueryParam, QueryResult, VersionBound } from '@osdk/api';
         import type { $ExpectedClientVersion } from '../../OntologyMetadata.js';
         import { $osdkMetadata } from '../../OntologyMetadata.js';
         import type { Todo } from '../objects/Todo.js';
@@ -1576,10 +1570,9 @@ describe("generator", () => {
   });
   describe("query depends on foreign object", () => {
     it("generates the correct code", async () => {
-      await expect(generateClientSdkVersionTwoPointZero(referencingOntology, "", helper.minimalFiles, BASE_PATH, "module", new Map([["com.example.dep.Task", "@com.example.dep/osdk"]]), new Map([["com.example.dep.SomeInterface", "@com.example.dep/osdk"]]), new Map([["com.example.dep.spt", "@com.example.dep/osdk"]]))).resolves.toMatchInlineSnapshot(`undefined`);
+      await expect(generateClientSdkVersionTwoPointZero(referencingOntology, "", helper.minimalFiles, BASE_PATH, "module", new Map([["com.example.dep.Task", "@com.example.dep/osdk"]]), new Map([["com.example.dep.SomeInterface", "@com.example.dep/osdk"]]), new Map([["com.example.dep.spt", "@com.example.dep/osdk"]]), true)).resolves.toMatchInlineSnapshot(`undefined`);
       expect(helper.getFiles()["/foo/ontology/queries/getTask.ts"]).toMatchInlineSnapshot(`
-          "import type { QueryDefinition, VersionBound } from '@osdk/api';
-          import type { QueryParam, QueryResult } from '@osdk/api';
+          "import type { QueryDefinition, QueryParam, QueryResult, VersionBound } from '@osdk/api';
           import type { $ExpectedClientVersion } from '../../OntologyMetadata.js';
           import { $osdkMetadata } from '../../OntologyMetadata.js';
           import type { Task as $Imported$com$example$dep$Task } from '@com.example.dep/osdk';
@@ -1642,7 +1635,7 @@ describe("generator", () => {
   });
   describe("object uses on foreign spt", () => {
     it("stuff", async () => {
-      await expect(generateClientSdkVersionTwoPointZero(referencingOntology, "", helper.minimalFiles, BASE_PATH, "module", new Map([["com.example.dep.Task", "@com.example.dep/osdk"]]), new Map([["com.example.dep.SomeInterface", "@com.example.dep/osdk"]]), new Map([["com.example.dep.spt", "@com.example.dep/osdk"]]))).resolves.toMatchInlineSnapshot(`undefined`);
+      await expect(generateClientSdkVersionTwoPointZero(referencingOntology, "", helper.minimalFiles, BASE_PATH, "module", new Map([["com.example.dep.Task", "@com.example.dep/osdk"]]), new Map([["com.example.dep.SomeInterface", "@com.example.dep/osdk"]]), new Map([["com.example.dep.spt", "@com.example.dep/osdk"]]), true)).resolves.toMatchInlineSnapshot(`undefined`);
       expect(helper.getFiles()["/foo/ontology/objects/UsesForeignSpt.ts"]).toMatchInlineSnapshot(`
           "import type { PropertyDef as $PropertyDef } from '@osdk/api';
           import { $osdkMetadata } from '../../OntologyMetadata.js';
@@ -1666,24 +1659,21 @@ describe("generator", () => {
             export type Links = {};
 
             export interface Props {
-              readonly body: $PropType['string'] | undefined;
-              readonly id: $PropType['integer'] | undefined;
-            }
-            export interface StrictProps {
               readonly body: $PropType['string'] | undefined;
               readonly id: $PropType['integer'];
             }
+            export type StrictProps = Props;
 
             export interface ObjectSet extends $ObjectSet<UsesForeignSpt, UsesForeignSpt.ObjectSet> {}
 
             export type OsdkInstance<
-              OPTIONS extends never | '$notStrict' | '$rid' = never,
+              OPTIONS extends never | '$rid' = never,
               K extends keyof UsesForeignSpt.Props = keyof UsesForeignSpt.Props,
             > = $Osdk.Instance<UsesForeignSpt, OPTIONS, K>;
 
             /** @deprecated use OsdkInstance */
             export type OsdkObject<
-              OPTIONS extends never | '$notStrict' | '$rid' = never,
+              OPTIONS extends never | '$rid' = never,
               K extends keyof UsesForeignSpt.Props = keyof UsesForeignSpt.Props,
             > = OsdkInstance<OPTIONS, K>;
           }
@@ -1739,7 +1729,7 @@ describe("generator", () => {
   });
   describe("action depends on foreign object", () => {
     it("can generate the action", async () => {
-      await expect(generateClientSdkVersionTwoPointZero(referencingOntology, "", helper.minimalFiles, BASE_PATH, "module", new Map([["com.example.dep.Task", "@com.example.dep/osdk"]]), new Map([["com.example.dep.SomeInterface", "@com.example.dep/osdk"]]), new Map([["com.example.dep.spt", "@com.example.dep/osdk"]]))).resolves.toMatchInlineSnapshot(`undefined`);
+      await expect(generateClientSdkVersionTwoPointZero(referencingOntology, "", helper.minimalFiles, BASE_PATH, "module", new Map([["com.example.dep.Task", "@com.example.dep/osdk"]]), new Map([["com.example.dep.SomeInterface", "@com.example.dep/osdk"]]), new Map([["com.example.dep.spt", "@com.example.dep/osdk"]]), true)).resolves.toMatchInlineSnapshot(`undefined`);
       expect(helper.getFiles()["/foo/ontology/actions/setTaskBody.ts"]).toMatchInlineSnapshot(`
           "import type {
             ActionDefinition,
@@ -1822,7 +1812,9 @@ describe("generator", () => {
     });
   });
   it("can generate an sdk package that is entirely a library", async () => {
+    const mockConsola = vi.spyOn(consola, "info");
     await expect(generateClientSdkVersionTwoPointZero(referencedOntology, "", helper.minimalFiles, BASE_PATH, "module")).resolves.toMatchInlineSnapshot(`undefined`);
+    expect(mockConsola).toHaveBeenCalledWith(`{"type":"futureUnknownType"} is not a supported propertyType`);
     expect(tweakedFilesForSnapshotConsistency(helper.getFiles())).toMatchInlineSnapshot(`
         {
           "/foo/OntologyMetadata.ts": "export type $ExpectedClientVersion = 'PLACEHOLDER';
@@ -1844,7 +1836,7 @@ describe("generator", () => {
         ",
           "/foo/ontology/interfaces.ts": "export { SomeInterface } from './interfaces/SomeInterface.js';
         ",
-          "/foo/ontology/interfaces/SomeInterface.ts": "import type { PropertyDef as $PropertyDef } from '@osdk/api';
+          "/foo/ontology/interfaces/SomeInterface.ts": "import type { PropertyDef as $PropertyDef } from '@osdk/client';
         import { $osdkMetadata } from '../../OntologyMetadata.js';
 
         import type {
@@ -1852,7 +1844,7 @@ describe("generator", () => {
           ObjectSet as $ObjectSet,
           Osdk as $Osdk,
           PropertyValueWireToClient as $PropType,
-        } from '@osdk/api';
+        } from '@osdk/client';
 
         export type OsdkObjectLinks$SomeInterface = {};
 
@@ -1862,20 +1854,18 @@ describe("generator", () => {
           export interface Props {
             readonly spt: $PropType['string'] | undefined;
           }
-          export interface StrictProps {
-            readonly spt: $PropType['string'] | undefined;
-          }
+          export type StrictProps = Props;
 
           export interface ObjectSet extends $ObjectSet<SomeInterface, SomeInterface.ObjectSet> {}
 
           export type OsdkInstance<
-            OPTIONS extends never | '$notStrict' | '$rid' = never,
+            OPTIONS extends never | '$rid' = never,
             K extends keyof SomeInterface.Props = keyof SomeInterface.Props,
           > = $Osdk.Instance<SomeInterface, OPTIONS, K>;
 
           /** @deprecated use OsdkInstance */
           export type OsdkObject<
-            OPTIONS extends never | '$notStrict' | '$rid' = never,
+            OPTIONS extends never | '$rid' = never,
             K extends keyof SomeInterface.Props = keyof SomeInterface.Props,
           > = OsdkInstance<OPTIONS, K>;
         }
@@ -1912,21 +1902,21 @@ describe("generator", () => {
         ",
           "/foo/ontology/objects.ts": "export { Task } from './objects/Task.js';
         ",
-          "/foo/ontology/objects/Task.ts": "import type { PropertyDef as $PropertyDef } from '@osdk/api';
+          "/foo/ontology/objects/Task.ts": "import type { PropertyDef as $PropertyDef } from '@osdk/client';
         import { $osdkMetadata } from '../../OntologyMetadata.js';
         import type { $ExpectedClientVersion } from '../../OntologyMetadata.js';
         import type {
           PropertyKeys as $PropertyKeys,
           ObjectTypeDefinition as $ObjectTypeDefinition,
           ObjectMetadata as $ObjectMetadata,
-        } from '@osdk/api';
+        } from '@osdk/client';
         import type {
           ObjectSet as $ObjectSet,
           Osdk as $Osdk,
           OsdkObject as $OsdkObject,
           PropertyValueWireToClient as $PropType,
           SingleLinkAccessor as $SingleLinkAccessor,
-        } from '@osdk/api';
+        } from '@osdk/client';
 
         export namespace Task {
           export type PropertyKeys = 'taskId' | 'body';
@@ -1934,24 +1924,21 @@ describe("generator", () => {
           export type Links = {};
 
           export interface Props {
-            readonly body: $PropType['string'] | undefined;
-            readonly taskId: $PropType['string'] | undefined;
-          }
-          export interface StrictProps {
             readonly body: $PropType['string'] | undefined;
             readonly taskId: $PropType['string'];
           }
+          export type StrictProps = Props;
 
           export interface ObjectSet extends $ObjectSet<Task, Task.ObjectSet> {}
 
           export type OsdkInstance<
-            OPTIONS extends never | '$notStrict' | '$rid' = never,
+            OPTIONS extends never | '$rid' = never,
             K extends keyof Task.Props = keyof Task.Props,
           > = $Osdk.Instance<Task, OPTIONS, K>;
 
           /** @deprecated use OsdkInstance */
           export type OsdkObject<
-            OPTIONS extends never | '$notStrict' | '$rid' = never,
+            OPTIONS extends never | '$rid' = never,
             K extends keyof Task.Props = keyof Task.Props,
           > = OsdkInstance<OPTIONS, K>;
         }