@osdk/generator 1.14.0-beta.0 → 1.14.0-beta.2

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @osdk/generator
 
+## 1.14.0-beta.2
+
+### Minor Changes
+
+- 68a8dc7: Fixes an issue that could cause an object with sub-selection to be assigned as a full object
+- 081114f: Splits batchApplyAction out of applyAction
+
+## 1.14.0-beta.1
+
+### Minor Changes
+
+- 51fe88c: Fix edge case with never in newly generated types
+
 ## 1.14.0-beta.0
 
 ### Minor Changes

package/build/browser/index.js

@@ -71,7 +71,7 @@ var EnhancedAction = class extends EnhancedBase {
     return this.og.operations;
   }
   get paramsIdentifier() {
-    return `${this.shortApiName}.Parameters`;
+    return `${this.shortApiName}.Params`;
   }
   get definitionIdentifier() {
     return `${this.shortApiName}.Definition`;
@@ -1940,7 +1940,7 @@ function wireObjectTypeV2ToSdkObjectConstV2(wireObject, {
 
 
 
-  /** @deprecated use ${object.shortApiName}.Definition **/
+  
   export type ${objectDefIdentifier} = ${object.shortApiName}.Definition;
 
 
@@ -1970,7 +1970,7 @@ function createOsdkObject(object, identifier, {
   const definition = object.getCleanedUpDefinition(true);
   return `
   export type ${identifier}<
-      OPTIONS extends "$strict" | "$notStrict" | "$rid" = "$strict",
+      OPTIONS extends never | "$notStrict" | "$rid" = never,
       K extends keyof ${osdkObjectPropsIdentifier}= keyof ${osdkObjectPropsIdentifier},
 
   > 
@@ -1978,6 +1978,8 @@ function createOsdkObject(object, identifier, {
         ${objectDefIdentifier}, 
         K | OPTIONS
       > & Pick<
+       [OPTIONS] extends [never]
+        ? ${osdkObjectStrictPropsIdentifier} :
         OPTIONS extends "$notStrict" ? ${osdkObjectPropsIdentifier} : ${osdkObjectStrictPropsIdentifier}
         , K
 > & {
@@ -2006,37 +2008,37 @@ $ObjectSet<${objectDefIdentifier},
 ${objectSetIdentifier}
 >
 {
-readonly aggregate: <AO extends $AggregateOpts<${objectDefIdentifier}>>(
+readonly aggregate: <const AO extends $AggregateOpts<${objectDefIdentifier}>>(
   req: $AggregateOptsThatErrorsAndDisallowsOrderingWithMultipleGroupBy<${objectDefIdentifier}, AO>,
 ) => Promise<$AggregationsResults<${objectDefIdentifier}, AO>>;
 
 
-readonly pivotTo: <L extends $LinkNames<${objectDefIdentifier}>>(type: L) => $LinkedType<${objectDefIdentifier}, L>["objectSet"];
+readonly pivotTo: <const L extends $LinkNames<${objectDefIdentifier}>>(type: L) => $LinkedType<${objectDefIdentifier}, L>["objectSet"];
  ${object instanceof EnhancedObjectType ? ` 
 readonly fetchOne: <
-    L extends ${propertyKeysIdentifier},
-    R extends boolean,
-    S extends false | "throw" = $NullabilityAdherenceDefault,
+    const L extends ${propertyKeysIdentifier},
+    const R extends boolean,
+    const S extends false | "throw" = $NullabilityAdherenceDefault,
   >(
     primaryKey: $PropertyValueClientToWire[${objectDefIdentifier}["primaryKeyType"]],
     options?: $SelectArg<${objectDefIdentifier}, L, R, S>,
   ) => Promise<
    ${osdkObjectIdentifier}<
-    (S extends false ? "$notStrict" : "$strict") | ($DefaultToFalse<R> extends false? never:  "$rid" ),
+    (S extends false ? "$notStrict" : never) | ($DefaultToFalse<R> extends false? never:  "$rid" ),
     L
    >>
   ;
 
 readonly fetchOneWithErrors: <
-    L extends ${propertyKeysIdentifier},
-    R extends boolean,
-    S extends false | "throw" = $NullabilityAdherenceDefault,
+    const L extends ${propertyKeysIdentifier},
+    const R extends boolean,
+    const S extends false | "throw" = $NullabilityAdherenceDefault,
   >(
     primaryKey: $PropertyValueClientToWire[${objectDefIdentifier}["primaryKeyType"]],
     options?: $SelectArg<${objectDefIdentifier}, L, R, S>,
   ) => Promise<$Result<
         ${osdkObjectIdentifier}<
-        (S extends false ? "$notStrict" : "$strict") | ($DefaultToFalse<R> extends false?never: "$rid"),
+        (S extends false ? "$notStrict" : never) | ($DefaultToFalse<R> extends false?never: "$rid"),
         L
       >
    >> 
@@ -2046,29 +2048,29 @@ readonly fetchOneWithErrors: <
 ` : ""}
 
 readonly fetchPage: <
-  L extends ${propertyKeysIdentifier},
-  R extends boolean,
-  const A extends $Augments,
-  S extends $NullabilityAdherence = $NullabilityAdherenceDefault,
+  const L extends ${propertyKeysIdentifier},
+  const R extends boolean,
+  const const A extends $Augments,
+  const S extends $NullabilityAdherence = $NullabilityAdherenceDefault,
 >(
   args?: $FetchPageArgs<${objectDefIdentifier}, L, R, A, S>,
 ) => Promise<
   $PageResult<${osdkObjectIdentifier}<
-    (S extends false ? "$notStrict" : "$strict") | ($DefaultToFalse<R> extends false? never: "$rid"),
+    (S extends false ? "$notStrict" : never) | ($DefaultToFalse<R> extends false? never: "$rid"),
     L
   >>
 >;
 
 readonly fetchPageWithErrors: <
-  L extends ${propertyKeysIdentifier},
-  R extends boolean,
+  const L extends ${propertyKeysIdentifier},
+  const R extends boolean,
   const A extends $Augments,
-  S extends $NullabilityAdherence = $NullabilityAdherenceDefault,
+  const S extends $NullabilityAdherence = $NullabilityAdherenceDefault,
 >(
   args?: $FetchPageArgs<${objectDefIdentifier}, L, R, A, S>,
 ) => Promise<$Result<
  $PageResult<${osdkObjectIdentifier}<
- (S extends false ? "$notStrict" : "$strict") | ($DefaultToFalse<R> extends false? never : "$rid"),
+ (S extends false ? "$notStrict" : never) | ($DefaultToFalse<R> extends false? never : "$rid"),
  L>>
  >>;
 
@@ -2189,9 +2191,9 @@ async function generatePerActionDataFiles({
               return JSON.stringify(type);
             } else if (type.type === "object") {
               const obj = enhancedOntology.requireObjectType(type.object);
-              return `ObjectActionDataType<"${obj.fullApiName}", ${obj.getImportedDefinitionIdentifier(true)}>`;
+              return `ObjectActionDataType<"${obj.fullApiName}", ${obj.getImportedDefinitionIdentifier(true)}.Definition>`;
             } else if (type.type === "objectSet") {
-              return `ObjectSetActionDataType<"${type.objectSet}", ${getObjectDefIdentifier(type.objectSet, true)}>`;
+              return `ObjectSetActionDataType<"${type.objectSet}", ${getObjectDefIdentifier(type.objectSet, true)}.Definition>`;
             }
             return void 0;
           }
@@ -2204,9 +2206,9 @@ async function generatePerActionDataFiles({
       if (typeof input === "string") {
         return `ActionParam.PrimitiveType<${JSON.stringify(input)}>`;
       } else if (input.type === "object") {
-        return `ActionParam.ObjectType<${enhancedOntology.requireObjectType(input.object).getImportedDefinitionIdentifier(true)}>`;
+        return `ActionParam.ObjectType<${enhancedOntology.requireObjectType(input.object).getImportedDefinitionIdentifier(true)}.Definition>`;
       } else if (input.type === "objectSet") {
-        return `ActionParam.ObjectSetType<${enhancedOntology.requireObjectType(input.objectSet).getImportedDefinitionIdentifier(true)}>`;
+        return `ActionParam.ObjectSetType<${enhancedOntology.requireObjectType(input.objectSet).getImportedDefinitionIdentifier(true)}.Definition>`;
       }
     }
     function createV2Types() {
@@ -2217,7 +2219,7 @@ async function generatePerActionDataFiles({
             ${createParamsDef()}
 
             ${getDescriptionIfPresent(action.description)}
-            export interface Parameters {
+            export interface Params {
               ${stringify(parameters, {
         "*": (ogValue, _, ogKey) => {
           const key = `${getDescriptionIfPresent(ogValue.description)}
@@ -2227,10 +2229,12 @@ async function generatePerActionDataFiles({
         }
       })}
             }
+            /** @deprecated **/
+            export type Parameters = Params;
 
 
               // Represents the definition of the action
-              export interface Definition extends ActionDefinition<"${action.shortApiName}", ${uniqueApiNamesString}, ${action.shortApiName}>, VersionBound<$ExpectedClientVersion> {
+              export interface Definition extends ActionDefinition<"${action.shortApiName}", ${uniqueApiNamesString}, ${action.shortApiName}.Signatures>, VersionBound<$ExpectedClientVersion> {
               ${Object.entries(actionDefSansParameters).sort((a, b) => a[0].localeCompare(b[0])).map(([key, value]) => {
         return `${key}: ${JSON.stringify(value)};`;
       }).join("\n")}
@@ -2239,9 +2243,11 @@ async function generatePerActionDataFiles({
             }
 
             // Represents a fqn of the action
-            export interface Signature {
+            export interface Signatures {
               ${getDescriptionIfPresent(action.description)}
-               <P extends ${action.paramsIdentifier} | ReadonlyArray<${action.paramsIdentifier}>, OP extends (P extends  ReadonlyArray<${action.paramsIdentifier}> ? ApplyBatchActionOptions: ApplyActionOptions)>(args: P, options?: OP): Promise<ActionReturnTypeForOptions<OP>>;
+              applyAction<P extends ${action.paramsIdentifier}, OP extends ApplyActionOptions>(args: P, options?: OP): Promise<ActionReturnTypeForOptions<OP>>;
+           
+              batchApplyAction<P extends ReadonlyArray<${action.paramsIdentifier}>, OP extends ApplyBatchActionOptions>(args: P, options?: OP): Promise<ActionReturnTypeForOptions<OP>>;
             }
   
           }
@@ -2252,7 +2258,7 @@ async function generatePerActionDataFiles({
           export type ${oldParamsIdentifier} = ${action.paramsIdentifier} | ReadonlyArray<${action.paramsIdentifier}>;
 
           /** @deprecated Use \`${action.definitionIdentifier}\` **/
-          export type ${action.shortApiName} = ${action.shortApiName}.Signature;
+          export type ${action.shortApiName} = ${action.shortApiName}.Signatures;
           `;
     }
     function createV2Object() {