@osdk/client 2.1.0-beta.9 → 2.1.0

package/build/browser/object/convertWireToOsdkObjects/getDollarLink.js

@@ -13,48 +13,25 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 import { getWireObjectSet } from "../../objectSet/createObjectSet.js";
 import { fetchSingle, fetchSingleWithErrors } from "../fetchSingle.js";
-import { ClientRef, ObjectDefRef, RawObject } from "./InternalSymbols.js";
+import { ClientRef, ObjectDefRef, UnderlyingOsdkObject } from "./InternalSymbols.js";
 /** @internal */
 export function get$link(holder) {
-  return new Proxy(holder, DollarLinkProxyHandler);
-}
-const DollarLinkProxyHandler = {
-  get(target, p) {
-    const {
-      [ObjectDefRef]: objDef,
-      [ClientRef]: client,
-      [RawObject]: rawObj
-    } = target;
-    const linkDef = objDef.links[p];
-    if (linkDef == null) {
-      return;
-    }
+  const client = holder[ClientRef];
+  const objDef = holder[ObjectDefRef];
+  const rawObj = holder[UnderlyingOsdkObject];
+  return Object.freeze(Object.fromEntries(Object.keys(objDef.links).map(linkName => {
+    const linkDef = objDef.links[linkName];
     const objectSet = client.objectSetFactory(objDef, client).where({
       [objDef.primaryKeyApiName]: rawObj.$primaryKey
-    }).pivotTo(p);
-    if (!linkDef.multiplicity) {
-      return {
-        fetchOne: options => fetchSingle(client, objDef, options ?? {}, getWireObjectSet(objectSet)),
-        fetchOneWithErrors: options => fetchSingleWithErrors(client, objDef, options ?? {}, getWireObjectSet(objectSet))
-      };
-    } else {
-      return objectSet;
-    }
-  },
-  ownKeys(target) {
-    return [...Object.keys(target[ObjectDefRef].links)];
-  },
-  getOwnPropertyDescriptor(target, p) {
-    if (target[ObjectDefRef].links[p]) {
-      return {
-        enumerable: true,
-        configurable: true,
-        // fixme
-        writable: false
-      };
-    }
-  }
-};
+    }).pivotTo(linkName);
+    const value = !linkDef.multiplicity ? {
+      fetchOne: options => fetchSingle(client, objDef, options ?? {}, getWireObjectSet(objectSet)),
+      fetchOneWithErrors: options => fetchSingleWithErrors(client, objDef, options ?? {}, getWireObjectSet(objectSet))
+    } : objectSet;
+    return [linkName, value];
+  })));
+}
 //# sourceMappingURL=getDollarLink.js.map

package/build/browser/object/convertWireToOsdkObjects/getDollarLink.js.map

@@ -1 +1 @@
-{"version":3,"file":"getDollarLink.js","names":["getWireObjectSet","fetchSingle","fetchSingleWithErrors","ClientRef","ObjectDefRef","RawObject","get$link","holder","Proxy","DollarLinkProxyHandler","get","target","p","objDef","client","rawObj","linkDef","links","objectSet","objectSetFactory","where","primaryKeyApiName","$primaryKey","pivotTo","multiplicity","fetchOne","options","fetchOneWithErrors","ownKeys","Object","keys","getOwnPropertyDescriptor","enumerable","configurable","writable"],"sources":["getDollarLink.js"],"sourcesContent":["/*\n * Copyright 2024 Palantir Technologies, Inc. All rights reserved.\n *\n * Licensed under the Apache License, Version 2.0 (the \"License\");\n * you may not use this file except in compliance with the License.\n * You may obtain a copy of the License at\n *\n *     http://www.apache.org/licenses/LICENSE-2.0\n *\n * Unless required by applicable law or agreed to in writing, software\n * distributed under the License is distributed on an \"AS IS\" BASIS,\n * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n * See the License for the specific language governing permissions and\n * limitations under the License.\n */\nimport { getWireObjectSet } from \"../../objectSet/createObjectSet.js\";\nimport { fetchSingle, fetchSingleWithErrors } from \"../fetchSingle.js\";\nimport { ClientRef, ObjectDefRef, RawObject } from \"./InternalSymbols.js\";\n/** @internal */\nexport function get$link(holder) {\n    return new Proxy(holder, DollarLinkProxyHandler);\n}\nconst DollarLinkProxyHandler = {\n    get(target, p) {\n        const { [ObjectDefRef]: objDef, [ClientRef]: client, [RawObject]: rawObj, } = target;\n        const linkDef = objDef.links[p];\n        if (linkDef == null) {\n            return;\n        }\n        const objectSet = client.objectSetFactory(objDef, client)\n            .where({\n            [objDef.primaryKeyApiName]: rawObj.$primaryKey,\n        })\n            .pivotTo(p);\n        if (!linkDef.multiplicity) {\n            return {\n                fetchOne: (options) => fetchSingle(client, objDef, options ?? {}, getWireObjectSet(objectSet)),\n                fetchOneWithErrors: (options) => fetchSingleWithErrors(client, objDef, options ?? {}, getWireObjectSet(objectSet)),\n            };\n        }\n        else {\n            return objectSet;\n        }\n    },\n    ownKeys(target) {\n        return [...Object.keys(target[ObjectDefRef].links)];\n    },\n    getOwnPropertyDescriptor(target, p) {\n        if (target[ObjectDefRef].links[p]) {\n            return {\n                enumerable: true,\n                configurable: true, // fixme\n                writable: false,\n            };\n        }\n    },\n};\n"],"mappings":"AAAA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA,SAASA,gBAAgB,QAAQ,oCAAoC;AACrE,SAASC,WAAW,EAAEC,qBAAqB,QAAQ,mBAAmB;AACtE,SAASC,SAAS,EAAEC,YAAY,EAAEC,SAAS,QAAQ,sBAAsB;AACzE;AACA,OAAO,SAASC,QAAQA,CAACC,MAAM,EAAE;EAC7B,OAAO,IAAIC,KAAK,CAACD,MAAM,EAAEE,sBAAsB,CAAC;AACpD;AACA,MAAMA,sBAAsB,GAAG;EAC3BC,GAAGA,CAACC,MAAM,EAAEC,CAAC,EAAE;IACX,MAAM;MAAE,CAACR,YAAY,GAAGS,MAAM;MAAE,CAACV,SAAS,GAAGW,MAAM;MAAE,CAACT,SAAS,GAAGU;IAAQ,CAAC,GAAGJ,MAAM;IACpF,MAAMK,OAAO,GAAGH,MAAM,CAACI,KAAK,CAACL,CAAC,CAAC;IAC/B,IAAII,OAAO,IAAI,IAAI,EAAE;MACjB;IACJ;IACA,MAAME,SAAS,GAAGJ,MAAM,CAACK,gBAAgB,CAACN,MAAM,EAAEC,MAAM,CAAC,CACpDM,KAAK,CAAC;MACP,CAACP,MAAM,CAACQ,iBAAiB,GAAGN,MAAM,CAACO;IACvC,CAAC,CAAC,CACGC,OAAO,CAACX,CAAC,CAAC;IACf,IAAI,CAACI,OAAO,CAACQ,YAAY,EAAE;MACvB,OAAO;QACHC,QAAQ,EAAGC,OAAO,IAAKzB,WAAW,CAACa,MAAM,EAAED,MAAM,EAAEa,OAAO,IAAI,CAAC,CAAC,EAAE1B,gBAAgB,CAACkB,SAAS,CAAC,CAAC;QAC9FS,kBAAkB,EAAGD,OAAO,IAAKxB,qBAAqB,CAACY,MAAM,EAAED,MAAM,EAAEa,OAAO,IAAI,CAAC,CAAC,EAAE1B,gBAAgB,CAACkB,SAAS,CAAC;MACrH,CAAC;IACL,CAAC,MACI;MACD,OAAOA,SAAS;IACpB;EACJ,CAAC;EACDU,OAAOA,CAACjB,MAAM,EAAE;IACZ,OAAO,CAAC,GAAGkB,MAAM,CAACC,IAAI,CAACnB,MAAM,CAACP,YAAY,CAAC,CAACa,KAAK,CAAC,CAAC;EACvD,CAAC;EACDc,wBAAwBA,CAACpB,MAAM,EAAEC,CAAC,EAAE;IAChC,IAAID,MAAM,CAACP,YAAY,CAAC,CAACa,KAAK,CAACL,CAAC,CAAC,EAAE;MAC/B,OAAO;QACHoB,UAAU,EAAE,IAAI;QAChBC,YAAY,EAAE,IAAI;QAAE;QACpBC,QAAQ,EAAE;MACd,CAAC;IACL;EACJ;AACJ,CAAC","ignoreList":[]}
+{"version":3,"file":"getDollarLink.js","names":["getWireObjectSet","fetchSingle","fetchSingleWithErrors","ClientRef","ObjectDefRef","UnderlyingOsdkObject","get$link","holder","client","objDef","rawObj","Object","freeze","fromEntries","keys","links","map","linkName","linkDef","objectSet","objectSetFactory","where","primaryKeyApiName","$primaryKey","pivotTo","value","multiplicity","fetchOne","options","fetchOneWithErrors"],"sources":["getDollarLink.ts"],"sourcesContent":["/*\n * Copyright 2024 Palantir Technologies, Inc. All rights reserved.\n *\n * Licensed under the Apache License, Version 2.0 (the \"License\");\n * you may not use this file except in compliance with the License.\n * You may obtain a copy of the License at\n *\n *     http://www.apache.org/licenses/LICENSE-2.0\n *\n * Unless required by applicable law or agreed to in writing, software\n * distributed under the License is distributed on an \"AS IS\" BASIS,\n * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n * See the License for the specific language governing permissions and\n * limitations under the License.\n */\n\nimport type {\n  ObjectSet,\n  ObjectTypeDefinition,\n  OsdkObjectLinksObject,\n  SelectArg,\n  WhereClause,\n} from \"@osdk/api\";\nimport { getWireObjectSet } from \"../../objectSet/createObjectSet.js\";\nimport { fetchSingle, fetchSingleWithErrors } from \"../fetchSingle.js\";\nimport {\n  ClientRef,\n  ObjectDefRef,\n  UnderlyingOsdkObject,\n} from \"./InternalSymbols.js\";\nimport type { ObjectHolder } from \"./ObjectHolder.js\";\n\n/** @internal */\nexport function get$link(\n  holder: ObjectHolder<any>,\n): OsdkObjectLinksObject<any> {\n  const client = holder[ClientRef];\n  const objDef = holder[ObjectDefRef];\n  const rawObj = holder[UnderlyingOsdkObject];\n  return Object.freeze(Object.fromEntries(\n    Object.keys(objDef.links).map(\n      (linkName) => {\n        const linkDef = objDef.links[linkName as keyof typeof objDef.links];\n        const objectSet =\n          (client.objectSetFactory(objDef, client) as ObjectSet<any>)\n            .where({\n              [objDef.primaryKeyApiName]: rawObj.$primaryKey,\n            } as WhereClause<ObjectTypeDefinition>)\n            .pivotTo(linkName);\n\n        const value = !linkDef.multiplicity\n          ? {\n            fetchOne: <A extends SelectArg<any>>(options?: A) =>\n              fetchSingle(\n                client,\n                objDef,\n                options ?? {},\n                getWireObjectSet(objectSet),\n              ),\n            fetchOneWithErrors: <A extends SelectArg<any>>(options?: A) =>\n              fetchSingleWithErrors(\n                client,\n                objDef,\n                options ?? {},\n                getWireObjectSet(objectSet),\n              ),\n          }\n          : objectSet;\n\n        return [linkName, value];\n      },\n    ),\n  ));\n}\n"],"mappings":"AAAA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;;AASA,SAASA,gBAAgB,QAAQ,oCAAoC;AACrE,SAASC,WAAW,EAAEC,qBAAqB,QAAQ,mBAAmB;AACtE,SACEC,SAAS,EACTC,YAAY,EACZC,oBAAoB,QACf,sBAAsB;AAG7B;AACA,OAAO,SAASC,QAAQA,CACtBC,MAAyB,EACG;EAC5B,MAAMC,MAAM,GAAGD,MAAM,CAACJ,SAAS,CAAC;EAChC,MAAMM,MAAM,GAAGF,MAAM,CAACH,YAAY,CAAC;EACnC,MAAMM,MAAM,GAAGH,MAAM,CAACF,oBAAoB,CAAC;EAC3C,OAAOM,MAAM,CAACC,MAAM,CAACD,MAAM,CAACE,WAAW,CACrCF,MAAM,CAACG,IAAI,CAACL,MAAM,CAACM,KAAK,CAAC,CAACC,GAAG,CAC1BC,QAAQ,IAAK;IACZ,MAAMC,OAAO,GAAGT,MAAM,CAACM,KAAK,CAACE,QAAQ,CAA8B;IACnE,MAAME,SAAS,GACZX,MAAM,CAACY,gBAAgB,CAACX,MAAM,EAAED,MAAM,CAAC,CACrCa,KAAK,CAAC;MACL,CAACZ,MAAM,CAACa,iBAAiB,GAAGZ,MAAM,CAACa;IACrC,CAAsC,CAAC,CACtCC,OAAO,CAACP,QAAQ,CAAC;IAEtB,MAAMQ,KAAK,GAAG,CAACP,OAAO,CAACQ,YAAY,GAC/B;MACAC,QAAQ,EAA6BC,OAAW,IAC9C3B,WAAW,CACTO,MAAM,EACNC,MAAM,EACNmB,OAAO,IAAI,CAAC,CAAC,EACb5B,gBAAgB,CAACmB,SAAS,CAC5B,CAAC;MACHU,kBAAkB,EAA6BD,OAAW,IACxD1B,qBAAqB,CACnBM,MAAM,EACNC,MAAM,EACNmB,OAAO,IAAI,CAAC,CAAC,EACb5B,gBAAgB,CAACmB,SAAS,CAC5B;IACJ,CAAC,GACCA,SAAS;IAEb,OAAO,CAACF,QAAQ,EAAEQ,KAAK,CAAC;EAC1B,CACF,CACF,CAAC,CAAC;AACJ","ignoreList":[]}

package/build/browser/object/convertWireToOsdkObjects.js

@@ -13,8 +13,10 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 import invariant from "tiny-invariant";
 import { createOsdkObject } from "./convertWireToOsdkObjects/createOsdkObject.js";
+
 /**
  * If interfaceApiName is not undefined, converts the instances of the
  * interface into their respective
@@ -40,6 +42,7 @@ export async function convertWireToOsdkObjects(client, objects, interfaceApiName
   for (const rawObj of objects) {
     const objectDef = await client.ontologyProvider.getObjectDefinition(rawObj.$apiName);
     !objectDef ? process.env.NODE_ENV !== "production" ? invariant(false, `Missing definition for '${rawObj.$apiName}'`) : invariant(false) : void 0;
+
     // default value for when we are checking an object
     let objProps;
     let conforming = true;
@@ -65,6 +68,45 @@ export async function convertWireToOsdkObjects(client, objects, interfaceApiName
   client.logger?.debug(`END convertWireToOsdkObjects()`);
   return ret;
 }
+
+/**
+ * @internal
+ */
+export async function convertWireToOsdkObjects2(client, objects, interfaceApiName, forceRemoveRid = false, selectedProps, strictNonNull = false, interfaceToObjectTypeMappings = {}) {
+  client.logger?.debug(`START convertWireToOsdkObjects2()`);
+  fixObjectPropertiesInPlace(objects, forceRemoveRid);
+  const ret = [];
+  for (const rawObj of objects) {
+    const objectDef = await client.ontologyProvider.getObjectDefinition(rawObj.$apiName);
+    !objectDef ? process.env.NODE_ENV !== "production" ? invariant(false, `Missing definition for '${rawObj.$apiName}'`) : invariant(false) : void 0;
+    const interfaceToObjMapping = interfaceApiName ? interfaceToObjectTypeMappings[interfaceApiName][rawObj.$apiName] : undefined;
+    const ifaceSelected = interfaceApiName && interfaceToObjMapping ? selectedProps ? Object.keys(interfaceToObjMapping).filter(val => {
+      selectedProps?.includes(interfaceToObjMapping[val]);
+    }) : [...Object.values(interfaceToObjMapping), objectDef.primaryKeyApiName] : undefined;
+
+    // default value for when we are checking an object
+    let objProps;
+    let conforming = true;
+    if (interfaceApiName && ifaceSelected) {
+      invariantInterfacesAsViews(objectDef, interfaceApiName, client);
+      objProps = ifaceSelected;
+    } else {
+      objProps = selectedProps ?? Object.keys(objectDef.properties);
+    }
+    conforming &&= isConforming(client, objectDef, rawObj, objProps);
+    if (strictNonNull === "throw" && !conforming) {
+      throw new Error("Unable to safely convert objects as some non nullable properties are null");
+    } else if (strictNonNull === "drop" && !conforming) {
+      continue;
+    }
+    let osdkObject = createOsdkObject(client, objectDef, rawObj);
+    if (interfaceApiName) osdkObject = osdkObject.$as(interfaceApiName);
+    ret.push(osdkObject);
+  }
+  client.logger?.debug(`END convertWireToOsdkObjects2()`);
+  return ret;
+}
+
 /**
  * Utility function that lets us take down selected property names from an interface
  * and convert them to an array of property names on an object.
@@ -72,6 +114,7 @@ export async function convertWireToOsdkObjects(client, objects, interfaceApiName
 function convertInterfacePropNamesToObjectPropNames(objectDef, interfaceApiName, ifacePropsToMap) {
   return ifacePropsToMap.map(ifaceProp => objectDef.interfaceMap[interfaceApiName][ifaceProp]);
 }
+
 /**
  * Takes a raw object from the wire (contextually as an interface) and
  * updates the fields to reflect the underlying objectDef instead
@@ -133,14 +176,18 @@ function fixObjectPropertiesInPlace(objs, forceRemoveRid) {
       obj.$rid = obj.__rid;
       delete obj.__rid;
     }
+
     // Backend returns as __apiName but we want to stick to $ structure
-    obj.$apiName = obj.__apiName;
+    obj.$apiName ??= obj.__apiName;
+
     // for now these are the same but when we start doing interface projections the $objectType will always be underlying and
     // the $apiName will be for the current view (in current designs)
-    obj.$objectType = obj.__apiName;
+    obj.$objectType = obj.$apiName;
+
     // copying over for now as its always returned. In the future, this should just be inferred from underlying
-    obj.$primaryKey = obj.__primaryKey;
-    obj.$title = obj.__title;
+    obj.$primaryKey ??= obj.__primaryKey;
+    obj.$title ??= obj.__title;
+
     // we don't want people to use these
     delete obj.__apiName;
     delete obj.__primaryKey;

package/build/browser/object/convertWireToOsdkObjects.js.map

@@ -1 +1 @@
-{"version":3,"file":"convertWireToOsdkObjects.js","names":["invariant","createOsdkObject","convertWireToOsdkObjects","client","objects","interfaceApiName","forceRemoveRid","selectedProps","strictNonNull","logger","debug","fixObjectPropertiesInPlace","ifaceDef","ontologyProvider","getInterfaceDefinition","undefined","ifaceSelected","Object","keys","properties","ret","rawObj","objectDef","getObjectDefinition","$apiName","process","env","NODE_ENV","objProps","conforming","invariantInterfacesAsViews","apiName","isConforming","reframeAsObjectInPlace","convertInterfacePropNamesToObjectPropNames","Error","osdkObject","$as","push","ifacePropsToMap","map","ifaceProp","interfaceMap","newProps","sptProp","regularProp","entries","value","assign","primaryKeyApiName","$primaryKey","def","obj","propsToCheck","propName","nullable","$objectType","warning","warn","console","error","objs","__rid","$rid","__apiName","__primaryKey","$title","__title"],"sources":["convertWireToOsdkObjects.js"],"sourcesContent":["/*\n * Copyright 2023 Palantir Technologies, Inc. All rights reserved.\n *\n * Licensed under the Apache License, Version 2.0 (the \"License\");\n * you may not use this file except in compliance with the License.\n * You may obtain a copy of the License at\n *\n *     http://www.apache.org/licenses/LICENSE-2.0\n *\n * Unless required by applicable law or agreed to in writing, software\n * distributed under the License is distributed on an \"AS IS\" BASIS,\n * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n * See the License for the specific language governing permissions and\n * limitations under the License.\n */\nimport invariant from \"tiny-invariant\";\nimport { createOsdkObject } from \"./convertWireToOsdkObjects/createOsdkObject.js\";\n/**\n * If interfaceApiName is not undefined, converts the instances of the\n * interface into their respective\n * underlying concrete types and then returns the $as() representation\n * for the consumers.\n *\n * Otherwise just does the conversion\n *\n * May mutate in place for performance reasons. If you need a clean copy,\n * keep it first.\n *\n * However, you must use the returned value, which will be whatever is correct.\n *\n * @internal\n * @param interfaceApiName - if undefined\n */\nexport async function convertWireToOsdkObjects(client, objects, interfaceApiName, forceRemoveRid = false, selectedProps, strictNonNull = false) {\n    client.logger?.debug(`START convertWireToOsdkObjects()`);\n    fixObjectPropertiesInPlace(objects, forceRemoveRid);\n    const ifaceDef = interfaceApiName\n        ? await client.ontologyProvider.getInterfaceDefinition(interfaceApiName)\n        : undefined;\n    const ifaceSelected = ifaceDef\n        ? (selectedProps ?? Object.keys(ifaceDef.properties))\n        : undefined;\n    const ret = [];\n    for (const rawObj of objects) {\n        const objectDef = await client.ontologyProvider.getObjectDefinition(rawObj.$apiName);\n        invariant(objectDef, `Missing definition for '${rawObj.$apiName}'`);\n        // default value for when we are checking an object\n        let objProps;\n        let conforming = true;\n        if (ifaceDef && ifaceSelected) {\n            // API returns interface spt names but we cache by real values\n            invariantInterfacesAsViews(objectDef, ifaceDef.apiName, client);\n            conforming &&= isConforming(client, ifaceDef, rawObj, ifaceSelected);\n            reframeAsObjectInPlace(objectDef, ifaceDef.apiName, rawObj);\n            objProps = convertInterfacePropNamesToObjectPropNames(objectDef, ifaceDef.apiName, ifaceSelected);\n        }\n        else {\n            objProps = selectedProps ?? Object.keys(objectDef.properties);\n        }\n        conforming &&= isConforming(client, objectDef, rawObj, objProps);\n        if (strictNonNull === \"throw\" && !conforming) {\n            throw new Error(\"Unable to safely convert objects as some non nullable properties are null\");\n        }\n        else if (strictNonNull === \"drop\" && !conforming) {\n            continue;\n        }\n        let osdkObject = createOsdkObject(client, objectDef, rawObj);\n        if (interfaceApiName)\n            osdkObject = osdkObject.$as(interfaceApiName);\n        ret.push(osdkObject);\n    }\n    client.logger?.debug(`END convertWireToOsdkObjects()`);\n    return ret;\n}\n/**\n * Utility function that lets us take down selected property names from an interface\n * and convert them to an array of property names on an object.\n */\nfunction convertInterfacePropNamesToObjectPropNames(objectDef, interfaceApiName, ifacePropsToMap) {\n    return ifacePropsToMap.map((ifaceProp) => objectDef.interfaceMap[interfaceApiName][ifaceProp]);\n}\n/**\n * Takes a raw object from the wire (contextually as an interface) and\n * updates the fields to reflect the underlying objectDef instead\n * @param objectDef\n * @param interfaceApiName\n * @param client\n * @param rawObj\n */\nfunction reframeAsObjectInPlace(objectDef, interfaceApiName, rawObj) {\n    const newProps = {};\n    for (const [sptProp, regularProp] of Object.entries(objectDef.interfaceMap[interfaceApiName])) {\n        if (sptProp in rawObj) {\n            const value = rawObj[sptProp];\n            delete rawObj[sptProp];\n            if (value !== undefined) {\n                newProps[regularProp] = value;\n            }\n        }\n    }\n    Object.assign(rawObj, newProps);\n    if (!(objectDef.primaryKeyApiName in rawObj)) {\n        rawObj[objectDef.primaryKeyApiName] = rawObj.$primaryKey;\n    }\n}\nfunction isConforming(client, def, obj, propsToCheck) {\n    for (const propName of propsToCheck) {\n        if (def.properties[propName].nullable === false && obj[propName] == null) {\n            if (process.env.NODE_ENV !== \"production\") {\n                client.logger?.debug({\n                    obj: {\n                        $objectType: obj[\"$objectType\"],\n                        $primaryKey: obj[\"$primaryKey\"],\n                    },\n                }, `Found object that does not conform to its definition. Expected ${def.apiName}'s ${propName} to not be null.`);\n            }\n            return false;\n        }\n    }\n    return true;\n}\nfunction invariantInterfacesAsViews(objectDef, interfaceApiName, client) {\n    if (objectDef.interfaceMap?.[interfaceApiName] == null) {\n        const warning = \"Interfaces are only supported 'as views' but your metadata object is missing the correct information. This suggests your interfaces have not been migrated to the newer version yet and you cannot use this version of the SDK.\";\n        if (client.logger) {\n            client.logger.warn(warning);\n        }\n        else {\n            // eslint-disable-next-line no-console\n            console.error(`WARNING! ${warning}`);\n        }\n        throw new Error(warning);\n    }\n}\nfunction fixObjectPropertiesInPlace(objs, forceRemoveRid) {\n    for (const obj of objs) {\n        if (forceRemoveRid) {\n            delete obj.__rid;\n        }\n        if (obj.__rid) {\n            obj.$rid = obj.__rid;\n            delete obj.__rid;\n        }\n        // Backend returns as __apiName but we want to stick to $ structure\n        obj.$apiName = obj.__apiName;\n        // for now these are the same but when we start doing interface projections the $objectType will always be underlying and\n        // the $apiName will be for the current view (in current designs)\n        obj.$objectType = obj.__apiName;\n        // copying over for now as its always returned. In the future, this should just be inferred from underlying\n        obj.$primaryKey = obj.__primaryKey;\n        obj.$title = obj.__title;\n        // we don't want people to use these\n        delete obj.__apiName;\n        delete obj.__primaryKey;\n        delete obj.__title;\n    }\n}\n"],"mappings":"AAAA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA,OAAOA,SAAS,MAAM,gBAAgB;AACtC,SAASC,gBAAgB,QAAQ,gDAAgD;AACjF;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA,OAAO,eAAeC,wBAAwBA,CAACC,MAAM,EAAEC,OAAO,EAAEC,gBAAgB,EAAEC,cAAc,GAAG,KAAK,EAAEC,aAAa,EAAEC,aAAa,GAAG,KAAK,EAAE;EAC5IL,MAAM,CAACM,MAAM,EAAEC,KAAK,CAAC,kCAAkC,CAAC;EACxDC,0BAA0B,CAACP,OAAO,EAAEE,cAAc,CAAC;EACnD,MAAMM,QAAQ,GAAGP,gBAAgB,GAC3B,MAAMF,MAAM,CAACU,gBAAgB,CAACC,sBAAsB,CAACT,gBAAgB,CAAC,GACtEU,SAAS;EACf,MAAMC,aAAa,GAAGJ,QAAQ,GACvBL,aAAa,IAAIU,MAAM,CAACC,IAAI,CAACN,QAAQ,CAACO,UAAU,CAAC,GAClDJ,SAAS;EACf,MAAMK,GAAG,GAAG,EAAE;EACd,KAAK,MAAMC,MAAM,IAAIjB,OAAO,EAAE;IAC1B,MAAMkB,SAAS,GAAG,MAAMnB,MAAM,CAACU,gBAAgB,CAACU,mBAAmB,CAACF,MAAM,CAACG,QAAQ,CAAC;IACpF,CAAUF,SAAS,GAAAG,OAAA,CAAAC,GAAA,CAAAC,QAAA,oBAAnB3B,SAAS,QAAY,2BAA2BqB,MAAM,CAACG,QAAQ,GAAG,IAAlExB,SAAS;IACT;IACA,IAAI4B,QAAQ;IACZ,IAAIC,UAAU,GAAG,IAAI;IACrB,IAAIjB,QAAQ,IAAII,aAAa,EAAE;MAC3B;MACAc,0BAA0B,CAACR,SAAS,EAAEV,QAAQ,CAACmB,OAAO,EAAE5B,MAAM,CAAC;MAC/D0B,UAAU,KAAKG,YAAY,CAAC7B,MAAM,EAAES,QAAQ,EAAES,MAAM,EAAEL,aAAa,CAAC;MACpEiB,sBAAsB,CAACX,SAAS,EAAEV,QAAQ,CAACmB,OAAO,EAAEV,MAAM,CAAC;MAC3DO,QAAQ,GAAGM,0CAA0C,CAACZ,SAAS,EAAEV,QAAQ,CAACmB,OAAO,EAAEf,aAAa,CAAC;IACrG,CAAC,MACI;MACDY,QAAQ,GAAGrB,aAAa,IAAIU,MAAM,CAACC,IAAI,CAACI,SAAS,CAACH,UAAU,CAAC;IACjE;IACAU,UAAU,KAAKG,YAAY,CAAC7B,MAAM,EAAEmB,SAAS,EAAED,MAAM,EAAEO,QAAQ,CAAC;IAChE,IAAIpB,aAAa,KAAK,OAAO,IAAI,CAACqB,UAAU,EAAE;MAC1C,MAAM,IAAIM,KAAK,CAAC,2EAA2E,CAAC;IAChG,CAAC,MACI,IAAI3B,aAAa,KAAK,MAAM,IAAI,CAACqB,UAAU,EAAE;MAC9C;IACJ;IACA,IAAIO,UAAU,GAAGnC,gBAAgB,CAACE,MAAM,EAAEmB,SAAS,EAAED,MAAM,CAAC;IAC5D,IAAIhB,gBAAgB,EAChB+B,UAAU,GAAGA,UAAU,CAACC,GAAG,CAAChC,gBAAgB,CAAC;IACjDe,GAAG,CAACkB,IAAI,CAACF,UAAU,CAAC;EACxB;EACAjC,MAAM,CAACM,MAAM,EAAEC,KAAK,CAAC,gCAAgC,CAAC;EACtD,OAAOU,GAAG;AACd;AACA;AACA;AACA;AACA;AACA,SAASc,0CAA0CA,CAACZ,SAAS,EAAEjB,gBAAgB,EAAEkC,eAAe,EAAE;EAC9F,OAAOA,eAAe,CAACC,GAAG,CAAEC,SAAS,IAAKnB,SAAS,CAACoB,YAAY,CAACrC,gBAAgB,CAAC,CAACoC,SAAS,CAAC,CAAC;AAClG;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA,SAASR,sBAAsBA,CAACX,SAAS,EAAEjB,gBAAgB,EAAEgB,MAAM,EAAE;EACjE,MAAMsB,QAAQ,GAAG,CAAC,CAAC;EACnB,KAAK,MAAM,CAACC,OAAO,EAAEC,WAAW,CAAC,IAAI5B,MAAM,CAAC6B,OAAO,CAACxB,SAAS,CAACoB,YAAY,CAACrC,gBAAgB,CAAC,CAAC,EAAE;IAC3F,IAAIuC,OAAO,IAAIvB,MAAM,EAAE;MACnB,MAAM0B,KAAK,GAAG1B,MAAM,CAACuB,OAAO,CAAC;MAC7B,OAAOvB,MAAM,CAACuB,OAAO,CAAC;MACtB,IAAIG,KAAK,KAAKhC,SAAS,EAAE;QACrB4B,QAAQ,CAACE,WAAW,CAAC,GAAGE,KAAK;MACjC;IACJ;EACJ;EACA9B,MAAM,CAAC+B,MAAM,CAAC3B,MAAM,EAAEsB,QAAQ,CAAC;EAC/B,IAAI,EAAErB,SAAS,CAAC2B,iBAAiB,IAAI5B,MAAM,CAAC,EAAE;IAC1CA,MAAM,CAACC,SAAS,CAAC2B,iBAAiB,CAAC,GAAG5B,MAAM,CAAC6B,WAAW;EAC5D;AACJ;AACA,SAASlB,YAAYA,CAAC7B,MAAM,EAAEgD,GAAG,EAAEC,GAAG,EAAEC,YAAY,EAAE;EAClD,KAAK,MAAMC,QAAQ,IAAID,YAAY,EAAE;IACjC,IAAIF,GAAG,CAAChC,UAAU,CAACmC,QAAQ,CAAC,CAACC,QAAQ,KAAK,KAAK,IAAIH,GAAG,CAACE,QAAQ,CAAC,IAAI,IAAI,EAAE;MACtE,IAAI7B,OAAO,CAACC,GAAG,CAACC,QAAQ,KAAK,YAAY,EAAE;QACvCxB,MAAM,CAACM,MAAM,EAAEC,KAAK,CAAC;UACjB0C,GAAG,EAAE;YACDI,WAAW,EAAEJ,GAAG,CAAC,aAAa,CAAC;YAC/BF,WAAW,EAAEE,GAAG,CAAC,aAAa;UAClC;QACJ,CAAC,EAAE,kEAAkED,GAAG,CAACpB,OAAO,MAAMuB,QAAQ,kBAAkB,CAAC;MACrH;MACA,OAAO,KAAK;IAChB;EACJ;EACA,OAAO,IAAI;AACf;AACA,SAASxB,0BAA0BA,CAACR,SAAS,EAAEjB,gBAAgB,EAAEF,MAAM,EAAE;EACrE,IAAImB,SAAS,CAACoB,YAAY,GAAGrC,gBAAgB,CAAC,IAAI,IAAI,EAAE;IACpD,MAAMoD,OAAO,GAAG,iOAAiO;IACjP,IAAItD,MAAM,CAACM,MAAM,EAAE;MACfN,MAAM,CAACM,MAAM,CAACiD,IAAI,CAACD,OAAO,CAAC;IAC/B,CAAC,MACI;MACD;MACAE,OAAO,CAACC,KAAK,CAAC,YAAYH,OAAO,EAAE,CAAC;IACxC;IACA,MAAM,IAAItB,KAAK,CAACsB,OAAO,CAAC;EAC5B;AACJ;AACA,SAAS9C,0BAA0BA,CAACkD,IAAI,EAAEvD,cAAc,EAAE;EACtD,KAAK,MAAM8C,GAAG,IAAIS,IAAI,EAAE;IACpB,IAAIvD,cAAc,EAAE;MAChB,OAAO8C,GAAG,CAACU,KAAK;IACpB;IACA,IAAIV,GAAG,CAACU,KAAK,EAAE;MACXV,GAAG,CAACW,IAAI,GAAGX,GAAG,CAACU,KAAK;MACpB,OAAOV,GAAG,CAACU,KAAK;IACpB;IACA;IACAV,GAAG,CAAC5B,QAAQ,GAAG4B,GAAG,CAACY,SAAS;IAC5B;IACA;IACAZ,GAAG,CAACI,WAAW,GAAGJ,GAAG,CAACY,SAAS;IAC/B;IACAZ,GAAG,CAACF,WAAW,GAAGE,GAAG,CAACa,YAAY;IAClCb,GAAG,CAACc,MAAM,GAAGd,GAAG,CAACe,OAAO;IACxB;IACA,OAAOf,GAAG,CAACY,SAAS;IACpB,OAAOZ,GAAG,CAACa,YAAY;IACvB,OAAOb,GAAG,CAACe,OAAO;EACtB;AACJ","ignoreList":[]}
+{"version":3,"file":"convertWireToOsdkObjects.js","names":["invariant","createOsdkObject","convertWireToOsdkObjects","client","objects","interfaceApiName","forceRemoveRid","selectedProps","strictNonNull","logger","debug","fixObjectPropertiesInPlace","ifaceDef","ontologyProvider","getInterfaceDefinition","undefined","ifaceSelected","Object","keys","properties","ret","rawObj","objectDef","getObjectDefinition","$apiName","process","env","NODE_ENV","objProps","conforming","invariantInterfacesAsViews","apiName","isConforming","reframeAsObjectInPlace","convertInterfacePropNamesToObjectPropNames","Error","osdkObject","$as","push","convertWireToOsdkObjects2","interfaceToObjectTypeMappings","interfaceToObjMapping","filter","val","includes","values","primaryKeyApiName","ifacePropsToMap","map","ifaceProp","interfaceMap","newProps","sptProp","regularProp","entries","value","assign","$primaryKey","def","obj","propsToCheck","propName","nullable","$objectType","warning","warn","console","error","objs","__rid","$rid","__apiName","__primaryKey","$title","__title"],"sources":["convertWireToOsdkObjects.ts"],"sourcesContent":["/*\n * Copyright 2023 Palantir Technologies, Inc. All rights reserved.\n *\n * Licensed under the Apache License, Version 2.0 (the \"License\");\n * you may not use this file except in compliance with the License.\n * You may obtain a copy of the License at\n *\n *     http://www.apache.org/licenses/LICENSE-2.0\n *\n * Unless required by applicable law or agreed to in writing, software\n * distributed under the License is distributed on an \"AS IS\" BASIS,\n * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n * See the License for the specific language governing permissions and\n * limitations under the License.\n */\n\nimport type {\n  InterfaceMetadata,\n  NullabilityAdherence,\n  ObjectMetadata,\n  ObjectOrInterfaceDefinition,\n  Osdk,\n} from \"@osdk/api\";\nimport type {\n  InterfaceToObjectTypeMappings,\n  InterfaceTypeApiName,\n  OntologyObjectV2,\n} from \"@osdk/foundry.ontologies\";\nimport invariant from \"tiny-invariant\";\nimport type { MinimalClient } from \"../MinimalClientContext.js\";\nimport {\n  type FetchedObjectTypeDefinition,\n} from \"../ontology/OntologyProvider.js\";\nimport { createOsdkObject } from \"./convertWireToOsdkObjects/createOsdkObject.js\";\n\n/**\n * If interfaceApiName is not undefined, converts the instances of the\n * interface into their respective\n * underlying concrete types and then returns the $as() representation\n * for the consumers.\n *\n * Otherwise just does the conversion\n *\n * May mutate in place for performance reasons. If you need a clean copy,\n * keep it first.\n *\n * However, you must use the returned value, which will be whatever is correct.\n *\n * @internal\n * @param interfaceApiName - if undefined\n */\nexport async function convertWireToOsdkObjects(\n  client: MinimalClient,\n  objects: OntologyObjectV2[],\n  interfaceApiName: string | undefined,\n  forceRemoveRid: boolean = false,\n  selectedProps?: ReadonlyArray<string>,\n  strictNonNull: NullabilityAdherence = false,\n): Promise<Osdk.Instance<ObjectOrInterfaceDefinition>[]> {\n  client.logger?.debug(`START convertWireToOsdkObjects()`);\n\n  fixObjectPropertiesInPlace(objects, forceRemoveRid);\n\n  const ifaceDef = interfaceApiName\n    ? await client.ontologyProvider.getInterfaceDefinition(interfaceApiName)\n    : undefined;\n  const ifaceSelected = ifaceDef\n    ? (selectedProps ?? Object.keys(ifaceDef.properties))\n    : undefined;\n\n  const ret = [];\n  for (const rawObj of objects) {\n    const objectDef = await client.ontologyProvider.getObjectDefinition(\n      rawObj.$apiName,\n    );\n    invariant(objectDef, `Missing definition for '${rawObj.$apiName}'`);\n\n    // default value for when we are checking an object\n    let objProps;\n\n    let conforming = true;\n    if (ifaceDef && ifaceSelected) {\n      // API returns interface spt names but we cache by real values\n      invariantInterfacesAsViews(objectDef, ifaceDef.apiName, client);\n\n      conforming &&= isConforming(client, ifaceDef, rawObj, ifaceSelected);\n\n      reframeAsObjectInPlace(objectDef, ifaceDef.apiName, rawObj);\n\n      objProps = convertInterfacePropNamesToObjectPropNames(\n        objectDef,\n        ifaceDef.apiName,\n        ifaceSelected,\n      );\n    } else {\n      objProps = selectedProps ?? Object.keys(objectDef.properties);\n    }\n\n    conforming &&= isConforming(client, objectDef, rawObj, objProps);\n\n    if (strictNonNull === \"throw\" && !conforming) {\n      throw new Error(\n        \"Unable to safely convert objects as some non nullable properties are null\",\n      );\n    } else if (strictNonNull === \"drop\" && !conforming) {\n      continue;\n    }\n\n    let osdkObject = createOsdkObject(client, objectDef, rawObj);\n    if (interfaceApiName) osdkObject = osdkObject.$as(interfaceApiName);\n\n    ret.push(osdkObject);\n  }\n\n  client.logger?.debug(`END convertWireToOsdkObjects()`);\n  return ret;\n}\n\n/**\n * @internal\n */\nexport async function convertWireToOsdkObjects2(\n  client: MinimalClient,\n  objects: OntologyObjectV2[],\n  interfaceApiName: string | undefined,\n  forceRemoveRid: boolean = false,\n  selectedProps?: ReadonlyArray<string>,\n  strictNonNull: NullabilityAdherence = false,\n  interfaceToObjectTypeMappings: Record<\n    InterfaceTypeApiName,\n    InterfaceToObjectTypeMappings\n  > = {},\n): Promise<Osdk.Instance<ObjectOrInterfaceDefinition>[]> {\n  client.logger?.debug(`START convertWireToOsdkObjects2()`);\n\n  fixObjectPropertiesInPlace(objects, forceRemoveRid);\n\n  const ret = [];\n  for (const rawObj of objects) {\n    const objectDef = await client.ontologyProvider.getObjectDefinition(\n      rawObj.$apiName,\n    );\n    invariant(objectDef, `Missing definition for '${rawObj.$apiName}'`);\n\n    const interfaceToObjMapping = interfaceApiName\n      ? interfaceToObjectTypeMappings[interfaceApiName as InterfaceTypeApiName][\n        rawObj.$apiName\n      ]\n      : undefined;\n\n    const ifaceSelected = interfaceApiName && interfaceToObjMapping\n      ? (selectedProps\n        ? Object.keys(interfaceToObjMapping).filter(\n          val => {\n            selectedProps?.includes(interfaceToObjMapping[val]);\n          },\n        )\n        : [\n          ...Object.values(interfaceToObjMapping),\n          objectDef.primaryKeyApiName,\n        ])\n      : undefined;\n\n    // default value for when we are checking an object\n    let objProps;\n\n    let conforming = true;\n    if (interfaceApiName && ifaceSelected) {\n      invariantInterfacesAsViews(objectDef, interfaceApiName, client);\n\n      objProps = ifaceSelected;\n    } else {\n      objProps = selectedProps ?? Object.keys(objectDef.properties);\n    }\n\n    conforming &&= isConforming(client, objectDef, rawObj, objProps);\n\n    if (strictNonNull === \"throw\" && !conforming) {\n      throw new Error(\n        \"Unable to safely convert objects as some non nullable properties are null\",\n      );\n    } else if (strictNonNull === \"drop\" && !conforming) {\n      continue;\n    }\n\n    let osdkObject = createOsdkObject(client, objectDef, rawObj);\n    if (interfaceApiName) osdkObject = osdkObject.$as(interfaceApiName);\n\n    ret.push(osdkObject);\n  }\n\n  client.logger?.debug(`END convertWireToOsdkObjects2()`);\n  return ret;\n}\n\n/**\n * Utility function that lets us take down selected property names from an interface\n * and convert them to an array of property names on an object.\n */\nfunction convertInterfacePropNamesToObjectPropNames(\n  objectDef: FetchedObjectTypeDefinition & { interfaceMap: {} },\n  interfaceApiName: string,\n  ifacePropsToMap: readonly string[],\n) {\n  return ifacePropsToMap.map((ifaceProp) =>\n    objectDef.interfaceMap[interfaceApiName][ifaceProp]\n  );\n}\n\n/**\n * Takes a raw object from the wire (contextually as an interface) and\n * updates the fields to reflect the underlying objectDef instead\n * @param objectDef\n * @param interfaceApiName\n * @param client\n * @param rawObj\n */\nfunction reframeAsObjectInPlace(\n  objectDef: FetchedObjectTypeDefinition & { interfaceMap: {} },\n  interfaceApiName: string,\n  rawObj: OntologyObjectV2,\n) {\n  const newProps: Record<string, any> = {};\n  for (\n    const [sptProp, regularProp] of Object.entries(\n      objectDef.interfaceMap[interfaceApiName],\n    )\n  ) {\n    if (sptProp in rawObj) {\n      const value = rawObj[sptProp];\n      delete rawObj[sptProp];\n      if (value !== undefined) {\n        newProps[regularProp] = value;\n      }\n    }\n  }\n  Object.assign(rawObj, newProps);\n\n  if (!(objectDef.primaryKeyApiName in rawObj)) {\n    rawObj[objectDef.primaryKeyApiName] = rawObj.$primaryKey;\n  }\n}\n\nfunction isConforming(\n  client: MinimalClient,\n  def:\n    | InterfaceMetadata\n    | ObjectMetadata,\n  obj: OntologyObjectV2,\n  propsToCheck: readonly string[],\n) {\n  for (const propName of propsToCheck) {\n    if (def.properties[propName].nullable === false && obj[propName] == null) {\n      if (process.env.NODE_ENV !== \"production\") {\n        client.logger?.debug(\n          {\n            obj: {\n              $objectType: obj[\"$objectType\"],\n              $primaryKey: obj[\"$primaryKey\"],\n            },\n          },\n          `Found object that does not conform to its definition. Expected ${def.apiName}'s ${propName} to not be null.`,\n        );\n      }\n      return false;\n    }\n  }\n  return true;\n}\n\nfunction invariantInterfacesAsViews(\n  objectDef: FetchedObjectTypeDefinition,\n  interfaceApiName: string,\n  client: MinimalClient,\n): asserts objectDef is typeof objectDef & { interfaceMap: {} } {\n  if (objectDef.interfaceMap?.[interfaceApiName] == null) {\n    const warning =\n      \"Interfaces are only supported 'as views' but your metadata object is missing the correct information. This suggests your interfaces have not been migrated to the newer version yet and you cannot use this version of the SDK.\";\n    if (client.logger) {\n      client.logger.warn(warning);\n    } else {\n      // eslint-disable-next-line no-console\n      console.error(`WARNING! ${warning}`);\n    }\n    throw new Error(warning);\n  }\n}\n\nfunction fixObjectPropertiesInPlace(\n  objs: OntologyObjectV2[],\n  forceRemoveRid: boolean,\n) {\n  for (const obj of objs) {\n    if (forceRemoveRid) {\n      delete obj.__rid;\n    }\n\n    if (obj.__rid) {\n      obj.$rid = obj.__rid;\n      delete obj.__rid;\n    }\n\n    // Backend returns as __apiName but we want to stick to $ structure\n    obj.$apiName ??= obj.__apiName;\n\n    // for now these are the same but when we start doing interface projections the $objectType will always be underlying and\n    // the $apiName will be for the current view (in current designs)\n    obj.$objectType = obj.$apiName;\n\n    // copying over for now as its always returned. In the future, this should just be inferred from underlying\n    obj.$primaryKey ??= obj.__primaryKey;\n    obj.$title ??= obj.__title;\n\n    // we don't want people to use these\n    delete obj.__apiName;\n    delete obj.__primaryKey;\n    delete obj.__title;\n  }\n}\n"],"mappings":"AAAA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;;AAcA,OAAOA,SAAS,MAAM,gBAAgB;AAKtC,SAASC,gBAAgB,QAAQ,gDAAgD;;AAEjF;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA,OAAO,eAAeC,wBAAwBA,CAC5CC,MAAqB,EACrBC,OAA2B,EAC3BC,gBAAoC,EACpCC,cAAuB,GAAG,KAAK,EAC/BC,aAAqC,EACrCC,aAAmC,GAAG,KAAK,EACY;EACvDL,MAAM,CAACM,MAAM,EAAEC,KAAK,CAAC,kCAAkC,CAAC;EAExDC,0BAA0B,CAACP,OAAO,EAAEE,cAAc,CAAC;EAEnD,MAAMM,QAAQ,GAAGP,gBAAgB,GAC7B,MAAMF,MAAM,CAACU,gBAAgB,CAACC,sBAAsB,CAACT,gBAAgB,CAAC,GACtEU,SAAS;EACb,MAAMC,aAAa,GAAGJ,QAAQ,GACzBL,aAAa,IAAIU,MAAM,CAACC,IAAI,CAACN,QAAQ,CAACO,UAAU,CAAC,GAClDJ,SAAS;EAEb,MAAMK,GAAG,GAAG,EAAE;EACd,KAAK,MAAMC,MAAM,IAAIjB,OAAO,EAAE;IAC5B,MAAMkB,SAAS,GAAG,MAAMnB,MAAM,CAACU,gBAAgB,CAACU,mBAAmB,CACjEF,MAAM,CAACG,QACT,CAAC;IACD,CAAUF,SAAS,GAAAG,OAAA,CAAAC,GAAA,CAAAC,QAAA,oBAAnB3B,SAAS,QAAY,2BAA2BqB,MAAM,CAACG,QAAQ,GAAG,IAAlExB,SAAS;;IAET;IACA,IAAI4B,QAAQ;IAEZ,IAAIC,UAAU,GAAG,IAAI;IACrB,IAAIjB,QAAQ,IAAII,aAAa,EAAE;MAC7B;MACAc,0BAA0B,CAACR,SAAS,EAAEV,QAAQ,CAACmB,OAAO,EAAE5B,MAAM,CAAC;MAE/D0B,UAAU,KAAKG,YAAY,CAAC7B,MAAM,EAAES,QAAQ,EAAES,MAAM,EAAEL,aAAa,CAAC;MAEpEiB,sBAAsB,CAACX,SAAS,EAAEV,QAAQ,CAACmB,OAAO,EAAEV,MAAM,CAAC;MAE3DO,QAAQ,GAAGM,0CAA0C,CACnDZ,SAAS,EACTV,QAAQ,CAACmB,OAAO,EAChBf,aACF,CAAC;IACH,CAAC,MAAM;MACLY,QAAQ,GAAGrB,aAAa,IAAIU,MAAM,CAACC,IAAI,CAACI,SAAS,CAACH,UAAU,CAAC;IAC/D;IAEAU,UAAU,KAAKG,YAAY,CAAC7B,MAAM,EAAEmB,SAAS,EAAED,MAAM,EAAEO,QAAQ,CAAC;IAEhE,IAAIpB,aAAa,KAAK,OAAO,IAAI,CAACqB,UAAU,EAAE;MAC5C,MAAM,IAAIM,KAAK,CACb,2EACF,CAAC;IACH,CAAC,MAAM,IAAI3B,aAAa,KAAK,MAAM,IAAI,CAACqB,UAAU,EAAE;MAClD;IACF;IAEA,IAAIO,UAAU,GAAGnC,gBAAgB,CAACE,MAAM,EAAEmB,SAAS,EAAED,MAAM,CAAC;IAC5D,IAAIhB,gBAAgB,EAAE+B,UAAU,GAAGA,UAAU,CAACC,GAAG,CAAChC,gBAAgB,CAAC;IAEnEe,GAAG,CAACkB,IAAI,CAACF,UAAU,CAAC;EACtB;EAEAjC,MAAM,CAACM,MAAM,EAAEC,KAAK,CAAC,gCAAgC,CAAC;EACtD,OAAOU,GAAG;AACZ;;AAEA;AACA;AACA;AACA,OAAO,eAAemB,yBAAyBA,CAC7CpC,MAAqB,EACrBC,OAA2B,EAC3BC,gBAAoC,EACpCC,cAAuB,GAAG,KAAK,EAC/BC,aAAqC,EACrCC,aAAmC,GAAG,KAAK,EAC3CgC,6BAGC,GAAG,CAAC,CAAC,EACiD;EACvDrC,MAAM,CAACM,MAAM,EAAEC,KAAK,CAAC,mCAAmC,CAAC;EAEzDC,0BAA0B,CAACP,OAAO,EAAEE,cAAc,CAAC;EAEnD,MAAMc,GAAG,GAAG,EAAE;EACd,KAAK,MAAMC,MAAM,IAAIjB,OAAO,EAAE;IAC5B,MAAMkB,SAAS,GAAG,MAAMnB,MAAM,CAACU,gBAAgB,CAACU,mBAAmB,CACjEF,MAAM,CAACG,QACT,CAAC;IACD,CAAUF,SAAS,GAAAG,OAAA,CAAAC,GAAA,CAAAC,QAAA,oBAAnB3B,SAAS,QAAY,2BAA2BqB,MAAM,CAACG,QAAQ,GAAG,IAAlExB,SAAS;IAET,MAAMyC,qBAAqB,GAAGpC,gBAAgB,GAC1CmC,6BAA6B,CAACnC,gBAAgB,CAAyB,CACvEgB,MAAM,CAACG,QAAQ,CAChB,GACCT,SAAS;IAEb,MAAMC,aAAa,GAAGX,gBAAgB,IAAIoC,qBAAqB,GAC1DlC,aAAa,GACZU,MAAM,CAACC,IAAI,CAACuB,qBAAqB,CAAC,CAACC,MAAM,CACzCC,GAAG,IAAI;MACLpC,aAAa,EAAEqC,QAAQ,CAACH,qBAAqB,CAACE,GAAG,CAAC,CAAC;IACrD,CACF,CAAC,GACC,CACA,GAAG1B,MAAM,CAAC4B,MAAM,CAACJ,qBAAqB,CAAC,EACvCnB,SAAS,CAACwB,iBAAiB,CAC5B,GACD/B,SAAS;;IAEb;IACA,IAAIa,QAAQ;IAEZ,IAAIC,UAAU,GAAG,IAAI;IACrB,IAAIxB,gBAAgB,IAAIW,aAAa,EAAE;MACrCc,0BAA0B,CAACR,SAAS,EAAEjB,gBAAgB,EAAEF,MAAM,CAAC;MAE/DyB,QAAQ,GAAGZ,aAAa;IAC1B,CAAC,MAAM;MACLY,QAAQ,GAAGrB,aAAa,IAAIU,MAAM,CAACC,IAAI,CAACI,SAAS,CAACH,UAAU,CAAC;IAC/D;IAEAU,UAAU,KAAKG,YAAY,CAAC7B,MAAM,EAAEmB,SAAS,EAAED,MAAM,EAAEO,QAAQ,CAAC;IAEhE,IAAIpB,aAAa,KAAK,OAAO,IAAI,CAACqB,UAAU,EAAE;MAC5C,MAAM,IAAIM,KAAK,CACb,2EACF,CAAC;IACH,CAAC,MAAM,IAAI3B,aAAa,KAAK,MAAM,IAAI,CAACqB,UAAU,EAAE;MAClD;IACF;IAEA,IAAIO,UAAU,GAAGnC,gBAAgB,CAACE,MAAM,EAAEmB,SAAS,EAAED,MAAM,CAAC;IAC5D,IAAIhB,gBAAgB,EAAE+B,UAAU,GAAGA,UAAU,CAACC,GAAG,CAAChC,gBAAgB,CAAC;IAEnEe,GAAG,CAACkB,IAAI,CAACF,UAAU,CAAC;EACtB;EAEAjC,MAAM,CAACM,MAAM,EAAEC,KAAK,CAAC,iCAAiC,CAAC;EACvD,OAAOU,GAAG;AACZ;;AAEA;AACA;AACA;AACA;AACA,SAASc,0CAA0CA,CACjDZ,SAA6D,EAC7DjB,gBAAwB,EACxB0C,eAAkC,EAClC;EACA,OAAOA,eAAe,CAACC,GAAG,CAAEC,SAAS,IACnC3B,SAAS,CAAC4B,YAAY,CAAC7C,gBAAgB,CAAC,CAAC4C,SAAS,CACpD,CAAC;AACH;;AAEA;AACA;AACA;AACA;AACA;AACA;AACA;AACA;AACA,SAAShB,sBAAsBA,CAC7BX,SAA6D,EAC7DjB,gBAAwB,EACxBgB,MAAwB,EACxB;EACA,MAAM8B,QAA6B,GAAG,CAAC,CAAC;EACxC,KACE,MAAM,CAACC,OAAO,EAAEC,WAAW,CAAC,IAAIpC,MAAM,CAACqC,OAAO,CAC5ChC,SAAS,CAAC4B,YAAY,CAAC7C,gBAAgB,CACzC,CAAC,EACD;IACA,IAAI+C,OAAO,IAAI/B,MAAM,EAAE;MACrB,MAAMkC,KAAK,GAAGlC,MAAM,CAAC+B,OAAO,CAAC;MAC7B,OAAO/B,MAAM,CAAC+B,OAAO,CAAC;MACtB,IAAIG,KAAK,KAAKxC,SAAS,EAAE;QACvBoC,QAAQ,CAACE,WAAW,CAAC,GAAGE,KAAK;MAC/B;IACF;EACF;EACAtC,MAAM,CAACuC,MAAM,CAACnC,MAAM,EAAE8B,QAAQ,CAAC;EAE/B,IAAI,EAAE7B,SAAS,CAACwB,iBAAiB,IAAIzB,MAAM,CAAC,EAAE;IAC5CA,MAAM,CAACC,SAAS,CAACwB,iBAAiB,CAAC,GAAGzB,MAAM,CAACoC,WAAW;EAC1D;AACF;AAEA,SAASzB,YAAYA,CACnB7B,MAAqB,EACrBuD,GAEkB,EAClBC,GAAqB,EACrBC,YAA+B,EAC/B;EACA,KAAK,MAAMC,QAAQ,IAAID,YAAY,EAAE;IACnC,IAAIF,GAAG,CAACvC,UAAU,CAAC0C,QAAQ,CAAC,CAACC,QAAQ,KAAK,KAAK,IAAIH,GAAG,CAACE,QAAQ,CAAC,IAAI,IAAI,EAAE;MACxE,IAAIpC,OAAO,CAACC,GAAG,CAACC,QAAQ,KAAK,YAAY,EAAE;QACzCxB,MAAM,CAACM,MAAM,EAAEC,KAAK,CAClB;UACEiD,GAAG,EAAE;YACHI,WAAW,EAAEJ,GAAG,CAAC,aAAa,CAAC;YAC/BF,WAAW,EAAEE,GAAG,CAAC,aAAa;UAChC;QACF,CAAC,EACD,kEAAkED,GAAG,CAAC3B,OAAO,MAAM8B,QAAQ,kBAC7F,CAAC;MACH;MACA,OAAO,KAAK;IACd;EACF;EACA,OAAO,IAAI;AACb;AAEA,SAAS/B,0BAA0BA,CACjCR,SAAsC,EACtCjB,gBAAwB,EACxBF,MAAqB,EACyC;EAC9D,IAAImB,SAAS,CAAC4B,YAAY,GAAG7C,gBAAgB,CAAC,IAAI,IAAI,EAAE;IACtD,MAAM2D,OAAO,GACX,iOAAiO;IACnO,IAAI7D,MAAM,CAACM,MAAM,EAAE;MACjBN,MAAM,CAACM,MAAM,CAACwD,IAAI,CAACD,OAAO,CAAC;IAC7B,CAAC,MAAM;MACL;MACAE,OAAO,CAACC,KAAK,CAAC,YAAYH,OAAO,EAAE,CAAC;IACtC;IACA,MAAM,IAAI7B,KAAK,CAAC6B,OAAO,CAAC;EAC1B;AACF;AAEA,SAASrD,0BAA0BA,CACjCyD,IAAwB,EACxB9D,cAAuB,EACvB;EACA,KAAK,MAAMqD,GAAG,IAAIS,IAAI,EAAE;IACtB,IAAI9D,cAAc,EAAE;MAClB,OAAOqD,GAAG,CAACU,KAAK;IAClB;IAEA,IAAIV,GAAG,CAACU,KAAK,EAAE;MACbV,GAAG,CAACW,IAAI,GAAGX,GAAG,CAACU,KAAK;MACpB,OAAOV,GAAG,CAACU,KAAK;IAClB;;IAEA;IACAV,GAAG,CAACnC,QAAQ,KAAKmC,GAAG,CAACY,SAAS;;IAE9B;IACA;IACAZ,GAAG,CAACI,WAAW,GAAGJ,GAAG,CAACnC,QAAQ;;IAE9B;IACAmC,GAAG,CAACF,WAAW,KAAKE,GAAG,CAACa,YAAY;IACpCb,GAAG,CAACc,MAAM,KAAKd,GAAG,CAACe,OAAO;;IAE1B;IACA,OAAOf,GAAG,CAACY,SAAS;IACpB,OAAOZ,GAAG,CAACa,YAAY;IACvB,OAAOb,GAAG,CAACe,OAAO;EACpB;AACF","ignoreList":[]}

package/build/browser/object/convertWireToOsdkObjects.test.js

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 import { $ontologyRid, Employee, FooInterface, objectTypeWithAllPropertyTypes } from "@osdk/client.test.ontology";
 import { createSharedClientContext } from "@osdk/shared.client.impl";
 import { apiServer } from "@osdk/shared.test";
@@ -20,9 +21,16 @@ import { afterAll, beforeAll, describe, expect, expectTypeOf, it } from "vitest"
 import { additionalContext } from "../Client.js";
 import { createClient } from "../createClient.js";
 import { createMinimalClient } from "../createMinimalClient.js";
-import { convertWireToOsdkObjects } from "./convertWireToOsdkObjects.js";
+import { convertWireToOsdkObjects, convertWireToOsdkObjects2 } from "./convertWireToOsdkObjects.js";
 describe("convertWireToOsdkObjects", () => {
   let client;
+  const interfaceToObjectTypeMappings = {
+    FooInterface: {
+      Employee: {
+        fooSpt: "fullName"
+      }
+    }
+  };
   beforeAll(async () => {
     apiServer.listen();
     client = createClient("https://stack.palantir.com", $ontologyRid, async () => "myAccessToken");
@@ -34,7 +42,7 @@ describe("convertWireToOsdkObjects", () => {
     const {
       data: [employee]
     } = await client(Employee).fetchPage();
-    expect(Object.keys(employee).sort()).toEqual(["employeeId", "fullName", "office", "class", "startDate", "employeeStatus", "$apiName", "$objectType", "$primaryKey", "employeeLocation"].sort());
+    expect(Object.keys(employee).sort()).toEqual(["employeeId", "$title", "fullName", "office", "class", "startDate", "employeeSensor", "employeeStatus", "$apiName", "$objectType", "$primaryKey", "employeeLocation"].sort());
     expect(Object.keys(employee.$as)).toEqual([]);
     expect(Object.keys(employee.$link)).toEqual(["peeps", "lead", "officeLink"]);
   });
@@ -55,11 +63,13 @@ describe("convertWireToOsdkObjects", () => {
         }
       }]
     }).fetchPage();
+
     // Should not have $title
-    expect(JSON.stringify(employee)).toMatchInlineSnapshot(`"{"employeeId":50030,"fullName":"John Doe","office":"NYC","class":"Red","startDate":"2019-01-01","employeeStatus":{},"employeeLocation":{},"$apiName":"Employee","$objectType":"Employee","$primaryKey":50030}"`);
+    expect(JSON.stringify(employee)).toMatchInlineSnapshot(`"{"employeeId":50030,"fullName":"John Doe","office":"NYC","class":"Red","startDate":"2019-01-01","employeeStatus":{},"employeeSensor":{},"employeeLocation":{},"$apiName":"Employee","$objectType":"Employee","$primaryKey":50030}"`);
     expect(JSON.stringify(employee.$as(FooInterface))).toMatchInlineSnapshot(`"{"$apiName":"FooInterface","$objectType":"Employee","$primaryKey":50030,"fooSpt":"John Doe"}"`);
+
     // Should have $title
-    expect(JSON.stringify(employee2)).toMatchInlineSnapshot(`"{"employeeId":50031,"fullName":"Jane Doe","office":"SEA","class":"Blue","startDate":"2012-02-12","employeeStatus":{},"employeeLocation":{},"$apiName":"Employee","$objectType":"Employee","$primaryKey":50031,"$title":"Jane Doe"}"`);
+    expect(JSON.stringify(employee2)).toMatchInlineSnapshot(`"{"employeeId":50031,"fullName":"Jane Doe","office":"SEA","class":"Blue","startDate":"2012-02-12","employeeStatus":{},"employeeSensor":{},"employeeLocation":{},"$apiName":"Employee","$objectType":"Employee","$primaryKey":50031,"$title":"Jane Doe"}"`);
     expect(JSON.stringify(employee2.$as(FooInterface))).toMatchInlineSnapshot(`"{"$apiName":"FooInterface","$objectType":"Employee","$primaryKey":50031,"$title":"Jane Doe","fooSpt":"Jane Doe"}"`);
   });
   it("reuses the object prototype across objects", async () => {
@@ -91,53 +101,67 @@ describe("convertWireToOsdkObjects", () => {
     expect(emptyAttachment).toBeUndefined();
     expect(emptyAttachmentArray).toBeUndefined();
   });
-  it("works even with unknown apiNames", async () => {
+  it("converts media as expected", async () => {
+    const withValues = await client(objectTypeWithAllPropertyTypes).where({
+      id: 1
+    }).fetchPage();
+    expect(withValues.data.length).toBeGreaterThanOrEqual(1);
+    const {
+      mediaReference
+    } = withValues.data[0];
+    expectTypeOf(mediaReference).toMatchTypeOf;
+    expect(mediaReference).toBeDefined();
+    const withoutValues = await client(objectTypeWithAllPropertyTypes).where({
+      id: 2
+    }).fetchPage();
+    const {
+      mediaReference: emptyMedia
+    } = withoutValues.data[0];
+    expect(emptyMedia).toBeUndefined();
+  });
+  it("creates immutable objects", async () => {
+    const employees = await client(Employee).fetchPage();
+    expect(employees.data.length).toBeGreaterThanOrEqual(2);
+    const [a, b] = employees.data;
+    expect(a).toBeDefined();
+    expect(() => {
+      a.somePropertyThatShouldNotExist = 5;
+    }).toThrow();
+    const objAsFoo = a.$as(FooInterface);
+    expect(objAsFoo).toBeDefined();
+    expect(() => {
+      objAsFoo.somePropertyThatShouldNotExist = 5;
+    }).toThrow();
+  });
+  it("works even with unknown apiNames - old", async () => {
     const clientCtx = createMinimalClient({
       ontologyRid: $ontologyRid
     }, "https://stack.palantir.com", async () => "myAccessToken");
     createSharedClientContext("https://stack.palantir.com", async () => "myAccessToken", "userAgent");
-    let object = {
+    const object = {
       __apiName: Employee.apiName,
       __primaryKey: 0
     };
     const prototypeBefore = Object.getPrototypeOf(object);
-    let object2 = await convertWireToOsdkObjects(clientCtx, [object], undefined, undefined, undefined, false);
+    const object2 = await convertWireToOsdkObjects(clientCtx, [object], undefined, undefined, undefined, false);
     const prototypeAfter = Object.getPrototypeOf(object2);
     expect(prototypeBefore).not.toBe(prototypeAfter);
   });
-  it("updates interface when underlying changes", async () => {
+  it("works even with unknown apiNames - new", async () => {
     const clientCtx = createMinimalClient({
       ontologyRid: $ontologyRid
     }, "https://stack.palantir.com", async () => "myAccessToken");
-    const [obj] = await convertWireToOsdkObjects(clientCtx, [{
-      __apiName: "Employee",
-      __primaryKey: 0,
-      __title: "Steve",
-      fullName: "Steve",
-      employeeId: "5"
-    }], undefined);
-    expect(obj.fullName).toEqual("Steve");
-    expect(Object.keys(obj).sort()).toEqual(["$apiName", "$objectType", "$primaryKey", "$title", "employeeId", "fullName"].sort());
-    const objAsFoo = obj.$as(FooInterface);
-    expect(objAsFoo).toMatchObject({
-      fooSpt: obj.fullName,
-      $apiName: FooInterface.apiName,
-      $primaryKey: obj.$primaryKey,
-      $objectType: obj.$objectType,
-      $title: obj.$title
-    });
-    console.log(obj);
-    console.log(objAsFoo);
-    obj.$updateInternalValues({
-      fullName: "Bob"
-    });
-    expect(obj.fullName).toEqual("Bob");
-    expect(objAsFoo.fooSpt).toEqual(obj.fullName);
-    expect(Object.keys(objAsFoo).sort()).toEqual(["$apiName", "$objectType", "$primaryKey", "$title", "fooSpt"].sort());
-    expect(obj).toBe(objAsFoo.$as(Employee));
-    expect(objAsFoo).toBe(obj.$as(FooInterface));
+    createSharedClientContext("https://stack.palantir.com", async () => "myAccessToken", "userAgent");
+    const object = {
+      __apiName: Employee.apiName,
+      __primaryKey: 0
+    };
+    const prototypeBefore = Object.getPrototypeOf(object);
+    const object2 = await convertWireToOsdkObjects2(clientCtx, [object], undefined, undefined, undefined, false);
+    const prototypeAfter = Object.getPrototypeOf(object2);
+    expect(prototypeBefore).not.toBe(prototypeAfter);
   });
-  it("reconstitutes interfaces properly without rid", async () => {
+  it("reconstitutes interfaces properly without rid - old", async () => {
     const clientCtx = createMinimalClient({
       ontologyRid: $ontologyRid
     }, "https://stack.palantir.com", async () => "myAccessToken");
@@ -169,6 +193,37 @@ describe("convertWireToOsdkObjects", () => {
       }
     `);
   });
+  it("reconstitutes interfaces properly without rid - new", async () => {
+    const clientCtx = createMinimalClient({
+      ontologyRid: $ontologyRid
+    }, "https://stack.palantir.com", async () => "myAccessToken");
+    const [objAsFoo] = await convertWireToOsdkObjects2(clientCtx, [{
+      __apiName: "Employee",
+      __primaryKey: 0,
+      __title: "Steve",
+      fullName: "Steve"
+    }], FooInterface.apiName, false, undefined, false, interfaceToObjectTypeMappings);
+    expect(objAsFoo).toMatchInlineSnapshot(`
+      {
+        "$apiName": "FooInterface",
+        "$objectType": "Employee",
+        "$primaryKey": 0,
+        "$title": "Steve",
+        "fooSpt": "Steve",
+      }
+    `);
+    const obj = objAsFoo.$as(Employee);
+    expect(obj.fullName).toEqual("Steve");
+    expect(obj).toMatchInlineSnapshot(`
+      {
+        "$apiName": "Employee",
+        "$objectType": "Employee",
+        "$primaryKey": 0,
+        "$title": "Steve",
+        "fullName": "Steve",
+      }
+    `);
+  });
   it("reconstitutes interfaces properly with rid", async () => {
     const clientCtx = createMinimalClient({
       ontologyRid: $ontologyRid
@@ -206,9 +261,47 @@ describe("convertWireToOsdkObjects", () => {
     `);
     expect(obj.$rid).toEqual("hiMom");
   });
+  it("reconstitutes interfaces properly with rid - new", async () => {
+    const clientCtx = createMinimalClient({
+      ontologyRid: $ontologyRid
+    }, "https://stack.palantir.com", async () => "myAccessToken");
+    const [objAsFoo] = await convertWireToOsdkObjects2(clientCtx, [{
+      __apiName: "Employee",
+      __primaryKey: 0,
+      __title: "Steve",
+      __rid: "hiMom",
+      fullName: "Steve",
+      employeeId: 0
+    }], FooInterface.apiName, false, undefined, false, interfaceToObjectTypeMappings);
+    expect(objAsFoo).toMatchInlineSnapshot(`
+      {
+        "$apiName": "FooInterface",
+        "$objectType": "Employee",
+        "$primaryKey": 0,
+        "$rid": "hiMom",
+        "$title": "Steve",
+        "fooSpt": "Steve",
+      }
+    `);
+    expect(objAsFoo.$rid).toEqual("hiMom");
+    const obj = objAsFoo.$as(Employee);
+    expect(obj.fullName).toEqual("Steve");
+    expect(obj).toMatchInlineSnapshot(`
+      {
+        "$apiName": "Employee",
+        "$objectType": "Employee",
+        "$primaryKey": 0,
+        "$rid": "hiMom",
+        "$title": "Steve",
+        "employeeId": 0,
+        "fullName": "Steve",
+      }
+    `);
+    expect(obj.$rid).toEqual("hiMom");
+  });
   describe("selection keys", () => {
     it("throws when required is missing", async () => {
-      let object = {
+      const object = {
         __apiName: "Employee",
         __primaryKey: 0
       };
@@ -235,30 +328,90 @@ describe("convertWireToOsdkObjects", () => {
       expect(result.length).toBe(1);
     });
   });
+  describe("selection keys - new", () => {
+    it("throws when required is missing", async () => {
+      const object = {
+        __apiName: "Employee",
+        __primaryKey: 0
+      };
+      await expect(() => convertWireToOsdkObjects2(client[additionalContext], [object], undefined, undefined, ["employeeId"], "throw")).rejects.toThrowErrorMatchingInlineSnapshot(`[Error: Unable to safely convert objects as some non nullable properties are null]`);
+    });
+    it("does not throw when optional is missing", async () => {
+      await expect(convertWireToOsdkObjects2(client[additionalContext], [{
+        __apiName: "Employee",
+        __primaryKey: 0
+      }], undefined, undefined, ["fullName"], "throw")).resolves.to.not.toBeUndefined();
+    });
+    it("filters when it should", async () => {
+      const result = await convertWireToOsdkObjects2(client[additionalContext], [{
+        __apiName: "Employee",
+        __primaryKey: 0
+      }], undefined, undefined, ["employeeId"], "drop");
+      expect(result.length).toBe(0);
+    });
+    it("does not filter when it shouldn't", async () => {
+      const result = await convertWireToOsdkObjects2(client[additionalContext], [{
+        __apiName: "Employee",
+        __primaryKey: 0
+      }], undefined, undefined, ["fullName"], "drop");
+      expect(result.length).toBe(1);
+    });
+  });
   describe("without selection keys", () => {
     it("throws when required is missing", async () => {
-      let object = {
+      const object = {
         __apiName: "Employee",
         __primaryKey: 0
       };
-      await expect(() => convertWireToOsdkObjects(client[additionalContext], [object], undefined, undefined, undefined, "throw")).rejects.toThrowErrorMatchingInlineSnapshot(`[Error: Unable to safely convert objects as some non nullable properties are null]`);
+      await expect(() => convertWireToOsdkObjects2(client[additionalContext], [object], undefined, undefined, undefined, "throw")).rejects.toThrowErrorMatchingInlineSnapshot(`[Error: Unable to safely convert objects as some non nullable properties are null]`);
     });
     it("does not throw when required is present", async () => {
-      await expect(convertWireToOsdkObjects(client[additionalContext], [{
+      await expect(convertWireToOsdkObjects2(client[additionalContext], [{
         __apiName: "Employee",
         __primaryKey: 0,
         "employeeId": 0
       }], undefined, undefined, undefined, "throw")).resolves.to.not.toBeUndefined();
     });
     it("filters when it should", async () => {
-      const result = await convertWireToOsdkObjects(client[additionalContext], [{
+      const result = await convertWireToOsdkObjects2(client[additionalContext], [{
         __apiName: "Employee",
         __primaryKey: 0
       }], undefined, undefined, undefined, "drop");
       expect(result.length).toBe(0);
     });
     it("does not filter when it shouldn't", async () => {
-      const result = await convertWireToOsdkObjects(client[additionalContext], [{
+      const result = await convertWireToOsdkObjects2(client[additionalContext], [{
+        __apiName: "Employee",
+        __primaryKey: 0,
+        "employeeId": 0
+      }], undefined, undefined, undefined, "drop");
+      expect(result.length).toBe(1);
+    });
+  });
+  describe("without selection keys - new", () => {
+    it("throws when required is missing", async () => {
+      const object = {
+        __apiName: "Employee",
+        __primaryKey: 0
+      };
+      await expect(() => convertWireToOsdkObjects2(client[additionalContext], [object], undefined, undefined, undefined, "throw")).rejects.toThrowErrorMatchingInlineSnapshot(`[Error: Unable to safely convert objects as some non nullable properties are null]`);
+    });
+    it("does not throw when required is present", async () => {
+      await expect(convertWireToOsdkObjects2(client[additionalContext], [{
+        __apiName: "Employee",
+        __primaryKey: 0,
+        "employeeId": 0
+      }], undefined, undefined, undefined, "throw")).resolves.to.not.toBeUndefined();
+    });
+    it("filters when it should", async () => {
+      const result = await convertWireToOsdkObjects2(client[additionalContext], [{
+        __apiName: "Employee",
+        __primaryKey: 0
+      }], undefined, undefined, undefined, "drop");
+      expect(result.length).toBe(0);
+    });
+    it("does not filter when it shouldn't", async () => {
+      const result = await convertWireToOsdkObjects2(client[additionalContext], [{
         __apiName: "Employee",
         __primaryKey: 0,
         "employeeId": 0
@@ -267,11 +420,11 @@ describe("convertWireToOsdkObjects", () => {
     });
   });
   it("behaves correctly when converting", async () => {
-    const result = await convertWireToOsdkObjects(client[additionalContext], [{
+    const result = await convertWireToOsdkObjects2(client[additionalContext], [{
       __apiName: "Employee",
       __primaryKey: 0,
       fooSpt: "hi"
-    }], "FooInterface", undefined, ["fooSpt"], "drop");
+    }], "FooInterface", undefined, ["fooSpt"], "drop", interfaceToObjectTypeMappings);
     expect(result.length).toBe(1);
   });
 });