@oscarpalmer/atoms 0.172.1 → 0.172.2

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@oscarpalmer/atoms",
-	"version": "0.172.1",
+	"version": "0.172.2",
 	"description": "Atomic utilities for making your JavaScript better.",
 	"keywords": [
 		"helper",

package/plugin/array.js

@@ -0,0 +1,22 @@
+import {getPlugin, isArrayMethod} from './helpers.js';
+
+export default [
+	getPlugin(
+		{
+			full: 'array.exists',
+			short: 'exists',
+		},
+		new Set(['includes']),
+		isArrayMethod,
+		'Array.prototype',
+	),
+	getPlugin(
+		{
+			full: 'array.sort',
+			short: 'sort',
+		},
+		new Set(['sort']),
+		isArrayMethod,
+		'Array.prototype',
+	),
+];

package/plugin/helpers.js

@@ -1,3 +1,88 @@
+/**
+ * @typedef Name
+ * @property {string} full
+ * @property {string} short
+ */
+
+/**
+ * @typedef Plugin
+ * @property {string} message
+ * @property {string} name
+ * @property {string} selector
+ * @property {import('eslint').Rule.RuleModule} value
+ */
+
+/**
+ * @typedef Validator
+ * @param {import('eslint').Rule.RuleContext} context
+ * @param {import('estree').CallExpression & import('eslint').Rule.NodeParentExtension} node
+ * @param {Set<string>} methods
+ * @returns {boolean}
+ */
+
+/**
+ * @param {Set<string>} methods
+ * @param {string|undefined} prefix
+ * @returns {string}
+ */
+function getMethodNames(methods, prefix) {
+	const array = [...methods];
+	const {length} = array;
+
+	let names = '';
+
+	for (let index = 0; index < length; index += 1) {
+		const method = array[index];
+
+		const name = prefix == null ? method : `${prefix}.${method}`;
+
+		if (index === 0) {
+			names = `'${name}'`;
+		} else {
+			names += index === length - 1 ? `, and '${name}'` : `, '${name}'`;
+		}
+	}
+
+	return names;
+}
+
+/**
+ * @param {Name} name
+ * @param {Set<string>} methods
+ * @param {Validator} validator
+ * @param {string|undefined} prefix
+ * @returns {Plugin}
+ */
+export function getPlugin(name, methods, validator, prefix) {
+	const message = `Prefer using '${name.short}' (@oscarpalmer/atoms) instead of ${getMethodNames(methods, prefix)}`;
+
+	return {
+		message,
+		name: name.full,
+		selector: `CallExpression[callee.type="${memberExpression}"][callee.object.type="${arrayExpression}"][callee.property.type="${identifierType}"]`,
+		value: {
+			create(context) {
+				return {
+					CallExpression(node) {
+						if (validator(context, node, methods)) {
+							context.report({
+								message,
+								node,
+							});
+						}
+					},
+				};
+			},
+			meta: {
+				docs: {
+					description: message,
+				},
+				type: 'suggestion',
+			},
+		},
+	};
+}
+
 /**
  * @param {import('eslint').Rule.RuleContext} context
  * @param {import('estree').CallExpression & import('eslint').Rule.NodeParentExtension} node

package/plugin/index.js

@@ -1,5 +1,5 @@
-import arrayExistsPlugin from './array/array.exists.plugin.js';
-import arraySortPlugin from './array/array.sort.plugin.js';
+import {groupBy} from '../dist/array/group-by.mjs';
+import array from './array.js';
 
 /**
  * @typedef {import('eslint').Linter.Config} ESLintConfig
@@ -11,7 +11,6 @@ export default {
 		version: '1.0.0',
 	},
 	rules: {
-		[arrayExistsPlugin.name]: arrayExistsPlugin.value,
-		[arraySortPlugin.name]: arraySortPlugin.value,
+		...groupBy(array, 'name', 'value'),
 	},
 };

package/plugin/array/array.exists.plugin.js

@@ -1,39 +0,0 @@
-import {isArrayMethod} from '../helpers.js';
-
-/**
- * @typedef Plugin
- * @property {string} name
- * @property {import('eslint').Rule.RuleModule} value
- */
-
-const message =
-	"Prefer the use of 'exists()' (@oscarpalmer/atoms) over 'Array.prototype.includes()'";
-
-const methods = new Set(['includes']);
-
-/**
- * @type {Plugin}
- */
-export default {
-	name: 'array.exists',
-	value: {
-		create(context) {
-			return {
-				CallExpression(node) {
-					if (isArrayMethod(context, node, methods)) {
-						context.report({
-							message,
-							node,
-						});
-					}
-				},
-			};
-		},
-		meta: {
-			docs: {
-				description: message,
-			},
-			type: 'suggestion',
-		},
-	},
-};

package/plugin/array/array.sort.plugin.js

@@ -1,38 +0,0 @@
-import {isArrayMethod} from '../helpers.js';
-
-/**
- * @typedef Plugin
- * @property {string} name
- * @property {import('eslint').Rule.RuleModule} value
- */
-
-const message = "Prefer the use of 'sort()' (@oscarpalmer/atoms) over 'Array.prototype.sort()'";
-
-const methods = new Set(['sort']);
-
-/**
- * @type {Plugin}
- */
-export default {
-	name: 'array.sort',
-	value: {
-		create(context) {
-			return {
-				CallExpression(node) {
-					if (isArrayMethod(context, node, methods)) {
-						context.report({
-							message,
-							node,
-						});
-					}
-				},
-			};
-		},
-		meta: {
-			docs: {
-				description: message,
-			},
-			type: 'suggestion',
-		},
-	},
-};