@oscarpalmer/abydon 0.8.0 → 0.9.0

package/src/node/attribute/value.ts

@@ -1,26 +1,17 @@
-import {closest} from '@oscarpalmer/atoms/element';
 import type {PlainObject} from '@oscarpalmer/atoms/models';
 import {getString} from '@oscarpalmer/atoms/string';
 import {effect, isReactive} from '@oscarpalmer/sentinel';
-import type {FragmentElement} from '../../models';
-
-const booleanAttributes = new Set([
-	'checked',
-	'disabled',
-	'hidden',
-	'inert',
-	'multiple',
-	'open',
-	'readOnly',
-	'required',
-	'selected',
-]);
+import {
+	isBooleanAttribute,
+	setAttribute as setAttr,
+} from '@oscarpalmer/toretto/attribute';
+import type {ProperElement} from '../../models';
 
 const classPattern = /^class\./;
 const stylePattern = /^style\./;
 
 export function setAttribute(
-	element: FragmentElement,
+	element: ProperElement,
 	name: string,
 	value: unknown,
 ): void {
@@ -42,7 +33,7 @@ export function setAttribute(
 }
 
 function setClasses(
-	element: FragmentElement,
+	element: ProperElement,
 	name: string,
 	value: unknown,
 ): void {
@@ -65,11 +56,7 @@ function setClasses(
 	}
 }
 
-function setStyle(
-	element: FragmentElement,
-	name: string,
-	value: unknown,
-): void {
+function setStyle(element: ProperElement, name: string, value: unknown): void {
 	function update(value: unknown): void {
 		if (value == null || value === false || (value === true && unit == null)) {
 			element.style.removeProperty(property);
@@ -96,17 +83,13 @@ function setStyle(
 	}
 }
 
-function setValue(
-	element: FragmentElement,
-	name: string,
-	value: unknown,
-): void {
+function setValue(element: ProperElement, name: string, value: unknown): void {
 	const callback =
-		booleanAttributes.has(name) && name in element
+		isBooleanAttribute(name) && name in element
 			? name === 'selected'
-				? updateSelected(element)
+				? updateSelected
 				: updateProperty
-			: updateAttribute;
+			: setAttr;
 
 	if (isReactive(value)) {
 		effect(() => {
@@ -123,20 +106,8 @@ function triggerSelectChange(select: HTMLSelectElement): void {
 	}
 }
 
-function updateAttribute(
-	element: FragmentElement,
-	name: string,
-	value: unknown,
-): void {
-	if (value == null) {
-		element.removeAttribute(name);
-	} else {
-		element.setAttribute(name, getString(value));
-	}
-}
-
 function updateProperty(
-	element: FragmentElement,
+	element: ProperElement,
 	name: string,
 	value: unknown,
 ): void {
@@ -145,15 +116,17 @@ function updateProperty(
 	);
 }
 
-function updateSelected(element: FragmentElement) {
-	const select = closest(element, 'select')[0] as HTMLSelectElement;
+function updateSelected(
+	element: ProperElement,
+	name: string,
+	value: unknown,
+): void {
+	const select = element.closest('select') as HTMLSelectElement;
 	const options = [...(select?.options ?? [])];
 
-	return (element: FragmentElement, name: string, value: unknown): void => {
-		if (select != null && options.includes(element as HTMLOptionElement)) {
-			triggerSelectChange(select);
-		}
+	if (select != null && options.includes(element as HTMLOptionElement)) {
+		triggerSelectChange(select);
+	}
 
-		updateProperty(element, name, value);
-	};
+	updateProperty(element, name, value);
 }

package/src/node/event.ts

@@ -1,4 +1,4 @@
-import type {FragmentElement} from '../models';
+import type {ProperElement} from '../models';
 
 function getOptions(options: string): AddEventListenerOptions {
 	const parts = options.split(':');
@@ -11,7 +11,7 @@ function getOptions(options: string): AddEventListenerOptions {
 }
 
 export function mapEvent(
-	element: FragmentElement,
+	element: ProperElement,
 	name: string,
 	value: unknown,
 ): void {

package/src/node/index.ts

@@ -1,7 +1,7 @@
 import {isReactive} from '@oscarpalmer/sentinel';
-import {isFragmentElement} from '../helpers';
+import {isFragment, isProperElement} from '../helpers';
 import {createNodes} from '../helpers/dom';
-import type {FragmentData} from '../models';
+import type {FragmentData, ProperNode} from '../models';
 import {mapAttributes} from './attribute';
 import {setReactiveNode} from './value';
 
@@ -12,11 +12,11 @@ function mapNode(data: FragmentData, comment: Comment): void {
 	const value = matches == null ? null : data.values[+matches[1]];
 
 	if (value != null) {
-		mapValue(comment, value);
+		mapValue(data, comment, value);
 	}
 }
 
-export function mapNodes(data: FragmentData, nodes: Node[]): void {
+export function mapNodes(data: FragmentData, nodes: ProperNode[]): void {
 	const {length} = nodes;
 
 	for (let index = 0; index < length; index += 1) {
@@ -28,28 +28,44 @@ export function mapNodes(data: FragmentData, nodes: Node[]): void {
 			continue;
 		}
 
-		if (isFragmentElement(node)) {
+		if (isProperElement(node)) {
 			mapAttributes(data, node);
 		}
 
 		if (node.hasChildNodes()) {
-			mapNodes(data, [...node.childNodes]);
+			mapNodes(data, [...node.childNodes] as ProperNode[]);
 		}
 	}
 }
 
-function mapValue(comment: Comment, value: unknown): void {
+function mapValue(data: FragmentData, comment: Comment, value: unknown): void {
 	switch (true) {
 		case typeof value === 'function':
-			mapValue(comment, value());
+			mapValue(data, comment, value());
 			return;
 
 		case isReactive(value):
-			setReactiveNode(comment, value);
+			setReactiveNode(data, comment, value);
 			break;
 
 		default:
-			comment.replaceWith(...createNodes(value));
+			replaceComment(data, comment, value);
 			break;
 	}
 }
+
+function replaceComment(
+	data: FragmentData,
+	comment: Comment,
+	value: unknown,
+): void {
+	const item = data.items.find(item => item.nodes.includes(comment));
+	const nodes = createNodes(value);
+
+	if (item != null) {
+		item.fragment = isFragment(value) ? value : undefined;
+		item.nodes = nodes;
+	}
+
+	comment.replaceWith(...nodes);
+}

package/src/node/value.ts

@@ -1,48 +1,87 @@
 import {isNullableOrWhitespace} from '@oscarpalmer/atoms/is';
 import {getString} from '@oscarpalmer/atoms/string';
 import {type Reactive, effect} from '@oscarpalmer/sentinel';
-import {isFragment, isFragmentNode} from '../helpers';
+import type {Fragment} from '../fragment';
+import {isFragment, isProperNode} from '../helpers';
 import {createNodes, replaceNodes} from '../helpers/dom';
-import type {FragmentNode} from '../models';
+import type {FragmentData, ProperNode} from '../models';
 
-export function setReactiveNode(comment: Comment, reactive: Reactive): void {
+function setNodes(
+	nodes: ProperNode[] | undefined,
+	comment: Comment,
+	text: Text,
+	value: Fragment | ProperNode,
+): ProperNode[] {
+	const next = createNodes(value);
+
+	if (nodes == null) {
+		if (comment.parentNode != null) {
+			replaceNodes([comment], next);
+		} else if (text.parentNode != null) {
+			replaceNodes([text], next);
+		}
+	} else {
+		replaceNodes(nodes, next);
+	}
+
+	return next;
+}
+
+export function setReactiveNode(
+	data: FragmentData,
+	comment: Comment,
+	reactive: Reactive,
+): void {
+	const item = data.items.find(item => item.nodes.includes(comment));
 	const text = new Text();
 
-	let nodes: FragmentNode[] | undefined;
+	let nodes: ProperNode[] | undefined;
 
 	effect(() => {
 		const value = reactive.get();
 
-		if (isFragment(value) || isFragmentNode(value)) {
-			const next = createNodes(value);
-
-			if (nodes == null) {
-				if (comment.parentNode != null) {
-					replaceNodes([comment], next);
-				} else if (text.parentNode != null) {
-					replaceNodes([text], next);
-				}
-			} else {
-				replaceNodes(nodes, next);
-			}
+		const valueIsFragment = isFragment(value);
 
-			nodes = next;
+		if (valueIsFragment || isProperNode(value)) {
+			nodes = setNodes(nodes, comment, text, value);
+		} else {
+			nodes = setText(nodes, comment, text, value) ? [text] : undefined;
+		}
 
-			return;
+		if (item != null) {
+			item.fragment = valueIsFragment ? value : undefined;
+			item.nodes = [...(nodes ?? [comment])];
 		}
+	});
+}
 
-		const isNullable = isNullableOrWhitespace(value);
+function setText(
+	nodes: ProperNode[] | undefined,
+	comment: Comment,
+	text: Text,
+	value: unknown,
+): boolean {
+	const isNullable = isNullableOrWhitespace(value);
 
-		text.textContent = getString(value);
+	text.textContent = isNullable ? '' : getString(value);
 
-		if (nodes != null) {
-			replaceNodes(nodes, [isNullable ? comment : text]);
-		} else if (isNullable && comment.parentNode == null) {
-			text.replaceWith(comment);
-		} else if (!isNullable && text.parentNode == null) {
-			comment.replaceWith(text);
-		}
+	if (nodes != null) {
+		replaceNodes(nodes, [isNullable ? comment : text]);
 
-		nodes = undefined;
-	});
+		return !isNullable;
+	}
+
+	if (isNullable && comment.parentNode == null) {
+		text.replaceWith(comment);
+
+		return false;
+	}
+
+	if (!isNullable && text.parentNode == null) {
+		comment.replaceWith(text);
+
+		return true;
+	}
+
+	return false;
 }

package/types/helpers/dom.d.ts

@@ -1,5 +1,3 @@
-import type { FragmentNode } from '../models';
-export declare function createNodes(value: unknown): FragmentNode[];
-export declare function createTemplate(html: string): Node;
-export declare function getNodes(node: Node): Node[];
-export declare function replaceNodes(from: FragmentNode[], to: FragmentNode[]): void;
+import type { ProperNode } from '../models';
+export declare function createNodes(value: unknown): ProperNode[];
+export declare function replaceNodes(from: ProperNode[], to: ProperNode[]): void;

package/types/helpers/index.d.ts

@@ -1,5 +1,5 @@
 import type { Fragment } from '../fragment';
-import type { FragmentElement, FragmentNode } from '../models';
+import type { ProperElement, ProperNode } from '../models';
 export declare function isFragment(value: unknown): value is Fragment;
-export declare function isFragmentElement(value: unknown): value is FragmentElement;
-export declare function isFragmentNode(value: unknown): value is FragmentNode;
+export declare function isProperElement(value: unknown): value is ProperElement;
+export declare function isProperNode(value: unknown): value is ProperNode;

package/types/models.d.ts

@@ -1,8 +1,13 @@
+import type { Fragment } from './fragment';
 export type FragmentData = {
     expressions: unknown[];
-    nodes: Node[];
+    items: FragmentItem[];
     strings: TemplateStringsArray;
     values: unknown[];
 };
-export type FragmentElement = HTMLElement | SVGElement;
-export type FragmentNode = Comment | Element | Text;
+export type FragmentItem = {
+    fragment?: Fragment;
+    nodes: ProperNode[];
+};
+export type ProperElement = HTMLElement | SVGElement;
+export type ProperNode = CharacterData | Element;

package/types/node/attribute/index.d.ts

@@ -1,3 +1,2 @@
-import type { FragmentData, FragmentElement } from '../../models';
-export declare function isBadAttribute(name: string, value: string): boolean;
-export declare function mapAttributes(data: FragmentData, element: FragmentElement): void;
+import type { FragmentData, ProperElement } from '../../models';
+export declare function mapAttributes(data: FragmentData, element: ProperElement): void;

package/types/node/attribute/value.d.ts

@@ -1,2 +1,2 @@
-import type { FragmentElement } from '../../models';
-export declare function setAttribute(element: FragmentElement, name: string, value: unknown): void;
+import type { ProperElement } from '../../models';
+export declare function setAttribute(element: ProperElement, name: string, value: unknown): void;

package/types/node/event.d.ts

@@ -1,2 +1,2 @@
-import type { FragmentElement } from '../models';
-export declare function mapEvent(element: FragmentElement, name: string, value: unknown): void;
+import type { ProperElement } from '../models';
+export declare function mapEvent(element: ProperElement, name: string, value: unknown): void;

package/types/node/index.d.ts

@@ -1,2 +1,2 @@
-import type { FragmentData } from '../models';
-export declare function mapNodes(data: FragmentData, nodes: Node[]): void;
+import type { FragmentData, ProperNode } from '../models';
+export declare function mapNodes(data: FragmentData, nodes: ProperNode[]): void;

package/types/node/value.d.ts

@@ -1,2 +1,3 @@
 import { type Reactive } from '@oscarpalmer/sentinel';
-export declare function setReactiveNode(comment: Comment, reactive: Reactive): void;
+import type { FragmentData } from '../models';
+export declare function setReactiveNode(data: FragmentData, comment: Comment, reactive: Reactive): void;