@os-eco/overstory-cli 0.9.1 → 0.9.2

package/src/commands/coordinator.test.ts

@@ -29,6 +29,11 @@ import {
 	createCoordinatorCommand,
 	resolveAttach,
 } from "./coordinator.ts";
+import {
+	buildOrchestratorBeacon,
+	createOrchestratorCommand,
+	orchestratorCommand,
+} from "./orchestrator.ts";
 
 // --- Fake Tmux ---
 
@@ -272,14 +277,26 @@ beforeEach(async () => {
 				canSpawn: true,
 				constraints: [],
 			},
+			orchestrator: {
+				file: "orchestrator.md",
+				model: "opus",
+				tools: ["Read", "Bash"],
+				capabilities: ["orchestrate", "coordinate"],
+				canSpawn: true,
+				constraints: [],
+			},
+		},
+		capabilityIndex: {
+			coordinate: ["coordinator", "orchestrator"],
+			orchestrate: ["orchestrator"],
 		},
-		capabilityIndex: { coordinate: ["coordinator"] },
 	};
 	await Bun.write(
 		join(overstoryDir, "agent-manifest.json"),
 		`${JSON.stringify(manifest, null, "\t")}\n`,
 	);
 	await Bun.write(join(agentDefsDir, "coordinator.md"), "# Coordinator\n");
+	await Bun.write(join(agentDefsDir, "orchestrator.md"), "# Orchestrator\n");
 
 	// Override cwd so coordinator commands find our temp project
 	process.chdir(tempDir);
@@ -1255,14 +1272,16 @@ describe("buildCoordinatorBeacon", () => {
 
 	test("includes hierarchy enforcement instruction", () => {
 		const beacon = buildCoordinatorBeacon();
-		expect(beacon).toContain("ONLY spawn leads");
-		expect(beacon).toContain("NEVER spawn non-lead agents directly");
+		expect(beacon).toContain("Default to leads");
+		expect(beacon).toContain("spawn scout/builder directly");
+		expect(beacon).toContain("NEVER spawn reviewer or merger directly");
 	});
 
 	test("includes delegation instruction", () => {
 		const beacon = buildCoordinatorBeacon();
 		expect(beacon).toContain("DELEGATION");
-		expect(beacon).toContain("spawn a lead who will spawn scouts");
+		expect(beacon).toContain("spawn a lead who will handle scouts/builders/reviewers");
+		expect(beacon).toContain("--dispatch-max-agents 1/2");
 	});
 
 	test("parts are joined with em-dash separator", () => {
@@ -1273,6 +1292,60 @@ describe("buildCoordinatorBeacon", () => {
 	});
 });
 
+describe("orchestratorCommand", () => {
+	test("help shows orchestrator command name", async () => {
+		const output = await captureStdout(() => orchestratorCommand(["--help"]));
+		expect(output).toContain("orchestrator");
+	});
+
+	test("start creates orchestrator session with orchestrator capability", async () => {
+		const { deps, calls } = makeDeps({ "overstory-test-project-orchestrator": true });
+		const originalSleep = Bun.sleep;
+		Bun.sleep = (() => Promise.resolve()) as typeof Bun.sleep;
+
+		try {
+			const output = await captureStdout(() =>
+				orchestratorCommand(["start", "--no-attach", "--json"], deps),
+			);
+			const parsed = JSON.parse(output) as Record<string, unknown>;
+
+			expect(parsed.agentName).toBe("orchestrator");
+			expect(parsed.capability).toBe("orchestrator");
+			expect(parsed.tmuxSession).toBe("overstory-test-project-orchestrator");
+			expect(calls.createSession[0]?.name).toBe("overstory-test-project-orchestrator");
+			expect(calls.createSession[0]?.command).toContain("orchestrator.md");
+
+			const session = loadSessionsFromDb().find((entry) => entry.agentName === "orchestrator");
+			expect(session?.capability).toBe("orchestrator");
+		} finally {
+			Bun.sleep = originalSleep;
+		}
+	});
+
+	test("command registration includes orchestrator start/stop/status", () => {
+		const cmd = createOrchestratorCommand({});
+		const subcommandNames = cmd.commands.map((c) => c.name());
+		expect(subcommandNames).toContain("start");
+		expect(subcommandNames).toContain("stop");
+		expect(subcommandNames).toContain("status");
+		expect(subcommandNames).not.toContain("check-complete");
+	});
+});
+
+describe("buildOrchestratorBeacon", () => {
+	test("includes orchestrator identity in header", () => {
+		const beacon = buildOrchestratorBeacon();
+		expect(beacon).toContain("[OVERSTORY] orchestrator (orchestrator)");
+	});
+
+	test("includes ecosystem startup instructions", () => {
+		const beacon = buildOrchestratorBeacon("sd");
+		expect(beacon).toContain("ov mail check --agent orchestrator");
+		expect(beacon).toContain("sd ready");
+		expect(beacon).toContain("inspect ecosystem status");
+	});
+});
+
 describe("resolveAttach", () => {
 	test("--attach flag forces attach regardless of TTY", () => {
 		expect(resolveAttach(["--attach"], false)).toBe(true);