@os-eco/overstory-cli 0.7.2 → 0.7.4

package/src/commands/dashboard.test.ts

@@ -7,18 +7,27 @@
  */
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
-import { mkdir, mkdtemp, rm } from "node:fs/promises";
+import { mkdir, mkdtemp } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { ValidationError } from "../errors.ts";
+import { createEventStore } from "../events/store.ts";
+import { color } from "../logging/color.ts";
 import { createSessionStore } from "../sessions/store.ts";
+import { cleanupTempDir } from "../test-helpers.ts";
+import type { DashboardStores } from "./dashboard.ts";
 import {
 	closeDashboardStores,
+	computeAgentPanelHeight,
 	dashboardCommand,
+	dimBox,
 	filterAgentsByRun,
 	horizontalLine,
 	openDashboardStores,
 	pad,
+	renderAgentPanel,
+	renderFeedPanel,
+	renderTasksPanel,
 	truncate,
 } from "./dashboard.ts";
 
@@ -40,7 +49,7 @@ describe("dashboardCommand", () => {
 
 	afterEach(async () => {
 		process.stdout.write = originalWrite;
-		await rm(tempDir, { recursive: true, force: true });
+		await cleanupTempDir(tempDir);
 	});
 
 	function output(): string {
@@ -203,6 +212,202 @@ describe("filterAgentsByRun", () => {
 	});
 });
 
+describe("dimBox", () => {
+	test("dimBox.vertical equals color.dim(│)", () => {
+		expect(dimBox.vertical).toBe(color.dim("│"));
+	});
+
+	test("dimBox.horizontal equals color.dim(─)", () => {
+		expect(dimBox.horizontal).toBe(color.dim("─"));
+	});
+
+	test("dimBox.tee equals color.dim(├)", () => {
+		expect(dimBox.tee).toBe(color.dim("├"));
+	});
+
+	test("dimBox.teeRight equals color.dim(┤)", () => {
+		expect(dimBox.teeRight).toBe(color.dim("┤"));
+	});
+
+	test("dimBox values equal color.dim() applied to their characters", () => {
+		// dimBox values are always equal to color.dim(char) regardless of whether
+		// Chalk emits ANSI codes (it may suppress them in non-TTY / NO_COLOR envs).
+		expect(dimBox.topLeft).toBe(color.dim("┌"));
+		expect(dimBox.topRight).toBe(color.dim("┐"));
+		expect(dimBox.bottomLeft).toBe(color.dim("└"));
+		expect(dimBox.bottomRight).toBe(color.dim("┘"));
+		expect(dimBox.cross).toBe(color.dim("┼"));
+	});
+});
+
+describe("computeAgentPanelHeight", () => {
+	test("0 agents: clamps to minimum 8", () => {
+		// max(8, min(floor(30*0.5), 0+4)) = max(8, min(15,4)) = max(8,4) = 8
+		expect(computeAgentPanelHeight(30, 0)).toBe(8);
+	});
+
+	test("4 agents: still clamps to minimum 8", () => {
+		// max(8, min(15, 4+4)) = max(8, 8) = 8
+		expect(computeAgentPanelHeight(30, 4)).toBe(8);
+	});
+
+	test("20 agents with height 30: clamps to floor(height*0.5)", () => {
+		// max(8, min(15, 24)) = max(8,15) = 15
+		expect(computeAgentPanelHeight(30, 20)).toBe(15);
+	});
+
+	test("10 agents with height 30: grows with agent count", () => {
+		// max(8, min(15, 14)) = max(8,14) = 14
+		expect(computeAgentPanelHeight(30, 10)).toBe(14);
+	});
+
+	test("small height: respects 50% cap", () => {
+		// height=20: max(8, min(10, 20+4)) = max(8,10) = 10
+		expect(computeAgentPanelHeight(20, 20)).toBe(10);
+	});
+});
+
+// Helper to build a minimal DashboardData for panel tests
+function makeDashboardData(
+	overrides: Partial<{
+		tasks: Array<{ id: string; title: string; priority: number; status: string; type: string }>;
+		recentEvents: Array<{
+			id: number;
+			agentName: string;
+			eventType: string;
+			level: string;
+			createdAt: string;
+			runId: null;
+			sessionId: null;
+			toolName: null;
+			toolArgs: null;
+			toolDurationMs: null;
+			data: null;
+		}>;
+	}> = {},
+) {
+	return {
+		currentRunId: null,
+		status: {
+			currentRunId: null,
+			agents: [],
+			worktrees: [],
+			tmuxSessions: [],
+			unreadMailCount: 0,
+			mergeQueueCount: 0,
+			recentMetricsCount: 0,
+		},
+		recentMail: [],
+		mergeQueue: [],
+		metrics: { totalSessions: 0, avgDuration: 0, byCapability: {} },
+		tasks: overrides.tasks ?? [],
+		recentEvents: (overrides.recentEvents as never[]) ?? [],
+	};
+}
+
+describe("renderTasksPanel", () => {
+	test("renders task id in output", () => {
+		const data = makeDashboardData({
+			tasks: [{ id: "t1", title: "Test task", priority: 2, status: "open", type: "task" }],
+		});
+		const out = renderTasksPanel(data, 1, 80, 10, 1);
+		expect(out).toContain("t1");
+	});
+
+	test("renders task title in output", () => {
+		const data = makeDashboardData({
+			tasks: [{ id: "t1", title: "Test task", priority: 2, status: "open", type: "task" }],
+		});
+		const out = renderTasksPanel(data, 1, 80, 10, 1);
+		expect(out).toContain("Test task");
+	});
+
+	test("renders priority label in output", () => {
+		const data = makeDashboardData({
+			tasks: [{ id: "t1", title: "Test task", priority: 2, status: "open", type: "task" }],
+		});
+		const out = renderTasksPanel(data, 1, 80, 10, 1);
+		expect(out).toContain("P2");
+	});
+
+	test("shows 'No tracker data' when tasks list is empty", () => {
+		const data = makeDashboardData({ tasks: [] });
+		const out = renderTasksPanel(data, 1, 80, 10, 1);
+		expect(out).toContain("No tracker data");
+	});
+
+	test("renders Tasks header", () => {
+		const data = makeDashboardData({ tasks: [] });
+		const out = renderTasksPanel(data, 1, 80, 6, 1);
+		expect(out).toContain("Tasks");
+	});
+
+	test("renders multiple tasks", () => {
+		const data = makeDashboardData({
+			tasks: [
+				{ id: "abc-001", title: "First task", priority: 1, status: "open", type: "task" },
+				{ id: "abc-002", title: "Second task", priority: 3, status: "in_progress", type: "bug" },
+			],
+		});
+		const out = renderTasksPanel(data, 1, 80, 10, 1);
+		expect(out).toContain("abc-001");
+		expect(out).toContain("abc-002");
+	});
+});
+
+describe("renderFeedPanel", () => {
+	test("shows 'No recent events' when recentEvents is empty", () => {
+		const data = makeDashboardData({ recentEvents: [] });
+		const out = renderFeedPanel(data, 1, 80, 8, 1);
+		expect(out).toContain("No recent events");
+	});
+
+	test("renders Feed header", () => {
+		const data = makeDashboardData({ recentEvents: [] });
+		const out = renderFeedPanel(data, 1, 80, 8, 1);
+		expect(out).toContain("Feed");
+	});
+
+	test("renders event agent name when events are present", () => {
+		const event = {
+			id: 1,
+			agentName: "test-agent",
+			eventType: "tool_end" as const,
+			level: "info" as const,
+			createdAt: new Date().toISOString(),
+			runId: null,
+			sessionId: null,
+			toolName: null,
+			toolArgs: null,
+			toolDurationMs: null,
+			data: null,
+		};
+		const data = makeDashboardData({ recentEvents: [event] });
+		// formatEventLine is a stub — returns "" — so output won't have agent name from it.
+		// But the panel itself should not throw and should render the border structure.
+		const out = renderFeedPanel(data, 1, 80, 8, 1);
+		// Panel renders without error and contains Feed header
+		expect(out).toContain("Feed");
+		// At least 1 row rendered (not the "No recent events" path)
+		expect(out).not.toContain("No recent events");
+	});
+});
+
+describe("renderAgentPanel", () => {
+	test("renders Agents header", () => {
+		const data = makeDashboardData({});
+		const out = renderAgentPanel(data, 100, 12, 3);
+		expect(out).toContain("Agents");
+	});
+
+	test("renders with dimmed border characters", () => {
+		const data = makeDashboardData({});
+		const out = renderAgentPanel(data, 100, 12, 3);
+		// dimBox.vertical is a dimmed ANSI string — present in output
+		expect(out).toContain(dimBox.vertical);
+	});
+});
+
 describe("openDashboardStores", () => {
 	let tempDir: string;
 
@@ -211,14 +416,12 @@ describe("openDashboardStores", () => {
 	});
 
 	afterEach(async () => {
-		await rm(tempDir, { recursive: true, force: true });
+		await cleanupTempDir(tempDir);
 	});
 
 	test("sessionStore is non-null when .overstory/ has sessions.db", async () => {
-		// Create the .overstory directory and seed a sessions.db via createSessionStore
 		const overstoryDir = join(tempDir, ".overstory");
 		await mkdir(overstoryDir, { recursive: true });
-		// createSessionStore creates and initialises sessions.db
 		const seeder = createSessionStore(join(overstoryDir, "sessions.db"));
 		seeder.close();
 
@@ -271,6 +474,38 @@ describe("openDashboardStores", () => {
 			closeDashboardStores(stores);
 		}
 	});
+
+	test("eventStore is null when events.db does not exist", async () => {
+		const overstoryDir = join(tempDir, ".overstory");
+		await mkdir(overstoryDir, { recursive: true });
+		const seeder = createSessionStore(join(overstoryDir, "sessions.db"));
+		seeder.close();
+
+		const stores = openDashboardStores(tempDir);
+		try {
+			expect(stores.eventStore).toBeNull();
+		} finally {
+			closeDashboardStores(stores);
+		}
+	});
+
+	test("eventStore is non-null when events.db exists", async () => {
+		const overstoryDir = join(tempDir, ".overstory");
+		await mkdir(overstoryDir, { recursive: true });
+		const seeder = createSessionStore(join(overstoryDir, "sessions.db"));
+		seeder.close();
+
+		// Create events.db via createEventStore
+		const eventsDb = createEventStore(join(overstoryDir, "events.db"));
+		eventsDb.close();
+
+		const stores = openDashboardStores(tempDir);
+		try {
+			expect(stores.eventStore).not.toBeNull();
+		} finally {
+			closeDashboardStores(stores);
+		}
+	});
 });
 
 describe("closeDashboardStores", () => {
@@ -281,7 +516,7 @@ describe("closeDashboardStores", () => {
 	});
 
 	afterEach(async () => {
-		await rm(tempDir, { recursive: true, force: true });
+		await cleanupTempDir(tempDir);
 	});
 
 	test("closing stores does not throw", async () => {
@@ -305,4 +540,28 @@ describe("closeDashboardStores", () => {
 		// Second close should not throw due to best-effort try/catch
 		expect(() => closeDashboardStores(stores)).not.toThrow();
 	});
+
+	test("closing stores with eventStore does not throw", async () => {
+		const overstoryDir = join(tempDir, ".overstory");
+		await mkdir(overstoryDir, { recursive: true });
+		const seeder = createSessionStore(join(overstoryDir, "sessions.db"));
+		seeder.close();
+		const eventsDb = createEventStore(join(overstoryDir, "events.db"));
+		eventsDb.close();
+
+		const stores = openDashboardStores(tempDir);
+		expect(() => closeDashboardStores(stores)).not.toThrow();
+	});
+});
+
+// Type check: DashboardStores includes eventStore
+test("DashboardStores type includes eventStore field", () => {
+	const stores: DashboardStores = {
+		sessionStore: null as never,
+		mailStore: null,
+		mergeQueue: null,
+		metricsStore: null,
+		eventStore: null,
+	};
+	expect(stores.eventStore).toBeNull();
 });