@orval/mock 8.28.1 → 8.30.0

package/dist/index.mjs

@@ -1,4 +1,4 @@
-import { EnumGeneration, OutputMockType, OutputMode, PropertySortOrder, camelPathParamName, compareNatural, compareVersions, escapeRegExp, generalJSTypesWithArray, generateDependencyImports, getKey, getOperationTagKey, getRefInfo, getRequiredKeys, isBoolean, isFunction, isMswMock, isNumber, isObject, isReference, isString, jsStringLiteralEscape, mergeDeep, pascal, resolveRef, stringify, toColonRoutePath } from "@orval/core";
+import { EnumGeneration, OutputMockType, OutputMode, PropertySortOrder, camelPathParamName, compareNatural, compareVersions, escapeRegExp, generalJSTypesWithArray, generateDependencyImports, getKey, getOperationTagKey, getRefInfo, getRequiredKeys, isBoolean, isFunction, isMswMock, isNumber, isObject, isReference, isString, jsStringLiteralEscape, mergeDeep, pascal, resolveRef, safeNumericConstraint, stringify, toColonRoutePath } from "@orval/core";
 import { prop } from "remeda";
 //#region src/mock-types.ts
 function isStrictMock(mockOptions) {
@@ -911,18 +911,20 @@ function getMockScalar({ item, imports, mockOptions, operationId, tags, combine,
 		case "number":
 		case "integer": {
 			const intFunction = context.output.override.useBigInt && (item.format === "int64" || item.format === "uint64") ? "bigInt" : "int";
-			const numMin = typeof item.exclusiveMinimum === "number" ? item.exclusiveMinimum : item.minimum ?? safeMockOptions.numberMin;
-			const numMax = typeof item.exclusiveMaximum === "number" ? item.exclusiveMaximum : item.maximum ?? safeMockOptions.numberMax;
+			const specMin = safeNumericConstraint(item.minimum, "minimum");
+			const specMax = safeNumericConstraint(item.maximum, "maximum");
+			const numMin = typeof item.exclusiveMinimum === "number" ? safeNumericConstraint(item.exclusiveMinimum, "exclusiveMinimum") : specMin ?? safeMockOptions.numberMin;
+			const numMax = typeof item.exclusiveMaximum === "number" ? safeNumericConstraint(item.exclusiveMaximum, "exclusiveMaximum") : specMax ?? safeMockOptions.numberMax;
 			const intParts = [];
 			if (numMin !== void 0) intParts.push(`min: ${numMin}`);
 			if (numMax !== void 0) intParts.push(`max: ${numMax}`);
-			if (isFakerV9 && item.multipleOf !== void 0) intParts.push(`multipleOf: ${item.multipleOf}`);
+			if (isFakerV9 && item.multipleOf !== void 0) intParts.push(`multipleOf: ${safeNumericConstraint(item.multipleOf, "multipleOf")}`);
 			let value = getNullable(`faker.number.${intFunction}(${intParts.length > 0 ? `{${intParts.join(", ")}}` : ""})`, isNullable, nonNullableOption);
 			if (type === "number") {
 				const floatParts = [];
 				if (numMin !== void 0) floatParts.push(`min: ${numMin}`);
 				if (numMax !== void 0) floatParts.push(`max: ${numMax}`);
-				if (isFakerV9 && item.multipleOf !== void 0) floatParts.push(`multipleOf: ${item.multipleOf}`);
+				if (isFakerV9 && item.multipleOf !== void 0) floatParts.push(`multipleOf: ${safeNumericConstraint(item.multipleOf, "multipleOf")}`);
 				else if (safeMockOptions.fractionDigits !== void 0) floatParts.push(`fractionDigits: ${safeMockOptions.fractionDigits}`);
 				value = getNullable(`faker.number.float(${floatParts.length > 0 ? `{${floatParts.join(", ")}}` : ""})`, isNullable, nonNullableOption);
 			}
@@ -1027,8 +1029,8 @@ function getMockScalar({ item, imports, mockOptions, operationId, tags, combine,
 			});
 			if (extractedItemCall) mapValue = extractedItemCall;
 			if (combine && !value.startsWith("faker") && !value.startsWith("{") && !value.startsWith("Array.from")) mapValue = `{${value}}`;
-			const arrSchemaMin = item.minItems;
-			const arrSchemaMax = item.maxItems;
+			const arrSchemaMin = safeNumericConstraint(item.minItems, "minItems");
+			const arrSchemaMax = safeNumericConstraint(item.maxItems, "maxItems");
 			const arrGlobalMin = safeMockOptions.arrayMin;
 			const arrGlobalMax = safeMockOptions.arrayMax;
 			let arrMin;
@@ -1051,8 +1053,8 @@ function getMockScalar({ item, imports, mockOptions, operationId, tags, combine,
 			};
 		}
 		case "string": {
-			const schemaMin = item.minLength;
-			const schemaMax = item.maxLength;
+			const schemaMin = safeNumericConstraint(item.minLength, "minLength");
+			const schemaMax = safeNumericConstraint(item.maxLength, "maxLength");
 			const globalMin = safeMockOptions.stringMin;
 			const globalMax = safeMockOptions.stringMax;
 			let strMin;
@@ -1137,9 +1139,23 @@ function getItemType(item) {
 	if (!type) return;
 	return ["string", "number"].includes(type) ? type : void 0;
 }
+/**
+* Renders one enum member as a literal for the generated faker array.
+*
+* The branch is on the member's own type, never on the schema's declared
+* `type`: both come from the document and nothing makes them agree. Keying off
+* the declared type meant a string member under `type: 'integer'` was spliced
+* in as a live expression, a numeric member under `type: 'string'` crashed the
+* generator, and an object member emitted `[object Object]`.
+*/
+function formatEnumMember(value) {
+	if (isString(value)) return `'${jsStringLiteralEscape(value)}'`;
+	if (isNumber(value) || isBoolean(value)) return String(value);
+	return JSON.stringify(value);
+}
 function getEnum(item, imports, context, existingReferencedProperties, type) {
 	if (!item.enum) return "";
-	let enumValue = `[${item.enum.filter((e) => e !== null).map((e) => type === "string" || type === void 0 && isString(e) ? `'${jsStringLiteralEscape(e)}'` : e).join(",")}]`;
+	let enumValue = `[${item.enum.filter((e) => e !== null).map((e) => formatEnumMember(e)).join(",")}]`;
 	if (context.output.override.enumGenerationType === EnumGeneration.ENUM) {
 		const isRootSchema = !item.parentName && existingReferencedProperties.at(-1) === item.name;
 		if (item.isRef || existingReferencedProperties.length === 0 || isRootSchema) {
@@ -1153,7 +1169,7 @@ function getEnum(item, imports, context, existingReferencedProperties, type) {
 			imports.push({ name: parentReference });
 		}
 	} else enumValue += " as const";
-	if (item.isRef && type === "string" && context.output.override.enumGenerationType !== EnumGeneration.UNION) {
+	if (item.isRef && type === "string" && item.enum.every((e) => isString(e)) && context.output.override.enumGenerationType !== EnumGeneration.UNION) {
 		enumValue = `Object.values(${item.name})`;
 		imports.push({
 			name: item.name,
@@ -1531,7 +1547,7 @@ function combineSchemasMock({ item, separator, mockOptions, operationId, tags, c
 }
 //#endregion
 //#region src/faker/getters/route.ts
-const getRouteMSW = (route, baseUrl = "*") => `${baseUrl}${toColonRoutePath(route.replaceAll(":", String.raw`\\:`), camelPathParamName)}`;
+const getRouteMSW = (route, baseUrl = "*") => `${jsStringLiteralEscape(baseUrl)}${toColonRoutePath(jsStringLiteralEscape(route).replaceAll(":", String.raw`\\:`), camelPathParamName)}`;
 //#endregion
 //#region src/msw/mocks.ts
 function getMockPropertiesWithoutFunc(properties, spec) {
@@ -1649,7 +1665,7 @@ function getResponsesMockDefinition({ operationId, tags, returnType, responses,
 		};
 		else if (!originalSchema) continue;
 		const resolvedSchema = resolveRef(originalSchema, context).schema;
-		const responseImports = imports ?? [];
+		const responseImports = imports ? [...imports] : [];
 		const importsBefore = responseImports.length;
 		const scalar = getMockScalar({
 			item: {
@@ -1697,6 +1713,24 @@ function getMockOptionsDataOverride(operationTags, operationId, override) {
 }
 //#endregion
 //#region src/msw/index.ts
+/**
+* Resolves an OpenAPI response key to the numeric status the generated handler
+* emits.
+*
+* The key comes straight from the document and lands in an unquoted expression
+* position (`{ status: 200 }`), so there is no quote to escape and no way to
+* make a non-numeric value safe there — a key like
+* `2,x:(<expression>)` would splice live code into the handler. Parse it, and
+* refuse the document rather than emitting whatever it says.
+*
+* `default` maps to 200 and a `NXX` wildcard to `N00`, matching what the
+* handler previously emitted for those keys.
+*/
+function assertSafeStatusCode(status) {
+	const normalized = status === "default" ? "200" : /^\dXX$/.test(status) ? `${status[0]}00` : status;
+	if (!/^\d{3}$/.test(normalized)) throw new Error(`orval: refusing to generate a mock handler for an OpenAPI response key that is not a status code (got "${status}"). This value would otherwise be emitted verbatim into generated source.`);
+	return Number(normalized);
+}
 function getMSWDependencies(options) {
 	const locale = options?.locale;
 	const fakerDependency = {
@@ -1775,7 +1809,7 @@ function generateDefinition(name, route, getResponseMockFunctionNameBase, handle
 	const binaryTypeRewriteRegex = new RegExp(String.raw`\b(?:${["Blob", ...binaryRefNames].map((n) => escapeRegExp(n)).join("|")})\b`, "g");
 	const mockReturnType = isBinaryResponse ? returnType.replaceAll(binaryTypeRewriteRegex, "ArrayBuffer") : returnType;
 	const isVoidUnionType = mockReturnType !== "void" && mockReturnType.split("|").some((part) => part.trim() === "void");
-	const noContentStatusCode = isVoidUnionType ? responses.find((r) => r.value === "void")?.key ?? "204" : void 0;
+	const noContentStatusCode = isVoidUnionType ? assertSafeStatusCode(responses.find((r) => r.value === "void")?.key ?? "204") : void 0;
 	const nonVoidMockReturnType = isVoidUnionType ? mockReturnType.split("|").filter((part) => part.trim() !== "void").join(" | ").trim() : mockReturnType;
 	const hasJsonContentType = contentTypesByPreference.some((ct) => ct.includes("json") || ct.includes("+json"));
 	const hasStringReturnType = isTypeExactlyString(mockReturnType) || isUnionContainingString(mockReturnType);
@@ -1810,14 +1844,14 @@ function generateDefinition(name, route, getResponseMockFunctionNameBase, handle
 	const resolvedResponseExpr = `overrideResponse !== undefined
     ? (typeof overrideResponse === "function" ? await overrideResponse(${infoParam}) : overrideResponse)
     : ${getResponseMockFunctionName}()`;
-	const statusCode = status === "default" ? 200 : status.replace(/XX$/, "00");
+	const statusCode = assertSafeStatusCode(status);
 	const binaryContentType = (preferredContentTypeMatch && isBinaryLikeContentType(preferredContentTypeMatch) ? preferredContentTypeMatch : contentTypes.find((ct) => isBinaryLikeContentType(ct))) ?? "application/octet-stream";
 	const firstTextCt = isExactlyStringReturnType && !!preferredContentTypeMatch && !isTextLikeContentType(preferredContentTypeMatch) && hasTextLikeContentType ? contentTypes.find((ct) => isTextLikeContentType(ct)) : contentTypesByPreference.find((ct) => isTextLikeContentType(ct));
 	const textHelper = firstTextCt === "application/xml" || firstTextCt?.endsWith("+xml") ? "xml" : firstTextCt === "text/html" ? "html" : "text";
 	const firstJsonCt = contentTypesByPreference.find((ct) => ct.includes("json"));
 	const textHelperDefaultContentType = textHelper === "xml" ? "text/xml" : textHelper === "html" ? "text/html" : "text/plain";
-	const jsonCtHeaderSuffix = firstJsonCt && firstJsonCt !== "application/json" ? `, headers: { 'Content-Type': '${firstJsonCt}' }` : preferredContentTypeMatch && !preferredContentTypeMatch.includes("json") ? `, headers: { 'Content-Type': '${preferredContentTypeMatch}' }` : "";
-	const textCtHeaderSuffix = firstTextCt && firstTextCt !== textHelperDefaultContentType ? `, headers: { 'Content-Type': '${firstTextCt}' }` : "";
+	const jsonCtHeaderSuffix = firstJsonCt && firstJsonCt !== "application/json" ? `, headers: { 'Content-Type': '${jsStringLiteralEscape(firstJsonCt)}' }` : preferredContentTypeMatch && !preferredContentTypeMatch.includes("json") ? `, headers: { 'Content-Type': '${jsStringLiteralEscape(preferredContentTypeMatch)}' }` : "";
+	const textCtHeaderSuffix = firstTextCt && firstTextCt !== textHelperDefaultContentType ? `, headers: { 'Content-Type': '${jsStringLiteralEscape(firstTextCt)}' }` : "";
 	let responseBody;
 	let responsePrelude = "";
 	if (isReturnHttpResponse) {
@@ -1834,7 +1868,7 @@ function generateDefinition(name, route, getResponseMockFunctionNameBase, handle
         ? binaryBody
         : new ArrayBuffer(0),
       { status: ${statusCode},
-        headers: { 'Content-Type': '${binaryContentType}' }
+        headers: { 'Content-Type': '${jsStringLiteralEscape(binaryContentType)}' }
       })`;
 	else if (isVoidUnionType) {
 		let nonVoidBody;