@orthacms/media-provider-local 0.3.0 → 0.4.1

package/dist/lib/local-storage-provider.d.ts

@@ -3,8 +3,6 @@ import type { StorageProvider } from '@orthacms/media-server';
 export interface LocalStorageConfig {
     /** Directory blobs live under (absolute or project-relative). */
     rootDir: string;
-    /** Base path the browser hits to stream a blob (reserved for direct URLs). */
-    publicBasePath: string;
 }
 /**
  * Raised when a storage key resolves outside the provider's `rootDir`.

package/dist/lib/local-storage-provider.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"local-storage-provider.d.ts","sourceRoot":"","sources":["../../src/lib/local-storage-provider.ts"],"names":[],"mappings":"AAMA,OAAO,KAAK,EAER,eAAe,EAElB,MAAM,wBAAwB,CAAC;AAEhC,0CAA0C;AAC1C,MAAM,WAAW,kBAAkB;IAC/B,iEAAiE;IACjE,OAAO,EAAE,MAAM,CAAC;IAChB,8EAA8E;IAC9E,cAAc,EAAE,MAAM,CAAC;CAC1B;AAED;;;;;;;;;;GAUG;AACH,qBAAa,0BAA2B,SAAQ,KAAK;IACrC,QAAQ,CAAC,UAAU,EAAE,MAAM;gBAAlB,UAAU,EAAE,MAAM;CAI1C;AAgFD;;;;;;;;;;;;GAYG;AACH,wBAAgB,0BAA0B,CACtC,MAAM,EAAE,kBAAkB,GAC3B,eAAe,CA2IjB"}
+{"version":3,"file":"local-storage-provider.d.ts","sourceRoot":"","sources":["../../src/lib/local-storage-provider.ts"],"names":[],"mappings":"AAOA,OAAO,KAAK,EAER,eAAe,EAElB,MAAM,wBAAwB,CAAC;AAEhC,0CAA0C;AAC1C,MAAM,WAAW,kBAAkB;IAC/B,iEAAiE;IACjE,OAAO,EAAE,MAAM,CAAC;CACnB;AAED;;;;;;;;;;GAUG;AACH,qBAAa,0BAA2B,SAAQ,KAAK;IACrC,QAAQ,CAAC,UAAU,EAAE,MAAM;gBAAlB,UAAU,EAAE,MAAM;CAI1C;AAgFD;;;;;;;;;;;;GAYG;AACH,wBAAgB,0BAA0B,CACtC,MAAM,EAAE,kBAAkB,GAC3B,eAAe,CA2JjB"}

package/dist/lib/local-storage-provider.js

@@ -8,6 +8,7 @@ const promises_1 = require("node:fs/promises");
 const node_path_1 = require("node:path");
 const node_stream_1 = require("node:stream");
 const promises_2 = require("node:stream/promises");
+const media_server_1 = require("@orthacms/media-server");
 /**
  * Raised when a storage key resolves outside the provider's `rootDir`.
  *
@@ -150,6 +151,18 @@ function createLocalStorageProvider(config) {
         return target;
     };
     return {
+        id: 'local',
+        capabilities: {
+            // A filesystem cannot mint a URL the browser may fetch on its own:
+            // serving `rootDir` statically would hand every blob to anyone
+            // holding a key, and keys are returned in API responses. Downloads
+            // stay proxied through the app's own route.
+            directUrl: false,
+            // Accepted and dropped — a filesystem has nowhere to put it. The
+            // authoritative type stays `media_asset.mime_type`.
+            contentTypeMetadata: false,
+            streamingPut: true
+        },
         async put(object) {
             const storageKey = keyFor(object.workspaceId, object.assetId, object.fileName, object.isVariant ?? false);
             const target = absolute(storageKey);
@@ -190,7 +203,23 @@ function createLocalStorageProvider(config) {
             // response was already a streaming 200 that could no longer become
             // a 404. Opening the descriptor here moves the failure back in
             // front of the response.
-            const handle = await (0, promises_1.open)(absolute(storageKey), 'r');
+            //
+            // The *kind* of rejection is the port's too, not this backend's:
+            // a raw `ENOENT` reaching the controller made a missing blob a
+            // **500**, where the row exists and the bytes do not — from the
+            // caller's side indistinguishable from a missing asset, which the
+            // route already answers 404 for. `ObjectNotFoundError` is what
+            // `to-http.ts` maps; `provider-s3` raises the same for `NoSuchKey`.
+            //
+            // Only `ENOENT`/`ENOTDIR` — a permission error or a full descriptor
+            // table is an operator's problem, and reporting it as "not found"
+            // would hide an outage behind a plausible 404.
+            const handle = await (0, promises_1.open)(absolute(storageKey), 'r').catch((error) => {
+                if (error.code === 'ENOENT' || error.code === 'ENOTDIR') {
+                    throw new media_server_1.ObjectNotFoundError(storageKey, error);
+                }
+                throw error;
+            });
             const stats = await handle.stat();
             if (!stats.isFile()) {
                 await handle.close();
@@ -204,20 +233,6 @@ function createLocalStorageProvider(config) {
             const target = absolute(storageKey);
             await (0, promises_1.rm)(target, { force: true });
             await pruneEmptyDirectories((0, node_path_1.dirname)(target), root);
-        },
-        async url(storageKey) {
-            // NOTE: no route serves this path today — downloads go through
-            // `GET /api/media/assets/:id/raw`, which resolves the key from the
-            // asset row *after* checking workspace membership. Nothing calls
-            // `url()`; it exists because the port promises a direct URL that a
-            // signed-URL backend (S3) can give and a filesystem cannot.
-            //
-            // Whoever implements the static-serving mode: it must not be an
-            // `express.static` over `rootDir`. That would serve every blob to
-            // anyone who can guess a key and would bypass the membership check
-            // wholesale — the keys are uuids, but they are also handed out in
-            // API responses.
-            return `${config.publicBasePath}/blob/${encodeURIComponent(storageKey)}`;
         }
     };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@orthacms/media-provider-local",
-    "version": "0.3.0",
+    "version": "0.4.1",
     "description": "@orthacms/media-provider-local — part of Ortha CMS.",
     "license": "MIT",
     "homepage": "https://github.com/ortha-source/ortha-cms/tree/main/packages/media/provider-local",
@@ -25,7 +25,7 @@
         "dist"
     ],
     "dependencies": {
-        "@orthacms/media-server": "^0.3.0",
+        "@orthacms/media-server": "^0.4.1",
         "tslib": "^2.3.0"
     },
     "publishConfig": {