@ornncompute/cli 1.0.72 → 1.0.97

package/src/vm-commands.mjs

@@ -1,3 +1,4 @@
+import { getReservation } from "../vendor/api-client/commerce.js";
 import { spawn as spawnProcessDefault } from "node:child_process";
 import { createHash } from "node:crypto";
 import { readFile } from "node:fs/promises";
@@ -9,6 +10,7 @@ import { resolvedMountPath } from "./mount-commands.mjs";
 import {
   isReferenceMiss,
   listActiveDirectReservations,
+  listActiveReservations,
   listOwnedActiveMachines,
   reservationLabeler,
   resolveMachineReference,
@@ -70,14 +72,13 @@ function machineAccessMode(value) {
 
 function reservationAccessMode(value) {
   const reservation = record(value);
-  const mode =
-    (text(reservation.access_mode) ?? text(reservation.accessMode))?.toLowerCase() ?? null;
+  const mode = text(reservation.provisioningType)?.toLowerCase() ?? null;
   return mode === "virtual-machine" ? "vm" : mode;
 }
 
 function isDirectReservation(value) {
   const mode = reservationAccessMode(value);
-  return !mode || mode === "vm" || mode === "bare-metal";
+  return mode === "vm" || mode === "bare-metal";
 }
 
 function machineIsReady(value) {
@@ -303,7 +304,6 @@ function failedOperationRecoveryCommand(value, interaction) {
       `--mode ${accessMode}`,
       `--network ${networkMode}`,
       accessMode !== sourceMode ? "--erase-local-data" : null,
-      "--yes",
       `--idempotency-key ${requestId}`,
     ]
       .filter(Boolean)
@@ -317,7 +317,6 @@ function failedOperationRecoveryCommand(value, interaction) {
       `ornn machines ${command}`,
       shellQuote(id),
       command === "reset" ? "--erase-local-data" : null,
-      "--yes",
       `--idempotency-key ${requestId}`,
     ]
       .filter(Boolean)
@@ -392,7 +391,7 @@ function positional(input, expected, usage, interaction) {
   return values;
 }
 
-function machineMutationPreflight(input, interaction, { requireYes = true } = {}) {
+function machineMutationPreflight(input, interaction) {
   if (!interaction.machine) return;
   if (!text(input.idempotencyKey)) {
     interaction.usage("--idempotency-key is required for automation.", {
@@ -400,12 +399,6 @@ function machineMutationPreflight(input, interaction, { requireYes = true } = {}
       field: "idempotencyKey",
     });
   }
-  if (requireYes && input.yes !== true) {
-    interaction.usage("--yes is required for automation after reviewing the exact intent.", {
-      code: "consent_required",
-      field: "yes",
-    });
-  }
 }
 
 async function selectedOrganization(context, interaction, expectedId) {
@@ -432,7 +425,7 @@ async function selectedOrganization(context, interaction, expectedId) {
 
 function assertActiveReservation(value, expectedRef, interaction, expectedMode = null) {
   const reservation = record(value);
-  const ref = resourceId(reservation);
+  const ref = text(reservation.reservationId);
   if (!ref || ref !== expectedRef) {
     interaction.error("The gateway returned an unrelated capacity reservation.", {
       code: "reservation_correlation_changed",
@@ -471,7 +464,7 @@ async function resolveReservation(context, input, interaction, expectedMode = nu
   if (supplied) {
     const ref = requireCanonical(interaction, supplied, "reservation", "Capacity reservation");
     return assertActiveReservation(
-      await context.fetch(`/v1/workflows/commerce/reservations/${encodeURIComponent(ref)}`),
+      await getReservation(context.fetch, ref),
       ref,
       interaction,
       expectedMode
@@ -483,29 +476,23 @@ async function resolveReservation(context, input, interaction, expectedMode = nu
       field: "reservation",
     });
   }
-  const payload = await context.fetch("/v1/workflows/commerce/reservations?status=active&limit=50");
   const requestedMode = expectedMode ?? text(input.mode)?.toLowerCase() ?? null;
-  const candidates = (Array.isArray(payload) ? payload : (record(payload).reservations ?? []))
-    .map(record)
-    .filter(
-      (reservation) =>
-        (text(reservation.status) ?? "").toLowerCase() === ACTIVE_RESERVATION &&
-        resourceId(reservation) &&
-        (!requestedMode || reservationAccessMode(reservation) === requestedMode)
-    );
+  const candidates = (await listActiveReservations(context, interaction)).filter(
+    (reservation) => !requestedMode || reservationAccessMode(reservation) === requestedMode
+  );
   if (!candidates.length) {
     interaction.error("No active capacity reservation is eligible for launch.", {
       code: "no_active_reservation",
     });
   }
-  let ref = resourceId(candidates[0]);
+  let ref = text(candidates[0].reservationId);
   if (candidates.length > 1) {
     const reservationLabel = await reservationLabeler(context.fetch);
     ref = await interaction.ask({
       label: "Capacity reservation",
       choices: candidates.map((reservation) => ({
         label: reservationLabel(reservation),
-        value: resourceId(reservation),
+        value: text(reservation.reservationId),
       })),
     });
   }
@@ -514,7 +501,7 @@ async function resolveReservation(context, input, interaction, expectedMode = nu
       code: "missing_input",
     });
   return assertActiveReservation(
-    await context.fetch(`/v1/workflows/commerce/reservations/${encodeURIComponent(ref)}`),
+    await getReservation(context.fetch, ref),
     ref,
     interaction,
     expectedMode
@@ -821,12 +808,6 @@ function launchInputPreflight(input, interaction) {
       field: "label",
     });
   }
-  if (input.yes !== true) {
-    interaction.usage("--yes is required for automation after reviewing the launch intent.", {
-      code: "consent_required",
-      field: "yes",
-    });
-  }
   if (!text(input.idempotencyKey)) {
     interaction.usage("--idempotency-key is required for automation.", {
       code: "idempotency_key_required",
@@ -1058,7 +1039,7 @@ export const vmLaunchModeHandler = {
     input = await normalizePublicKeyInput(input);
     const organization = await selectedOrganization(context, interaction);
     const reservation = await resolveReservation(context, input, interaction, "vm");
-    const reservationId = resourceId(reservation);
+    const reservationId = text(reservation.reservationId);
     const keyPlan = await keyPlanFromInput(context, input, interaction);
     const [reviewedMachines, reviewedRelationships] = await Promise.all([
       fetchMachines(context, reservationId),
@@ -1109,9 +1090,7 @@ export const vmLaunchModeHandler = {
 
     await selectedOrganization(context, interaction, organization.id);
     const currentReservation = assertActiveReservation(
-      await context.fetch(
-        `/v1/workflows/commerce/reservations/${encodeURIComponent(reservationId)}`
-      ),
+      await getReservation(context.fetch, reservationId),
       reservationId,
       interaction,
       "vm"
@@ -1199,7 +1178,7 @@ export const vmLaunchModeHandler = {
           resourceId(key),
           "--idempotency-key",
           idempotencyKey,
-          ...(interaction.machine ? ["--yes", "--no-wait", "--format", "json"] : []),
+          ...(interaction.machine ? ["--no-wait", "--format", "json"] : []),
         ].join(" ");
         return uncertainMutationFailure(interaction, error, {
           data: {
@@ -1362,15 +1341,13 @@ function reservationAllocationContext(value) {
   const reservation = record(value);
   return {
     term: {
-      start: text(reservation.start_at) ?? text(reservation.start),
-      end: text(reservation.end_at) ?? text(reservation.end),
+      start: text(reservation.startsAt),
+      end: text(reservation.endsAt),
     },
-    machine_count: Number.isSafeInteger(reservation.node_count)
-      ? reservation.node_count
-      : Number.isSafeInteger(reservation.machine_count)
-        ? reservation.machine_count
-        : null,
-    gpu_count: Number.isSafeInteger(reservation.gpu_count) ? reservation.gpu_count : null,
+    machine_count: reservation.reservedNodeCount,
+    gpu_count: Number.isSafeInteger(reservation.reservedGpuCount)
+      ? reservation.reservedGpuCount
+      : null,
   };
 }
 
@@ -1434,7 +1411,7 @@ function bareMetalIntentSignature(reservation, relationships) {
 }
 
 function bareMetalLaunchData(reservation, machine, key, relationships, waitPolicy, replayed) {
-  const reservationId = resourceId(reservation);
+  const reservationId = text(reservation.reservationId);
   const invocation = isSshReady(machine, key) ? sshInvocation(machine) : null;
   return {
     mode: "bare-metal",
@@ -1520,16 +1497,13 @@ function durableWorkspaceAllocation(reservation, interaction) {
   const endMilliseconds = Date.parse(end ?? "");
   const duration = endMilliseconds - startMilliseconds;
   const machineCount = allocation.machine_count;
-  const gpusPerMachine = Number.isSafeInteger(reservation.gpus_per_node)
-    ? reservation.gpus_per_node
-    : Number.isSafeInteger(reservation.gpus_per_machine)
-      ? reservation.gpus_per_machine
-      : null;
+  const gpusPerMachine = reservation.gpusPerNode;
   const gpuCount = Number.isSafeInteger(allocation.gpu_count)
     ? allocation.gpu_count
     : Number.isSafeInteger(machineCount) && Number.isSafeInteger(gpusPerMachine)
       ? machineCount * gpusPerMachine
       : null;
+  // CPU capacity has no GPUs; a workspace needs only its whole machines.
   if (
     !start ||
     !end ||
@@ -1537,9 +1511,7 @@ function durableWorkspaceAllocation(reservation, interaction) {
     !Number.isFinite(endMilliseconds) ||
     duration <= 0 ||
     !Number.isSafeInteger(machineCount) ||
-    machineCount < 1 ||
-    !Number.isSafeInteger(gpuCount) ||
-    gpuCount < 1
+    machineCount < 1
   ) {
     interaction.error("The active capacity reservation does not contain valid allocation facts.", {
       code: "reservation_allocation_incomplete",
@@ -1559,7 +1531,6 @@ function durableWorkspaceAllocation(reservation, interaction) {
 function workspaceStepContext(context, interaction, signal) {
   const stepInteraction = Object.create(interaction);
   stepInteraction.review = async () => true;
-  stepInteraction.options = { ...interaction.options, yes: true };
   return {
     ...context,
     fetch: (path, init = {}) =>
@@ -1642,7 +1613,7 @@ function workspaceRelationshipConflict(facts, goal, interaction) {
 function durableWorkspaceSignature(reservation, key, facts, goal, interaction) {
   return JSON.stringify({
     capacity_reservation: {
-      id: resourceId(reservation),
+      id: text(reservation.reservationId),
       status: text(reservation.status),
       allocation: durableWorkspaceAllocation(reservation, interaction),
     },
@@ -1681,7 +1652,7 @@ function workspaceResumeCommand(input, goal, facts, id, interaction, localResume
   if (goal.username) parts.push("--username", goal.username);
   if (input.noWait) parts.push("--no-wait");
   if (input.wait) parts.push("--wait", "--timeout", text(input.timeout));
-  if (interaction.machine) parts.push("--yes", "--format", interaction.format);
+  if (interaction.machine) parts.push("--format", interaction.format);
   return parts.map(shellQuote).join(" ");
 }
 
@@ -1799,7 +1770,7 @@ async function launchDurableBareMetalWorkspace({
   keyPlan,
 }) {
   const id = workspaceId(input, interaction);
-  const reservationId = resourceId(reservation);
+  const reservationId = text(reservation.reservationId);
   if (keyPlan.kind !== "existing") {
     interaction.usage("A durable Bare Metal workspace requires a declared existing SSH key.", {
       code: "workspace_ssh_key_required",
@@ -1843,8 +1814,8 @@ async function launchDurableBareMetalWorkspace({
         value: `${allocation.term.start} to ${allocation.term.end} (${allocation.term.hours} hours)`,
       },
       {
-        label: "GPU quantity",
-        value: `${allocation.quantity.gpu_count} GPUs across ${allocation.quantity.machine_count} machine${allocation.quantity.machine_count === 1 ? "" : "s"}`,
+        label: "Quantity",
+        value: `${allocation.quantity.gpu_count > 0 ? `${allocation.quantity.gpu_count} GPUs` : "CPU"} across ${allocation.quantity.machine_count} machine${allocation.quantity.machine_count === 1 ? "" : "s"}`,
       },
       {
         label: "Creation",
@@ -1875,7 +1846,7 @@ async function launchDurableBareMetalWorkspace({
 
   await selectedOrganization(context, interaction, organization.id);
   const [currentReservationValue, currentKeyPlan, currentFacts] = await Promise.all([
-    context.fetch(`/v1/workflows/commerce/reservations/${encodeURIComponent(reservationId)}`),
+    getReservation(context.fetch, reservationId),
     keyPlanFromInput(context, input, interaction),
     workspaceResourceFacts(context, interaction, input, reservationId),
   ]);
@@ -1952,7 +1923,6 @@ async function launchDurableBareMetalWorkspace({
         $positionals: [reservationId],
         key: resourceId(key),
         idempotencyKey: `${id}:ssh-key`,
-        yes: true,
       }
     );
     states.ssh_key_assignment = {
@@ -1988,7 +1958,6 @@ async function launchDurableBareMetalWorkspace({
         idempotencyKey: `${id}:volume-mount`,
         noWait: true,
         volume: facts.volume.id,
-        yes: true,
       }
     );
     facts.volumeMount = mount.data.volume_mount;
@@ -2307,7 +2276,7 @@ export const bareMetalLaunchModeHandler = {
     input = await normalizePublicKeyInput(input);
     const organization = await selectedOrganization(context, interaction, resumeOrganizationId);
     const reservation = await resolveReservation(context, input, interaction, "bare-metal");
-    const reservationId = resourceId(reservation);
+    const reservationId = text(reservation.reservationId);
     const keyPlan = await keyPlanFromInput(context, input, interaction);
     if (durableWorkspace) {
       return launchDurableBareMetalWorkspace({
@@ -2375,7 +2344,7 @@ export const bareMetalLaunchModeHandler = {
 
     const [currentReservationValue, currentRelationships, existingAssigned, projectedMachines] =
       await Promise.all([
-        context.fetch(`/v1/workflows/commerce/reservations/${encodeURIComponent(reservationId)}`),
+        getReservation(context.fetch, reservationId),
         bareMetalRelationships(context, reservationId),
         fetchAssignedKeys(context, reservationId),
         fetchMachines(context, reservationId),
@@ -2464,7 +2433,7 @@ export const bareMetalLaunchModeHandler = {
           resourceId(key),
           "--idempotency-key",
           idempotencyKey,
-          ...(interaction.machine ? ["--yes", "--no-wait", "--format", "json"] : []),
+          ...(interaction.machine ? ["--no-wait", "--format", "json"] : []),
         ].join(" ");
         return uncertainMutationFailure(interaction, error, {
           data: {
@@ -2757,9 +2726,7 @@ function createDirectMachineConnectModeHandler({
           code: "machine_correlation_failed",
         });
       }
-      const reservation = await context.fetch(
-        `/v1/workflows/commerce/reservations/${encodeURIComponent(reservationId)}`
-      );
+      const reservation = await getReservation(context.fetch, reservationId);
       if (!isDirectReservation(reservation)) return null;
       const privateTransportRequired = text(machine.network_mode) === "private";
       return {
@@ -3002,24 +2969,12 @@ function validateWaitInput(input, interaction, { waitCommand = false } = {}) {
 function requireMachineMutationSafety(input, interaction, { destructive = false } = {}) {
   validateWaitInput(input, interaction);
   if (destructive && input.eraseLocalData !== true) {
-    interaction.usage(
-      "machines reset requires --erase-local-data; --yes cannot infer destructive scope.",
-      {
-        code: "erase_local_data_required",
-        field: "eraseLocalData",
-      }
-    );
+    interaction.usage("machines reset requires --erase-local-data.", {
+      code: "erase_local_data_required",
+      field: "eraseLocalData",
+    });
   }
   if (interaction.machine || !interaction.eligibleHuman) {
-    if (input.yes !== true) {
-      interaction.usage(
-        "--yes is required outside an eligible terminal after reviewing the exact intent.",
-        {
-          code: "consent_required",
-          field: "yes",
-        }
-      );
-    }
     if (!text(input.idempotencyKey)) {
       interaction.usage("--idempotency-key is required outside an eligible terminal.", {
         code: "idempotency_key_required",
@@ -3103,9 +3058,7 @@ async function resolveMachineCommandTarget(input, context, interaction, usage) {
       code: "machine_correlation_failed",
     });
   }
-  const reservation = await context.fetch(
-    `/v1/workflows/commerce/reservations/${encodeURIComponent(reservationId)}`
-  );
+  const reservation = await getReservation(context.fetch, reservationId);
   if (!isDirectReservation(reservation)) {
     interaction.error(
       "The selected machine belongs to a cluster rather than the direct-machine lifecycle.",
@@ -3360,19 +3313,19 @@ async function guidedSwitchReservation(context, interaction) {
       code: "no_active_reservation",
     });
   }
-  let reference = resourceId(reservations[0]);
+  let reference = text(reservations[0].reservationId);
   if (reservations.length > 1) {
     const reservationLabel = await reservationLabeler(context.fetch);
     reference = await interaction.ask({
       label: "Capacity reservation",
       choices: reservations.map((reservation) => ({
         label: reservationLabel(reservation),
-        value: resourceId(reservation),
+        value: text(reservation.reservationId),
       })),
     });
   }
   return assertActiveReservation(
-    await context.fetch(`/v1/workflows/commerce/reservations/${encodeURIComponent(reference)}`),
+    await getReservation(context.fetch, reference),
     reference,
     interaction
   );
@@ -3409,14 +3362,12 @@ async function switchMachine(input, context, interaction) {
   }
   const reservation = suppliedReservation
     ? assertActiveReservation(
-        await context.fetch(
-          `/v1/workflows/commerce/reservations/${encodeURIComponent(suppliedReservation)}`
-        ),
+        await getReservation(context.fetch, suppliedReservation),
         suppliedReservation,
         interaction
       )
     : await guidedSwitchReservation(context, interaction);
-  const reservationId = resourceId(reservation);
+  const reservationId = text(reservation.reservationId);
   if (!isDirectReservation(reservation)) {
     interaction.error("machines switch accepts only a direct VM or Bare Metal reservation.", {
       code: "reservation_not_direct",
@@ -3452,7 +3403,7 @@ async function switchMachine(input, context, interaction) {
   const erasesLocalData = targetMode !== currentMode;
   if (erasesLocalData && input.eraseLocalData !== true) {
     interaction.usage(
-      "Changing between VM and Bare Metal permanently erases source-local data and requires --erase-local-data; --yes cannot infer destructive scope.",
+      "Changing between VM and Bare Metal permanently erases source-local data and requires --erase-local-data; cannot infer destructive scope.",
       { code: "erase_local_data_required", field: "eraseLocalData" }
     );
   }
@@ -3525,7 +3476,7 @@ async function switchMachine(input, context, interaction) {
   }
   const [currentReservationValue, currentMachines, currentRelationships, currentKeys] =
     await Promise.all([
-      context.fetch(`/v1/workflows/commerce/reservations/${encodeURIComponent(reservationId)}`),
+      getReservation(context.fetch, reservationId),
       fetchMachines(context, reservationId),
       bareMetalRelationships(context, reservationId),
       fetchAssignedKeys(context, reservationId),
@@ -3561,7 +3512,6 @@ async function switchMachine(input, context, interaction) {
     requestedMode ? `--mode ${requestedMode}` : null,
     requestedNetwork ? `--network ${requestedNetwork}` : null,
     erasesLocalData ? "--erase-local-data" : null,
-    "--yes",
     "--no-wait",
     `--idempotency-key ${shellQuote(idempotencyKey)}`,
   ]
@@ -3663,7 +3613,6 @@ async function switchMachine(input, context, interaction) {
     `--mode ${targetMode}`,
     `--network ${targetNetwork}`,
     erasesLocalData ? "--erase-local-data" : null,
-    "--yes",
     `--idempotency-key ${shellQuote(interaction.idempotencyKey())}`,
   ]
     .filter(Boolean)
@@ -3781,7 +3730,6 @@ async function maintainMachine(command, input, context, interaction) {
     `ornn machines ${command}`,
     shellQuote(machineId(machine)),
     destructive ? "--erase-local-data" : null,
-    "--yes",
     "--no-wait",
     `--idempotency-key ${shellQuote(idempotencyKey)}`,
   ]
@@ -3874,7 +3822,6 @@ async function maintainMachine(command, input, context, interaction) {
     `ornn machines ${command}`,
     shellQuote(machineId(waitOutcome.value)),
     destructive ? "--erase-local-data" : null,
-    "--yes",
     `--idempotency-key ${shellQuote(interaction.idempotencyKey())}`,
   ]
     .filter(Boolean)