@ornikar/eslint-plugin-ornikar 20.2.1 → 21.0.0

package/.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "eslint.workingDirectories": ["../../"]
+}

package/CHANGELOG.md

@@ -3,6 +3,19 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.0.0](https://github.com/ornikar/eslint-configs/compare/v20.2.1...v21.0.0) (2023-09-26)
+
+
+### ⚠ BREAKING CHANGES
+
+* update to node 18 ECF-280 (#615)
+
+### Features
+
+* update to node 18 ECF-280 ([#615](https://github.com/ornikar/eslint-configs/issues/615)) ([51c7f5e](https://github.com/ornikar/eslint-configs/commit/51c7f5ee059a3517fba9ebec136e458d342c5c99))
+
+
+
 ## [20.2.1](https://github.com/ornikar/eslint-configs/compare/v20.2.0...v20.2.1) (2023-09-20)
 
 **Note:** Version bump only for package @ornikar/eslint-plugin-ornikar

package/configs/all.js

@@ -2,6 +2,7 @@
 
 module.exports = {
   rules: {
+    '@ornikar/ornikar/forbid-fetch-import': 'error',
     '@ornikar/ornikar/react-function-component-return-react-node': 'error',
   },
 };

package/docs/rules/forbid-fetch-import.md

@@ -0,0 +1,21 @@
+# Forbid importing libraries replacing fetch which is now available in native, browser and node.
+
+💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs).
+
+## Fail
+
+```ts
+import fetch from 'node-fetch';
+
+fetch('/api').then(console.log);
+```
+
+## Pass
+
+```ts
+fetch('/api').then(console.log);
+```
+
+## Options
+
+None

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ornikar/eslint-plugin-ornikar",
-  "version": "20.2.1",
+  "version": "21.0.0",
   "description": "eslint plugin for ornikar",
   "repository": {
     "directory": "@ornikar/eslint-plugin-ornikar",
@@ -37,5 +37,8 @@
     "@typescript-eslint/utils": "6.7.2",
     "eslint": "8.49.0"
   },
-  "gitHead": "6c7c0e2b83e6f40d1eda4d7d904c3597d5fe43b1"
+  "engines": {
+    "node": ">=18.18.0"
+  },
+  "gitHead": "99c0a576f6ee3da108b9101453f6a0954c54b33e"
 }

package/rules/forbid-fetch-import.js

@@ -0,0 +1,40 @@
+'use strict';
+
+exports.meta = {
+  type: 'problem',
+
+  docs: {
+    description: 'Forbid node-fetch import now that fetch is available in node and browsers',
+    category: 'Best Practices',
+    recommended: true,
+  },
+
+  messages: {
+    forbidden: 'import from "{{value}}" is forbidden. Fetch is available in browsers and node since 18.0.0.',
+  },
+};
+
+const fetchLibs = ['node-fetch', 'cross-fetch', 'isomorphic-fetch'];
+
+exports.create = (context) => {
+  const checkNode = (node) => {
+    const importSource = node.source.value.trim();
+
+    if (fetchLibs.includes(importSource)) {
+      context.report({
+        node,
+        messageId: 'forbidden',
+        data: { value: importSource },
+      });
+    }
+  };
+  return {
+    ImportDeclaration: checkNode,
+    ExportNamedDeclaration(node) {
+      if (node.source) {
+        checkNode(node);
+      }
+    },
+    ExportAllDeclaration: checkNode,
+  };
+};

package/rules/forbid-fetch-import.test.js

@@ -0,0 +1,35 @@
+'use strict';
+
+const { RuleTester } = require('eslint');
+const rule = require('./forbid-fetch-import');
+
+const parserOptions = {
+  ecmaVersion: 2018,
+  sourceType: 'module',
+};
+
+const ruleTester = new RuleTester({ parserOptions });
+
+ruleTester.run('forbid-fetch-import', rule, {
+  valid: [
+    {
+      code: `
+      fetch('https://example.com');
+    `,
+    },
+  ],
+  invalid: [
+    {
+      code: `
+      import fetch from 'node-fetch';
+      fetch('https://example.com');
+    `,
+      errors: [
+        {
+          messageId: 'forbidden',
+          data: { value: 'node-fetch' },
+        },
+      ],
+    },
+  ],
+});

package/rules/test-utils/RuleTester.js

@@ -1,8 +1,7 @@
 'use strict';
 
-// eslint-disable-next-line import/no-unresolved -- waiting for node 18
 const { after, describe, it } = require('node:test');
-// eslint-disable-next-line import/no-unresolved, import/order -- missing main field
+// eslint-disable-next-line import/no-unresolved -- missing main field
 const { RuleTester } = require('@typescript-eslint/rule-tester');
 
 RuleTester.afterAll = after;