@ornikar/eslint-config 18.8.0 → 18.11.0

package/CHANGELOG.md

@@ -3,6 +3,51 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [18.11.0](https://github.com/ornikar/eslint-configs/compare/v18.10.0...v18.11.0) (2022-06-07)
+
+
+### Features
+
+* disable no-process-exit rule from eslint-plugin-node [no issue] ([#322](https://github.com/ornikar/eslint-configs/issues/322)) ([f51fd2c](https://github.com/ornikar/eslint-configs/commit/f51fd2c5deecdda56d8746c1e8ab951ca5e9e0dc))
+
+
+
+
+
+# [18.10.0](https://github.com/ornikar/eslint-configs/compare/v18.9.0...v18.10.0) (2022-05-31)
+
+
+### Bug Fixes
+
+* **eslint-config:** allow non-linteral fs filename for tests ([31cc2f3](https://github.com/ornikar/eslint-configs/commit/31cc2f3d98a415956122a315ec742ed30120865e))
+
+
+### Features
+
+* **eslint-config:** prefer-native-coercion-functions ([#311](https://github.com/ornikar/eslint-configs/issues/311)) ([ecb42c7](https://github.com/ornikar/eslint-configs/commit/ecb42c7146cee49d705357bfe29e68d7438c1859))
+
+
+
+
+
+# [18.9.0](https://github.com/ornikar/eslint-configs/compare/v18.8.0...v18.9.0) (2022-05-31)
+
+
+### Bug Fixes
+
+* **eslint-config:** allow non-linteral fs filename for dev scripts ([9a28882](https://github.com/ornikar/eslint-configs/commit/9a288820bc48fe2e428235b4b0d5c629c5d8367e))
+
+
+### Features
+
+* **eslint-config:** enable unicorn/prefer-modern-math-apis [no issue] ([#309](https://github.com/ornikar/eslint-configs/issues/309)) ([1e2d294](https://github.com/ornikar/eslint-configs/commit/1e2d294030c4604afdf0cbcf9406302113cac64b))
+* replace eslint-plugin-node by eslint-plugin-n [no issue] ([#310](https://github.com/ornikar/eslint-configs/issues/310)) ([8fd3c19](https://github.com/ornikar/eslint-configs/commit/8fd3c19df11d15cff679e0880f20e8b032c73e5c))
+* update expiring todo comments [no issue] ([#297](https://github.com/ornikar/eslint-configs/issues/297)) ([0cc2e08](https://github.com/ornikar/eslint-configs/commit/0cc2e0835a1f5fb7fbe3ed76bea5d1242b02c479))
+
+
+
+
+
 # [18.8.0](https://github.com/ornikar/eslint-configs/compare/v18.7.0...v18.8.0) (2022-05-02)
 
 

package/node-module-override.js

@@ -2,5 +2,5 @@
 
 /* prefer usage of .mjs files over this override */
 module.exports = {
-  extends: ['plugin:node/recommended-module', require.resolve('./rules/node-override')],
+  extends: ['plugin:n/recommended-module', require.resolve('./rules/node-override')],
 };

package/package.json

@@ -1,8 +1,12 @@
 {
   "name": "@ornikar/eslint-config",
-  "version": "18.8.0",
+  "version": "18.11.0",
   "description": "eslint config files",
-  "repository": "ornikar/eslint-configs",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/ornikar/eslint-configs.git",
+    "directory": "@ornikar/eslint-config"
+  },
   "main": "index.js",
   "license": "ISC",
   "engines": {
@@ -17,7 +21,7 @@
     "eslint-plugin-import": "^2.25.4",
     "eslint-plugin-jest": "^26.1.5",
     "eslint-plugin-jsx-a11y": "^6.4.1",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^15.2.0",
     "eslint-plugin-security": "^1.5.0",
     "eslint-plugin-simple-import-sort": "^7.0.0",
     "eslint-plugin-unicorn": "^42.0.0"
@@ -27,8 +31,8 @@
     "prettier": "^2.2.1"
   },
   "devDependencies": {
-    "eslint": "8.14.0",
+    "eslint": "8.16.0",
     "prettier": "2.6.2"
   },
-  "gitHead": "004aa9c1bb2cc7c6b8e17d734c4f856d6676d5e4"
+  "gitHead": "94f2317e02a558fb56955486b739314c32e9b7fd"
 }

package/root.js

@@ -11,5 +11,9 @@ module.exports = {
         devDependencies: true,
       },
     ],
+
+    // Allow non-literal fs filename for dev scripts
+    'security/detect-non-literal-fs-filename': 'off',
+    'security/detect-non-literal-require': 'off',
   },
 };

package/rules/node-override.js

@@ -5,18 +5,19 @@ const airbnbStyleRules = require('eslint-config-airbnb-base/rules/style');
 module.exports = {
   rules: {
     // already checked by import plugin
-    'node/no-unpublished-require': 'off',
-    'node/no-unpublished-import': 'off',
-    'node/no-extraneous-require': 'off',
-    'node/no-extraneous-import': 'off',
-    'node/no-missing-require': 'off',
-    'node/no-missing-import': 'off',
+    'n/no-unpublished-require': 'off',
+    'n/no-unpublished-import': 'off',
+    'n/no-extraneous-require': 'off',
+    'n/no-extraneous-import': 'off',
+    'n/no-missing-require': 'off',
+    'n/no-missing-import': 'off',
 
     // Use for-of instead of for
     'unicorn/no-for-loop': 'error',
 
-    // allow process.exit
+    // allow process.exit, disallowed when not used in script via https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-process-exit.md
     'no-process-exit': 'off',
+    'n/no-process-exit': 'off',
 
     // Allow for-of, now supported by node 6
     'no-restricted-syntax': [

package/rules/node.js

@@ -1,8 +1,8 @@
 'use strict';
 
 module.exports = {
-  plugins: ['node'],
-  extends: ['plugin:node/recommended', require.resolve('./node-override')],
+  plugins: ['n'],
+  extends: ['plugin:n/recommended', require.resolve('./node-override')],
 
   parserOptions: {
     // top level await is introduced in ecmaVersion: 2022 but supported since node 14
@@ -18,11 +18,11 @@ module.exports = {
   overrides: [
     {
       files: ['*.cjs'],
-      extends: ['plugin:node/recommended-script', require.resolve('./node-override')],
+      extends: ['plugin:n/recommended-script', require.resolve('./node-override')],
     },
     {
       files: ['*.mjs'],
-      extends: ['plugin:node/recommended-module', require.resolve('./node-override')],
+      extends: ['plugin:n/recommended-module', require.resolve('./node-override')],
       parserOptions: {
         // top level await is introduced in ecmaVersion: 2022 but supported since node 14
         ecmaVersion: 2022,

package/rules/unicorn.js

@@ -112,9 +112,12 @@ const formTree = shallow(tree.find(x => FormWithApiCall(x)).prop('children')());
 
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/expiring-todo-comments.md
     'unicorn/expiring-todo-comments': [
-      'error',
+      'warn',
       {
         allowWarningComments: false,
+        ignoreDatesOnPullRequests: true,
+        ignore: [/(\[https:\/\/ornikar.atlassian.net\/browse\/[A-Z]+-\d+])/i], // JIRA issue format (ex: https://ornikar.atlassian.net/browse/DR-123)
+        date: '9999-12-31', // invalidates all expiring dates <9999-12-31
       },
     ],
 
@@ -281,12 +284,12 @@ const formTree = shallow(tree.find(x => FormWithApiCall(x)).prop('children')());
     'unicorn/no-useless-switch-case': 'off',
 
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-modern-math-apis.md
-    'unicorn/prefer-modern-math-apis': 'off',
+    'unicorn/prefer-modern-math-apis': 'error',
 
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-unreadable-iife.md
     'unicorn/no-unreadable-iife': 'off',
 
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-native-coercion-functions.md
-    'unicorn/prefer-native-coercion-functions': 'off',
+    'unicorn/prefer-native-coercion-functions': 'error',
   },
 };

package/tests-override.js

@@ -15,5 +15,9 @@ module.exports = {
         devDependencies: true,
       },
     ],
+
+    // Allow non-literal fs filename for tests
+    'security/detect-non-literal-fs-filename': 'off',
+    'security/detect-non-literal-require': 'off',
   },
 };