@ordergroove/offers 2.30.6-alpha-PR-719-2.5 → 2.30.6

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.30.6](https://github.com/ordergroove/plush-toys/compare/@ordergroove/offers@2.30.5...@ordergroove/offers@2.30.6) (2023-02-27)
+
+
+### Bug Fixes
+
+* rounding issue on prepaid when calculating subscriptionPrice ([4710c5e](https://github.com/ordergroove/plush-toys/commit/4710c5e3c8ec0571d0d85870c01c6858f9baf568))
+
+
+
+
+
 ## [2.30.5](https://github.com/ordergroove/plush-toys/compare/@ordergroove/offers@2.30.4...@ordergroove/offers@2.30.5) (2023-02-17)
 
 **Note:** Version bump only for package @ordergroove/offers

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ordergroove/offers",
-  "version": "2.30.6-alpha-PR-719-2.5+da65ad5e",
+  "version": "2.30.6",
   "description": "offer state component",
   "author": "Eugenio Lattanzio <eugenio63@gmail.com>",
   "homepage": "https://github.com/ordergroove/plush-toys#readme",
@@ -47,5 +47,5 @@
   "devDependencies": {
     "@ordergroove/offers-templates": "^0.5.3"
   },
-  "gitHead": "da65ad5e152472bd2f558b35c68725272d08959a"
+  "gitHead": "1845a87c8a39b7a1b1fc79c62db1d9aa37decc72"
 }

package/src/shopify/__tests__/productPlan.spec.js

@@ -371,7 +371,7 @@ describe('Shopify productPlan Reducer', () => {
       expect(productPlanCreated).toEqual(expectedProductPlan);
     });
 
-    it('should create prepaid product plan solving rounding issue', () => {
+    it('should create prepaid product plan that rounds subscriptionPrice to nearest decimal', () => {
       const allocation = {
         price_adjustments: [
           {
@@ -414,21 +414,11 @@ describe('Shopify productPlan Reducer', () => {
         }
       ];
 
-      const expectedProductPlan = {
-        frequency: '688412983572',
-        regularPrice: '$19.99',
-        // There is to be an issue when not rounding where subscriptionPrice was calculated as $1599.3333333333333.35
-        subscriptionPrice: '$15.99',
-        discountRate: '20%',
-        prepaidShipments: 3,
-        regularPrepaidPrice: '$47.98',
-        prepaidSavingsPerShipment: '$4.00',
-        prepaidSavingsTotal: '$11.99'
-      };
+      const expectedsubscriptionPrice = '$15.99';
 
       const productPlanCreated = mapSellingPlanToDiscount(allocation, sellingPlans);
 
-      expect(productPlanCreated).toEqual(expectedProductPlan);
+      expect(productPlanCreated.subscriptionPrice).toEqual(expectedsubscriptionPrice);
     });
 
     it('should create prepaid product plan with extra discount percentage', () => {