@ordergroove/offers 2.30.4 → 2.30.6-alpha-PR-719-2.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ordergroove/offers",
-  "version": "2.30.4",
+  "version": "2.30.6-alpha-PR-719-2.5+da65ad5e",
   "description": "offer state component",
   "author": "Eugenio Lattanzio <eugenio63@gmail.com>",
   "homepage": "https://github.com/ordergroove/plush-toys#readme",
@@ -45,7 +45,7 @@
     "throttle-debounce": "^2.1.0"
   },
   "devDependencies": {
-    "@ordergroove/offers-templates": "^0.5.2"
+    "@ordergroove/offers-templates": "^0.5.3"
   },
-  "gitHead": "8f41940bb20d4eb376250add3aaa154e773a481b"
+  "gitHead": "da65ad5e152472bd2f558b35c68725272d08959a"
 }

package/src/shopify/__tests__/productPlan.spec.js

@@ -371,6 +371,66 @@ describe('Shopify productPlan Reducer', () => {
       expect(productPlanCreated).toEqual(expectedProductPlan);
     });
 
+    it('should create prepaid product plan solving rounding issue', () => {
+      const allocation = {
+        price_adjustments: [
+          {
+            position: 1,
+            price: 4798
+          }
+        ],
+        price: 4798,
+        compare_at_price: 1999,
+        per_delivery_price: 4798,
+        selling_plan_id: 688412983572
+      };
+
+      const sellingPlans = [
+        {
+          id: 688412983572,
+          name: 'Delivered every 1 month, prepaid for 3 shipments',
+          description: null,
+          options: [
+            {
+              name: 'Delivery every',
+              position: 1,
+              value: 'PREPAID-1 month'
+            },
+            {
+              name: 'Shipment amount',
+              position: 2,
+              value: '3 shipments'
+            }
+          ],
+          recurring_deliveries: true,
+          price_adjustments: [
+            {
+              order_count: null,
+              position: 1,
+              value_type: 'price',
+              value: 4798
+            }
+          ]
+        }
+      ];
+
+      const expectedProductPlan = {
+        frequency: '688412983572',
+        regularPrice: '$19.99',
+        // There is to be an issue when not rounding where subscriptionPrice was calculated as $1599.3333333333333.35
+        subscriptionPrice: '$15.99',
+        discountRate: '20%',
+        prepaidShipments: 3,
+        regularPrepaidPrice: '$47.98',
+        prepaidSavingsPerShipment: '$4.00',
+        prepaidSavingsTotal: '$11.99'
+      };
+
+      const productPlanCreated = mapSellingPlanToDiscount(allocation, sellingPlans);
+
+      expect(productPlanCreated).toEqual(expectedProductPlan);
+    });
+
     it('should create prepaid product plan with extra discount percentage', () => {
       const allocation = {
         price_adjustments: [

package/src/shopify/reducers/productPlans.ts

@@ -27,7 +27,7 @@ export const getAllocationRegularPrice = (allocation: ShopifySellingPlanAllocati
 export const getAllocationSubscriptionPrice = (allocation: ShopifySellingPlanAllocationsEntity) => {
   if (isPrepaidAllocation(allocation)) {
     const prepaidShipmentsPerBilling = getPrepaidShipmentsNumberFromOptions(allocation.selling_plan?.options);
-    const pricePerShipment = allocation.price / prepaidShipmentsPerBilling;
+    const pricePerShipment = Math.round(allocation.price / prepaidShipmentsPerBilling);
     return money(pricePerShipment);
   }