@orderful/droid 0.7.0 → 0.8.0

package/src/lib/skills.ts

@@ -5,6 +5,7 @@ import { fileURLToPath } from 'url';
 import YAML from 'yaml';
 import { loadConfig, saveConfig } from './config.js';
 import { AITool, SkillStatus, type SkillManifest, type InstalledSkill } from './types.js';
+import { getInstalledAgentsDir, installAgentFromPath, uninstallAgent, isAgentInstalled } from './agents.js';
 
 // Marker comments for CLAUDE.md skill registration
 const DROID_SKILLS_START = '<!-- droid-skills-start -->';
@@ -336,6 +337,22 @@ export function installSkill(skillName: string): { success: boolean; message: st
         }
       }
     }
+
+    // Check bundled agent collisions
+    const agentsSource = join(bundledSkillDir, 'agents');
+    if (existsSync(agentsSource)) {
+      const agentDirs = readdirSync(agentsSource, { withFileTypes: true })
+        .filter(dirent => dirent.isDirectory())
+        .map(dirent => dirent.name);
+      for (const agentName of agentDirs) {
+        if (isAgentInstalled(agentName)) {
+          return {
+            success: false,
+            message: `Cannot install: agent '${agentName}' already exists at ${getInstalledAgentsDir()}`,
+          };
+        }
+      }
+    }
   }
 
   // Ensure skills directory exists
@@ -354,6 +371,22 @@ export function installSkill(skillName: string): { success: boolean; message: st
     writeFileSync(skillMdTarget, content);
   }
 
+  // Copy references if present (skill documentation files)
+  const referencesSource = join(bundledSkillDir, 'references');
+  if (existsSync(referencesSource)) {
+    const targetReferencesDir = join(targetSkillDir, 'references');
+    if (!existsSync(targetReferencesDir)) {
+      mkdirSync(targetReferencesDir, { recursive: true });
+    }
+    const referenceFiles = readdirSync(referencesSource).filter(f => f.endsWith('.md'));
+    for (const file of referenceFiles) {
+      const sourcePath = join(referencesSource, file);
+      const targetPath = join(targetReferencesDir, file);
+      const content = readFileSync(sourcePath, 'utf-8');
+      writeFileSync(targetPath, content);
+    }
+  }
+
   // Copy commands if present
   const commandsSource = join(bundledSkillDir, 'commands');
   if (existsSync(commandsSource)) {
@@ -369,10 +402,29 @@ export function installSkill(skillName: string): { success: boolean; message: st
     }
   }
 
+  // Install bundled agents if present
+  const installedAgents: string[] = [];
+  const agentsSource = join(bundledSkillDir, 'agents');
+  if (existsSync(agentsSource)) {
+    const agentDirs = readdirSync(agentsSource, { withFileTypes: true })
+      .filter(dirent => dirent.isDirectory())
+      .map(dirent => dirent.name);
+
+    for (const agentName of agentDirs) {
+      // Use the skill's bundled agent path instead of global agents
+      const agentDir = join(agentsSource, agentName);
+      const result = installAgentFromPath(agentDir, agentName);
+      if (result.success) {
+        installedAgents.push(agentName);
+      }
+    }
+  }
+
   // Update config
   config.skills[skillName] = {
     version: manifest.version,
     installed_at: new Date().toISOString(),
+    ...(installedAgents.length > 0 && { bundled_agents: installedAgents }),
   };
   saveConfig(config);
 
@@ -414,6 +466,14 @@ export function uninstallSkill(skillName: string): { success: boolean; message:
     }
   }
 
+  // Remove bundled agents if they were installed with this skill
+  const installedSkillInfo = config.skills[skillName];
+  if (installedSkillInfo?.bundled_agents) {
+    for (const agentName of installedSkillInfo.bundled_agents) {
+      uninstallAgent(agentName);
+    }
+  }
+
   // Remove from config
   delete config.skills[skillName];
   saveConfig(config);

package/src/lib/types.ts

@@ -43,6 +43,7 @@ export interface DroidConfig {
 export interface InstalledSkill {
   version: string;
   installed_at: string;
+  bundled_agents?: string[]; // Agents installed with this skill
 }
 
 export interface SkillExample {

package/src/skills/brain/SKILL.md

@@ -38,16 +38,16 @@ Ideas develop through iteration, not single prompts.
 
 ## Configuration
 
-Check `~/.droid/skills/brain/overrides.yaml` for user settings:
+**IMPORTANT:** Before using any default paths, ALWAYS read `~/.droid/skills/brain/overrides.yaml` first. If `brain_dir` is configured there, use that path. Only fall back to defaults if the file doesn't exist or lacks a `brain_dir` setting.
 
 | Setting | Default | Description |
 |---------|---------|-------------|
-| `brain_dir` | `~/{ai_tool}/brain` | Where docs are stored (varies by AI tool) |
+| `brain_dir` | (see below) | Where docs are stored |
 | `inbox_folder` | (empty) | Optional subfolder for new docs (omit for flat structure) |
 
-Default `brain_dir` by AI tool:
+Default `brain_dir` by AI tool (only if not configured):
 - **claude-code**: `~/.claude/brain`
-- **opencode**: `~/.opencode/brain`
+- **opencode**: `~/.config/opencode/brain`
 
 ## Core Concepts
 
@@ -68,20 +68,22 @@ Default `brain_dir` by AI tool:
 | Command | Action |
 |---------|--------|
 | `/brain` | List recent docs or create new |
-| `/brain {topic}` | Open existing (fuzzy match) → becomes active |
-| `/brain plan {topic}` | Create planning doc → becomes active |
-| `/brain research {topic}` | Create research doc → becomes active |
-| `/brain review {topic}` | Create review doc → becomes active |
+| `/brain {topic}` | **Search** for existing doc (fuzzy match) → becomes active |
+| `/brain plan {topic}` | Create planning doc (requires `plan` keyword) |
+| `/brain research {topic}` | Create research doc (requires `research` keyword) |
+| `/brain review {topic}` | Create review doc (requires `review` keyword) |
 | `/brain note {text}` | Quick capture (standalone, doesn't become active) |
 | `/brain add {text}` | Append to active doc |
 | `/brain check` | Address @droid comments in active doc |
 | `/brain done` | Finalize active doc, update status |
 
+**IMPORTANT:** The default action for `/brain {topic}` is to **SEARCH** for existing docs, NOT create. Only use `/brain plan {topic}` or `/brain research {topic}` when the user explicitly wants to create a new doc.
+
 ## Opening a Doc
 
 **Trigger:** `/brain {topic}` or user asks to open a brain doc
 
-**TLDR:** Fuzzy-match topic against existing docs, read content, set as active.
+**TLDR:** Search for and open an existing doc. Fuzzy-match topic against existing docs, read content, set as active.
 
 Full procedure: `references/workflows.md` § Opening
 

package/src/skills/brain/SKILL.yaml

@@ -4,7 +4,7 @@ description: >-
   "let's use our brain", "let's think through this", or "plan this out" to capture
   AI output into a persistent doc. Create docs with /brain plan, /brain research,
   or /brain review. Use @mentions for async discussion. Docs persist across sessions.
-version: 0.1.0
+version: 0.1.1
 status: beta
 dependencies: []
 provides_output: false

package/src/skills/brain/commands/brain.md

@@ -1,6 +1,6 @@
 ---
 description: Collaborative scratch pad for planning and research
-argument-hint: [plan|research|review|note|add|check|done] {topic/text}
+argument-hint: "[{topic} | plan|research|review {topic} | note|add {text} | check|done]"
 allowed-tools: Read, Write, Edit, Glob, Grep, Bash(mkdir:*), Bash(ls:*)
 ---
 
@@ -12,12 +12,16 @@ Entry point for brain doc management. See the **brain skill** for full behavior.
 
 $ARGUMENTS
 
+## Default Behavior
+
+**IMPORTANT:** When given just a topic (e.g., `/brain auth-refactor`), the default action is to **SEARCH** for existing docs, NOT create. Only create docs with explicit `/brain plan {topic}` or `/brain research {topic}`.
+
 ## Usage
 
 ```
 /brain                      # List recent docs or create new
-/brain {topic}              # Open existing (fuzzy match) → active
-/brain plan {topic}         # Create planning doc → active
+/brain {topic}              # SEARCH: Open existing doc (fuzzy match) → active
+/brain plan {topic}         # CREATE: New planning doc → active
 /brain research {topic}     # Create research doc → active
 /brain review {topic}       # Create review doc → active
 /brain note {text}          # Quick capture (fire-and-forget)
@@ -28,7 +32,8 @@ $ARGUMENTS
 
 ## Configuration
 
-From `~/.droid/skills/brain/overrides.yaml`:
+**ALWAYS read `~/.droid/skills/brain/overrides.yaml` first.** Use configured values if present, only fall back to defaults if missing.
+
 - `brain_dir` - Where docs live (default varies by AI tool)
 - `inbox_folder` - Subfolder for new docs (empty = flat)
 

package/src/skills/brain/references/workflows.md

@@ -8,7 +8,9 @@ Detailed procedures for each brain operation.
 
 **Steps:**
 
-1. **Resolve brain_dir** from config (default: `~/.claude/brain` for claude-code)
+1. **Read config first**
+   - Read `~/.droid/skills/brain/overrides.yaml`
+   - Use `brain_dir` if configured, otherwise use default for current AI tool
 
 2. **Search for matches**
    ```
@@ -35,7 +37,10 @@ Detailed procedures for each brain operation.
 
 **Steps:**
 
-1. **Resolve brain_dir** and **inbox_folder** from config
+1. **Read config first**
+   - Read `~/.droid/skills/brain/overrides.yaml`
+   - Use `brain_dir` if configured, otherwise use default for current AI tool
+   - Use `inbox_folder` if configured
 
 2. **Generate filename** using naming conventions (see `naming.md`):
    - Format: `{type}-{topic-slug}.md`
@@ -66,7 +71,10 @@ Detailed procedures for each brain operation.
 
 **Steps:**
 
-1. **Resolve brain_dir** and **inbox_folder** from config
+1. **Read config first**
+   - Read `~/.droid/skills/brain/overrides.yaml`
+   - Use `brain_dir` if configured, otherwise use default for current AI tool
+   - Use `inbox_folder` if configured
 
 2. **Generate filename:**
    - Format: `note-{date}-{slug}.md` where date is `YYYYMMDD`
@@ -169,7 +177,9 @@ Detailed procedures for each brain operation.
 
 **Steps:**
 
-1. **Resolve brain_dir** from config
+1. **Read config first**
+   - Read `~/.droid/skills/brain/overrides.yaml`
+   - Use `brain_dir` if configured, otherwise use default for current AI tool
 
 2. **Find recent docs:**
    ```

package/src/skills/code-review/SKILL.md

@@ -0,0 +1,57 @@
+---
+name: code-review
+description: >-
+  Comprehensive code review using specialized agents. Reviews PRs, staged changes,
+  branches, or specific files. Includes EDI/partnership analysis, test coverage,
+  error handling, and type safety checks with confidence scoring.
+globs:
+  - "**/*"
+alwaysApply: false
+---
+
+# Code Review Skill
+
+Run comprehensive code reviews using specialized agents, each focused on a specific concern.
+
+## How It Works
+
+The `/code-review` command orchestrates multiple specialized agents in parallel:
+
+1. **edi-standards-reviewer** - EDI patterns, partnership handling, billing concerns
+2. **test-coverage-analyzer** - Test completeness and edge cases
+3. **error-handling-reviewer** - Silent failures, missing error handling
+4. **type-reviewer** - TypeScript type design, interface contracts
+
+Each agent returns issues with confidence scores (0-100). Issues below 80% confidence are filtered out to reduce noise.
+
+## Usage
+
+```bash
+/code-review #123           # Review PR #123
+/code-review staged         # Review staged changes
+/code-review branch         # Review current branch vs main
+/code-review path/to/file   # Review specific file
+```
+
+## Output Format
+
+Reviews are presented in prioritized categories:
+
+🔴 **Critical** - Security, data loss, billing errors
+🟠 **Important** - Bugs, missing tests, type issues
+🟡 **Suggestions** - Style, readability improvements
+
+## Post-Review Actions
+
+After presenting findings, you can:
+- Post the review as a PR comment
+- Get suggested fixes for specific issues
+- Check out the branch and fix critical issues
+
+## Domain-Aware Reviews
+
+The EDI Standards Reviewer discovers project conventions by reading:
+- `.claude/CLAUDE.md` or `CLAUDE.md` for team conventions
+- `AGENTS.md` or `docs/` for architecture guidance
+
+This lets it apply your project's specific patterns rather than generic rules.

package/src/skills/code-review/SKILL.yaml

@@ -0,0 +1,22 @@
+name: code-review
+description: >-
+  Comprehensive code review using specialized agents. Reviews PRs, staged changes,
+  branches, or specific files. Includes EDI/partnership analysis, test coverage,
+  error handling, and type safety checks with confidence scoring.
+version: 0.1.0
+status: alpha
+dependencies: []
+provides_output: false
+examples:
+  - title: "Review a PR"
+    code: |
+      /code-review #123
+  - title: "Review staged changes"
+    code: |
+      /code-review staged
+  - title: "Review current branch vs main"
+    code: |
+      /code-review branch
+  - title: "Review a specific file"
+    code: |
+      /code-review src/billing/BillingService.ts

package/src/skills/code-review/agents/edi-standards-reviewer/AGENT.md

@@ -0,0 +1,39 @@
+You are a domain-aware code reviewer that understands EDI patterns and integration best practices.
+
+## How to Review
+
+1. **First, find project context:**
+   - Look for `.claude/CLAUDE.md` or `CLAUDE.md` for team conventions
+   - Look for `AGENTS.md` or `docs/` for architecture guidance
+   - These files define what "correct" looks like for this codebase
+
+2. **Review with that context:**
+   - Apply the project's stated conventions and patterns
+   - Flag deviations from documented best practices
+   - Consider EDI-specific concerns (partnerships, billing, transactions)
+
+## Output Format
+
+Return JSON:
+
+```json
+{
+  "issues": [
+    {
+      "file": "path/to/file.ts",
+      "line": 42,
+      "severity": "critical|important|suggestion",
+      "confidence": 85,
+      "issue": "Brief description",
+      "suggestion": "How to fix"
+    }
+  ],
+  "summary": "One-line summary"
+}
+```
+
+## Severity Guidelines
+
+- **critical**: Security, data loss, billing errors
+- **important**: Bugs, missing validations, pattern violations
+- **suggestion**: Style, documentation, minor improvements

package/src/skills/code-review/agents/edi-standards-reviewer/AGENT.yaml

@@ -0,0 +1,14 @@
+name: edi-standards-reviewer
+description: >-
+  Review code for EDI integration patterns, partnership handling, and billing
+  system concerns. Use PROACTIVELY when changes touch trading partners,
+  transactions, or billing.
+version: 0.1.0
+status: alpha
+mode: subagent
+model: sonnet
+color: blue
+tools:
+  - Read
+  - Grep
+  - Glob

package/src/skills/code-review/agents/error-handling-reviewer/AGENT.md

@@ -0,0 +1,51 @@
+You are a reliability engineer hunting for silent failures.
+
+## Silent Failure Patterns
+
+1. Empty catch blocks: `catch (e) {}`
+2. Catch-and-log-only: `catch (e) { console.log(e) }` without rethrowing
+3. Promises without `.catch()` or try/catch
+4. Optional chaining hiding real errors: `data?.value` when data should exist
+5. Missing validation before operations
+6. Ignored return values from functions that can fail
+
+## Review Process
+
+1. Grep for `catch` blocks - check they handle/rethrow appropriately
+2. Find async functions - verify error propagation
+3. Look for external calls - network, DB, APIs need error handling
+4. Check critical paths - billing, transactions, partnerships
+
+## Orderful-Specific
+
+- BillingEvent creation failures must be surfaced
+- Partnership API calls need retry logic
+- Transaction processing errors must not be swallowed
+- Chargebee integration errors need proper handling
+
+## Output Format
+
+Return JSON:
+
+```json
+{
+  "issues": [
+    {
+      "file": "src/billing/BillingService.ts",
+      "line": 89,
+      "severity": "critical",
+      "confidence": 95,
+      "issue": "Catch block swallows BillingEvent creation error",
+      "suggestion": "Rethrow the error or implement proper error recovery"
+    }
+  ],
+  "summary": "One-line summary of error handling concerns"
+}
+```
+
+## Confidence Guidelines
+
+- Silent failures in billing/transactions: 90-100
+- Missing error handling in external API calls: 85-95
+- Optional chaining style issues: 60-75
+- Logging-only catch blocks in non-critical code: 70-80

package/src/skills/code-review/agents/error-handling-reviewer/AGENT.yaml

@@ -0,0 +1,14 @@
+name: error-handling-reviewer
+description: >-
+  Hunt for silent failures and missing error handling. Use PROACTIVELY to find
+  try/catch blocks that swallow errors, promises without rejection handling,
+  and missing validation.
+version: 0.1.0
+status: alpha
+mode: subagent
+model: sonnet
+color: orange
+tools:
+  - Read
+  - Grep
+  - Glob

package/src/skills/code-review/agents/test-coverage-analyzer/AGENT.md

@@ -0,0 +1,53 @@
+You are a testing specialist focused on comprehensive coverage.
+
+## Review Process
+
+1. Identify changed files (production code)
+2. Find corresponding test files
+3. Analyze: Are key behaviors tested?
+4. Check edge cases: nulls, errors, boundaries, async paths
+
+## Specific Checks
+
+- New functions should have tests
+- Conditionals: Are all branches covered?
+- Error paths: Are failure cases tested?
+- Async code: Is timeout/failure handling tested?
+- Mocking: Are external dependencies properly mocked?
+
+## Orderful-Specific
+
+- BillingService methods need billing event assertions
+- Partnership changes need isolation tests
+- Transaction Template rendering needs snapshot/output tests
+
+## Output Format
+
+Return JSON:
+
+```json
+{
+  "issues": [
+    {
+      "file": "src/billing/BillingService.ts",
+      "line": 67,
+      "severity": "important",
+      "confidence": 90,
+      "issue": "New `calculatePartnershipFee` function has no test coverage",
+      "suggestion": "Add test in BillingService.spec.ts covering standard and 'first partnership free' scenarios"
+    }
+  ],
+  "coverage_summary": {
+    "new_functions_tested": 3,
+    "new_functions_untested": 1,
+    "branches_uncovered": 2
+  },
+  "summary": "One-line summary of test coverage concerns"
+}
+```
+
+## Severity Guidelines
+
+- **critical**: No tests for billing/payment code, security-related code untested
+- **important**: New functions untested, major branches uncovered
+- **suggestion**: Edge cases, additional assertions

package/src/skills/code-review/agents/test-coverage-analyzer/AGENT.yaml

@@ -0,0 +1,14 @@
+name: test-coverage-analyzer
+description: >-
+  Analyze test coverage for code changes. Use PROACTIVELY when reviewing PRs
+  or before merging to ensure adequate test coverage.
+version: 0.1.0
+status: alpha
+mode: subagent
+model: sonnet
+color: green
+tools:
+  - Read
+  - Grep
+  - Glob
+  - Bash

package/src/skills/code-review/agents/type-reviewer/AGENT.md

@@ -0,0 +1,50 @@
+You are a TypeScript expert focused on type safety and design.
+
+## Review Focus
+
+1. **No sneaky `any`**: Explicit types for function params/returns
+2. **Domain types**: Use branded types for IDs (PartnerId, TransactionId)
+3. **Null safety**: Proper handling of optional values
+4. **Interface contracts**: APIs have explicit input/output types
+5. **Enums and unions**: Use discriminated unions for state machines
+
+## Specific Patterns at Orderful
+
+- BillingEvent types should be exhaustive
+- Partnership configs need strict typing
+- Transaction Templates have well-defined shapes
+- API responses should use Zod schemas
+
+## Anti-Patterns to Flag
+
+- `as any` type assertions
+- Implicit `any` from untyped dependencies
+- `// @ts-ignore` without explanation
+- Overly permissive union types
+- Missing return types on exported functions
+
+## Output Format
+
+Return JSON:
+
+```json
+{
+  "issues": [
+    {
+      "file": "src/api/handlers.ts",
+      "line": 45,
+      "severity": "important",
+      "confidence": 88,
+      "issue": "Function `processTransaction` has implicit `any` return type",
+      "suggestion": "Add explicit return type `Promise<TransactionResult>`"
+    }
+  ],
+  "summary": "One-line summary of type safety concerns"
+}
+```
+
+## Severity Guidelines
+
+- **critical**: `any` in billing/transaction code, missing API contract types
+- **important**: Implicit `any`, missing return types on public APIs
+- **suggestion**: Could use stricter types, minor improvements

package/src/skills/code-review/agents/type-reviewer/AGENT.yaml

@@ -0,0 +1,13 @@
+name: type-reviewer
+description: >-
+  Review TypeScript type design and interface contracts. Check for proper
+  typing, avoid `any`, ensure domain types are used correctly.
+version: 0.1.0
+status: alpha
+mode: subagent
+model: sonnet
+color: purple
+tools:
+  - Read
+  - Grep
+  - Glob

package/src/skills/code-review/commands/code-review.md

@@ -0,0 +1,91 @@
+---
+description: Run comprehensive code review using specialized agents. Accepts PR number, 'staged', 'branch', or file path.
+argument-hint: "[#123 | staged | branch | path/to/file.ts]"
+allowed-tools: Task, Bash(git:*), Bash(gh:*), Read, Glob
+---
+
+# /code-review - Run comprehensive code review using specialized agents
+
+Review target: $ARGUMENTS
+
+## Usage
+
+```
+/code-review #123           # Review PR #123
+/code-review staged         # Review staged changes
+/code-review branch         # Review current branch vs main
+/code-review path/to/file   # Review specific file
+```
+
+### Step 1: Determine Review Scope
+
+Parse the argument to determine what to review:
+
+**If argument starts with `#` or is a number (e.g., `#123` or `123`):**
+- This is a PR number
+- Fetch PR details: `gh pr view $PR_NUMBER --json title,body,baseRefName,headRefName,files`
+- Get the diff: `gh pr diff $PR_NUMBER`
+- Note the PR author and description for context
+
+**If argument is `staged` or empty:**
+- Review staged changes: `git diff --cached`
+
+**If argument is `branch`:**
+- Review current branch vs main: `git diff origin/main...HEAD`
+
+**If argument is a file path:**
+- Review specific file: `git diff HEAD -- $FILE_PATH`
+- If no changes, review the entire file for issues
+
+### Step 2: Gather Context
+
+For PR reviews, also fetch:
+- PR description (may contain context about the change)
+- Linked issues: `gh pr view $PR_NUMBER --json body` and parse for #issue refs
+- Changed files list for targeted agent assignment
+
+### Step 3: Parallel Agent Reviews
+
+Launch these agents in parallel using the Task tool with `run_in_background: true`:
+
+1. **edi-standards-reviewer**: EDI patterns, partnership handling, billing concerns
+2. **test-coverage-analyzer**: Test completeness and edge cases
+3. **error-handling-reviewer**: Silent failures, missing error handling
+4. **type-reviewer**: Type design, interface contracts
+
+Pass each agent:
+1. The diff content
+2. The full file content for changed files (for context)
+3. PR description if available
+
+Use TaskOutput to collect results from all agents.
+
+### Step 4: Confidence Filtering
+
+Each agent returns issues with confidence scores (0-100).
+Filter out issues with confidence < 80.
+
+### Step 5: Synthesize Report
+
+Compile findings into a prioritized report:
+
+**PR #123: "Add partnership billing events"** (if reviewing a PR)
+*Author: @username*
+
+**Critical** (security, data loss, billing errors)
+- `file.ts:42` - Issue description
+
+**Important** (bugs, missing tests, type issues)
+- `file.ts:67` - Issue description
+
+**Suggestions** (style, readability)
+- `file.ts:89` - Issue description
+
+**Summary**: X critical, Y important, Z suggestions across N files.
+
+### Step 6: Offer Actions (for PRs)
+
+After presenting the report, offer:
+- "Would you like me to post this as a PR comment?"
+- "Should I suggest fixes for any of these issues?"
+- "Want me to check out this branch and fix the critical issues?"