@orderful/droid 0.34.0 → 0.35.0

package/.claude-plugin/marketplace.json

@@ -61,7 +61,7 @@
     {
       "name": "droid-codex",
       "description": "Shared organizational knowledge - PRDs, tech designs, domains, proposals, patterns, and explored topics. Use when loading project context, searching codex, capturing decisions, or creating new entries.",
-      "version": "0.1.10",
+      "version": "0.2.0",
       "source": {
         "source": "github",
         "repo": "orderful/droid",

package/CHANGELOG.md

@@ -1,5 +1,29 @@
 # @orderful/droid
 
+## 0.35.0
+
+### Minor Changes
+
+- [#209](https://github.com/Orderful/droid/pull/209) [`74cbdbb`](https://github.com/Orderful/droid/commit/74cbdbba131741412f3a5d490472ff8b4c22e286) Thanks [@frytyler](https://github.com/frytyler)! - feat(codex): add review skill for conversational document reviews
+
+  New capability for reviewing structured documents (tech designs, PRDs) conversationally in the CLI.
+
+  Features:
+  - Generic review workflow for structured docs
+  - Tech design document type support
+  - Section-based navigation ("Show me the rollout section")
+  - Context search in thought docs ("Why was X rejected?")
+  - MVP scope (read-only, CLI navigation)
+
+  Commands:
+  - `/codex review {type} --pr {number}` - Load and review a PR
+
+## 0.34.1
+
+### Patch Changes
+
+- [#207](https://github.com/Orderful/droid/pull/207) [`1bb9dab`](https://github.com/Orderful/droid/commit/1bb9dab3079c32ecfa6069c074cbc6b076273f68) Thanks [@frytyler](https://github.com/frytyler)! - Fix config migration and TUI config persistence. Migration now properly re-runs if incomplete, and TUI tool config updates now persist to the consolidated config location instead of old override files.
+
 ## 0.34.0
 
 ### Minor Changes

package/dist/bin/droid.js

@@ -75,11 +75,15 @@ function migrateConfig(config) {
   };
 }
 function migrateToolConfigs(config) {
-  if (config.migrations?.tools_consolidated) {
-    return false;
-  }
   const skillsDir = join(CONFIG_DIR, "skills");
   if (!existsSync(skillsDir)) {
+    if (!config.migrations) {
+      config.migrations = {};
+    }
+    if (!config.migrations.tools_consolidated) {
+      config.migrations.tools_consolidated = true;
+      return true;
+    }
     return false;
   }
   let migrated = false;
@@ -97,18 +101,21 @@ function migrateToolConfigs(config) {
           if (!config.tools) {
             config.tools = {};
           }
-          config.tools[skillName] = overrides;
-          migrated = true;
+          if (!config.tools[skillName]) {
+            config.tools[skillName] = overrides;
+            migrated = true;
+          }
         }
       } catch {
         continue;
       }
     }
-    if (migrated) {
-      if (!config.migrations) {
-        config.migrations = {};
-      }
+    if (!config.migrations) {
+      config.migrations = {};
+    }
+    if (!config.migrations.tools_consolidated) {
       config.migrations.tools_consolidated = true;
+      migrated = true;
     }
     return migrated;
   } catch {
@@ -218,6 +225,14 @@ function getToolSettings(name) {
   const config = loadConfig();
   return config.tools?.[name] ?? {};
 }
+function setToolSettings(name, settings) {
+  const config = loadConfig();
+  if (!config.tools) {
+    config.tools = {};
+  }
+  config.tools[name] = settings;
+  saveConfig(config);
+}
 function getAutoUpdateConfig() {
   const config = loadConfig();
   return {
@@ -3219,7 +3234,7 @@ function SkillConfigScreen({ skill, onComplete, onCancel }) {
   const [selectOptionIndex, setSelectOptionIndex] = useState6(0);
   const totalItems = configKeys.length + 1;
   const handleSave = () => {
-    saveSkillOverrides(skill.name, values);
+    setToolSettings(skill.name, values);
     onComplete();
   };
   const handleSubmitEdit = () => {

package/dist/index.js

@@ -87,11 +87,15 @@ function migrateConfig(config) {
   };
 }
 function migrateToolConfigs(config) {
-  if (config.migrations?.tools_consolidated) {
-    return false;
-  }
   const skillsDir = join(CONFIG_DIR, "skills");
   if (!existsSync(skillsDir)) {
+    if (!config.migrations) {
+      config.migrations = {};
+    }
+    if (!config.migrations.tools_consolidated) {
+      config.migrations.tools_consolidated = true;
+      return true;
+    }
     return false;
   }
   let migrated = false;
@@ -109,18 +113,21 @@ function migrateToolConfigs(config) {
           if (!config.tools) {
             config.tools = {};
           }
-          config.tools[skillName] = overrides;
-          migrated = true;
+          if (!config.tools[skillName]) {
+            config.tools[skillName] = overrides;
+            migrated = true;
+          }
         }
       } catch {
         continue;
       }
     }
-    if (migrated) {
-      if (!config.migrations) {
-        config.migrations = {};
-      }
+    if (!config.migrations) {
+      config.migrations = {};
+    }
+    if (!config.migrations.tools_consolidated) {
       config.migrations.tools_consolidated = true;
+      migrated = true;
     }
     return migrated;
   } catch {

package/dist/lib/config.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"config.d.ts","sourceRoot":"","sources":["../../src/lib/config.ts"],"names":[],"mappings":"AAUA,OAAO,EAGL,KAAK,WAAW,EAEhB,KAAK,cAAc,EACnB,KAAK,gBAAgB,EACrB,KAAK,UAAU,EACf,KAAK,UAAU,EAChB,MAAM,SAAS,CAAC;AA+GjB;;GAEG;AACH,wBAAgB,eAAe,IAAI,IAAI,CAItC;AAED;;GAEG;AACH,wBAAgB,YAAY,IAAI,OAAO,CAEtC;AAED;;;GAGG;AACH,wBAAgB,UAAU,IAAI,WAAW,CAgCxC;AAED;;GAEG;AACH,wBAAgB,UAAU,CAAC,MAAM,EAAE,WAAW,GAAG,IAAI,CAKpD;AAED;;GAEG;AACH,wBAAgB,cAAc,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAanD;AAED;;GAEG;AACH,wBAAgB,cAAc,CAAC,GAAG,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,GAAG,IAAI,CAiBhE;AAED;;GAEG;AACH,wBAAgB,aAAa,IAAI,MAAM,CAEtC;AAED;;GAEG;AACH,wBAAgB,YAAY,IAAI,MAAM,CAErC;AAWD;;GAEG;AACH,wBAAgB,qBAAqB,CAAC,SAAS,EAAE,MAAM,GAAG,MAAM,CAG/D;AAED;;;GAGG;AACH,wBAAgB,kBAAkB,CAAC,SAAS,EAAE,MAAM,GAAG,cAAc,CAsBpE;AAED;;GAEG;AACH,wBAAgB,kBAAkB,CAChC,SAAS,EAAE,MAAM,EACjB,SAAS,EAAE,cAAc,GACxB,IAAI,CAWN;AAED;;GAEG;AACH,wBAAgB,eAAe,CAAC,IAAI,EAAE,MAAM,GAAG,UAAU,CAGxD;AAED;;GAEG;AACH,wBAAgB,eAAe,CAAC,IAAI,EAAE,MAAM,EAAE,QAAQ,EAAE,UAAU,GAAG,IAAI,CAOxE;AAED;;GAEG;AACH,wBAAgB,cAAc,CAAC,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,GAAG,IAAI,CAI9E;AAED;;GAEG;AACH,wBAAgB,mBAAmB,IAAI,gBAAgB,CAMtD;AAED;;GAEG;AACH,wBAAgB,mBAAmB,CAAC,OAAO,EAAE,OAAO,CAAC,gBAAgB,CAAC,GAAG,IAAI,CAQ5E;AAYD;;GAEG;AACH,wBAAgB,QAAQ,IAAI,UAAU,EAAE,CAGvC;AAED;;GAEG;AACH,wBAAgB,OAAO,CAAC,IAAI,EAAE,MAAM,GAAG,UAAU,GAAG,SAAS,CAG5D;AAED;;GAEG;AACH,wBAAgB,WAAW,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,GAAG,SAAS,CAM5D;AAED;;GAEG;AACH,wBAAgB,OAAO,CAAC,IAAI,EAAE,UAAU,GAAG,IAAI,CAiB9C;AAED;;GAEG;AACH,wBAAgB,UAAU,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAchD"}
+{"version":3,"file":"config.d.ts","sourceRoot":"","sources":["../../src/lib/config.ts"],"names":[],"mappings":"AAUA,OAAO,EAGL,KAAK,WAAW,EAEhB,KAAK,cAAc,EACnB,KAAK,gBAAgB,EACrB,KAAK,UAAU,EACf,KAAK,UAAU,EAChB,MAAM,SAAS,CAAC;AA2HjB;;GAEG;AACH,wBAAgB,eAAe,IAAI,IAAI,CAItC;AAED;;GAEG;AACH,wBAAgB,YAAY,IAAI,OAAO,CAEtC;AAED;;;GAGG;AACH,wBAAgB,UAAU,IAAI,WAAW,CAgCxC;AAED;;GAEG;AACH,wBAAgB,UAAU,CAAC,MAAM,EAAE,WAAW,GAAG,IAAI,CAKpD;AAED;;GAEG;AACH,wBAAgB,cAAc,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAanD;AAED;;GAEG;AACH,wBAAgB,cAAc,CAAC,GAAG,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,GAAG,IAAI,CAiBhE;AAED;;GAEG;AACH,wBAAgB,aAAa,IAAI,MAAM,CAEtC;AAED;;GAEG;AACH,wBAAgB,YAAY,IAAI,MAAM,CAErC;AAWD;;GAEG;AACH,wBAAgB,qBAAqB,CAAC,SAAS,EAAE,MAAM,GAAG,MAAM,CAG/D;AAED;;;GAGG;AACH,wBAAgB,kBAAkB,CAAC,SAAS,EAAE,MAAM,GAAG,cAAc,CAsBpE;AAED;;GAEG;AACH,wBAAgB,kBAAkB,CAChC,SAAS,EAAE,MAAM,EACjB,SAAS,EAAE,cAAc,GACxB,IAAI,CAWN;AAED;;GAEG;AACH,wBAAgB,eAAe,CAAC,IAAI,EAAE,MAAM,GAAG,UAAU,CAGxD;AAED;;GAEG;AACH,wBAAgB,eAAe,CAAC,IAAI,EAAE,MAAM,EAAE,QAAQ,EAAE,UAAU,GAAG,IAAI,CAOxE;AAED;;GAEG;AACH,wBAAgB,cAAc,CAAC,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,GAAG,IAAI,CAI9E;AAED;;GAEG;AACH,wBAAgB,mBAAmB,IAAI,gBAAgB,CAMtD;AAED;;GAEG;AACH,wBAAgB,mBAAmB,CAAC,OAAO,EAAE,OAAO,CAAC,gBAAgB,CAAC,GAAG,IAAI,CAQ5E;AAYD;;GAEG;AACH,wBAAgB,QAAQ,IAAI,UAAU,EAAE,CAGvC;AAED;;GAEG;AACH,wBAAgB,OAAO,CAAC,IAAI,EAAE,MAAM,GAAG,UAAU,GAAG,SAAS,CAG5D;AAED;;GAEG;AACH,wBAAgB,WAAW,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,GAAG,SAAS,CAM5D;AAED;;GAEG;AACH,wBAAgB,OAAO,CAAC,IAAI,EAAE,UAAU,GAAG,IAAI,CAiB9C;AAED;;GAEG;AACH,wBAAgB,UAAU,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAchD"}

package/dist/tools/codex/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "droid-codex",
-  "version": "0.1.10",
+  "version": "0.2.0",
   "description": "Shared organizational knowledge - PRDs, tech designs, domains, proposals, patterns, and explored topics. Use when loading project context, searching codex, capturing decisions, or creating new entries.",
   "author": {
     "name": "Orderful",

package/dist/tools/codex/TOOL.yaml

@@ -1,6 +1,6 @@
 name: codex
 description: "Shared organizational knowledge - PRDs, tech designs, domains, proposals, patterns, and explored topics. Use when loading project context, searching codex, capturing decisions, or creating new entries."
-version: 0.1.10
+version: 0.2.0
 status: beta
 
 includes:

package/dist/tools/codex/skills/codex/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: codex
-description: "Shared organizational knowledge - PRDs, tech designs, patterns, and explored topics. Use when loading project context ('load transaction-templates'), searching codex ('search webhook'), capturing decisions ('codex decision'), or adding explored topics ('add topic'). User prompts like 'check the codex', 'what's in the codex about X', 'load the PRD for Y'."
-argument-hint: "[projects | domains | proposals | patterns | topics | {name} | search {query} | new {type} {name} | decision {text}]"
+description: "Shared organizational knowledge - PRDs, tech designs, patterns, and explored topics. Use when loading project context ('load transaction-templates'), searching codex ('search webhook'), reviewing documents ('review tech-design'), capturing decisions ('codex decision'), or adding explored topics ('add topic'). User prompts like 'check the codex', 'what's in the codex about X', 'load the PRD for Y'."
+argument-hint: "[projects | domains | proposals | patterns | topics | {name} | search {query} | review {type} | new {type} {name} | decision {text}]"
 allowed-tools:
   [
     Read,
@@ -173,6 +173,7 @@ The codex has five categories:
 | `/codex search {query}`                      | Search and load entry (searches all categories)         |
 | `/codex search {query} -- {instruction}`     | Search, load, then execute follow-up instruction        |
 | `/codex {category} search {query}`           | Search within a specific category only                  |
+| `/codex review {type} --pr {number}`         | Conversational review of a document PR                  |
 | `/codex new {category} {name}`               | Scaffold new entry (project/domain/proposal/pattern/topic) |
 | `/codex decision {text}`                     | Append to active project's DECISIONS.md                 |
 | `/codex snapshot {type} {file} {name}` | Import PDF/markdown to codex (uses agent)       |
@@ -360,6 +361,20 @@ Artifacts are supplementary documents that support a project but aren't core doc
 
 Artifacts get lighter frontmatter with `type: artifact` and source like `interview`, `transcript`, `notes`, `meeting`, `research`, `spike`, or `analysis`.
 
+## Reviewing Documents
+
+**Trigger:** `/codex review {type} --pr {number}`
+
+**Procedure:**
+
+1. **Run preamble:** `droid config --get tools.codex | droid exec codex git-preamble --config -`
+2. **Fetch PR info:** `gh pr view {number} --json files,title`
+3. **Filter & Load:** Identify the primary document (e.g., `TECH-DESIGN.md`) and context (e.g., `thought-doc.md`) based on the `{type}` definition.
+4. **Interactive Review:** Guide the user through the document sections.
+
+Full procedure: `references/review/workflow.md`
+Type definitions: `references/review/{type}.md`
+
 ## Creating New Entries
 
 **Trigger:** `/codex new {category} {name}`

package/dist/tools/codex/skills/codex/references/review/tech-design.md

@@ -0,0 +1,34 @@
+# Tech Design Document Type
+
+Configuration for reviewing Tech Design documents via `/codex review tech-design`.
+
+## File Patterns
+
+| Role | Pattern | Description |
+| --- | --- | --- |
+| **Primary** | `**/TECH-DESIGN.md` | The main document being reviewed. Sections are parsed from here. |
+| **Context** | `**/thought-doc.md` | Backstory, alternatives, and trade-offs. Used for "why" questions. |
+
+*Note: In the MVP, we assume a single TECH-DESIGN.md per PR.*
+
+## Section Parsing
+Sections in `TECH-DESIGN.md` are defined by H2 headers (`## `). H3 headers (`###`) are treated as content within sections for MVP.
+
+**The tool dynamically discovers ALL sections present in the document.** It does not filter for specific section names.
+
+**Common sections** (examples, not exhaustive):
+- TL;DR
+- Problem
+- Scope
+- Solution
+- Key Decisions
+- Risks
+- Rollout
+- Implementation Phases
+
+Authors may include additional sections (e.g., "Security", "Performance", "Alternatives Considered") and the tool will present them for navigation.
+
+## Consistency Checks (Deferred)
+*Future feature: Rules to automatically check consistency.*
+- "Risks" section must list mitigations
+- "Implementation Phases" must match "Rollout" steps

package/dist/tools/codex/skills/codex/references/review/workflow.md

@@ -0,0 +1,250 @@
+# Generic Document Review Workflow
+
+The `/codex review` command provides a conversational interface for reviewing structured documents (tech designs, PRDs, etc.) directly in the CLI.
+
+## 1. Loading the PR
+
+**Trigger:** `/codex review {type} --pr {number}`
+
+**Step 1: Preamble**
+Run the git preamble to ensure we are on a clean state (though we're mostly reading).
+```bash
+droid config --get tools.codex | droid exec codex git-preamble --config -
+```
+
+**Step 2: Fetch PR Details**
+Get the PR metadata to validate it exists and get the file list.
+
+```bash
+# Get codex repo path from config
+codex_repo=$(droid config --get tools.codex.codex_dir)
+
+# Fetch PR info
+gh pr view {number} --json files,title,url,headRefName --repo "$codex_repo"
+```
+
+Check exit code: if non-zero, PR not found (see Error Handling below).
+
+**Step 3: Checkout PR Branch**
+Check out the PR to read files easily.
+
+```bash
+cd "$codex_repo"
+gh pr checkout {number}
+```
+
+This creates/switches to the PR branch locally.
+
+**Step 4: Identify Files**
+Match the file list against patterns in `references/review/{type}.md`.
+
+For tech-design:
+- **Primary:** `**/TECH-DESIGN.md`
+- **Context:** `**/thought-doc.md` (optional)
+
+Find files using:
+```bash
+find . -name "TECH-DESIGN.md" -type f
+find . -name "thought-doc.md" -type f
+```
+
+**Step 5: Read Content**
+Read identified files using the Read tool. Count lines for display.
+
+```bash
+wc -l {path_to_primary}  # Get line count
+```
+
+**Error Handling:**
+
+**PR not found:**
+```bash
+gh pr view {number} --repo "$codex_repo"
+# Check exit code
+if [ $? -ne 0 ]; then
+  echo "❌ PR #{number} not found in codex repo"
+  exit 1
+fi
+```
+
+**TECH-DESIGN.md not found:**
+If `find . -name "TECH-DESIGN.md"` returns nothing:
+```
+❌ No TECH-DESIGN.md found in PR #{number}
+
+This PR doesn't appear to contain a tech design document.
+```
+
+**thought-doc.md missing (optional):**
+If not found, continue without it:
+```
+⚠️  No thought-doc.md found - context search will be limited
+```
+
+**gh CLI fails:**
+```
+❌ Failed to fetch PR details. Is gh CLI authenticated?
+
+Try: gh auth status
+```
+
+## 2. Parsing Structure
+
+**Step 1: Parse Sections**
+Read the **Primary** document and extract H2 headers (lines starting with `## `).
+
+Extract using pattern: `^##\s+(.+)$`
+- Match lines starting with `##` followed by whitespace
+- Capture everything after as the section name
+- Strip leading/trailing whitespace
+- Ignore H3 headers (`###`) for MVP - treat as content within sections
+
+Example parsing:
+```
+## TL;DR           → Section: "TL;DR"
+## Problem         → Section: "Problem"
+### Sub-problem   → (ignored, part of Problem section)
+## Solution        → Section: "Solution"
+```
+
+**Step 2: Display Overview**
+Output a dynamic summary based on the actual PR content:
+
+```
+📋 Review: {PR Title} (PR #{number})
+
+Documents loaded:
+✓ {path_to_primary} ({line_count} lines)
+✓ {path_to_context} ({line_count} lines) [if found]
+
+Structure ({count} sections):
+1. {First section name}
+2. {Second section name}
+...
+{N}. {Last section name}
+
+What would you like to do?
+- Show me a specific section (e.g., "show me the {example section}")
+- Ask questions about decisions (e.g., "why was X rejected?")
+- Walk through section by section
+```
+
+**Note:** All values are dynamic:
+- PR title comes from `gh pr view`
+- File paths come from what's actually in the PR
+- Section count and names come from parsing the TECH-DESIGN.md H2 headers
+- If thought-doc.md not found, only show the primary document
+
+**Example output:**
+```
+📋 Review: Transaction Templates Tech Design (PR #128)
+
+Documents loaded:
+✓ projects/transaction-templates/TECH-DESIGN.md (250 lines)
+✓ projects/transaction-templates/artifacts/thought-doc.md (380 lines)
+
+Structure (8 sections):
+1. TL;DR
+2. Problem
+3. Scope
+4. Solution
+5. Key Decisions
+6. Risks
+7. Rollout
+8. Implementation Phases
+
+What would you like to do?
+- Show me a specific section (e.g., "show me the rollout")
+- Ask questions about decisions (e.g., "why was X rejected?")
+- Walk through section by section
+```
+
+**Step 3: Wait for User Request**
+User can now navigate conversationally.
+
+## 3. Conversational Navigation
+
+Map user requests to actions:
+
+**"Show me {section}"**
+1. Match the section name (see Section Matching below)
+2. Read the Primary file
+3. Extract content between `## {Match}` and the next `## ` header
+4. Display the section content
+
+**Section Matching Algorithm:**
+
+Use case-insensitive substring matching:
+
+1. Normalize user input and section names to lowercase
+2. Check if user input is substring of any section name
+3. If single match: use it
+4. If multiple matches: pick the first one (or ask user to clarify)
+5. If no matches: list available sections
+
+**Examples:**
+- User: "show rollout" → matches "Rollout"
+- User: "security" → matches "Security Considerations"
+- User: "risks" → matches "Risks"
+- User: "key decisions" → matches "Key Decisions"
+
+**"Walk me through it"**
+1. Start with the first section
+2. Display content
+3. Ask "Continue to {Next Section}?"
+4. Repeat until user stops or end of document
+
+**"Jump to {section}"**
+Same as "Show me {section}".
+
+## 4. Contextual Search (Thought Docs)
+
+**Trigger Detection:**
+
+If user query contains any of: "why", "rejected", "alternative", "decision", "reason", "chose", "didn't"
+→ Enter context search mode
+
+**Term Extraction:**
+
+Extract key phrases from the question:
+- Strip question words: "why was", "why did we", "what about"
+- Extract 2-4 word phrases: "event-based approach", "webhook pattern", "async processing"
+- If user mentions specific terms in quotes, use those exactly
+
+**Examples:**
+- "Why was event-based rejected?" → search for "event-based"
+- "Why did we choose sync over async?" → search for "sync" and "async"
+- "What about the webhook approach?" → search for "webhook"
+
+**Search Process:**
+
+1. Search the **Context** document (e.g., `thought-doc.md`) first:
+   ```bash
+   grep -C 5 -i "{term}" {path_to_context}
+   ```
+
+2. Display results with context (5 lines before/after)
+
+3. If multiple matches found: show first 3 matches
+
+4. If no match in context doc: search Primary document
+
+5. If still no match: "No mentions of '{term}' found in design docs"
+
+**Display Format:**
+
+```
+Searching thought doc for "event-based"...
+
+Found in Key Decisions section:
+
+> Event-based was rejected because of complexity in guaranteeing
+> order and handling failures. The synchronous API approach is
+> simpler and sufficient for the MVP requirements. We considered
+> event streaming but decided it was premature optimization.
+
+Anything else?
+```
+
+## 5. Posting Feedback (MVP: Deferred)
+*For MVP, we just display content. Users can use `gh pr comment` manually if they want, but the tool focuses on reading.*

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@orderful/droid",
-  "version": "0.34.0",
+  "version": "0.35.0",
   "description": "AI workflow toolkit for sharing skills, commands, and agents across the team",
   "type": "module",
   "bin": {

package/src/commands/tui/views/SkillConfigScreen.tsx

@@ -1,7 +1,7 @@
 import { Box, Text, useInput } from 'ink';
 import TextInput from 'ink-text-input';
 import { useState, useMemo } from 'react';
-import { loadSkillOverrides, saveSkillOverrides } from '../../../lib/config';
+import { loadSkillOverrides, setToolSettings } from '../../../lib/config';
 import { ConfigOptionType, type SkillManifest, type SkillOverrides } from '../../../lib/types';
 import { colors, MAX_VISIBLE_CONFIG_ITEMS } from '../constants';
 
@@ -38,7 +38,7 @@ export function SkillConfigScreen({ skill, onComplete, onCancel }: SkillConfigSc
   const totalItems = configKeys.length + 1;
 
   const handleSave = () => {
-    saveSkillOverrides(skill.name, values);
+    setToolSettings(skill.name, values);
     onComplete();
   };
 

package/src/lib/config.ts

@@ -71,15 +71,22 @@ function migrateConfig(
 /**
  * Migrate tool configs from old override files to config.tools.*
  * Keeps old files as backup (will be removed in follow-up PR)
+ *
+ * Always checks for unmigrated override files, even if migration flag is set.
+ * This ensures migration runs if it was previously incomplete.
  */
 function migrateToolConfigs(config: DroidConfig): boolean {
-  // Skip if already migrated
-  if (config.migrations?.tools_consolidated) {
-    return false;
-  }
-
   const skillsDir = join(CONFIG_DIR, 'skills');
   if (!existsSync(skillsDir)) {
+    // No skills directory means nothing to migrate
+    // Mark as complete to avoid future checks
+    if (!config.migrations) {
+      config.migrations = {};
+    }
+    if (!config.migrations.tools_consolidated) {
+      config.migrations.tools_consolidated = true;
+      return true; // Config changed (flag added)
+    }
     return false;
   }
 
@@ -101,12 +108,16 @@ function migrateToolConfigs(config: DroidConfig): boolean {
         const overrides = YAML.parse(content) as SkillOverrides;
 
         if (overrides && Object.keys(overrides).length > 0) {
-          // Migrate to new location
+          // Check if already migrated to new location
           if (!config.tools) {
             config.tools = {};
           }
-          config.tools[skillName] = overrides;
-          migrated = true;
+
+          // Only migrate if not already in new location
+          if (!config.tools[skillName]) {
+            config.tools[skillName] = overrides;
+            migrated = true;
+          }
         }
       } catch {
         // Skip files that can't be parsed
@@ -114,12 +125,13 @@ function migrateToolConfigs(config: DroidConfig): boolean {
       }
     }
 
-    if (migrated) {
-      // Record migration
-      if (!config.migrations) {
-        config.migrations = {};
-      }
+    // Mark migration as complete if not already marked
+    if (!config.migrations) {
+      config.migrations = {};
+    }
+    if (!config.migrations.tools_consolidated) {
       config.migrations.tools_consolidated = true;
+      migrated = true;
     }
 
     return migrated;

package/src/tools/codex/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "droid-codex",
-  "version": "0.1.10",
+  "version": "0.2.0",
   "description": "Shared organizational knowledge - PRDs, tech designs, domains, proposals, patterns, and explored topics. Use when loading project context, searching codex, capturing decisions, or creating new entries.",
   "author": {
     "name": "Orderful",

package/src/tools/codex/TOOL.yaml

@@ -1,6 +1,6 @@
 name: codex
 description: "Shared organizational knowledge - PRDs, tech designs, domains, proposals, patterns, and explored topics. Use when loading project context, searching codex, capturing decisions, or creating new entries."
-version: 0.1.10
+version: 0.2.0
 status: beta
 
 includes:

package/src/tools/codex/skills/codex/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: codex
-description: "Shared organizational knowledge - PRDs, tech designs, patterns, and explored topics. Use when loading project context ('load transaction-templates'), searching codex ('search webhook'), capturing decisions ('codex decision'), or adding explored topics ('add topic'). User prompts like 'check the codex', 'what's in the codex about X', 'load the PRD for Y'."
-argument-hint: "[projects | domains | proposals | patterns | topics | {name} | search {query} | new {type} {name} | decision {text}]"
+description: "Shared organizational knowledge - PRDs, tech designs, patterns, and explored topics. Use when loading project context ('load transaction-templates'), searching codex ('search webhook'), reviewing documents ('review tech-design'), capturing decisions ('codex decision'), or adding explored topics ('add topic'). User prompts like 'check the codex', 'what's in the codex about X', 'load the PRD for Y'."
+argument-hint: "[projects | domains | proposals | patterns | topics | {name} | search {query} | review {type} | new {type} {name} | decision {text}]"
 allowed-tools:
   [
     Read,
@@ -173,6 +173,7 @@ The codex has five categories:
 | `/codex search {query}`                      | Search and load entry (searches all categories)         |
 | `/codex search {query} -- {instruction}`     | Search, load, then execute follow-up instruction        |
 | `/codex {category} search {query}`           | Search within a specific category only                  |
+| `/codex review {type} --pr {number}`         | Conversational review of a document PR                  |
 | `/codex new {category} {name}`               | Scaffold new entry (project/domain/proposal/pattern/topic) |
 | `/codex decision {text}`                     | Append to active project's DECISIONS.md                 |
 | `/codex snapshot {type} {file} {name}` | Import PDF/markdown to codex (uses agent)       |
@@ -360,6 +361,20 @@ Artifacts are supplementary documents that support a project but aren't core doc
 
 Artifacts get lighter frontmatter with `type: artifact` and source like `interview`, `transcript`, `notes`, `meeting`, `research`, `spike`, or `analysis`.
 
+## Reviewing Documents
+
+**Trigger:** `/codex review {type} --pr {number}`
+
+**Procedure:**
+
+1. **Run preamble:** `droid config --get tools.codex | droid exec codex git-preamble --config -`
+2. **Fetch PR info:** `gh pr view {number} --json files,title`
+3. **Filter & Load:** Identify the primary document (e.g., `TECH-DESIGN.md`) and context (e.g., `thought-doc.md`) based on the `{type}` definition.
+4. **Interactive Review:** Guide the user through the document sections.
+
+Full procedure: `references/review/workflow.md`
+Type definitions: `references/review/{type}.md`
+
 ## Creating New Entries
 
 **Trigger:** `/codex new {category} {name}`

package/src/tools/codex/skills/codex/references/review/tech-design.md

@@ -0,0 +1,34 @@
+# Tech Design Document Type
+
+Configuration for reviewing Tech Design documents via `/codex review tech-design`.
+
+## File Patterns
+
+| Role | Pattern | Description |
+| --- | --- | --- |
+| **Primary** | `**/TECH-DESIGN.md` | The main document being reviewed. Sections are parsed from here. |
+| **Context** | `**/thought-doc.md` | Backstory, alternatives, and trade-offs. Used for "why" questions. |
+
+*Note: In the MVP, we assume a single TECH-DESIGN.md per PR.*
+
+## Section Parsing
+Sections in `TECH-DESIGN.md` are defined by H2 headers (`## `). H3 headers (`###`) are treated as content within sections for MVP.
+
+**The tool dynamically discovers ALL sections present in the document.** It does not filter for specific section names.
+
+**Common sections** (examples, not exhaustive):
+- TL;DR
+- Problem
+- Scope
+- Solution
+- Key Decisions
+- Risks
+- Rollout
+- Implementation Phases
+
+Authors may include additional sections (e.g., "Security", "Performance", "Alternatives Considered") and the tool will present them for navigation.
+
+## Consistency Checks (Deferred)
+*Future feature: Rules to automatically check consistency.*
+- "Risks" section must list mitigations
+- "Implementation Phases" must match "Rollout" steps

package/src/tools/codex/skills/codex/references/review/workflow.md

@@ -0,0 +1,250 @@
+# Generic Document Review Workflow
+
+The `/codex review` command provides a conversational interface for reviewing structured documents (tech designs, PRDs, etc.) directly in the CLI.
+
+## 1. Loading the PR
+
+**Trigger:** `/codex review {type} --pr {number}`
+
+**Step 1: Preamble**
+Run the git preamble to ensure we are on a clean state (though we're mostly reading).
+```bash
+droid config --get tools.codex | droid exec codex git-preamble --config -
+```
+
+**Step 2: Fetch PR Details**
+Get the PR metadata to validate it exists and get the file list.
+
+```bash
+# Get codex repo path from config
+codex_repo=$(droid config --get tools.codex.codex_dir)
+
+# Fetch PR info
+gh pr view {number} --json files,title,url,headRefName --repo "$codex_repo"
+```
+
+Check exit code: if non-zero, PR not found (see Error Handling below).
+
+**Step 3: Checkout PR Branch**
+Check out the PR to read files easily.
+
+```bash
+cd "$codex_repo"
+gh pr checkout {number}
+```
+
+This creates/switches to the PR branch locally.
+
+**Step 4: Identify Files**
+Match the file list against patterns in `references/review/{type}.md`.
+
+For tech-design:
+- **Primary:** `**/TECH-DESIGN.md`
+- **Context:** `**/thought-doc.md` (optional)
+
+Find files using:
+```bash
+find . -name "TECH-DESIGN.md" -type f
+find . -name "thought-doc.md" -type f
+```
+
+**Step 5: Read Content**
+Read identified files using the Read tool. Count lines for display.
+
+```bash
+wc -l {path_to_primary}  # Get line count
+```
+
+**Error Handling:**
+
+**PR not found:**
+```bash
+gh pr view {number} --repo "$codex_repo"
+# Check exit code
+if [ $? -ne 0 ]; then
+  echo "❌ PR #{number} not found in codex repo"
+  exit 1
+fi
+```
+
+**TECH-DESIGN.md not found:**
+If `find . -name "TECH-DESIGN.md"` returns nothing:
+```
+❌ No TECH-DESIGN.md found in PR #{number}
+
+This PR doesn't appear to contain a tech design document.
+```
+
+**thought-doc.md missing (optional):**
+If not found, continue without it:
+```
+⚠️  No thought-doc.md found - context search will be limited
+```
+
+**gh CLI fails:**
+```
+❌ Failed to fetch PR details. Is gh CLI authenticated?
+
+Try: gh auth status
+```
+
+## 2. Parsing Structure
+
+**Step 1: Parse Sections**
+Read the **Primary** document and extract H2 headers (lines starting with `## `).
+
+Extract using pattern: `^##\s+(.+)$`
+- Match lines starting with `##` followed by whitespace
+- Capture everything after as the section name
+- Strip leading/trailing whitespace
+- Ignore H3 headers (`###`) for MVP - treat as content within sections
+
+Example parsing:
+```
+## TL;DR           → Section: "TL;DR"
+## Problem         → Section: "Problem"
+### Sub-problem   → (ignored, part of Problem section)
+## Solution        → Section: "Solution"
+```
+
+**Step 2: Display Overview**
+Output a dynamic summary based on the actual PR content:
+
+```
+📋 Review: {PR Title} (PR #{number})
+
+Documents loaded:
+✓ {path_to_primary} ({line_count} lines)
+✓ {path_to_context} ({line_count} lines) [if found]
+
+Structure ({count} sections):
+1. {First section name}
+2. {Second section name}
+...
+{N}. {Last section name}
+
+What would you like to do?
+- Show me a specific section (e.g., "show me the {example section}")
+- Ask questions about decisions (e.g., "why was X rejected?")
+- Walk through section by section
+```
+
+**Note:** All values are dynamic:
+- PR title comes from `gh pr view`
+- File paths come from what's actually in the PR
+- Section count and names come from parsing the TECH-DESIGN.md H2 headers
+- If thought-doc.md not found, only show the primary document
+
+**Example output:**
+```
+📋 Review: Transaction Templates Tech Design (PR #128)
+
+Documents loaded:
+✓ projects/transaction-templates/TECH-DESIGN.md (250 lines)
+✓ projects/transaction-templates/artifacts/thought-doc.md (380 lines)
+
+Structure (8 sections):
+1. TL;DR
+2. Problem
+3. Scope
+4. Solution
+5. Key Decisions
+6. Risks
+7. Rollout
+8. Implementation Phases
+
+What would you like to do?
+- Show me a specific section (e.g., "show me the rollout")
+- Ask questions about decisions (e.g., "why was X rejected?")
+- Walk through section by section
+```
+
+**Step 3: Wait for User Request**
+User can now navigate conversationally.
+
+## 3. Conversational Navigation
+
+Map user requests to actions:
+
+**"Show me {section}"**
+1. Match the section name (see Section Matching below)
+2. Read the Primary file
+3. Extract content between `## {Match}` and the next `## ` header
+4. Display the section content
+
+**Section Matching Algorithm:**
+
+Use case-insensitive substring matching:
+
+1. Normalize user input and section names to lowercase
+2. Check if user input is substring of any section name
+3. If single match: use it
+4. If multiple matches: pick the first one (or ask user to clarify)
+5. If no matches: list available sections
+
+**Examples:**
+- User: "show rollout" → matches "Rollout"
+- User: "security" → matches "Security Considerations"
+- User: "risks" → matches "Risks"
+- User: "key decisions" → matches "Key Decisions"
+
+**"Walk me through it"**
+1. Start with the first section
+2. Display content
+3. Ask "Continue to {Next Section}?"
+4. Repeat until user stops or end of document
+
+**"Jump to {section}"**
+Same as "Show me {section}".
+
+## 4. Contextual Search (Thought Docs)
+
+**Trigger Detection:**
+
+If user query contains any of: "why", "rejected", "alternative", "decision", "reason", "chose", "didn't"
+→ Enter context search mode
+
+**Term Extraction:**
+
+Extract key phrases from the question:
+- Strip question words: "why was", "why did we", "what about"
+- Extract 2-4 word phrases: "event-based approach", "webhook pattern", "async processing"
+- If user mentions specific terms in quotes, use those exactly
+
+**Examples:**
+- "Why was event-based rejected?" → search for "event-based"
+- "Why did we choose sync over async?" → search for "sync" and "async"
+- "What about the webhook approach?" → search for "webhook"
+
+**Search Process:**
+
+1. Search the **Context** document (e.g., `thought-doc.md`) first:
+   ```bash
+   grep -C 5 -i "{term}" {path_to_context}
+   ```
+
+2. Display results with context (5 lines before/after)
+
+3. If multiple matches found: show first 3 matches
+
+4. If no match in context doc: search Primary document
+
+5. If still no match: "No mentions of '{term}' found in design docs"
+
+**Display Format:**
+
+```
+Searching thought doc for "event-based"...
+
+Found in Key Decisions section:
+
+> Event-based was rejected because of complexity in guaranteeing
+> order and handling failures. The synchronous API approach is
+> simpler and sufficient for the MVP requirements. We considered
+> event streaming but decided it was premature optimization.
+
+Anything else?
+```
+
+## 5. Posting Feedback (MVP: Deferred)
+*For MVP, we just display content. Users can use `gh pr comment` manually if they want, but the tool focuses on reading.*