@orchestrator-ui/orchestrator-ui-components 1.30.2 → 1.30.3

package/.turbo/turbo-build.log

@@ -1,5 +1,5 @@
 
-> @orchestrator-ui/orchestrator-ui-components@1.30.2 build
+> @orchestrator-ui/orchestrator-ui-components@1.30.3 build
 > tsup src/index.ts --format esm --dts --tsconfig tsconfig.build.json
 
 CLI Building entry: src/index.ts
@@ -8,7 +8,7 @@
 CLI Target: es6
 ESM Build start
 DTS Build start
-ESM dist/index.js 1.87 MB
-ESM ⚡️ Build success in 680ms
-DTS ⚡️ Build success in 14518ms
+ESM dist/index.js 1.86 MB
+ESM ⚡️ Build success in 743ms
+DTS ⚡️ Build success in 13941ms
 DTS dist/index.d.ts 174.58 KB

package/.turbo/turbo-lint.log

@@ -1,10 +1,4 @@
 
-> @orchestrator-ui/orchestrator-ui-components@1.30.2 lint
+> @orchestrator-ui/orchestrator-ui-components@1.30.3 lint
 > eslint "src/**/*.ts*"
 
-
-/home/runner/work/orchestrator-ui-library/orchestrator-ui-library/packages/orchestrator-ui-components/src/components/WfoForms/formFields/deprecated/VlanField.tsx
-  168:8  warning  React Hook useEffect has a missing dependency: 'disabled'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
-
-✖ 1 problem (0 errors, 1 warning)
-

package/.turbo/turbo-test.log

@@ -1,40 +1,40 @@
 
-> @orchestrator-ui/orchestrator-ui-components@1.30.2 test
+> @orchestrator-ui/orchestrator-ui-components@1.30.3 test
 > jest
 
 PASS Wfo-UI Tests src/components/WfoForms/formFields/utils.spec.ts
 PASS Wfo-UI Tests src/components/WfoSubscription/utils/utils.spec.ts
 PASS Wfo-UI Tests src/utils/date.spec.ts
-PASS Wfo-UI Tests src/utils/getProductNamesFromProcess.spec.ts
 PASS Wfo-UI Tests src/pages/processes/timelineUtils.spec.ts
 PASS Wfo-UI Tests src/components/WfoTree/treeUtils.spec.ts
+PASS Wfo-UI Tests src/utils/getProductNamesFromProcess.spec.ts
 PASS Wfo-UI Tests src/components/WfoTable/WfoDataGridTable/WfodataGridColumns.spec.ts
 PASS Wfo-UI Tests src/utils/string.spec.ts
 PASS Wfo-UI Tests src/components/WfoTable/WfoTableWithFilter/updateQueryString.spec.ts
 PASS Wfo-UI Tests src/components/WfoTable/utils/tableConfigPersistence.spec.ts
-PASS Wfo-UI Tests src/components/WfoTable/utils/tableUtils.spec.ts
 PASS Wfo-UI Tests src/components/WfoTable/utils/mapSortableAndFilterableValuesToTableColumnConfig.spec.ts
+PASS Wfo-UI Tests src/components/WfoTable/utils/tableUtils.spec.ts
 PASS Wfo-UI Tests src/utils/resultFlattener.spec.ts
 PASS Wfo-UI Tests src/components/WfoPageTemplate/WfoSidebar/utils/menuItemIsAllowed.spec.ts
 PASS Wfo-UI Tests src/utils/getEnvironmentVariables.spec.ts
-PASS Wfo-UI Tests src/messages/getTranslationMessages.spec.ts
 PASS Wfo-UI Tests src/utils/getToastMessage.spec.ts
+PASS Wfo-UI Tests src/messages/getTranslationMessages.spec.ts
 PASS Wfo-UI Tests src/utils/optionalArray.spec.ts
 PASS Wfo-UI Tests src/components/WfoTable/utils/columns.spec.ts
-PASS Wfo-UI Tests src/utils/sortObjectKeys.spec.ts
 PASS Wfo-UI Tests src/utils/filterData.spec.ts
+PASS Wfo-UI Tests src/utils/sortObjectKeys.spec.ts
 PASS Wfo-UI Tests src/components/WfoWorkflowSteps/stepListUtils.spec.ts
 PASS Wfo-UI Tests src/utils/getTokenName.spec.ts
 PASS Wfo-UI Tests src/utils/environmentVariables.spec.ts
-PASS Wfo-UI Tests src/utils/onlyUnique.spec.ts
 PASS Wfo-UI Tests src/utils/uuid.spec.ts
+PASS Wfo-UI Tests src/utils/onlyUnique.spec.ts
 PASS Wfo-UI Tests src/utils/getTypedFieldFromObject.spec.ts
 PASS Wfo-UI Tests src/utils/cacheTag.spec.ts
-PASS Wfo-UI Tests src/utils/getQueryVariablesForExport.spec.ts
 PASS Wfo-UI Tests src/components/WfoPageTemplate/WfoPageHeader/utils/toHexColorWithOpacity.spec.ts
+PASS Wfo-UI Tests src/utils/getQueryVariablesForExport.spec.ts
 
 Test Suites: 30 passed, 30 total
 Tests:       169 passed, 169 total
 Snapshots:   0 total
-Time:        3.938 s
+Time:        3.844 s
 Ran all test suites.

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @orchestrator-ui/orchestrator-ui-components
 
+## 1.30.3
+
+### Patch Changes
+
+-   679ae6c: Fix for vlan field not showing initial value on 2nd page on modify workflow
+
 ## 1.30.2
 
 ### Patch Changes

package/dist/index.js

@@ -43946,12 +43946,10 @@ function Vlan(_a) {
     (_item, index) => index.toString() !== nameArray.slice(-2, -1)[0]
   ).filter((item) => get6(item, subscriptionFieldName) === subscriptionId).map((item) => get6(item, selfName)).join(",");
   useEffect15(() => {
-    if (subscriptionId && isFetched && !portIsTagged && value !== "0") {
-      onChange("0");
-    } else if (!disabled && (!subscriptionId && value !== "" || subscriptionId && portIsTagged && value === "0")) {
+    if (!initialValue) {
       onChange("");
     }
-  }, [onChange, subscriptionId, value, isFetched, portIsTagged]);
+  }, [initialValue, onChange, subscriptionId, isFetched]);
   const [usedVlansInIms, setUsedVlansInIms] = useState25([]);
   const [missingInIms, setMissingInIms] = useState25(false);
   const {
@@ -43974,7 +43972,7 @@ function Vlan(_a) {
       setMissingInIms(true);
       setUsedVlansInIms([]);
     }
-  }, [data, error, fetchError, isLoading, nsiVlansOnly, subscriptionId]);
+  }, [data, fetchError]);
   const currentVlans = getAllNumbersForVlanRange(initialValue);
   const usedVlans = numbersFromGroupedArray(usedVlansInIms).filter(
     (n) => !currentVlans.includes(n)

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@orchestrator-ui/orchestrator-ui-components",
-    "version": "1.30.2",
+    "version": "1.30.3",
     "license": "Apache-2.0",
     "description": "Library of UI Components used to display the workflow orchestrator frontend",
     "author": {

package/src/components/WfoForms/formFields/deprecated/VlanField.tsx

@@ -155,17 +155,14 @@ function Vlan({
         .map((item) => get(item, selfName))
         .join(',');
 
+    // Refactored to simpler logic, no need to check for untagged ports and removed setting value to 0
+    // If the subscriptionId is changed then we need to reset the value only if there wasn't an initial value already set
+    // In the create workflow we need to reset the value if the subscriptionId is changed, in the modify workflow we don't
     useEffect(() => {
-        if (subscriptionId && isFetched && !portIsTagged && value !== '0') {
-            onChange('0');
-        } else if (
-            !disabled &&
-            ((!subscriptionId && value !== '') ||
-                (subscriptionId && portIsTagged && value === '0'))
-        ) {
+        if (!initialValue) {
             onChange('');
         }
-    }, [onChange, subscriptionId, value, isFetched, portIsTagged]);
+    }, [initialValue, onChange, subscriptionId, isFetched]);
 
     const [usedVlansInIms, setUsedVlansInIms] = useState<VlanRange[]>([]);
     const [missingInIms, setMissingInIms] = useState(false);
@@ -190,7 +187,7 @@ function Vlan({
             setMissingInIms(true);
             setUsedVlansInIms([]);
         }
-    }, [data, error, fetchError, isLoading, nsiVlansOnly, subscriptionId]);
+    }, [data, fetchError]);
 
     // Filter currently used vlans because they are probably from the current subscription
     const currentVlans = getAllNumbersForVlanRange(initialValue);