@orchestrator-claude/definitions 3.8.3 → 3.9.0

package/agents/task-generator.md

@@ -1,11 +1,14 @@
 ---
 name: task-generator
 description: Agente Gerador de Tarefas que transforma planos tecnicos em backlogs de tarefas atomicas. Use quando precisar criar tasks.md a partir de um plano aprovado.
-tools: Read, Write, Edit, Grep, Glob
+tools: Read, Write, Edit, Grep, Glob, mcp__orchestrator-extended__artifactStore, mcp__orchestrator-tools__startAgentInvocation, mcp__orchestrator-tools__completeAgentInvocation
 model: sonnet
 color: pink
 permissionMode: default
-skills: kb-lookup, artifact-validator
+memory: project
+skills:
+  - artifact-production
+  - project-conventions
 ---
 
 # Task Generator Agent
@@ -282,33 +285,23 @@ Uma tarefa so esta DONE quando:
 
 ## Output Esperado
 
-**CRITICAL**: Sub-agents do NOT have access to MCP tools.
+**Storage**: MinIO (via MCP tool)
 
-**Storage**: Filesystem (staging area)
-**Artifact Path**: Provided in prompt as staging path
+### Artifact Storage (Direct MCP)
 
-### Artifact Persistence Protocol
+Voce tem acesso direto a MCP tools para armazenamento de artefatos.
 
-**MUST** use Write tool to persist artifacts to the staging path provided in the prompt.
-**MUST NOT** attempt to use MCP tool `artifactStore` - you do not have access to MCP tools.
+1. Call ToolSearch("select:mcp__orchestrator-extended__artifactStore") to load schema
+2. Call artifactStore with: `{ workflowId, phase: "tasks", artifactType: "tasks", content, metadata }`
+3. Metadata must include: `{ author: "task-generator-agent", version: "1.0", status: "draft" }`
 
-The main agent will relay the artifact to MinIO after you complete.
+Nao e necessario staging path ou relay via filesystem — artefatos vao diretamente ao MinIO.
 
-**Example:**
-```
-Prompt includes: "stagingPath: /tmp/orchestrator/tasks_wf_abc123_1707934800.md"
-
-Your action:
-1. Generate tasks.md content
-2. Use Write tool to save to /tmp/orchestrator/tasks_wf_abc123_1707934800.md
-3. Return completion status with file path
-```
+### Invocation Tracking
 
-The main agent will then:
-1. Read the staging file
-2. Store it in MinIO via `artifactStore` MCP tool
-3. Register artifact metadata in PostgreSQL
-4. Delete the staging file
+Track your own execution for observability:
+1. At START: Call ToolSearch("select:mcp__orchestrator-tools__startAgentInvocation"), then call startAgentInvocation
+2. At END: Call completeAgentInvocation with result summary
 
 ### Artifact Requirements
 
@@ -318,7 +311,6 @@ O artefato deve:
 3. Ter tarefas atomicas (max 4h cada)
 4. Ter dependencias sem ciclos
 5. Ter criterios de aceite verificaveis
-6. Ser escrito no staging path fornecido usando Write tool
 
 ## Criterios de Qualidade
 

package/hooks/post-agent-artifact-relay.sh

@@ -1,157 +1,11 @@
 #!/bin/bash
-# Post-Agent Artifact Relay Hook
-# TD-039: Automatically relays artifacts from staging to MinIO after agent completion.
+# Post-Agent Artifact Relay Hook (DEPRECATED — ADR-012)
 #
-# Called as a PostToolUse hook on the Task matcher.
-# Reads stdin JSON with structure:
-#   { "tool_name": "Task", "tool_input": { "subagent_type": "...", ... } }
+# With ADR-012 F1, agents store artifacts directly via MCP artifactStore.
+# This hook is no longer needed. Kept as documentation.
 #
-# Flow:
-# 1. Extract subagent_type from stdin
-# 2. Skip non-artifact agents (orchestrator, reviewer, docs-guardian, etc.)
-# 3. Get active workflow from API
-# 4. Login to get JWT token
-# 5. Call DELETE /api/v1/workflows/:id/pending-action to trigger relay
-# 6. Log result
-
-set -e
-
-SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-PROJECT_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
-STATE_DIR="$PROJECT_ROOT/.orchestrator/.state"
-LOG_FILE="$STATE_DIR/relay-hook.log"
-
-# Ensure state directory exists
-mkdir -p "$STATE_DIR"
-
-# Log rotation: max 1MB
-MAX_LOG_SIZE=1048576
-if [ -f "$LOG_FILE" ]; then
-  LOG_SIZE=$(stat -f%z "$LOG_FILE" 2>/dev/null || stat -c%s "$LOG_FILE" 2>/dev/null || echo 0)
-  if [ "$LOG_SIZE" -gt "$MAX_LOG_SIZE" ]; then
-    [ -f "${LOG_FILE}.1" ] && mv "${LOG_FILE}.1" "${LOG_FILE}.2"
-    mv "$LOG_FILE" "${LOG_FILE}.1"
-  fi
-fi
-
-log() {
-  echo "[$(date -u +%Y-%m-%dT%H:%M:%SZ)] $*" >> "$LOG_FILE"
-}
-
-# Configuration
-API_URL="${ORCHESTRATOR_API_URL:-http://localhost:3001}"
-AUTH_EMAIL="${ORCHESTRATOR_AUTH_EMAIL:-admin@orchestrator.local}"
-AUTH_PASSWORD="${ORCHESTRATOR_AUTH_PASSWORD:-admin123}"
-
-# Read stdin
-STDIN_DATA=""
-if [ ! -t 0 ]; then
-  STDIN_DATA=$(cat)
-fi
-
-if [ -z "$STDIN_DATA" ]; then
-  log "SKIP: No stdin data"
-  exit 0
-fi
-
-# Extract agent type from stdin JSON
-AGENT_TYPE=$(echo "$STDIN_DATA" | node -e "
-  let data = '';
-  process.stdin.on('data', chunk => data += chunk);
-  process.stdin.on('end', () => {
-    try {
-      const json = JSON.parse(data);
-      const type = json.tool_input?.subagent_type
-                || json.subagent_type
-                || json.tool_input?.type
-                || '';
-      console.log(type);
-    } catch { console.log(''); }
-  });
-" 2>/dev/null)
-
-if [ -z "$AGENT_TYPE" ]; then
-  log "SKIP: Could not extract agent type"
-  exit 0
-fi
-
-# TD-039 Phase 3: Inverted whitelist → blacklist.
-# All agents produce artifacts EXCEPT orchestrator (coordinator only).
-case "$AGENT_TYPE" in
-  orchestrator)
-    log "SKIP: Agent '$AGENT_TYPE' is a coordinator, not an artifact producer"
-    exit 0
-    ;;
-  *)
-    log "RELAY: Agent '$AGENT_TYPE' completed, starting relay..."
-    ;;
-esac
-
-# Get active workflow status
-STATUS_RESPONSE=$(curl -s -f "${API_URL}/api/v1/workflows/status" 2>/dev/null) || {
-  log "SKIP: Could not reach API at ${API_URL}/api/v1/workflows/status"
-  exit 0
-}
-
-WORKFLOW_ID=$(echo "$STATUS_RESPONSE" | node -e "
-  let data = '';
-  process.stdin.on('data', chunk => data += chunk);
-  process.stdin.on('end', () => {
-    try {
-      const json = JSON.parse(data);
-      // Support both { id } and { data: { id } } shapes
-      const id = json.data?.id || json.id || '';
-      console.log(id);
-    } catch { console.log(''); }
-  });
-" 2>/dev/null)
-
-if [ -z "$WORKFLOW_ID" ]; then
-  log "SKIP: No active workflow found"
-  exit 0
-fi
-
-log "RELAY: Active workflow=$WORKFLOW_ID"
-
-# Login to get JWT token
-LOGIN_PAYLOAD=$(node -e "console.log(JSON.stringify({email:'${AUTH_EMAIL}',password:'${AUTH_PASSWORD}'}))")
-LOGIN_RESPONSE=$(curl -s -f -X POST "${API_URL}/api/v1/auth/login" \
-  -H "Content-Type: application/json" \
-  -d "$LOGIN_PAYLOAD" 2>/dev/null) || {
-  log "ERROR: Login failed"
-  exit 0
-}
-
-TOKEN=$(echo "$LOGIN_RESPONSE" | node -e "
-  let data = '';
-  process.stdin.on('data', chunk => data += chunk);
-  process.stdin.on('end', () => {
-    try {
-      const json = JSON.parse(data);
-      console.log(json.data?.accessToken || json.accessToken || json.token || '');
-    } catch { console.log(''); }
-  });
-" 2>/dev/null)
-
-if [ -z "$TOKEN" ]; then
-  log "ERROR: Could not extract token from login response"
-  exit 0
-fi
-
-# Call relay endpoint: DELETE /api/v1/workflows/:id/pending-action
-RELAY_RESPONSE=$(curl -s -w "\n%{http_code}" -X DELETE \
-  "${API_URL}/api/v1/workflows/${WORKFLOW_ID}/pending-action" \
-  -H "Content-Type: application/json" \
-  -H "Authorization: Bearer ${TOKEN}" \
-  -d '{}' 2>/dev/null)
-
-HTTP_CODE=$(echo "$RELAY_RESPONSE" | tail -1)
-BODY=$(echo "$RELAY_RESPONSE" | sed '$d')
-
-if [ "$HTTP_CODE" = "200" ] || [ "$HTTP_CODE" = "204" ]; then
-  log "SUCCESS: Relay completed for workflow=$WORKFLOW_ID agent=$AGENT_TYPE http=$HTTP_CODE"
-else
-  log "ERROR: Relay failed for workflow=$WORKFLOW_ID agent=$AGENT_TYPE http=$HTTP_CODE body=$BODY"
-fi
+# Previous behavior: relayed artifacts from filesystem staging to MinIO.
+# Now: agents call mcp__orchestrator-extended__artifactStore directly.
 
+# No-op: agents handle artifact storage directly
 exit 0

package/hooks/post-implement-validate.sh

@@ -1,139 +1,102 @@
 #!/bin/bash
-# Post-Implement Validation Hook
-# Validates orchestrator-index.json consistency after IMPLEMENT phase
-# Detects possible delegation bypass where code was written directly
-# instead of through the implementer subagent
+# Post-Implement Validation Hook (v2 — REST API)
+# Validates workflow consistency after IMPLEMENT phase.
+# Defense-in-depth: agents track progress via MCP, this validates externally.
 #
 # Exit codes:
-#   0 = Validation passed or skipped (jq not available)
-#   1 = Warning detected (possible delegation bypass)
-#
-# Author: Orchestrator System
-# Version: 1.0.0
+#   0 = Validation passed or skipped
+#   1 = Warning detected (TDD violation detected)
 
 set -e
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 PROJECT_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
-INDEX_FILE="$PROJECT_ROOT/.orchestrator/orchestrator-index.json"
+STATE_DIR="$PROJECT_ROOT/.orchestrator/.state"
+
+# API Configuration
+API_URL="${ORCHESTRATOR_API_URL:-http://localhost:3001}"
+AUTH_EMAIL="${ORCHESTRATOR_AUTH_EMAIL:-admin@orchestrator.local}"
+AUTH_PASSWORD="${ORCHESTRATOR_AUTH_PASSWORD:-admin123}"
+PROJECT_ID="${ORCHESTRATOR_PROJECT_ID:-d001d65d-25f5-4d13-b1dc-d006873e949c}"
 
-# Colors for output
+# Colors
 RED='\033[0;31m'
 YELLOW='\033[1;33m'
 GREEN='\033[0;32m'
-CYAN='\033[0;36m'
-NC='\033[0m' # No Color
-
-log_info() {
-    echo -e "${GREEN}[post-implement-validate]${NC} $1" >&2
-}
-
-log_warn() {
-    echo -e "${YELLOW}[post-implement-validate] WARNING:${NC} $1" >&2
-}
-
-log_error() {
-    echo -e "${RED}[post-implement-validate] ERROR:${NC} $1" >&2
-}
-
-log_debug() {
-    if [ "${DEBUG:-false}" = "true" ]; then
-        echo -e "${CYAN}[post-implement-validate] DEBUG:${NC} $1" >&2
+NC='\033[0m'
+
+log_info() { echo -e "${GREEN}[post-implement-validate]${NC} $1" >&2; }
+log_warn() { echo -e "${YELLOW}[post-implement-validate] WARNING:${NC} $1" >&2; }
+
+# Auth: get cached token
+get_token() {
+  mkdir -p "$STATE_DIR"
+  local cached="$STATE_DIR/jwt-token"
+  if [ -f "$cached" ]; then
+    local age=$(( $(date +%s) - $(stat -c%Y "$cached" 2>/dev/null || stat -f%m "$cached" 2>/dev/null || echo 0) ))
+    if [ "$age" -lt 3500 ]; then
+      cat "$cached"
+      return
     fi
+  fi
+  local resp
+  resp=$(curl -s -f -X POST "${API_URL}/api/v1/auth/login" \
+    -H "Content-Type: application/json" \
+    -d "{\"email\":\"${AUTH_EMAIL}\",\"password\":\"${AUTH_PASSWORD}\"}" 2>/dev/null) || return 1
+  local token
+  token=$(echo "$resp" | node -e "let d='';process.stdin.on('data',c=>d+=c);process.stdin.on('end',()=>{try{const j=JSON.parse(d);console.log(j.data?.accessToken||j.accessToken||j.token||'')}catch{console.log('')}})" 2>/dev/null)
+  if [ -n "$token" ]; then
+    echo "$token" > "$cached"
+    echo "$token"
+  fi
 }
 
-# Check if jq is available
-if ! command -v jq &> /dev/null; then
-    log_warn "jq not found, skipping validation (install jq for full validation)"
-    exit 0
-fi
-
-# Check if orchestrator-index.json exists
-if [ ! -f "$INDEX_FILE" ]; then
-    log_debug "orchestrator-index.json not found at $INDEX_FILE, skipping validation"
-    exit 0
-fi
-
-# Read statistics from orchestrator-index.json
-TASKS_COMPLETED=$(jq -r '.statistics.tasksCompleted // 0' "$INDEX_FILE" 2>/dev/null || echo "0")
-TASKS_PENDING=$(jq -r '.statistics.tasksPending // 0' "$INDEX_FILE" 2>/dev/null || echo "0")
-CURRENT_PHASE=$(jq -r '.activeWorkflow.currentPhase // "unknown"' "$INDEX_FILE" 2>/dev/null || echo "unknown")
-STATUS=$(jq -r '.activeWorkflow.status // "unknown"' "$INDEX_FILE" 2>/dev/null || echo "unknown")
-
-# Count TypeScript files in src/ (if directory exists)
+# Get workflow status from REST API
+TOKEN=$(get_token) || { exit 0; }  # Can't auth → skip silently
+
+WORKFLOW_RESP=$(curl -s -f "${API_URL}/api/v1/workflows?status=in_progress" \
+  -H "Authorization: Bearer $TOKEN" \
+  -H "X-Project-ID: $PROJECT_ID" 2>/dev/null) || { exit 0; }
+
+# Extract workflow info
+WORKFLOW_INFO=$(echo "$WORKFLOW_RESP" | node -e "
+  let d='';
+  process.stdin.on('data',c=>d+=c);
+  process.stdin.on('end',()=>{
+    try {
+      const j=JSON.parse(d);
+      const wfs=j.data||j;
+      const wf=Array.isArray(wfs)?wfs[0]:wfs;
+      if(!wf){console.log('{}');return;}
+      console.log(JSON.stringify({
+        id:wf.id||'',
+        phase:wf.currentPhase||wf.phase||'',
+        status:wf.status||''
+      }));
+    }catch{console.log('{}')}
+  });
+" 2>/dev/null)
+
+CURRENT_PHASE=$(echo "$WORKFLOW_INFO" | node -e "let d='';process.stdin.on('data',c=>d+=c);process.stdin.on('end',()=>{try{console.log(JSON.parse(d).phase||'unknown')}catch{console.log('unknown')}})" 2>/dev/null)
+STATUS=$(echo "$WORKFLOW_INFO" | node -e "let d='';process.stdin.on('data',c=>d+=c);process.stdin.on('end',()=>{try{console.log(JSON.parse(d).status||'unknown')}catch{console.log('unknown')}})" 2>/dev/null)
+
+# Count source and test files
 TS_FILES_COUNT=0
 if [ -d "$PROJECT_ROOT/src" ]; then
-    TS_FILES_COUNT=$(find "$PROJECT_ROOT/src" -name "*.ts" 2>/dev/null | wc -l | tr -d ' ' || echo "0")
+  TS_FILES_COUNT=$(find "$PROJECT_ROOT/src" -name "*.ts" 2>/dev/null | wc -l | tr -d ' ')
 fi
-
-# Count test files
 TEST_FILES_COUNT=0
 if [ -d "$PROJECT_ROOT/tests" ]; then
-    TEST_FILES_COUNT=$(find "$PROJECT_ROOT/tests" -name "*.spec.ts" -o -name "*.test.ts" 2>/dev/null | wc -l | tr -d ' ' || echo "0")
+  TEST_FILES_COUNT=$(find "$PROJECT_ROOT/tests" \( -name "*.test.ts" -o -name "*.spec.ts" \) 2>/dev/null | wc -l | tr -d ' ')
 fi
 
-log_info "Validating IMPLEMENT phase consistency..."
-log_info "  Current Phase: $CURRENT_PHASE"
-log_info "  Status: $STATUS"
-log_info "  Tasks Completed: $TASKS_COMPLETED"
-log_info "  Tasks Pending: $TASKS_PENDING"
-log_info "  TypeScript Files: $TS_FILES_COUNT"
-log_info "  Test Files: $TEST_FILES_COUNT"
-
-# Detection logic
-WARNINGS=0
-MESSAGES=()
-
-# Check 1: Few tasks completed but many pending (primary indicator)
-if [ "$TASKS_COMPLETED" -le 1 ] && [ "$TASKS_PENDING" -gt 5 ]; then
-    MESSAGES+=("Only $TASKS_COMPLETED task(s) completed but $TASKS_PENDING pending.")
-    MESSAGES+=("This suggests the implementer agent may not have been properly invoked.")
-    WARNINGS=$((WARNINGS + 1))
-fi
+log_info "Phase: $CURRENT_PHASE | Status: $STATUS | Src: $TS_FILES_COUNT | Tests: $TEST_FILES_COUNT"
 
-# Check 2: Many source files but few tasks completed
-if [ "$TS_FILES_COUNT" -gt 10 ] && [ "$TASKS_COMPLETED" -lt 5 ]; then
-    MESSAGES+=("Found $TS_FILES_COUNT TypeScript files but only $TASKS_COMPLETED tasks completed.")
-    MESSAGES+=("Code may have been generated without proper task tracking.")
-    WARNINGS=$((WARNINGS + 1))
-fi
-
-# Check 3: Status still "ready_for_implementation" after code exists
-if [ "$STATUS" = "ready_for_implementation" ] && [ "$TS_FILES_COUNT" -gt 5 ]; then
-    MESSAGES+=("Status is still 'ready_for_implementation' but $TS_FILES_COUNT code files exist.")
-    MESSAGES+=("Workflow state may not have been updated correctly.")
-    WARNINGS=$((WARNINGS + 1))
-fi
-
-# Check 4: Source files exist but no test files (TDD violation)
+# TDD check: source files without tests
 if [ "$TS_FILES_COUNT" -gt 5 ] && [ "$TEST_FILES_COUNT" -eq 0 ]; then
-    MESSAGES+=("Found $TS_FILES_COUNT source files but no test files.")
-    MESSAGES+=("TDD methodology may not have been followed.")
-    WARNINGS=$((WARNINGS + 1))
+  log_warn "Found $TS_FILES_COUNT source files but no test files. TDD may not have been followed."
+  exit 1
 fi
 
-# Summary
-if [ "$WARNINGS" -gt 0 ]; then
-    echo "" >&2
-    log_warn "============================================"
-    log_warn "Detected $WARNINGS potential issue(s):"
-    log_warn "============================================"
-    for msg in "${MESSAGES[@]}"; do
-        log_warn "  - $msg"
-    done
-    echo "" >&2
-    log_warn "Possible causes:"
-    log_warn "  1. Implementer agent was not invoked via Task tool"
-    log_warn "  2. Code was written directly instead of through delegation"
-    log_warn "  3. orchestrator-index.json was not updated during implementation"
-    echo "" >&2
-    log_warn "Recommended actions:"
-    log_warn "  1. Review CLAUDE.md section: MANDATORY: IMPLEMENT Phase Delegation"
-    log_warn "  2. Ensure Task tool is used with subagent_type='implementer'"
-    log_warn "  3. Update orchestrator-index.json with correct task progress"
-    echo "" >&2
-    exit 1
-else
-    log_info "Validation passed. No issues detected."
-    exit 0
-fi
+log_info "Validation passed."
+exit 0