@orchestrator-claude/definitions 3.33.0 → 3.35.0

package/skills/project-conventions/SKILL.md

@@ -1,34 +1,57 @@
 ---
 name: project-conventions
-description: Project-wide conventions, patterns, and known gotchas. Loaded by all agents to ensure consistency.
+description: Project patterns, conventions, and known gotchas. Stack-specific conventions are injected via StackContextBuilder at dispatch time.
 ---
 
-## Architecture
-- Clean Architecture: domain → application → infrastructure → presentation
-- TypeScript strict mode (exactOptionalPropertyTypes: true)
-- Vitest for testing, TDD discipline
-- PostgreSQL (OLTP) + Neo4j (Graph) + MinIO (Object Storage)
-
-## DI Patterns (CRITICAL)
-- 'ProjectRepositoryNew' = direct PostgreSQL (returns Project | null)
-- ServiceNames.ProjectRepository = adapter with Result<T> wrapping
-- ALWAYS use 'ProjectRepositoryNew' when consumer expects IProjectRepository
-- Register new services in src/infrastructure/di/container.ts
-
-## Code Patterns
-- Use conditional spread in toDomain() for optional properties
-- KBDocument: mapper inline in repository (no separate Mapper class)
-- Entities generate own IDs via crypto.randomUUID()
-- Definitions are global (no project_id on agent_definitions table)
-
-## Testing
-- Add context: { projectId } to request mocks
-- Set process.env.ENABLE_OBJECT_STORAGE = 'true' for MinIO tests
-- Use describe.skipIf for external service tests (Neo4j, PostgreSQL)
-- UUID IDs: entities generate own — don't pass id to constructors
-
-## What NOT to Do
-- NEVER edit .orchestrator/orchestrator-index.json (deprecated since RFC-012)
-- NEVER store artifacts on filesystem (use MinIO via MCP)
-- NEVER bump versions manually (use /release skill)
-- NEVER read/write orchestrator-index.json for workflow state
+# Project Conventions
+
+## Stack Context
+
+Stack-specific conventions (commands, patterns, architecture rules) are provided in the `[Stack Context]` section of your prompt — injected automatically by the orchestrator based on the detected workspace stack.
+
+If you need deeper guidance on a specific convention topic, use:
+```
+getStackConventions({ pack: "<pack-id-from-context>", topic: "<topic>" })
+```
+
+## Universal Conventions (Stack-Agnostic)
+
+These apply to ALL projects regardless of stack:
+
+### Quality Standards
+- TDD: Write tests BEFORE implementation
+- Coverage: Minimum 80% test coverage
+- SOLID principles: Single Responsibility, Open/Closed, Liskov Substitution, Interface Segregation, Dependency Inversion
+- Clean Code: Meaningful names, small functions, no magic numbers
+
+### Lint gate scope
+
+When task plans specify a lint verification gate (ruff, eslint, etc.), the default scope MUST cover **both `src/` and `tests/`** (or equivalent test directories) — not src-only.
+
+```bash
+# Python (ruff)
+ruff check src/ tests/
+
+# TypeScript (eslint)
+npx eslint src/ tests/
+```
+
+**Rationale:** src-only scoping masks lint debt landing in test files; subsequent CI runs / next contributors discover it as a fix-up commit window. Origin: S226 wave-3c TD-S226-003 fix-up commit (`8bad8d2`). Promoted from TD-S226-005.
+
+If a task-generator template emits a lint gate, it MUST default to broader scope. Optionally promote to `pre-commit` hook in target repo.
+
+### Git Conventions
+- Conventional Commits: feat/fix/refactor/test/docs/chore prefix
+- Co-Authored-By trailer for AI-assisted commits
+- Atomic commits: one logical change per commit
+
+### Architecture Principles
+- Dependencies point inward (presentation → application → domain)
+- Domain layer has zero external dependencies
+- Ports in application layer, adapters in infrastructure
+- No business logic in presentation layer
+
+### Documentation
+- Code should be self-documenting; comments explain "why" not "what"
+- Public APIs need JSDoc/docstrings
+- Architecture decisions in ADRs

package/skills/project-management-enterprise/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: project-management-enterprise
-description: PME workflow runtime playbook. Load when: "PME workflow", "consultoria", "consultoria externa", "consultoria interna", "software handoff", "cirurgico", "variant=consultoria-externa", or when starting/advancing a project_management_enterprise workflow. Provides variant selection guide, gate intensity tuning, persona pairing strategy, adversarial review iteration playbook, and phase lifecycle reference.
+description: 'PME workflow runtime playbook. Load when: "PME workflow", "consultoria", "consultoria externa", "consultoria interna", "software handoff", "cirurgico", "variant=consultoria-externa", or when starting/advancing a project_management_enterprise workflow. Provides variant selection guide, gate intensity tuning, persona pairing strategy, adversarial review iteration playbook, and phase lifecycle reference.'
 allowed-tools: Read
 ---