@orangesk/orange-design-system 3.10.0 → 3.12.0

package/src/components/Footer/Footer.tsx

@@ -1,6 +1,5 @@
 import cx from "classnames";
 import React from "react";
-import { SocialButton } from "../SocialButton";
 import {
   CLASS_ACCORDION_ICON,
   CLASS_ACCORDION_TOGGLE,
@@ -24,15 +23,26 @@ import {
   CLASS_TITLE,
 } from "./constants";
 import footerData, { apps, socials } from "./data";
-import { PlanObnovyImage } from "./PlanObnovy";
+import { FooterIcon } from "./FooterIcon";
 
 interface FooterProps extends React.HTMLAttributes<HTMLDivElement> {
   data?: typeof footerData;
   className?: string;
+  /** Override the theme sprite URL for a custom hosting location. */
+  spritePath?: string;
 }
 
-const Footer: React.FC<FooterProps> = ({ className, data = footerData }) => {
+const Footer: React.FC<FooterProps> = ({
+  className,
+  data = footerData,
+  spritePath,
+}) => {
   const accordionIdPrefix = `footer-${React.useId().replace(/:/g, "")}`;
+  const themeSpritePath =
+    spritePath ??
+    (className?.split(/\s+/).includes("is-dark")
+      ? "/footer-sprite-dark.svg"
+      : "/footer-sprite-light.svg");
 
   return (
     <footer className={cx(CLASS_ROOT, className)} data-footer>
@@ -43,45 +53,12 @@ const Footer: React.FC<FooterProps> = ({ className, data = footerData }) => {
             aria-label="Odkaz na úvodnú stránku"
             className={CLASS_LOGO}
           >
-            <svg
+            <FooterIcon
+              name="logo"
+              spritePath={themeSpritePath}
               width="48"
               height="48"
-              viewBox="0 0 48 48"
-              fill="none"
-              xmlns="http://www.w3.org/2000/svg"
-            >
-              <path d="M48 0H0V48H48V0Z" fill="black" />
-              <path
-                fillRule="evenodd"
-                clipRule="evenodd"
-                d="M48 48H0V0H48V48Z"
-                fill="#FF7900"
-              />
-              <path
-                d="M5.9078 44.1298C4.1702 44.1298 2.60156 43.0229 2.60156 40.6047C2.60156 38.1855 4.16924 37.0796 5.9078 37.0796C7.6454 37.0796 9.21116 38.1865 9.21116 40.6047C9.21116 43.0229 7.64636 44.1298 5.9078 44.1298ZM5.9078 38.5657C4.59356 38.5657 4.35356 39.7494 4.35356 40.6047C4.35356 41.4591 4.59356 42.6457 5.9078 42.6457C7.22204 42.6457 7.46204 41.4601 7.46204 40.6047C7.46204 39.7503 7.22204 38.5657 5.9078 38.5657Z"
-                fill="white"
-              />
-              <path
-                fillRule="evenodd"
-                clipRule="evenodd"
-                d="M10.418 37.2559H12.0912V38.0412C12.41 37.6179 13.1952 37.1196 13.9316 37.1196C14.0016 37.1196 14.088 37.1196 14.16 37.1283V38.7795H14.0736C13.3095 38.7795 12.4733 38.8985 12.2026 39.4927V43.9356H10.418V37.2559Z"
-                fill="white"
-              />
-              <path
-                d="M18.831 43.3547C18.1777 43.7913 17.4087 44.0223 16.623 44.0181C15.375 44.0181 14.6367 43.1887 14.6367 42.0751C14.6367 40.5794 16.0114 39.7903 18.8444 39.4706V39.0981C18.8444 38.6133 18.4767 38.3291 17.7961 38.3291C17.1164 38.3291 16.5634 38.5989 16.165 39.0971L14.9794 38.4223C15.6015 37.5506 16.55 37.1147 17.8239 37.1147C19.5673 37.1147 20.5455 37.8703 20.5455 39.0981C20.5455 39.0981 20.5436 43.9269 20.5455 43.9394H18.9865L18.831 43.3547ZM16.3686 41.9474C16.3686 42.3967 16.6498 42.8162 17.1606 42.8162C17.7126 42.8162 18.2511 42.5877 18.7887 42.1125V40.5304C17.1471 40.733 16.3686 41.1573 16.3686 41.9474Z"
-                fill="white"
-              />
-              <path
-                fillRule="evenodd"
-                clipRule="evenodd"
-                d="M21.9336 37.4342L23.3899 37.2336L23.5512 38.0256C24.371 37.4246 25.0229 37.1059 25.8437 37.1059C27.2184 37.1059 27.9288 37.8355 27.9288 39.2793V43.9296H26.1691V39.5846C26.1691 38.7667 25.9579 38.399 25.3214 38.399C24.7973 38.399 24.2731 38.6361 23.6741 39.1392V43.9296H21.9336V37.4342Z"
-                fill="white"
-              />
-              <path
-                d="M32.2317 42.5003C33.5642 42.4907 33.6784 41.1323 33.6784 40.2491C33.6784 39.2008 33.1677 38.355 32.2192 38.355C31.5885 38.355 30.8819 38.8158 30.8819 40.3221C30.8819 41.1438 30.9405 42.5118 32.2317 42.5003ZM35.3671 37.2328V43.5582C35.3671 44.6718 35.2787 46.515 32.0983 46.5314C30.785 46.541 29.5658 46.013 29.3239 44.8677L31.0567 44.5874C31.1296 44.9166 31.3322 45.2421 32.3152 45.2421C33.2263 45.2421 33.664 44.8072 33.664 43.7637V42.9851L33.641 42.9611C33.3616 43.4622 32.9373 43.9355 31.9168 43.9355C30.3578 43.9355 29.1328 42.8546 29.1328 40.5966C29.1328 38.3627 30.3981 37.1118 31.817 37.109C33.1514 37.107 33.6429 37.7147 33.76 38.0334L33.736 38.0315L33.8829 37.2328H35.3671ZM39.5709 44.0584C37.6029 44.0584 36.4279 42.7912 36.4279 40.5928C36.4279 38.3704 37.6163 37.1051 39.5431 37.1051C41.4698 37.1051 42.616 38.3339 42.616 40.5045C42.616 40.6216 42.6016 40.7349 42.6016 40.8501H38.1539C38.1664 42.1173 38.6925 42.7557 39.7274 42.7557C40.3907 42.7557 40.8314 42.4869 41.2442 41.9003L42.5306 42.6136C41.9642 43.5611 40.9427 44.0584 39.5709 44.0584ZM40.8899 39.7096C40.8899 38.8178 40.3773 38.2917 39.5431 38.2917C38.7482 38.2917 38.2519 38.8062 38.1827 39.7106L40.8899 39.7096ZM45.6256 34.7214L44.9776 36.3966L44.3191 34.7214H43.7546V36.9294H44.1203V35.0872H44.1299L44.8547 36.9304H45.088L45.808 35.0872H45.8195V36.9304H46.1824V34.7224L45.6256 34.7214ZM41.56 34.7214V35.0152H42.2503V36.9304H42.6151V35.0152H43.3072V34.7214H41.56Z"
-                fill="white"
-              />
-            </svg>
+            />
           </a>
           <ul
             className={cx(
@@ -94,11 +71,17 @@ const Footer: React.FC<FooterProps> = ({ className, data = footerData }) => {
             <li className={CLASS_LIST_BREAK_SM_DOWN} aria-hidden="true" />
             {socials.map((social, index) => (
               <li key={`footer-social-link-${index}`}>
-                <SocialButton
-                  name={social.name}
+                <a
+                  className={`social-button social-button--${social.name}`}
                   href={social.url}
                   aria-label={social.label}
-                />
+                >
+                  <FooterIcon
+                    name={social.name}
+                    spritePath={themeSpritePath}
+                    className="icon icon--medium"
+                  />
+                </a>
               </li>
             ))}
           </ul>
@@ -122,17 +105,12 @@ const Footer: React.FC<FooterProps> = ({ className, data = footerData }) => {
               >
                 <span className={CLASS_TITLE}>{column.title}</span>
                 <span className={CLASS_ACCORDION_ICON} aria-hidden="true">
-                  <svg
+                  <FooterIcon
+                    name="chevron-down"
+                    spritePath={themeSpritePath}
                     width="24"
                     height="24"
-                    viewBox="0 0 80 80"
-                    xmlns="http://www.w3.org/2000/svg"
-                  >
-                    <path
-                      d="M66.666 33.333 40 60 13.333 33.333 20 26.667l20 20 20-20 6.666 6.666Z"
-                      fill="currentColor"
-                    />
-                  </svg>
+                  />
                 </span>
               </button>
               <ul
@@ -166,7 +144,14 @@ const Footer: React.FC<FooterProps> = ({ className, data = footerData }) => {
             {apps.map((app, index) => (
               <li key={`footer-app-link-${index}`}>
                 <a href={app.url} target="_blank" rel="noopener noreferrer">
-                  <img src={app.src} alt={app.label} />
+                  <FooterIcon
+                    name={app.icon}
+                    spritePath={themeSpritePath}
+                    width={app.width}
+                    height={40}
+                    role="img"
+                    aria-label={app.label}
+                  />
                 </a>
               </li>
             ))}
@@ -176,7 +161,12 @@ const Footer: React.FC<FooterProps> = ({ className, data = footerData }) => {
             href="https://www.orange.sk/orange-slovensko/plan-obnovy"
             aria-label="Plán obnovy"
           >
-            <PlanObnovyImage />
+            <FooterIcon
+              name="plan-obnovy"
+              spritePath={themeSpritePath}
+              width="260"
+              height="60"
+            />
           </a>
         </div>
 

package/src/components/Footer/FooterIcon.tsx

@@ -0,0 +1,12 @@
+import React from "react";
+
+interface FooterIconProps extends React.SVGAttributes<SVGSVGElement> {
+  name: string;
+  spritePath: string;
+}
+
+export const FooterIcon = ({ name, spritePath, ...other }: FooterIconProps) => (
+  <svg aria-hidden={other["aria-label"] ? undefined : "true"} {...other}>
+    <use xlinkHref={`${spritePath}#${name}`} />
+  </svg>
+);

package/src/components/Footer/data.ts

@@ -102,12 +102,14 @@ export const socials: Array<{ name: SocialName; url: string; label: string }> =
 export const apps = [
   {
     label: "App Store",
-    src: "/appstore.svg",
+    icon: "appstore",
+    width: 120,
     url: "https://apps.apple.com/sk/app/m%C3%B4j-orange/id519421813",
   },
   {
     label: "Google Play",
-    src: "/googleplay.svg",
+    icon: "googleplay",
+    width: 135,
     url: "https://play.google.com/store/apps/details?id=sk.orange.android.orangego",
   },
 ];

package/src/components/Footer/tests/Footer.unit.test.jsx

@@ -1,8 +1,71 @@
+import { readFileSync } from "node:fs";
 import { render } from "@testing-library/react";
 import footerData from "../data";
 import { Footer } from "../Footer";
 
 describe("Footer", () => {
+  it.each([
+    [undefined, "/footer-sprite-light.svg"],
+    ["custom-footer is-dark", "/footer-sprite-dark.svg"],
+  ])("uses a complete standalone sprite for %s", (className, spritePath) => {
+    const { container } = render(<Footer className={className} />);
+    const sprite = new DOMParser().parseFromString(
+      readFileSync(`public${spritePath}`, "utf8"),
+      "image/svg+xml",
+    );
+    expect(sprite.querySelector("parsererror")).toBeNull();
+    expect(sprite.querySelectorAll("symbol")).toHaveLength(10);
+    const references = Array.from(container.querySelectorAll("use"));
+    expect(references).toHaveLength(13);
+    for (const reference of references) {
+      const href = reference.getAttribute("xlink:href");
+      expect(href).toMatch(new RegExp(`^${spritePath}#`));
+      expect(sprite.getElementById(href.split("#")[1])).not.toBeNull();
+    }
+    expect(container.querySelector("img, path")).toBeNull();
+    for (const element of sprite.querySelectorAll("[clip-path]")) {
+      const id = element
+        .getAttribute("clip-path")
+        .match(/url\(#([^)]+)\)/)?.[1];
+      expect(sprite.getElementById(id)).not.toBeNull();
+    }
+  });
+
+  it("supports a custom sprite hosting URL", () => {
+    const { container } = render(<Footer spritePath="/assets/footer.svg" />);
+    for (const reference of container.querySelectorAll("use")) {
+      expect(reference.getAttribute("xlink:href")).toMatch(
+        /^\/assets\/footer\.svg#/,
+      );
+    }
+  });
+
+  it("keeps social interaction colors and fixes theme colors in each sprite", () => {
+    for (const [theme, color] of [
+      ["light", "#000000"],
+      ["dark", "#ffffff"],
+    ]) {
+      const sprite = new DOMParser().parseFromString(
+        readFileSync(`public/footer-sprite-${theme}.svg`, "utf8"),
+        "image/svg+xml",
+      );
+      for (const name of ["chevron-down", "plan-obnovy"]) {
+        const symbol = sprite.getElementById(name);
+        expect(symbol.outerHTML).not.toContain("currentColor");
+        const colors = [
+          symbol.getAttribute("fill"),
+          ...Array.from(symbol.querySelectorAll("[fill]"), (element) =>
+            element.getAttribute("fill"),
+          ),
+        ];
+        expect(colors).toContain(color === "#000000" ? "#000" : "#fff");
+      }
+      expect(sprite.getElementById("facebook-2").outerHTML).toContain(
+        "currentColor",
+      );
+    }
+  });
+
   it("renders without crashing", () => {
     const { getByRole } = render(<Footer />);
     // Should render a footer landmark

package/src/components/Megamenu/styles/mixins.scss

@@ -659,7 +659,9 @@
 
 @mixin subnav-item {
   display: flex;
+  flex-wrap: wrap;
   column-gap: convert.to-rem(10px);
+  row-gap: convert.to-rem(5px);
   margin-bottom: convert.to-rem(10px) !important;
 
   > #{config.$class-root}__tag {