@orangesk/orange-design-system 2.0.0-beta.1 → 2.0.0-beta.11

package/src/components/Tag/tests/Tag.unit.test.js

@@ -55,6 +55,99 @@ describe("rendering", () => {
       });
     });
 
+    describe("interactive functionality", () => {
+      describe("onClick prop", () => {
+        it("renders as button when onClick is provided", () => {
+          const handleClick = jest.fn();
+          const { getByRole } = render(
+            <Tag onClick={handleClick}>Clickable Tag</Tag>,
+          );
+          expect(getByRole("button")).toBeInTheDocument();
+          expect(getByRole("button")).toHaveClass("tag");
+        });
+
+        it("calls onClick when clicked", () => {
+          const handleClick = jest.fn();
+          const { getByRole } = render(
+            <Tag onClick={handleClick}>Clickable Tag</Tag>,
+          );
+          getByRole("button").click();
+          expect(handleClick).toHaveBeenCalledTimes(1);
+        });
+
+        it("does not call onClick when disabled", () => {
+          const handleClick = jest.fn();
+          const { getByRole } = render(
+            <Tag onClick={handleClick} isDisabled>
+              Disabled Clickable Tag
+            </Tag>,
+          );
+          expect(getByRole("button")).toBeDisabled();
+          expect(getByRole("button")).toHaveAttribute("aria-disabled", "true");
+        });
+
+        it("has button type set to 'button'", () => {
+          const handleClick = jest.fn();
+          const { getByRole } = render(
+            <Tag onClick={handleClick}>Clickable Tag</Tag>,
+          );
+          expect(getByRole("button")).toHaveAttribute("type", "button");
+        });
+      });
+
+      describe("href prop", () => {
+        it("renders as anchor when href is provided", () => {
+          const { getByRole } = render(<Tag href="/test">Link Tag</Tag>);
+          expect(getByRole("link")).toBeInTheDocument();
+          expect(getByRole("link")).toHaveClass("tag");
+        });
+
+        it("sets href attribute correctly", () => {
+          const { getByRole } = render(<Tag href="/test-url">Link Tag</Tag>);
+          expect(getByRole("link")).toHaveAttribute("href", "/test-url");
+        });
+
+        it("supports external links with target attribute", () => {
+          const { getByRole } = render(
+            <Tag href="https://example.com" target="_blank">
+              External Link
+            </Tag>,
+          );
+          expect(getByRole("link")).toHaveAttribute(
+            "href",
+            "https://example.com",
+          );
+          expect(getByRole("link")).toHaveAttribute("target", "_blank");
+        });
+
+        it("sets aria-disabled when isDisabled is true", () => {
+          const { getByRole } = render(
+            <Tag href="/test" isDisabled>
+              Disabled Link Tag
+            </Tag>,
+          );
+          expect(getByRole("link")).toHaveAttribute("aria-disabled", "true");
+        });
+
+        it("supports other anchor attributes", () => {
+          const { getByRole } = render(
+            <Tag href="/test" rel="noopener" title="Test link">
+              Link with attributes
+            </Tag>,
+          );
+          expect(getByRole("link")).toHaveAttribute("rel", "noopener");
+          expect(getByRole("link")).toHaveAttribute("title", "Test link");
+        });
+      });
+
+      describe("default rendering", () => {
+        it("renders as span when neither onClick nor href is provided", () => {
+          const { getByText } = render(<Tag>Default Tag</Tag>);
+          expect(getByText("Default Tag").tagName).toBe("SPAN");
+        });
+      });
+    });
+
     describe("action button", () => {
       it("renders with action button", () => {
         const { getByRole } = render(

package/src/components/Tile/CHANGELOG.md

@@ -2,11 +2,25 @@
 
 ## [Unreleased]
 
+### Breaking Changes
+
+- **Refactored color prop**: The `color` prop now uses global utility classes instead of component-specific color modifiers:
+  - Old: `color="white"` applied `.tile--white` class with custom CSS
+  - New: Uses global classes like `surface-primary`, `surface-secondary`, `background-contrast`, etc.
+  - Removed `"default"` and `"white"` color options
+  - Added support for: `"surface-primary"`, `"surface-secondary"`, `"surface-tertiary"`, `"surface-subtle"`, `"surface-moderate"`, `"surface-contrast"`, `"background-primary"`, `"background-secondary"`, `"background-contrast"`, `"background-accent"`
+
+### Migration Guide
+
+- Replace `color="white"` with `color="surface-primary"`
+- Replace any custom styling that relied on `.tile--white` with global surface utility classes
+- The new color system provides consistent styling across all components in the design system
+
 ### Changed
 
 - Update `Tile` component documentation and usage examples:
   - Expanded usage examples in `Tile.mdx` and `/app/components/tile/page.mdx` to demonstrate:
-    - New color options (including `black`)
+    - New color options using global utility classes
     - Background image and icon support
     - Alignment options with `hAlign` and `vAlign` props
     - Block link and action variants

package/src/components/Tile/Tile.tsx

@@ -5,7 +5,12 @@ import { Image } from "../Image";
 import { Icon } from "../Icon";
 import { IconProps } from "../Icon/Icon";
 
-export type TileColor = "default" | "white";
+export const tileColors = [
+  "surface-primary",
+  "surface-subtle",
+  "surface-contrast",
+] as const;
+export type TileColor = (typeof tileColors)[number];
 export type TileHAlign = "center";
 export type TileVAlign = "center" | "end" | "space-between";
 
@@ -35,7 +40,7 @@ const Tile: React.FC<TileProps> = ({
   backgroundImage,
   vAlign,
   hAlign,
-  color = "default",
+  color,
   space,
   ...other
 }) => {
@@ -43,7 +48,10 @@ const Tile: React.FC<TileProps> = ({
     CLASS_ROOT,
     {
       [`${CLASS_ROOT}--${variant}`]: variant,
-      [`tile--${color}`]: color !== "default",
+      ...(color && color !== "surface-contrast" ? { [color]: true } : {}),
+      ...(color === "surface-contrast"
+        ? { [`${color} text-inverse`]: true }
+        : {}),
     },
     className,
   );

package/src/components/Tile/styles/config.scss

@@ -1,17 +1,6 @@
 @use "../../../styles/tokens/space";
 @use "../../../styles/tools/convert";
 
-$colors: (
-  default: (
-    background-color: transparent,
-    color: var(--color-text-default),
-  ),
-  white: (
-    background-color: var(--color-surface-primary),
-    color: var(--color-text-default),
-  ),
-);
-
 $spacing: (
   xs: convert.to-rem(15px),
   md: space.get("large"),

package/src/components/Tile/styles/style.scss

@@ -1,5 +1,3 @@
-@use "../../../styles/tools/generate";
-@use "./config";
 @use "./mixins";
 
 @layer components {
@@ -10,8 +8,6 @@
       @include mixins.tile-image-aspect;
     }
 
-    @include generate.variants(config.$colors);
-
     &::after {
       content: "";
       position: absolute;
@@ -19,7 +15,7 @@
       left: 0;
       right: 0;
       bottom: 0;
-      border: 1px solid var(--color-border-subtle);
+      border: 1px solid var(--color-border-strong);
       border-radius: inherit;
       pointer-events: none;
     }

package/src/components/Tile/tests/Tile.unit.test.js

@@ -87,11 +87,18 @@ describe("rendering Tile", () => {
       expect(container.querySelector("img")).toHaveClass("tile__bg");
       expect(container.querySelector("img")).toHaveClass("test-class");
     });
-    it("has class tile--black when color is set to black", () => {
+    it("has surface class when color prop is set", () => {
       const { getByTestId } = render(
-        <Tile data-testid="test-id" color="black" />,
+        <Tile data-testid="test-id" color="surface-secondary" />,
       );
-      expect(getByTestId("test-id")).toHaveClass("tile--black");
+      expect(getByTestId("test-id")).toHaveClass("surface-secondary");
+    });
+    it("applies surface-contrast and text-inverse classes when color is surface-contrast", () => {
+      const { getByTestId } = render(
+        <Tile data-testid="test-id" color="surface-contrast" />,
+      );
+      expect(getByTestId("test-id")).toHaveClass("surface-contrast");
+      expect(getByTestId("test-id")).toHaveClass("text-inverse");
     });
     it("applies hAlign and vAlign classes to body", () => {
       const { getByTestId } = render(

package/src/components/index.ts

@@ -1,6 +1,6 @@
-import "../styles/before-components.scss";
 import { Accordion, AccordionItem } from "./Accordion";
 import { Alert } from "./Alert";
+import { AnchorNavigation } from "./AnchorNavigation";
 import { Tag, TagButton } from "./Tag";
 import { Bar, BarBreak, BarItem } from "./Bar";
 import {
@@ -20,6 +20,7 @@ import {
 } from "./Button";
 import { Buttons } from "./Buttons";
 import { Carousel } from "./Carousel";
+import { CarouselHero, CarouselHeroItem } from "./CarouselHero";
 import { CarouselPromotions } from "./CarouselPromotions";
 import { CartTable } from "./CartTable";
 import { Container } from "./Container";
@@ -33,7 +34,6 @@ import {
 } from "./Dropdown";
 import { Expander } from "./Expander/Expander";
 import { FeatureAccordion, FeatureAccordionItem } from "./FeatureAccordion";
-import { Footer } from "./Footer";
 import { Card, CardSection, CardProductHeader } from "./Card";
 import { Icon, Pictogram } from "./Icon";
 import { Gauge } from "./Gauge";
@@ -41,7 +41,6 @@ import { Grid, GridCol } from "./Grid";
 import { Image } from "./Image";
 import { Link } from "./Link";
 import { Loader } from "./Loader";
-import { MegamenuDropdown } from "./Megamenu";
 import {
   Modal,
   ModalBody,
@@ -87,7 +86,6 @@ import { Tab, TabPanel, Tabs } from "./Tabs";
 import { Table } from "./Table";
 import { Tile } from "./Tile";
 import { Tooltip, InfoTooltip } from "./Tooltip";
-import "../styles/after-components.scss";
 import { Cover } from "./Cover";
 import { Testimonial } from "./Testimonial";
 import { Hero } from "./Hero";
@@ -97,6 +95,7 @@ export {
   Accordion,
   AccordionItem,
   Alert,
+  AnchorNavigation,
   Autocomplete,
   Bar,
   BarBreak,
@@ -116,6 +115,8 @@ export {
   CardProductHeader,
   CardSection,
   Carousel,
+  CarouselHero,
+  CarouselHeroItem,
   CarouselPromotions,
   CartTable,
   Checkbox,
@@ -133,7 +134,6 @@ export {
   Field,
   Fieldset,
   File,
-  Footer,
   Gauge,
   Grid,
   GridCol,
@@ -152,7 +152,6 @@ export {
   List,
   ListItem,
   Loader,
-  MegamenuDropdown,
   Message,
   Modal,
   ModalBody,

package/src/styles/base/globals.scss

@@ -4,6 +4,8 @@
 
 // Consider to add more conditions for light and dark themes
 :root,
+:host,
+:host(.is-light),
 .is-light,
 .bg-white,
 #root.is-light,
@@ -16,6 +18,7 @@
   color: var(--color-text-default);
 }
 
+:host(.is-dark),
 .is-dark,
 .bg-black,
 #root.is-dark,
@@ -28,8 +31,29 @@
   color: var(--color-text-default);
 }
 
+:root,
+:host {
+  --extra-scroll-margin: 0;
+  --header-height: 80px;
+}
+
+@media screen and (min-width: 992px) {
+  :root,
+  :host {
+    --header-height: 120px;
+  }
+}
+
+:target {
+  scroll-margin-top: calc(
+    var(--header-height) + var(--extra-scroll-margin) - 1px
+  );
+}
+
 html {
   font-size: base.$font-size;
+  scroll-padding-top: unset;
+  overflow-x: hidden;
 }
 
 html,

package/src/styles/base/styleguide.scss

@@ -1,11 +1,11 @@
-@use '../tokens/color';
-@use '../tokens/space';
-@use '../tools/convert';
-@use '../tools/text';
-@use '../tools/generate';
-@use '../tools/layout';
-@use '../typography/config' as typographyConfig;
-@use 'sass:map' as sassmap;
+@use "../tokens/color";
+@use "../tokens/space";
+@use "../tools/convert";
+@use "../tools/text";
+@use "../tools/generate";
+@use "../tools/layout";
+@use "../typography/config" as typographyConfig;
+@use "sass:map" as sassmap;
 
 main {
   min-height: 100vh;
@@ -13,9 +13,9 @@ main {
 }
 
 .l-debug {
-  padding: space.get('small');
-  background-color: color.$gray-300;
-  border: 1px solid color.$gray-400;
+  padding: space.get("small");
+  background-color: var(--color-surface-subtle);
+  border: 1px solid var(--color-border-strong);
 
   @include layout.reset-last-child-margin-bottom;
 }
@@ -29,7 +29,7 @@ main {
 }
 
 .code-wrapper {
-  border: 1px solid color.$gray-400;
+  border: 1px solid var(--color-border-strong);
 
   pre {
     margin-bottom: 0 !important;
@@ -57,17 +57,17 @@ main {
     width: convert.to-rem(220px);
     min-height: convert.to-rem(40px);
     margin-bottom: space.get();
-    margin-right: space.get('xsmall');
+    margin-right: space.get("xsmall");
     overflow-wrap: anywhere;
 
     .icon {
       cursor: pointer;
       flex-shrink: 0;
-      margin-right: space.get('small');
+      margin-right: space.get("small");
     }
 
     .icon:hover {
-      color: color.$orange;
+      color: var(--color-text-accent);
     }
   }
 }
@@ -122,7 +122,7 @@ main > div {
   }
 
   > h4 {
-    @include generate.css-map(typographyConfig.$body-text, 'large');
+    @include generate.css-map(typographyConfig.$body-text, "large");
   }
 }
 
@@ -130,5 +130,5 @@ main > div {
 main > div > h1 + p,
 main > div > h1 + p + p,
 main > div > h1 + p + p + p {
-  @include generate.css-map(typographyConfig.$body-text, 'large');
+  @include generate.css-map(typographyConfig.$body-text, "large");
 }

package/src/styles/export/base.js

@@ -2,13 +2,13 @@
 // Do not edit this file directly - edit the SCSS source instead
 
 export const exports = {
-  "font-family": "orangeSKNeue, Helvetica Neue, helvetica, arial, sans-serif",
+  "font-family": "OrangeSK Neue, Helvetica Neue, helvetica, arial, sans-serif",
   "font-size": "16px",
   "line-height": "1.25",
   "background": "var(--color-background-primary)",
   "text-color": "var(--color-text-default)",
   "focus-outline": "2px solid var(--color-border-contrast)",
-  "selection-background": "rgba(241, 110, 0, 0.9)"
+  "selection-background": "rgba(241, 94, 0, 0.9)"
 };
 
 export default exports;

package/src/styles/export/color.js

@@ -2,8 +2,8 @@
 // Do not edit this file directly - edit the SCSS source instead
 
 export const exports = {
-  "orange": "#f16e00",
-  "orange-dark": "#f16e00",
+  "orange": "#f15e00",
+  "orange-dark": "#f15e00",
   "black": "#000000",
   "white": "#ffffff",
   "blue": "#4bb4e6",

package/src/styles/shame.scss

@@ -4,7 +4,8 @@
 * This reset is required due to default list spacing in ods 1 and will be removed once megamenu and footer components are migrated to 1.
 **/
   .osk-footer-menu,
-  .mm-header ul {
+  .mm-header ul,
+  .megamenu-header ul {
     max-width: none;
     margin-top: 0;
 

package/src/styles/tokens/base.scss

@@ -1,7 +1,7 @@
 @use "sass:color" as sasscolor;
 @use "./color";
 
-$font-family: "orangeSKNeue", "Helvetica Neue", helvetica, arial, sans-serif;
+$font-family: "'OrangeSK Neue'", "Helvetica Neue", helvetica, arial, sans-serif;
 $font-size: 16px;
 $line-height: 1.25;
 

package/src/styles/tokens/color.scss

@@ -9,14 +9,14 @@ $colors-light: (
   background-accent2-blog: #eee7f7,
   surface-primary: #ffffff,
   surface-secondary: #ff7900,
-  surface-tertiary: #f16e00,
+  surface-tertiary: #f15e00,
   surface-subtle: #eeeeee,
   surface-moderate: #dddddd,
   surface-contrast: #141414,
   surface-accent: #fff6ed,
   fill-primary: #ffffff,
   fill-secondary: #ff7900,
-  fill-tertiary: #f16e00,
+  fill-tertiary: #f15e00,
   fill-subtle: #eeeeee,
   fill-moderate: #dddddd,
   fill-disabled: #cccccc,
@@ -33,14 +33,14 @@ $colors-light: (
   border-subtle: #dddddd,
   border-strong: #cccccc,
   border-contrast: #000000,
-  border-accent: #f16e00,
+  border-accent: #f15e00,
   border-information: #4170d8,
   border-positive: #228722,
   border-warning: #ffcc00,
   border-negative: #cd3c14,
   icon-default: #000000,
   icon-inverse: #ffffff,
-  icon-brand: #f16e00,
+  icon-brand: #f15e00,
   icon-accent: #ffc48f,
   icon-disabled: #cccccc,
   icon-information: #4170d8,
@@ -48,10 +48,10 @@ $colors-light: (
   icon-warning: #ffcc00,
   icon-negative: #cd3c14,
   text-default: #000000,
-  text-secondary: #000000,
+  text-secondary: #666666,
   text-disabled: #cccccc,
   text-inverse: #ffffff,
-  text-accent: #f16e00,
+  text-accent: #f15e00,
 );
 
 $colors-dark: (
@@ -63,14 +63,14 @@ $colors-dark: (
   background-accent2-blog: #2b1a10,
   surface-primary: #141414,
   surface-secondary: #ff7900,
-  surface-tertiary: #f16e00,
+  surface-tertiary: #f15e00,
   surface-subtle: #333333,
   surface-moderate: #595959,
   surface-contrast: #ffffff,
   surface-accent: #2b1a10,
   fill-primary: #000000,
   fill-secondary: #ff7900,
-  fill-tertiary: #f16e00,
+  fill-tertiary: #f15e00,
   fill-subtle: #333333,
   fill-moderate: #595959,
   fill-disabled: #666666,

package/src/styles/typography/mixins.scss

@@ -120,6 +120,8 @@
   margin: 0 0 space.get() 0;
   padding-left: space.get("large");
   @include text-readable;
+  // Apply the same font styles as paragraphs
+  @include generate.responsive-css-map(config.$body-text);
 }
 
 @mixin list-spacing($space, $config: config.$list-spacing) {
@@ -181,9 +183,26 @@
 
 @mixin list-marker-orange() {
   > li {
-
     &::marker {
       color: var(--color-icon-accent);
     }
   }
-}
+}
+
+@mixin description-list() {
+  @include text-readable;
+  @include generate.responsive-css-map(config.$body-text);
+  padding-left: 0;
+
+  dt {
+    font-weight: 700;
+  }
+  dd {
+    margin-left: 0;
+    margin-bottom: convert.to-rem(20px);
+
+    &:last-child {
+      margin-bottom: 0;
+    }
+  }
+}

package/src/styles/typography/style.scss

@@ -16,11 +16,14 @@
 @include readability();
 
 ol,
-ul,
-dl {
+ul {
   @include list-base();
 }
 
+dl {
+  @include description-list();
+}
+
 ul {
   @include ul-list-base();
 }
@@ -56,4 +59,4 @@ ul {
 
 .list--marker-orange {
   @include list-marker-orange();
-}
+}

package/src/styles/utilities/border.scss

@@ -19,7 +19,7 @@
     &.border-hover,
     &.is-indicating {
       &:hover {
-        border-color: color.$gray-700;
+        border-color: var(--color-text-secondary);
       }
     }
   }