@orangepro/orangepro-mcp 0.2.36 → 0.2.38

package/dist/local/operations.js

@@ -1,3 +1,4 @@
+import { loadRiskConfig } from "./score/riskConfig.js";
 import { execFileSync, spawnSync } from "node:child_process";
 import { existsSync, mkdirSync, readFileSync, renameSync, statSync, writeFileSync } from "node:fs";
 import { dirname, join, relative, resolve, sep } from "node:path";
@@ -1553,6 +1554,10 @@ export async function opStart(root, opts = {}, deps = defaultDeps()) {
     }, deps);
     const warnings = [...analyze.warnings];
     reportProgress("start: deterministic graph is ready", { current: 4, total: 8 });
+    // A per-repo/user risk config that fails to parse must announce itself here, not
+    // silently revert to defaults (round-three review finding #1).
+    for (const w of loadRiskConfig(root).warnings)
+        warnings.push(w);
     const staticSnapshot = writeStartStaticSnapshot(root, opts.baseRef, warnings);
     const aiProviderConfigured = deps.aiProvider !== undefined || resolveProviderConfig(providerEnv, providerOpts) !== null;
     const resolvedGenerationProvider = deps.aiProvider ?? resolveGenerationProvider(providerEnv, providerOpts);

package/dist/local/score/risk.js

@@ -337,7 +337,7 @@ function computeRawORS(node, depthCtx, incomingRefs, gitChurn, fanOut, detection
     const routeWeight = deriveRouteWeight(node);
     const flowDepth = getFlowDepth(node, depthCtx);
     const flowPosition = Math.max(0, 5 - flowDepth);
-    const dataSensitivity = signals.sensitivityIgnored ? 0 : deriveDataSensitivity(node);
+    const dataSensitivity = signals.sensitivityOverride !== undefined ? signals.sensitivityOverride : signals.sensitivityIgnored ? 0 : deriveDataSensitivity(node);
     // Irreversibility is impact: a bug on a path that reaches a delete/purge cannot be
     // rolled back. Bounded, additive, graph-derived (Fix C, signal 1).
     const rawI = incomingRefs * 0.3 + routeWeight * 0.3 + flowPosition * 0.2 + dataSensitivity * 0.2;
@@ -345,7 +345,7 @@ function computeRawORS(node, depthCtx, incomingRefs, gitChurn, fanOut, detection
     // queue fails where no request surfaces it (Fix C, signal 2). Proven stays proven.
     const silentFactor = signals.scheduledEntry && detectionTier !== "associated" ? 1.25 : 1;
     const d = DETECTION_MAP[detectionTier] * silentFactor;
-    return { p: rawP, i: rawI, d, reachesDestructiveSink: signals.reachesDestructiveSink, scheduledEntry: signals.scheduledEntry, sensitivityIgnored: signals.sensitivityIgnored };
+    return { p: rawP, i: rawI, d, reachesDestructiveSink: signals.reachesDestructiveSink, scheduledEntry: signals.scheduledEntry, sensitivityIgnored: signals.sensitivityIgnored, sensitivityOverride: signals.sensitivityOverride };
 }
 function staticTestLinkedIds(graph, candidateIds) {
     const ids = new Set();
@@ -565,7 +565,10 @@ export function rankRiskGaps(graph, opts = {}) {
         return computeRawORS(s, depthCtx, incoming_refs, git_churn, fan_out, detectionFor(s.external_id), ts, nowSec, {
             reachesDestructiveSink: cfg.tuning.irreversibility_floor && (reachesSink.get(s.external_id) ?? false),
             scheduledEntry: cfg.tuning.silence_multiplier && (isScheduledEntry(s) || (SCHEDULED_ENTRY_NAME_RE.test(s.title || "") && extraScheduled.some((re) => re.test(symbolFile(s))))),
-            sensitivityIgnored: sensitivityIgnore.some((re) => re.test(s.title || "") || re.test(s.external_id)) || overrideFor(s.external_id)?.action === "reclassify" && overrideFor(s.external_id)?.sensitivity === "none"
+            sensitivityIgnored: sensitivityIgnore.some((re) => re.test(s.title || "") || re.test(s.external_id)) || overrideFor(s.external_id)?.action === "reclassify" && overrideFor(s.external_id)?.sensitivity === "none",
+            // reclassify to a named class uses the SAME values deriveDataSensitivity assigns (payment 10, auth 9, pii 8)
+            sensitivityOverride: (() => { const o = overrideFor(s.external_id); if (!o || o.action !== "reclassify")
+                return undefined; return o.sensitivity === "payment" ? 10 : o.sensitivity === "auth" ? 9 : o.sensitivity === "pii" ? 8 : o.sensitivity === "none" ? 0 : undefined; })()
         });
     });
     const pinnedIds = new Set(symbols.filter((s) => overrideFor(s.external_id)?.action === "pin").map((s) => s.external_id));
@@ -583,7 +586,7 @@ export function rankRiskGaps(graph, opts = {}) {
         const fan_out = fanOut.get(s.external_id) ?? 0;
         const isEntry = entryPoint.get(s.external_id) ?? false;
         const route_weight = deriveRouteWeight(s);
-        const data_sensitivity = rawScores[idx].sensitivityIgnored ? 0 : deriveDataSensitivity(s);
+        const data_sensitivity = rawScores[idx].sensitivityOverride !== undefined ? rawScores[idx].sensitivityOverride : rawScores[idx].sensitivityIgnored ? 0 : deriveDataSensitivity(s);
         const flow_position = Math.max(0, 5 - getFlowDepth(s, depthCtx));
         const complexity_proxy = complexityProxy(s);
         const firstTs = firstCommitTs.get(file) ?? 0;
@@ -719,3 +722,28 @@ export function rankRiskGaps(graph, opts = {}) {
 export function rankPriorityGaps(graph, opts = {}) {
     return rankRiskGaps(graph, { ...opts, maxPerFile: 3, maxPerTitle: 1 });
 }
+/** What the per-repo config DID to this ranking — for visible disclosure in the report.
+ *  A tuned report must never pass as clean: every suppression is listed with its reason. */
+export function configDisclosureFor(graph, repoRoot) {
+    const loaded = loadRiskConfig(repoRoot);
+    const cfg = loaded.config;
+    const symbols = graph.nodes.filter((n) => n.kind === "CodeSymbol" && n.denominator_eligible === true && !n.stale);
+    const suppressed = [];
+    for (const o of cfg.overrides) {
+        if (o.action !== "suppress")
+            continue;
+        const re = globToRegExp(o.symbol);
+        for (const n of symbols)
+            if (n.external_id === o.symbol || re.test(n.external_id))
+                suppressed.push({ symbol: n.title || n.external_id, reason: o.reason });
+    }
+    return {
+        hash: loaded.hash,
+        warnings: loaded.warnings,
+        overridesActive: cfg.overrides.length,
+        suppressed,
+        rankExcludePaths: cfg.classification.rank_exclude_paths,
+        floor: cfg.tuning.irreversibility_floor,
+        silence: cfg.tuning.silence_multiplier
+    };
+}

package/dist/local/score/riskConfig.js

@@ -8,6 +8,7 @@
 import { createHash } from "node:crypto";
 import { existsSync, readFileSync } from "node:fs";
 import { join } from "node:path";
+import { homedir } from "node:os";
 export const DEFAULT_RISK_CONFIG = {
     classification: { test_support_paths: [], scheduled_entry_paths: [], destructive_sinks: [], sensitivity_ignore: [], rank_exclude_paths: [] },
     tuning: { irreversibility_floor: true, silence_multiplier: true },
@@ -21,41 +22,50 @@ export function globToRegExp(glob) {
     const esc = glob.replace(/[.+^${}()|[\]\\]/g, "\\$&").replace(/\*\*/g, "\u0000").replace(/\*/g, "[^/]*").replace(/\u0000/g, ".*");
     return new RegExp(`^${esc}$`);
 }
-export function loadRiskConfig(repoRoot) {
-    const warnings = [];
-    const cfg = JSON.parse(JSON.stringify(DEFAULT_RISK_CONFIG));
-    const file = join(repoRoot, ".orangepro", "config.json");
-    if (repoRoot && existsSync(file)) {
-        try {
-            const raw = JSON.parse(readFileSync(file, "utf8"));
-            const cls = (raw.classification ?? {});
-            cfg.classification.test_support_paths = asStringArray(cls.test_support_paths);
-            cfg.classification.scheduled_entry_paths = asStringArray(cls.scheduled_entry_paths);
-            cfg.classification.destructive_sinks = asStringArray(cls.destructive_sinks);
-            cfg.classification.sensitivity_ignore = asStringArray(cls.sensitivity_ignore);
-            cfg.classification.rank_exclude_paths = asStringArray(cls.rank_exclude_paths);
-            const tun = (raw.tuning ?? {});
-            if (typeof tun.irreversibility_floor === "boolean")
-                cfg.tuning.irreversibility_floor = tun.irreversibility_floor;
-            if (typeof tun.silence_multiplier === "boolean")
-                cfg.tuning.silence_multiplier = tun.silence_multiplier;
-            for (const o of Array.isArray(raw.overrides) ? raw.overrides : []) {
-                const ov = o;
-                if (typeof ov.symbol !== "string" || !["suppress", "pin", "reclassify"].includes(ov.action ?? "")) {
-                    warnings.push(`config: override ignored (needs symbol + action): ${JSON.stringify(o).slice(0, 80)}`);
-                    continue;
-                }
-                if (typeof ov.reason !== "string" || ov.reason.trim().length < 8) {
-                    warnings.push(`config: override for ${ov.symbol} ignored — a reason (≥8 chars) is required so it can be shown on the report.`);
-                    continue;
-                }
-                cfg.overrides.push({ symbol: ov.symbol, action: ov.action, sensitivity: ov.sensitivity, reason: ov.reason.trim() });
-            }
+/** User-level defaults: ~/.orangepro/config.json (override with ORANGEPRO_USER_CONFIG for tests/CI).
+ *  Applied FIRST; the analyzed repo's .orangepro/config.json wins on every key it sets.
+ *  The hash covers the merged result, so provenance still tells the truth. */
+export function userConfigPath() {
+    return process.env.ORANGEPRO_USER_CONFIG ?? join(homedir(), ".orangepro", "config.json");
+}
+function applyFile(cfg, file, warnings, label) {
+    if (!existsSync(file))
+        return;
+    try {
+        const raw = JSON.parse(readFileSync(file, "utf8"));
+        const cls = (raw.classification ?? {});
+        for (const k of ["test_support_paths", "scheduled_entry_paths", "destructive_sinks", "sensitivity_ignore", "rank_exclude_paths"]) {
+            if (Array.isArray(cls[k]))
+                cfg.classification[k] = asStringArray(cls[k]);
         }
-        catch (err) {
-            warnings.push(`config: .orangepro/config.json unreadable for risk settings (${err.message}); defaults used.`);
+        const tun = (raw.tuning ?? {});
+        if (typeof tun.irreversibility_floor === "boolean")
+            cfg.tuning.irreversibility_floor = tun.irreversibility_floor;
+        if (typeof tun.silence_multiplier === "boolean")
+            cfg.tuning.silence_multiplier = tun.silence_multiplier;
+        for (const o of Array.isArray(raw.overrides) ? raw.overrides : []) {
+            const ov = o;
+            if (typeof ov.symbol !== "string" || !["suppress", "pin", "reclassify"].includes(ov.action ?? "")) {
+                warnings.push(`config (${label}): override ignored (needs symbol + action): ${JSON.stringify(o).slice(0, 80)}`);
+                continue;
+            }
+            if (typeof ov.reason !== "string" || ov.reason.trim().length < 8) {
+                warnings.push(`config (${label}): override for ${ov.symbol} ignored — a reason (≥8 chars) is required so it can be shown on the report.`);
+                continue;
+            }
+            cfg.overrides.push({ symbol: ov.symbol, action: ov.action, sensitivity: ov.sensitivity, reason: ov.reason.trim() });
         }
     }
+    catch (err) {
+        warnings.push(`config (${label}): unreadable for risk settings (${err.message}); skipped.`);
+    }
+}
+export function loadRiskConfig(repoRoot) {
+    const warnings = [];
+    const cfg = JSON.parse(JSON.stringify(DEFAULT_RISK_CONFIG));
+    applyFile(cfg, userConfigPath(), warnings, "user defaults");
+    if (repoRoot)
+        applyFile(cfg, join(repoRoot, ".orangepro", "config.json"), warnings, "repo");
     const canonical = JSON.stringify(cfg, Object.keys(cfg).sort());
     const hash = createHash("sha256").update(JSON.stringify(cfg)).digest("hex").slice(0, 12);
     void canonical;

package/dist/local/viz/behaviorReportData.js

@@ -1,4 +1,5 @@
 import { loadRiskConfig } from "../score/riskConfig.js";
+import { configDisclosureFor } from "../score/risk.js";
 import { createHash } from "node:crypto";
 import path from "node:path";
 import { buildRtm } from "../rtm.js";
@@ -936,7 +937,9 @@ export function buildBehaviorReportData(graph, ledger, opts = {}) {
         .sort((a, b) => (b.probability ?? 0) - (a.probability ?? 0) || b.risk_score - a.risk_score || a.id.localeCompare(b.id))
         .slice(0, 20)
         .map((r) => ({ path: r.title, file: r.file, score: r.risk_score, probability: r.probability ?? 0 }));
-    const irreversible = wide.filter((r) => r.sink_callee).slice(0, 20)
+    // Fix: search the FULL ranking for sinks, not the top 200 — a stable destructive path
+    // ranked 300th is exactly what this panel exists to recover.
+    const irreversible = rankRiskGaps(graph, { repoRoot, limit: Number.MAX_SAFE_INTEGER, provenIds }).filter((r) => r.sink_callee).slice(0, 20)
         .map((r) => ({ path: r.title, file: r.file, score: r.risk_score, sink: r.sink_callee ?? "" }));
     const riskHealth = inspectRiskInputHealth(repoRoot);
     const churnAvailable = riskHealth.churnAvailable && riskGaps.every((risk) => risk.churn_available !== false);
@@ -950,7 +953,7 @@ export function buildBehaviorReportData(graph, ledger, opts = {}) {
         toolVersion: ORANGEPRO_VERSION,
         configHash: loadRiskConfig(repoRoot).hash,
         inputFingerprint: createHash("sha256")
-            .update(JSON.stringify({ root: graph.workspace.root_hash, commit: riskHealth.commit, history: riskHealth.history, churn: churnAvailable, window: riskHealth.churnWindow, version: ORANGEPRO_VERSION }))
+            .update(JSON.stringify({ root: graph.workspace.root_hash, commit: riskHealth.commit, history: riskHealth.history, churn: churnAvailable, window: riskHealth.churnWindow, version: ORANGEPRO_VERSION, config: loadRiskConfig(repoRoot).hash }))
             .digest("hex")
             .slice(0, 16),
         reason: churnAvailable ? undefined : (riskHealth.reason ?? "Git churn scan did not complete")
@@ -976,6 +979,7 @@ export function buildBehaviorReportData(graph, ledger, opts = {}) {
         candidateFlows: candidateFlows(graph),
         risks,
         worklists: { changeFrontier, irreversible },
+        configDisclosure: configDisclosureFor(graph, repoRoot),
         zeroProofExplainer: summary.proven === 0 ? { title: ZERO_PROOF_EXPLAINER.title, body: [...ZERO_PROOF_EXPLAINER.body] } : null,
         mapModel: buildSystemMapModel({ flows: flowRows, risks, behaviors: sortedBehaviors }),
         viewMeta: {

package/dist/local/viz/behaviorReportHtml.js

@@ -169,6 +169,24 @@ nav.tabs{display:flex;gap:2px;margin:18px 0 0;border-bottom:1px solid var(--bd)}
 /* RISKS */
 .risk-card{background:var(--s1);border:1px solid var(--bd);border-radius:9px;padding:14px 16px;margin-bottom:10px}
 .risk-tools{display:flex;align-items:center;gap:8px;margin:0 0 12px;flex-wrap:wrap}
+/* WORKLISTS — two views of one ranking */
+.wl-grid{display:grid;grid-template-columns:1fr 1fr;gap:12px;margin:0 0 14px}
+.wl-card{background:var(--s1);border:1px solid var(--bd);border-radius:9px;padding:12px 14px}
+.wl-title{font-size:11px;font-weight:700;letter-spacing:.04em;text-transform:uppercase;margin:0 0 2px}
+.wl-title.wl-change{color:var(--amber)} .wl-title.wl-irrev{color:var(--red)}
+.wl-sub{font-size:11px;color:var(--muted);margin:0 0 8px;line-height:1.45}
+.wl-row{display:flex;justify-content:space-between;gap:8px;padding:4px 0;border-bottom:1px solid var(--bd);font-family:var(--mono);font-size:11px;cursor:pointer}
+.wl-row:last-child{border-bottom:0}
+.wl-row:hover .wl-path{color:var(--ink)}
+.wl-path{color:var(--ink2);overflow:hidden;text-overflow:ellipsis;white-space:nowrap}
+.wl-meta{color:var(--faint);flex-shrink:0;max-width:46%;overflow:hidden;text-overflow:ellipsis;white-space:nowrap}
+.wl-empty{font-size:11.5px;color:var(--faint);padding:6px 0}
+.cfg{margin:0 0 12px;padding:8px 12px;border:1px solid var(--bd);border-radius:7px;background:var(--s1);font:11px/1.55 var(--mono);color:var(--muted)}
+.cfg b{color:var(--ink2);font-weight:600}
+.cfg.cfg-warn{border-color:var(--rbd);background:var(--rbg);color:var(--red)}
+.cfg.cfg-tuned{border-color:var(--obd);background:var(--obg);color:var(--ink2)}
+.cfg-row{display:block;margin-top:3px}
+@media(max-width:800px){.wl-grid{grid-template-columns:1fr}}
 .risk-filter{appearance:none;border:1px solid var(--bd);background:var(--s1);color:var(--muted);border-radius:20px;padding:5px 10px;font:inherit;font-size:12px;font-weight:600;cursor:pointer}
 .risk-filter:hover{border-color:var(--bd2);color:var(--ink2)}
 .risk-filter[aria-pressed="true"]{border-color:var(--orange);background:var(--obg);color:var(--orange)}
@@ -423,6 +441,8 @@ body[data-mode="expert"] .simple-only{display:none!important}
   <p class="bridge expert-only">This is the <b>priority-gap worklist</b>, ranked by blast radius and test weakness. It is separate from the coverage-status cards above: <b>Reachable · no test signal</b> is one strict coverage bucket, not the number of priority gaps.</p>
   <p class="bridge" id="risk-cap-note" style="font-size:12px;opacity:.75"></p>
   <div class="risk-tools" id="risk-tools"></div>
+  <div id="config-disclosure"></div>
+  <div id="worklists"></div>
   <div id="risk-list"></div>
 </section>
 
@@ -1008,6 +1028,41 @@ riskTools.addEventListener("click",e=>{
 });
 renderRiskFilters();
 renderRisks();
+// ── Config disclosure: what the per-repo config did. Always rendered — a tuned
+// report must never pass as clean, and a broken config must announce itself.
+(function(){
+  const C=D.configDisclosure, host=$("#config-disclosure");
+  if(!C||!host)return;
+  const warn=(C.warnings||[]).length>0;
+  const tuned=C.overridesActive>0||(C.rankExcludePaths||[]).length>0||!C.floor||!C.silence;
+  const bits=["config <b>"+esc(C.hash)+"</b>","overrides active <b>"+C.overridesActive+"</b>","suppressed <b>"+(C.suppressed||[]).length+"</b>"];
+  if((C.rankExcludePaths||[]).length)bits.push("ranking excludes <b>"+esc(C.rankExcludePaths.join(", "))+"</b>");
+  if(!C.floor)bits.push("<b>irreversibility floor OFF</b>");
+  if(!C.silence)bits.push("<b>silence multiplier OFF</b>");
+  let html="<div>"+bits.join(" · ")+"</div>";
+  (C.suppressed||[]).forEach(s=>{html+='<span class="cfg-row">suppressed by config: <b>'+esc(s.symbol)+'</b> — '+esc(s.reason)+'</span>';});
+  (C.warnings||[]).forEach(w=>{html+='<span class="cfg-row">⚠ '+esc(w)+'</span>';});
+  host.className="cfg"+(warn?" cfg-warn":tuned?" cfg-tuned":"");
+  host.innerHTML=html;
+})();
+// ── Worklists: two views of ONE ranking. A single P×I×D top-20 cannot hold
+// "changing fast" and "irreversible but stable" together; both are shown here.
+(function(){
+  const W=D.worklists, host=$("#worklists");
+  if(!W||!host)return;
+  const topPaths=new Set(D.risks.map(r=>r.path));
+  const row=(path,meta)=>{
+    const inTop=topPaths.has(path);
+    return \`<div class="wl-row" data-path="\${esc(path).replace(/"/g,'&quot;')}" title="\${inTop?'in the ranked list below — click to jump':'ranked, but below the top-20 cut'}"><span class="wl-path">\${esc(path)}</span><span class="wl-meta">\${esc(meta)}</span></div>\`;
+  };
+  const cf=(W.changeFrontier||[]).map(r=>row(r.path,"changes "+(r.probability>=7?"a lot":r.probability>=4?"often":"some"))).join("")||'<div class="wl-empty">nothing changing fast and unproven</div>';
+  const ir=(W.irreversible||[]).map(r=>row(r.path,"→ "+(r.sink||"").split(".").pop())).join("")||'<div class="wl-empty">no unproven path reaches a delete</div>';
+  host.innerHTML=\`<div class="wl-grid">
+    <div class="wl-card"><p class="wl-title wl-change">Changing fast · unproven</p><p class="wl-sub">Where the code moves most with nothing proving it. The place a bug is most likely to have just arrived.</p>\${cf}</div>
+    <div class="wl-card"><p class="wl-title wl-irrev">Can destroy data · unproven</p><p class="wl-sub">Paths that reach a delete or purge with nothing proving they do the right thing. Rarely changing — which is why nobody looks.</p>\${ir}</div>
+  </div>\`;
+  host.addEventListener("click",e=>{const r=e.target.closest("[data-path]");if(r&&topPaths.has(r.getAttribute("data-path")))scrollToRisk(r.getAttribute("data-path"));});
+})();
 // toggle test expand
 document.addEventListener('click',e=>{
   const h=e.target.closest('.gen-test-head');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@orangepro/orangepro-mcp",
-  "version": "0.2.36",
+  "version": "0.2.38",
   "private": false,
   "description": "OrangePro (`opro`) — a local-first, BYOK CLI + MCP server that builds an evidence graph from a local checkout, ingests runtime coverage, and generates grounded tests. Metadata-only exports; no source upload; generated tests stay local.",
   "license": "MIT",