@orangecheck/sdk 1.15.0 → 1.16.0

package/README.md

@@ -61,7 +61,6 @@ const outcome = await verify({
     addr: 'bc1q...',
     msg: canonicalMessage, // the exact signed text
     sig: signature,
-    scheme: 'bip322',
 });
 
 if (outcome.ok) {
@@ -69,6 +68,8 @@ if (outcome.ok) {
 }
 ```
 
+The signature's bytes decide how it is checked: 65 bytes is a legacy (BIP-137) signature, on any address it can stand for, and anything else is BIP-322 simple, with or without the `smp` prefix. `outcome.codes` names the one that verified, `sig_ok_bip322` or `sig_ok_legacy`. A BIP-322 full or proof-of-funds signature gets `sig_unsupported_script`. The `scheme` input is ignored.
+
 Use this when you already hold the `(addr, msg, sig)` tuple — e.g., a user pasted it into your UI, or you're verifying an offline proof.
 
 ---

package/dist/attestation.js

@@ -1,8 +1,8 @@
 'use strict';
 
 var base = require('@scure/base');
-var buffer = require('buffer');
 var bip322 = require('@orangecheck/bip322');
+var buffer = require('buffer');
 
 // src/canonical.ts
 function toLowerHex(bytes) {
@@ -157,107 +157,28 @@ function rfc3339Ms(value) {
   const ms = Date.parse(value);
   return Number.isNaN(ms) ? null : ms;
 }
-var log = createLogger("ocp/verify");
-function looksLikeHex(s) {
-  return /^[0-9a-fA-F]+$/.test(s) && s.length % 2 === 0;
-}
 function toBase64Maybe(sig) {
-  if (looksLikeHex(sig)) {
+  if (/^[0-9a-fA-F]+$/.test(sig) && sig.length % 2 === 0) {
     return buffer.Buffer.from(sig, "hex").toString("base64");
   }
   return sig;
 }
-function detectSignatureScheme(addr, sig) {
-  const isSegWit = addr.startsWith("bc1") || addr.startsWith("tb1");
-  if (isSegWit) {
-    return "bip322";
-  }
+function signatureScheme(sigBase64) {
+  if (/^(ful|pof)/.test(sigBase64)) return null;
+  if (sigBase64.startsWith("smp")) return "bip322";
+  return buffer.Buffer.from(sigBase64, "base64").length === 65 ? "legacy" : "bip322";
+}
+
+// src/verify.ts
+var log = createLogger("ocp/verify");
+async function verifySignature({ addr, msg, sig }) {
   const sigBase64 = toBase64Maybe(sig);
-  const looksLikeLegacy = sigBase64.length === 88 && /^[IHG]/.test(sigBase64);
-  if (looksLikeLegacy) {
-    return "legacy";
-  }
-  return "bip322";
-}
-async function verifySignature({
-  addr,
-  msg,
-  sig,
-  scheme
-}) {
-  const detectedScheme = scheme || detectSignatureScheme(addr, sig);
-  log.debug(
-    { addr, msgLength: msg.length, sigLength: sig.length, scheme: detectedScheme },
-    "Verifying signature"
-  );
-  if (detectedScheme === "bip322") {
-    const sigBase64 = toBase64Maybe(sig);
-    log.debug(
-      { sigBase64: sigBase64.substring(0, 50) + "..." },
-      "Signature converted to base64"
-    );
-    log.debug(
-      {
-        msgFull: msg,
-        msgLines: msg.split("\n").length,
-        msgFirstLine: msg.split("\n")[0],
-        msgLastLine: msg.split("\n")[msg.split("\n").length - 1]
-      },
-      "Message being verified"
-    );
-    const ok = bip322.verifySignature(addr, msg, sigBase64);
-    log.info({ addr, ok }, "BIP-322 verification result");
-    if (!ok) {
-      const isSegWit = addr.startsWith("bc1") || addr.startsWith("tb1");
-      if (isSegWit && sigBase64.length === 88) {
-        log.warn(
-          { addr, wallet: "possibly Electrum", sigLength: sigBase64.length },
-          "BIP-322 verification failed - likely Electrum wallet (does not support BIP-322 for SegWit)"
-        );
-      } else {
-        log.error(
-          {
-            addr,
-            sigLength: sigBase64.length,
-            msgLength: msg.length,
-            msgPreview: msg.substring(0, 200)
-          },
-          "BIP-322 verification failed - signature does not match message"
-        );
-      }
-    }
-    return ok ? "sig_ok_bip322" : "sig_invalid";
-  }
-  if (detectedScheme === "legacy") {
-    const sigBase64 = toBase64Maybe(sig);
-    if (!addr.startsWith("1") && !addr.startsWith("m") && !addr.startsWith("n")) {
-      log.warn({ addr }, "Legacy signature attempted on non-P2PKH address");
-      return "sig_unsupported_script";
-    }
-    log.debug(
-      {
-        addr,
-        sigBase64: sigBase64.substring(0, 50) + "...",
-        msgPreview: msg.substring(0, 100) + "...",
-        msgLength: msg.length
-      },
-      "Verifying legacy signature"
-    );
-    const ok = bip322.verifySignature(addr, msg, sigBase64);
-    log.info({ addr, ok, sigBase64Length: sigBase64.length }, "Legacy verification result");
-    if (!ok) {
-      log.error(
-        {
-          addr,
-          msgFirstLine: msg.split("\n")[0],
-          sigFormat: sigBase64.substring(0, 10)
-        },
-        "Legacy signature verification failed - check message format and signature"
-      );
-    }
-    return ok ? "sig_ok_legacy" : "sig_invalid";
-  }
-  return "invalid_scheme";
+  const scheme = signatureScheme(sigBase64);
+  if (!scheme) return "sig_unsupported_script";
+  const ok = bip322.verifySignature(addr, msg, sigBase64);
+  log.info({ addr, ok, scheme, msgLength: msg.length }, "Signature verification result");
+  if (!ok) return "sig_invalid";
+  return scheme === "legacy" ? "sig_ok_legacy" : "sig_ok_bip322";
 }
 async function signatureIsValid(input) {
   try {