@orangecheck/chat-core 0.1.0 → 0.1.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@orangecheck/chat-core",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Verify OC Chat's public artifacts: channel descriptors and posts, directory listings and did:oc session devices. See https://github.com/orangecheck/oc-chat-protocol.",
   "keywords": [
     "bitcoin",

package/src/binding.test.ts

@@ -337,6 +337,25 @@ describe('readChannelVersions: "no newer version" only when every read met the f
     });
 });
 
+describe('readChannelVersions: a page it cannot read past is a cut-off read (§8.3.1)', () => {
+    const ev = version(founderKey, genesis);
+    // 600 events under the channel's tag in one second, newer than the genesis: a
+    // page with \`until\` at that second brings back the same 500 every time.
+    const junk = Array.from({ length: 600 }, (_, i) => ({ ...ev, id: `junk-${i}`, created_at: ev.created_at + 86400, content: 'x' }));
+    const query = async (f: Record<string, unknown>) => {
+        const tagged = f['#t'] ? [...junk, ev].filter((e) => f.until === undefined || e.created_at <= (f.until as number)).slice(0, (f.limit as number) ?? Infinity) : [];
+        const byKey = Array.isArray(f.authors) && f.authors.includes(ev.pubkey) ? [ev] : [];
+        return { events: [...tagged, ...byKey], relayStatus: [{ eose: true }, { eose: true }, { eose: true }, { eose: true }] };
+    };
+    const keys = async () => ({ keys: [founderKey.nostrPk], answered: true, floor: true });
+
+    it('600 events in one second stall the open read: it is truncated, not complete', async () => {
+        const r = await readChannelVersions(genesis.channel_id, { query, everBoundKeys: keys }, FOUNDER);
+        expect(r.events.map((e) => e.id)).toContain(ev.id);
+        expect(r.truncated).toBe(true);
+    });
+});
+
 describe('recordReads.liveness for an address binding with a relay that did not answer', () => {
     const ADDR = 'bc1qmr7qn2t0ahj56ztpdswt54kn2r863ukd8wadj8';
     const kp = generateDeviceKey();

package/src/channel.ts

@@ -979,9 +979,13 @@ export async function readChannelVersions(
         });
         const fresh = add(res);
         for (const e of res.events ?? []) until = Math.min(until ?? Infinity, e.created_at);
-        // A full page that brought something new may have more behind it.
-        if ((res.events ?? []).length < VERSION_PAGE_LIMIT || fresh === 0) break;
-        if (page === VERSION_MAX_PAGES - 1) truncated = true;
+        // A full page may have more behind it. One that brought nothing new is
+        // stuck on a second it cannot page past: the read stops there, cut off.
+        if ((res.events ?? []).length < VERSION_PAGE_LIMIT) break;
+        if (fresh === 0 || page === VERSION_MAX_PAGES - 1) {
+            truncated = true;
+            break;
+        }
     }
     add(await legacy);