@orangecheck/agent-core 2.5.0 → 2.5.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@orangecheck/agent-core",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "OC Agent canonical messages, envelope formats (delegation/action/revocation), scope grammar, and verification. See https://github.com/orangecheck/oc-agent-protocol.",
   "keywords": [
     "bitcoin",

package/src/federation.test.ts

@@ -170,7 +170,7 @@ d('federation reject reasons (each invalid case fails for its named reason)', ()
     });
 });
 
-// FEDERATION.md §4 / SECURITY §7 item 7: a revoked federation delegation must
+// FEDERATION.md §4 / SECURITY §5 item 7: a revoked federation delegation must
 // not verify, and skipping the revocation check has to be stated.
 d('federation delegation revocation check', () => {
     const base = { skipSignatureVerification: true, skipTemporalCheck: true } as const;
@@ -180,6 +180,8 @@ d('federation delegation revocation check', () => {
         const r = await verifyFederationDelegation({ envelope: dv.expected.envelope, ...base });
         expect(r.ok).toBe(false);
         expect(r.ok === false && r.message).toMatch(/requires `revocations`/);
+        expect(r.ok === false && r.message).toMatch(/"#t": \[delegation id\]/);
+        expect(r.ok === false && r.message).not.toMatch(/#delegation/);
     });
 
     it('verifies with an empty revocation list', async () => {

package/src/federation.ts

@@ -228,7 +228,7 @@ async function checkFederationQuorum(
 export interface VerifyFederationDelegationInput extends VerifyFederationBase {
     envelope: FederationDelegationEnvelope;
     /**
-     * Revocations to check (kind-30085 by `#delegation`): federation revocations,
+     * Revocations to check (kind-30085 by `#t` with the delegation id, SPEC §9.4): federation revocations,
      * and agent self-revocations when `revocation.holders` includes "agent".
      * Required unless `skipRevocationCheck` states that revocation is not checked.
      */
@@ -290,7 +290,7 @@ export async function verifyFederationDelegation(
     if (!input.skipRevocationCheck && !input.revocations) {
         return fail(
             'E_MALFORMED',
-            'verifyFederationDelegation requires `revocations` (fetch kind-30085 by #delegation) ' +
+            'verifyFederationDelegation requires `revocations` (query kind 30085 with "#t": [delegation id], SPEC §9.4) ' +
                 'or an explicit skipRevocationCheck:true to state that revocation is not being checked'
         );
     }

package/src/revocation-failclosed.test.ts

@@ -1,6 +1,6 @@
-// SECURITY §7 item 7: "Query revocation feeds (Nostr kind-30085 by
-// `#delegation`) for the cited delegation id before reporting OK, **unless the
-// caller explicitly opts out** of revocation checking."
+// SECURITY §5 item 7: "Query revocation feeds (Nostr kind-30085 by `#t` with
+// the cited delegation id) before reporting OK, **unless the caller explicitly
+// opts out** of revocation checking."
 //
 // The default was inverted. verifyDelegation had NO revocations parameter at
 // all — a revoked delegation returned ok:true and a caller had no way to say
@@ -12,8 +12,9 @@
 // changed is that declining to is now a decision they have to state.
 import { describe, expect, it } from 'vitest';
 
-import { verifyDelegation } from './verify.js';
-import type { DelegationEnvelope } from './types.js';
+import { computeActionId } from './canonical.js';
+import { verifyAction, verifyDelegation } from './verify.js';
+import type { ActionEnvelope, DelegationEnvelope } from './types.js';
 
 // Inlined rather than read from oc-agent-protocol/test-vectors: this test is
 // about the revocation guard, not vector conformance, and a relative path into
@@ -68,11 +69,46 @@ describe('verifyDelegation fails closed on revocation', () => {
         });
         expect(r.ok).toBe(true);
     });
+});
+
+// The refusal tells the caller how to fetch revocations. SPEC §9.4: relays index
+// single-letter tags only and reject a `#delegation` filter (SPEC §10.4), so the
+// message must name the `#t` query.
+describe('the refusal names a query relays answer', () => {
+    const action: ActionEnvelope = (() => {
+        const canon = {
+            address: delegation.agent.address,
+            content_hash: 'sha256:' + '00'.repeat(32),
+            content_length: 0,
+            content_mime: 'text/plain',
+            signed_at: '2026-04-23T12:00:00Z',
+            delegation_id: delegation.id,
+            scope_exercised: delegation.scopes![0]!,
+        };
+        return {
+            v: 1,
+            kind: 'agent-action',
+            id: computeActionId(canon),
+            content: { hash: canon.content_hash, length: 0, mime: 'text/plain', ref: null },
+            signer: { address: canon.address, alg: 'bip322' },
+            signed_at: canon.signed_at,
+            delegation_id: delegation.id,
+            scope_exercised: canon.scope_exercised,
+            ots: null,
+            sig: { alg: 'bip322', pubkey: canon.address, value: 'AAAA' },
+        } as ActionEnvelope;
+    })();
 
-    // An empty list and a skip both verify — but they mean different things, and
-    // only one of them is a claim about the feed. That distinction is the point
-    // of the change.
-    it('the two are not the same statement', () => {
-        expect('revocations: []').not.toBe('skipRevocationCheck: true');
+    it('verifyDelegation', async () => {
+        const r = await verifyDelegation({ envelope: delegation, skipSignatureVerification: true, now: AT });
+        expect(r.ok === false && r.message).toMatch(/"#t": \[delegation id\]/);
+        expect(r.ok === false && r.message).not.toMatch(/#delegation/);
+    });
+
+    it('verifyAction', async () => {
+        const r = await verifyAction({ action, delegation, skipSignatureVerification: true });
+        expect(r.ok === false && r.code).toBe('E_MALFORMED');
+        expect(r.ok === false && r.message).toMatch(/"#t": \[id of every link in the chain\]/);
+        expect(r.ok === false && r.message).not.toMatch(/#delegation/);
     });
 });

package/src/verify.ts

@@ -51,9 +51,9 @@ export interface VerifyBase {
     /**
      * Verify WITHOUT consulting revocation feeds. Required to be explicit.
      *
-     * SECURITY §7 item 7: "Query revocation feeds (Nostr kind-30085 by
-     * `#delegation`) for the cited delegation id before reporting OK, **unless
-     * the caller explicitly opts out**." The default was inverted — revocations
+     * SECURITY §5 item 7: "Query revocation feeds (Nostr kind-30085 by `#t`
+     * with the cited delegation id) before reporting OK, **unless the caller
+     * explicitly opts out**." The default was inverted — revocations
      * were checked only when supplied, and omitting them skipped the check
      * silently, so "checked, clean" was indistinguishable from "never checked".
      *
@@ -63,7 +63,9 @@ export interface VerifyBase {
     skipRevocationCheck?: boolean;
     /**
      * Revocations to evaluate against the delegation (or, for an action, every
-     * link in its chain). Fetch these from kind-30085 by `#delegation`.
+     * link in its chain). Fetch kind-30085 events with `"#t": [<delegation id>]`
+     * (SPEC §9.4); relays do not index the multi-letter `delegation` tag. Pass
+     * `[]` only when a relay answered with EOSE and none matched (SPEC §10.4).
      */
     revocations?: RevocationEnvelope[];
 }
@@ -222,15 +224,15 @@ export async function verifyDelegation(input: VerifyDelegationInput): Promise<Ve
         if (!ok) return err('E_BAD_SIG', 'BIP-322 signature did not verify');
     }
 
-    // Revocation. SECURITY §7 item 7 — check unless the caller states otherwise.
+    // Revocation. SECURITY §5 item 7 — check unless the caller states otherwise.
     // Before this, verifyDelegation had NO revocations parameter at all: a
     // revoked delegation returned ok:true and a caller had no way to say
     // otherwise.
     if (!input.skipRevocationCheck && !input.revocations) {
         return err(
             'E_MALFORMED',
-            'verifyDelegation requires `revocations` (fetch kind-30085 by #delegation) or an ' +
-                'explicit skipRevocationCheck:true to state that revocation is not being checked',
+            'verifyDelegation requires `revocations` (query kind 30085 with "#t": [delegation id], ' +
+                'SPEC §9.4) or an explicit skipRevocationCheck:true to state that revocation is not being checked',
         );
     }
     if (input.revocations) {
@@ -452,8 +454,8 @@ export async function verifyAction(input: VerifyActionInput): Promise<VerifyActi
     if (!input.skipRevocationCheck && !input.revocations) {
         return err(
             'E_MALFORMED',
-            'verifyAction requires `revocations` (fetch kind-30085 by #delegation for every link ' +
-                'in the chain) or an explicit skipRevocationCheck:true',
+            'verifyAction requires `revocations` (query kind 30085 with "#t": [id of every link ' +
+                'in the chain], SPEC §9.4) or an explicit skipRevocationCheck:true',
         );
     }
     // Anchor heights only count once the proof is verified against the