@oracle/oraclejet 14.1.2 → 14.1.3

package/dist/js/libs/oj/debug_esm/ojmenu.js

@@ -2310,8 +2310,9 @@ import { isElementRegistered } from 'ojs/ojcustomelement-registry';
         createInitializedSubmenus(this);
         this._setup();
       }
-
-      this._reposition();
+      if (oj.ZOrderUtils.getStatus(this.element) === oj.ZOrderUtils.STATUS.OPEN) {
+        this._reposition();
+      }
     },
 
     _reposition: function () {
@@ -3349,6 +3350,11 @@ import { isElementRegistered } from 'ojs/ojcustomelement-registry';
       }
       this._updateMenuMaxHeight();
       rootElement.position(position);
+
+      // note the initial menu width/height
+      this.initialWidth = rootElement.width();
+      this.initialHeight = rootElement.height();
+
       // establish this._focusSkipLink, if iOS or Android
       this._initVoiceOverAssist(initialFocus);
       if (initialFocus === 'firstItem') {
@@ -3420,6 +3426,7 @@ import { isElementRegistered } from 'ojs/ojcustomelement-registry';
      * @return {Promise|void}
      */
     _afterOpenHandler: function (psOptions) {
+      var rootElement = psOptions[oj.PopupService.OPTION.POPUP];
       // From the context passed from the open restore local variable state.
       var context = psOptions[oj.PopupService.OPTION.CONTEXT];
       var event = context.event;
@@ -3435,6 +3442,18 @@ import { isElementRegistered } from 'ojs/ojcustomelement-registry';
       // Add current menu to openPopupMenus so that it will be closed on focus lost/click away.
       _openPopupMenus.push(this);
 
+      // JET-44685: iOS may reveal address bar during open animation, need to make sure the position is set
+      // properly after the animation completes. Also if the menu width/height changed during opening, re-apply position constraints
+      if (
+        this.initialWidth !== rootElement.width() ||
+        this.initialHeight !== rootElement.height() ||
+        oj.AgentUtils.getAgentInfo().os === oj.AgentUtils.OS.IOS
+      ) {
+        this._reposition();
+      }
+      delete this.initialWidth;
+      delete this.initialHeight;
+
       if (initialFocus === 'firstItem' || initialFocus === 'menu') {
         var focusElement;
         if (this._focusSkipLink && initialFocus === 'menu') {

package/dist/js/libs/oj/debug_esm/ojnavigationlist.js

@@ -7234,13 +7234,6 @@ SlidingNavListHandler.prototype.IsSelectable = function (item) {
   // Slider items don't have Aria-selected tag, overrding selction for slider navlist
 
   var itemSelectionMarkerAttr = 'aria-selected';
-  var prevAnchorTag;
-  var anchor = this.m_widget.getFocusItem($(item))[0];
-  var collapseClass = this.m_widget.getCollapseIconStyleClass();
-  prevAnchorTag = anchor.previousElementSibling;
-  if (prevAnchorTag && prevAnchorTag.classList.contains(collapseClass)) {
-    return false;
-  }
   return (
     this.m_widget.getFocusItem($(item))[0].getAttribute('role') === 'menuitem' &&
     !this.m_widget.getFocusItem($(item))[0].hasAttribute(itemSelectionMarkerAttr)

package/dist/js/libs/oj/debug_esm/ojpopupcore.js

@@ -3729,6 +3729,15 @@ PositionUtils.calcAvailablePopupSize = function (pos, feedback, withinElem) {
         // factor in half the width of the popup
         posLeft -= dirFactor * (data.elemWidth / 2);
 
+        // JET-53426: need to check if the popup element fits the screen after centering
+        // otherwise it could cause text reflow and popup resize which might result
+        // in another positioning cycle with a potential endless loop.
+        // If the element does not fit, apply the 'fit' collision to avoid the resize.
+        if (posLeft < withinOffset || posLeft + data.elemWidth > outerWidth - withinOffset) {
+          $.ui.position.fit.left.call(this, position, data);
+          posLeft = position.left;
+        }
+
         // Force the popup start to be within the viewport.
         // This collision rule is only used by input components internally. The notewindow will auto dismiss when
         // what it is aligned to is hidden in a scroll container.

package/dist/js/libs/oj/debug_esm/ojstreamlist.js

@@ -491,6 +491,9 @@ let StreamList = StreamList_1 = class StreamList extends Component {
                     !this.actionableMode) {
                     this.restoreFocus = true;
                 }
+                else {
+                    this.restoreFocus = false;
+                }
             }
         }
         if (data == null) {

package/dist/js/libs/oj/debug_esm/ojtable.js

@@ -2884,13 +2884,11 @@ Table.prototype._refreshTableBody = function (resultObject, startIndex, keepVisi
   }
   this._clearCachedDomRowData();
   this._hideNoDataMessage();
-  const tableBodyDocFrag = document.createDocumentFragment();
 
-  this._refreshAddNewRowPlaceholder(tableBodyDocFrag, true);
+  this._refreshAddNewRowPlaceholder(true);
 
   // if no new rows, and no existing rows, show no data message
   if (rows.length === 0 && this._getTableBodyRows().length === 0) {
-    this._appendElementToTableBody(tableBodyDocFrag, tableBody);
     this._showNoDataMessage();
     return this._finalizeNonBodyRowRendering([tableBody]);
   }
@@ -2922,6 +2920,7 @@ Table.prototype._refreshTableBody = function (resultObject, startIndex, keepVisi
   var layoutManager = this._getLayoutManager();
 
   var rowsCount = rows.length;
+  const tableBodyDocFrag = document.createDocumentFragment();
   if (this._animateOnFetch && this._IsCustomElement()) {
     this._animateOnFetch = false;
     var addedTableBodyRows = [];
@@ -3080,27 +3079,14 @@ Table.prototype._refreshTableBodyRow = function (
           tableBody
         );
         for (let i = 0; i < nodes.length; i++) {
-          if (nodes[i].tagName === 'TR') {
-            tableBodyRow.parentNode.replaceChild(nodes[i], tableBodyRow);
-            break;
-          } else {
-            tableBodyRow.appendChild(nodes[i]); // @HTMLUpdateOK
-          }
-        }
-        if (docFrag == null) {
-          // eslint-disable-next-line no-param-reassign
-          tableBodyRow = this._getRawTableBodyRow(rowIdx);
-        } else {
-          // eslint-disable-next-line no-param-reassign
-          docFragStartIdx = docFragStartIdx == null ? 0 : docFragStartIdx;
-          if (!docFrag.children) {
-            // use jquery children() because documentFragments do not have
-            // good browser support for .children
+          var node = nodes[i];
+          if (node.tagName === 'TR') {
+            tableBodyRow.parentNode.replaceChild(node, tableBodyRow);
             // eslint-disable-next-line no-param-reassign
-            tableBodyRow = $(docFrag).children()[rowIdx - docFragStartIdx];
+            tableBodyRow = node;
+            break;
           } else {
-            // eslint-disable-next-line no-param-reassign
-            tableBodyRow = docFrag.children[rowIdx - docFragStartIdx];
+            tableBodyRow.appendChild(node); // @HTMLUpdateOK
           }
         }
         this._hasRowTemplate = true;
@@ -3194,11 +3180,10 @@ Table.prototype._refreshTableBodyRow = function (
 
 /**
  * Refresh the add row placeholder if it exists
- * @param {Object} docFrag  document fragment
  * @param {boolean=} skipTopUpdate whether to skip applying 'top' values to the row cells
  * @private
  */
-Table.prototype._refreshAddNewRowPlaceholder = function (docFrag, skipTopUpdate) {
+Table.prototype._refreshAddNewRowPlaceholder = function (skipTopUpdate) {
   let placeHolderRow = this._getPlaceHolderRow();
   if (!this._isAddNewRowEnabled()) {
     if (placeHolderRow != null) {
@@ -3240,11 +3225,7 @@ Table.prototype._refreshAddNewRowPlaceholder = function (docFrag, skipTopUpdate)
       if (placeHolderRow == null) {
         placeHolderRow = this._createTableBodyRow();
       }
-      if (docFrag != null) {
-        docFrag.appendChild(placeHolderRow);
-      } else {
-        tableBody.insertBefore(placeHolderRow, tableBody.firstChild);
-      }
+      tableBody.insertBefore(placeHolderRow, tableBody.firstChild);
 
       var addRowCell;
       if (addRowTemplate != null && this._isDefaultAddRowTemplateSlotValid()) {
@@ -3258,24 +3239,16 @@ Table.prototype._refreshAddNewRowPlaceholder = function (docFrag, skipTopUpdate)
           tableBody
         );
         for (let i = 0; i < nodes.length; i++) {
-          if (nodes[i].tagName === 'TR') {
-            placeHolderRow.parentNode.replaceChild(nodes[i], placeHolderRow);
+          var node = nodes[i];
+          if (node.tagName === 'TR') {
+            placeHolderRow.parentNode.replaceChild(node, placeHolderRow);
+            placeHolderRow = node;
             break;
           } else {
-            placeHolderRow.appendChild(nodes[i]); // @HTMLUpdateOK
+            placeHolderRow.appendChild(node); // @HTMLUpdateOK
           }
         }
-        if (docFrag == null) {
-          placeHolderRow = this._getRawTableBodyRow(-1);
-        } else if (!docFrag.children) {
-          // use jquery children() because documentFragments do not have
-          // good browser support for .children
-          // eslint-disable-next-line no-param-reassign
-          placeHolderRow = $(docFrag).children()[0];
-        } else {
-          // eslint-disable-next-line no-param-reassign
-          placeHolderRow = docFrag.children[0];
-        }
+
         // make sure to honor any reordered columns when re-rendering the add row content from a row template
         if (this._columnsDestMap != null) {
           var renderedCells = this._getPlaceHolderRowCells(placeHolderRow);
@@ -3586,76 +3559,82 @@ Table.prototype._showProgressiveLoading = function () {
 /**
  * @private
  */
-Table.prototype._insertSkeletonRow = function (rowIdx) {
+Table.prototype._insertSkeletonRow = function (rowElem, rowIdx) {
   if (this._isSkeletonSupport()) {
     var pendingRow;
-    var tableBodyRows = this._getTableBodyRows();
-    if (rowIdx === -1 && this._isAddNewRowEnabled()) {
+    if (rowElem != null) {
+      pendingRow = rowElem;
+    } else if (rowIdx === -1) {
       pendingRow = this._getPlaceHolderRow();
-    } else if (tableBodyRows != null && tableBodyRows.length > 0) {
-      pendingRow = this._getTableBodyRow(rowIdx);
     } else {
-      return;
-    }
-    // add temporary table row for load more on scroll skeleton behavior
-    var existingCells = pendingRow.children;
-    for (var i = 0; i < existingCells.length; i++) {
-      existingCells[i].classList.add(Table.CSS_CLASSES._TABLE_HIDDEN_CELL_CLASS);
-    }
-    var skeletonCell = this._createTableBodyCell();
-    var columnsCount = this._getColumnDefs().length;
-    if (this._isGutterStartColumnEnabled()) {
-      columnsCount += 1;
-    }
-    if (this._isGutterEndColumnEnabled()) {
-      columnsCount += 1;
-    }
-    skeletonCell.colSpan = this._isDefaultSelectorEnabled() ? columnsCount + 1 : columnsCount;
-    skeletonCell.classList.add(Table.CSS_CLASSES._TABLE_SKELETON_CELL_CLASS);
-    if (rowIdx === -1) {
-      skeletonCell.style[Table.CSS_PROP._TOP] = existingCells[0].style.top;
+      pendingRow = this._getTableBodyRow(rowIdx);
     }
-    var skeletonRow = this._createSkeletonRow();
-    skeletonCell.appendChild(skeletonRow); // @HTMLUpdateOK
-    pendingRow.insertBefore(skeletonCell, pendingRow.firstChild); // @HTMLUpdateOK
+    if (pendingRow != null) {
+      // add temporary table row for load more on scroll skeleton behavior
+      var existingCells = pendingRow.children;
+      for (var i = 0; i < existingCells.length; i++) {
+        existingCells[i].classList.add(Table.CSS_CLASSES._TABLE_HIDDEN_CELL_CLASS);
+      }
+      var skeletonCell = this._createTableBodyCell();
+      var columnsCount = this._getColumnDefs().length;
+      if (this._isGutterStartColumnEnabled()) {
+        columnsCount += 1;
+      }
+      if (this._isGutterEndColumnEnabled()) {
+        columnsCount += 1;
+      }
+      skeletonCell.colSpan = this._isDefaultSelectorEnabled() ? columnsCount + 1 : columnsCount;
+      skeletonCell.classList.add(Table.CSS_CLASSES._TABLE_SKELETON_CELL_CLASS);
+      if (rowIdx === -1) {
+        skeletonCell.style[Table.CSS_PROP._TOP] = existingCells[0].style.top;
+      }
+      var skeletonRow = this._createSkeletonRow();
+      skeletonCell.appendChild(skeletonRow); // @HTMLUpdateOK
+      pendingRow.insertBefore(skeletonCell, pendingRow.firstChild); // @HTMLUpdateOK
 
-    this._skeletonHWMSFadeInEndListener = function () {
-      skeletonRow.classList.remove(Table.CSS_CLASSES._ANIMATION_SKELETON_FADE_IN_CLASS);
-      var skeletons = skeletonRow.querySelectorAll('.oj-table-skeleton');
-      skeletons.forEach(function (row) {
-        row.classList.add('oj-animation-skeleton');
-      });
-      skeletonRow.removeEventListener('animationend', this._skeletonHWMSFadeInEndListener);
-    }.bind(this);
-    skeletonRow.addEventListener('animationend', this._skeletonHWMSFadeInEndListener);
-    skeletonRow.classList.add(Table.CSS_CLASSES._ANIMATION_SKELETON_FADE_IN_CLASS);
+      this._skeletonHWMSFadeInEndListener = function () {
+        skeletonRow.classList.remove(Table.CSS_CLASSES._ANIMATION_SKELETON_FADE_IN_CLASS);
+        var skeletons = skeletonRow.querySelectorAll('.oj-table-skeleton');
+        skeletons.forEach(function (row) {
+          row.classList.add('oj-animation-skeleton');
+        });
+        skeletonRow.removeEventListener('animationend', this._skeletonHWMSFadeInEndListener);
+      }.bind(this);
+      skeletonRow.addEventListener('animationend', this._skeletonHWMSFadeInEndListener);
+      skeletonRow.classList.add(Table.CSS_CLASSES._ANIMATION_SKELETON_FADE_IN_CLASS);
+    }
   }
 };
 
 /**
  * @private
  */
-Table.prototype._removeSkeletonRow = function (rowIdx) {
+Table.prototype._removeSkeletonRow = function (rowElem, rowIdx) {
   if (this._isSkeletonSupport()) {
     var pendingRow;
-    var tableBodyRows = this._getTableBodyRows();
-    if (rowIdx === -1 && this._isAddNewRowEnabled()) {
+    if (rowElem != null) {
+      pendingRow = rowElem;
+    } else if (rowIdx === -1) {
       pendingRow = this._getPlaceHolderRow();
-    } else if (tableBodyRows != null && tableBodyRows.length > 0) {
-      pendingRow = this._getTableBodyRow(rowIdx);
     } else {
-      return;
+      pendingRow = this._getTableBodyRow(rowIdx);
     }
-    // remove temporary table row for pending skeleton behavior
-    var skeletonCell = pendingRow.children[0];
-    var skeletonRow = skeletonCell.children[0];
-    skeletonRow.classList.remove(Table.CSS_CLASSES._ANIMATION_SKELETON_FADE_IN_CLASS);
-    skeletonRow.removeEventListener('animationend', this._skeletonHWMSFadeInEndListener);
-    pendingRow.removeChild(skeletonCell);
-
-    var existingCells = pendingRow.children;
-    for (var i = 0; i < existingCells.length; i++) {
-      existingCells[i].classList.remove(Table.CSS_CLASSES._TABLE_HIDDEN_CELL_CLASS);
+    if (pendingRow != null) {
+      // remove temporary table row for pending skeleton behavior
+      var skeletonCell = pendingRow.children[0];
+      if (skeletonCell != null &&
+          skeletonCell.classList.contains(Table.CSS_CLASSES._TABLE_SKELETON_CELL_CLASS)) {
+        var skeletonRow = skeletonCell.children[0];
+        if (skeletonRow != null) {
+          skeletonRow.classList.remove(Table.CSS_CLASSES._ANIMATION_SKELETON_FADE_IN_CLASS);
+          skeletonRow.removeEventListener('animationend', this._skeletonHWMSFadeInEndListener);
+        }
+        pendingRow.removeChild(skeletonCell);
+      }
+      var existingCells = pendingRow.children;
+      for (var i = 0; i < existingCells.length; i++) {
+        existingCells[i].classList.remove(Table.CSS_CLASSES._TABLE_HIDDEN_CELL_CLASS);
+      }
     }
   }
 };
@@ -19681,27 +19660,30 @@ Table.prototype._setTableEditable = function (
       }
       if (editAcceptPromiseArray.length !== 0) {
         this._isEditPending = true;
-        this._insertSkeletonRow(rowIdx);
+        this._insertSkeletonRow(tableBodyRow);
         this._getTable().focus();
         this._queueTask(
           function () {
             return Promise.all(editAcceptPromiseArray).then(
               function () {
-                this._removeSkeletonRow(rowIdx);
-                // update editRow option
-                if (newEditRowValue) {
-                  this._fireEditRowChangeEvent(newEditRowValue, event);
+                this._removeSkeletonRow(tableBodyRow);
+                // recalculate the row index as it could have changed due to other tasks
+                var editableRowIndex = this._getRowIdxForRowKey(rowKey);
+                if (editable && rowIdx !== editableRowIndex) {
+                  newEditRowValue.rowIndex = editableRowIndex;
                 }
+                // update editRow option
+                this._fireEditRowChangeEvent(newEditRowValue, event);
 
                 if (editable) {
                   // set the editable row index
-                  this._setEditableRowIdx(rowIdx);
+                  this._setEditableRowIdx(editableRowIndex);
                   this._getTable().setAttribute(Table.DOM_ATTR._ARIA_LABELLEDBY, ''); // @HTMLUpdateOK
                   this._accStatus.setAttribute(Table.DOM_ATTR._ARIA_LABELLEDBY, ''); // @HTMLUpdateOK
                   // re-render the newly editable row
-                  return this._refreshRow(rowIdx, true, false, !isLegacyDataSource).then(
+                  return this._refreshRow(editableRowIndex, true, false, !isLegacyDataSource).then(
                     function () {
-                      this._setCellInRowFocus(rowIdx, columnIdx, forwardSearch);
+                      this._setCellInRowFocus(editableRowIndex, columnIdx, forwardSearch);
                       // clear out the old editable row
                       // make sure the row still exists before we refresh it
                       var prevEditableRowIdx = this._getRowIdxForRowKey(prevEditableRowKey);
@@ -19739,7 +19721,7 @@ Table.prototype._setTableEditable = function (
                 return Promise.resolve();
               }.bind(this),
               function () {
-                this._removeSkeletonRow(rowIdx);
+                this._removeSkeletonRow(tableBodyRow);
                 if (editable && prevEditableRowKey == null) {
                   this._syncActiveElement();
                 }
@@ -19752,9 +19734,7 @@ Table.prototype._setTableEditable = function (
         return Promise.all(editAcceptPromiseArray);
       }
       // update editRow option
-      if (newEditRowValue) {
-        this._fireEditRowChangeEvent(newEditRowValue, event);
-      }
+      this._fireEditRowChangeEvent(newEditRowValue, event);
 
       if (editable) {
         // set the editable row index
@@ -19764,10 +19744,12 @@ Table.prototype._setTableEditable = function (
         // re-render the newly editable row
         this._queueTask(
           function () {
-            return this._refreshRow(rowIdx, true, false, !isLegacyDataSource).then(
+            // recalculate the row index as it could have changed due to other tasks
+            var editableRowIndex = this._getRowIdxForRowKey(rowKey);
+            return this._refreshRow(editableRowIndex, true, false, !isLegacyDataSource).then(
               function () {
                 // set focus on the column in the row
-                this._setCellInRowFocus(rowIdx, columnIdx, forwardSearch);
+                this._setCellInRowFocus(editableRowIndex, columnIdx, forwardSearch);
               }.bind(this)
             );
           }.bind(this)
@@ -19815,13 +19797,13 @@ Table.prototype._handleAddRow = function (canceled, event) {
   }
   this._setTableActionableMode(false);
   if (addRowAcceptPromiseArray.length !== 0) {
-    this._insertSkeletonRow(-1);
+    this._insertSkeletonRow(null, -1);
     this._getTable().focus();
     this._queueTask(
       function () {
         return Promise.all(addRowAcceptPromiseArray).then(
           function () {
-            this._removeSkeletonRow(-1);
+            this._removeSkeletonRow(null, -1);
             this._isAddRowRendered = false;
             return this._refreshAddNewRowPlaceholder().then(
               function () {
@@ -19833,7 +19815,7 @@ Table.prototype._handleAddRow = function (canceled, event) {
             );
           }.bind(this),
           function () {
-            this._removeSkeletonRow(-1);
+            this._removeSkeletonRow(null, -1);
             this._setActiveAddRow();
             this._setTableActionableMode(true);
           }.bind(this)

package/dist/js/libs/oj/main-template.js

@@ -15,9 +15,9 @@
   requirejs.config({
     // Path mappings for the logical module names
     paths: {
-      'ojs': 'libs/oj/14.1.2/min@insertESLevelPath@',
-      'ojL10n': 'libs/oj/14.1.2/ojL10n',
-      'ojtranslations': 'libs/oj/14.1.2/resources',
+      'ojs': 'libs/oj/14.1.3/min@insertESLevelPath@',
+      'ojL10n': 'libs/oj/14.1.3/ojL10n',
+      'ojtranslations': 'libs/oj/14.1.3/resources',
       
   'knockout': 'libs/knockout/knockout-3.5.1',
   'jquery': 'libs/jquery/jquery-3.6.1.min',